[Lldb-commits] [PATCH] D96840: [LLDB] [docs] Update the list of supported architectures on Windows

DavidSpickett added subscribers: omjavaid, DavidSpickett. DavidSpickett added a reviewer: omjavaid. DavidSpickett added a comment. Do we support 32 bit Arm specifically? (I'm not very familiar with Windows targets) @omjavaid Has done some testing on the latest Windows On Arm which is AArch64. I

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

omjavaid added a comment. We are using SVE read/write in this test to make sure we do not overlap register offsets while calculating offsets for the dynamic registers. Further dynamic register sets should also be readable. Comment at: lldb/test/API/commands/register/register

[Lldb-commits] [PATCH] D96840: [LLDB] [docs] Update the list of supported architectures on Windows

mstorsjo added a comment. In D96840#2567890 , @DavidSpickett wrote: > Do we support 32 bit Arm specifically? (I'm not very familiar with Windows > targets) Yes, I implemented support for both ARM and AArch64 in late 2019. > @omjavaid Has done some test

Re: [Lldb-commits] [PATCH] D96840: [LLDB] [docs] Update the list of supported architectures on Windows

On Wed, 17 Feb 2021 at 15:10, Martin Storsjö via Phabricator < revi...@reviews.llvm.org> wrote: > mstorsjo added a comment. > > In D96840#2567890 , > @DavidSpickett wrote: > > > Do we support 32 bit Arm specifically? (I'm not very familiar with > Windows ta

Re: [Lldb-commits] [PATCH] D96840: [LLDB] [docs] Update the list of supported architectures on Windows

On Wed, 17 Feb 2021, Omair Javaid wrote: HI  mstorsjo, did you manage to run LLDB testsuite with python support enabled on windows. Can you please share steps to build and test LLDB on windows on Arm/AArch64 if you have them handy somewhere. I ll check if there is something missing on our part w

Re: [Lldb-commits] [PATCH] D96840: [LLDB] [docs] Update the list of supported architectures on Windows

On Wed, 17 Feb 2021 at 15:26, Martin Storsjö wrote: > On Wed, 17 Feb 2021, Omair Javaid wrote: > > > HI mstorsjo, did you manage to run LLDB testsuite with python support > > enabled on windows. Can you please share steps to build and test LLDB on > > windows on Arm/AArch64 if you have them hand

[Lldb-commits] [PATCH] D96840: [LLDB] [docs] Update the list of supported architectures on Windows

omjavaid added inline comments. Comment at: lldb/docs/index.rst:80 (*) Support for Windows is under active development. Basic functionality is -expected to work, with functionality improving rapidly. +expected to work, with functionality improving rapidly. ARM support is +more e

[Lldb-commits] [PATCH] D96840: [LLDB] [docs] Update the list of supported architectures on Windows

mstorsjo added inline comments. Comment at: lldb/docs/index.rst:80 (*) Support for Windows is under active development. Basic functionality is -expected to work, with functionality improving rapidly. +expected to work, with functionality improving rapidly. ARM support is +more e

[Lldb-commits] [PATCH] D96840: [LLDB] [docs] Update the list of supported architectures on Windows

mstorsjo updated this revision to Diff 324250. mstorsjo added a comment. Fixed the typo, labeling the AArch64 support experimental too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96840/new/ https://reviews.llvm.org/D96840 Files: lldb/docs/index.rst Index: lldb/docs/index.rst ===

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

DavidSpickett added inline comments. Comment at: lldb/test/API/commands/register/register/aarch64_dynamic_regset/TestArm64DynamicRegsets.py:35 + +p_value_bytes = ['0xff', '0x55', '0x11', '0x01', '0x00'] +for i in range(16): omjavaid wrote: > Davi

[Lldb-commits] [PATCH] D96817: Fix deep copying for OptionValue classes

tatyana-krasnukha added a comment. CRTP was my first implementation, however, I discarded it as more bug-prone. Virtual Clone function at the interface is so common that, I believe, everyone knows it must be overridden by a new derived class. The necessity of inheriting from base_clone_helper i

[Lldb-commits] [PATCH] D96817: Fix deep copying for OptionValue classes

teemperor added inline comments. Comment at: lldb/unittests/Interpreter/TestOptionValue.cpp:173 + // Trigger the callback second time. + file_list_copy_ptr->SetValueFromString(llvm::StringRef("0 another/path"), + eVarSetOperationReplace);

[Lldb-commits] [lldb] 8bcc037 - [lldb][NFC] Delete deleted const char* overloads of SetValueFromString

Author: Raphael Isemann Date: 2021-02-17T16:13:20+01:00 New Revision: 8bcc03767e440f229749d101f470f73b8e1cd2e5 URL: https://github.com/llvm/llvm-project/commit/8bcc03767e440f229749d101f470f73b8e1cd2e5 DIFF: https://github.com/llvm/llvm-project/commit/8bcc03767e440f229749d101f470f73b8e1cd2e5.dif

[Lldb-commits] [PATCH] D96861: [lldb][NFC] Delete deleted const char* overloads of SetValueFromString

This revision was automatically updated to reflect the committed changes. Closed by commit rG8bcc03767e44: [lldb][NFC] Delete deleted const char* overloads of SetValueFromString (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D96833: [lldb] Print a useful error message when trying to import modules with dots or dashes

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96833/new/ https://reviews.llvm.org/D96833 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [PATCH] D96839: Add a callout to the LanguageRuntime to override the normal UnwindPlan used for a frame

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. "Asynced" sounds funny to me, but I don't have suggestions other than "Async". Looks good to me. Comment at: lldb/source/Target/RegisterContextUnwind.cpp:558 +

[Lldb-commits] [PATCH] D96779: [lldb] Fix shared library directory computation on windows

stella.stamenova accepted this revision. stella.stamenova added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96779/new/ https://reviews.llvm.org/D96779 ___ lldb-commits mailing list lld

[Lldb-commits] [PATCH] D96839: Add a callout to the LanguageRuntime to override the normal UnwindPlan used for a frame

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Target/LanguageRuntime.h:177 + // A language runtime may be able to provide a special UnwindPlan for + // the frame represented by the register contents \a regctx when that Please use `///` so

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

werat added a comment. To be honest, I'm not sure how to reproduce this kind of debug info. I've tried a few examples (e.g. force inline the function from another CU) , but it didn't work. Should be postpone this patch until someone can figure out the test case then? Repository: rG LLVM Git

[Lldb-commits] [PATCH] D96839: Add a callout to the LanguageRuntime to override the normal UnwindPlan used for a frame

jingham added inline comments. Comment at: lldb/include/lldb/Target/LanguageRuntime.h:187 + static lldb::UnwindPlanSP + GetAsyncedFrameUnwindPlan(lldb_private::Thread &thread, +lldb_private::RegisterContext *regctx); JDevlieghere wro

[Lldb-commits] [PATCH] D96537: Make the error condition in Value::ValueType explicit (NFC)

aprantl closed this revision. aprantl added a comment. This landed as 057efa9916cdc354ef4653bcd128a578cc43125e I messed up the commit message. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96537/new/ https://reviews

[Lldb-commits] [lldb] d6e8057 - [lldb] Improve error message for modules with dots or dashes

Author: Jonas Devlieghere Date: 2021-02-17T10:00:29-08:00 New Revision: d6e80578fc5e5199d5783671bd0c8ce1050925f9 URL: https://github.com/llvm/llvm-project/commit/d6e80578fc5e5199d5783671bd0c8ce1050925f9 DIFF: https://github.com/llvm/llvm-project/commit/d6e80578fc5e5199d5783671bd0c8ce1050925f9.d

[Lldb-commits] [PATCH] D96833: [lldb] Print a useful error message when trying to import modules with dots or dashes

This revision was automatically updated to reflect the committed changes. Closed by commit rGd6e80578fc5e: [lldb] Improve error message for modules with dots or dashes (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D96833?vs=324169&id

[Lldb-commits] [PATCH] D96861: [lldb][NFC] Delete deleted const char* overloads of SetValueFromString

shafik added a comment. Nice catch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96861/new/ https://reviews.llvm.org/D96861 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.o

[Lldb-commits] [PATCH] D95712: [lldb/bindings] Add Python ScriptedProcess base class to lldb module

JDevlieghere added inline comments. Comment at: lldb/examples/python/scripted_process/scripted_process.py:18 + +Attributes: +args (lldb.SBStructuredData): Dictionary holding arbitrary values Doesn't the python documentation generator infer the attribu

[Lldb-commits] [PATCH] D95711: [lldb/Interpreter] Add ScriptInterpreter Wrapper for ScriptedProcess

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Interpreter/ScriptInterpreter.h:548 lldb::ScriptLanguage m_script_lang; + lldb::ScriptedProcessInterfaceSP m_scripted_process_interface_sp; }; Why does this need to be a shared pointer and not

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:117 + if (m_interpreter) +m_pid = m_interpreter->GetScriptedProcessInterface().GetProcessID(); +} `m_interpreter->GetScriptedProcessInterface()` seems to

[Lldb-commits] [PATCH] D96839: Add a callout to the LanguageRuntime to override the normal UnwindPlan used for a frame

jasonmolenda added inline comments. Comment at: lldb/include/lldb/Target/LanguageRuntime.h:187 + static lldb::UnwindPlanSP + GetAsyncedFrameUnwindPlan(lldb_private::Thread &thread, +lldb_private::RegisterContext *regctx); jingham wro

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

mib added inline comments. Comment at: lldb/test/API/functionalities/scripted_process/TestScriptedProcess.py:55 +scripted_process_example_relpath = "../../../../examples/python/scripted_process/my_scripted_process.py" +os.environ['SKIP_SCRIPTED_PROCESS_LAUNCH']

[Lldb-commits] [PATCH] D96548: [lldb] [Process/FreeBSDRemote] Introduce aarch64 hw break/watchpoint support

mgorny updated this revision to Diff 324393. mgorny retitled this revision from "[lldb] [Process/FreeBSDRemote] Introduce aarch64 hw break/watchpoint support [WIP]" to "[lldb] [Process/FreeBSDRemote] Introduce aarch64 hw break/watchpoint support". mgorny added a reviewer: mhorne. mgorny added a c

[Lldb-commits] [PATCH] D96548: [lldb] [Process/FreeBSDRemote] Introduce aarch64 hw break/watchpoint support

mgorny added a comment. Oh, and added the method to copy dbregs to new threads. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96548/new/ https://reviews.llvm.org/D96548 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [PATCH] D96548: [lldb] [Process/FreeBSDRemote] Introduce aarch64 hw break/watchpoint support

mgorny updated this revision to Diff 324394. mgorny added a comment. clang-format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96548/new/ https://reviews.llvm.org/D96548 Files: lldb/packages/Python/lldbsuite/test/dotest.py lldb/source/Plugins/Process/FreeBSD/NativeProcessFreeBSD.

[Lldb-commits] [PATCH] D96839: Add a callout to the LanguageRuntime to override the normal UnwindPlan used for a frame

clayborg added a comment. Can each real stack frame inject N frames in the middle of a stack frame for these asynchronous functions? Or is this like the libdispatch stuff that show more frames at the end of a normal stack trace? Can you attach some sample backtraces with some annotations? ==

[Lldb-commits] [PATCH] D96817: Fix deep copying for OptionValue classes

dblaikie added a comment. > CRTP was my first implementation, however, I discarded it as more bug-prone. > Virtual Clone function at the interface is so common that, I believe, > everyone knows it must be overridden by a new derived class. The necessity of > inheriting from base_clone_helper is

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

dblaikie added a comment. In D96778#2568794 , @werat wrote: > To be honest, I'm not sure how to reproduce this kind of debug info. I've > tried a few examples (e.g. force inline the function from another CU) , but > it didn't work. > > Should we postpone

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

jankratochvil added a comment. The D91014 patch has been found by a testsuite regression when running in DWZ mode. This patch has only the same pattern in the code and currently it is unclear whether this change is really reproducible or it is in fact just NFC.

[Lldb-commits] [PATCH] D96839: Add a callout to the LanguageRuntime to override the normal UnwindPlan used for a frame

jasonmolenda added inline comments. Comment at: lldb/include/lldb/Target/LanguageRuntime.h:188 + GetAsyncedFrameUnwindPlan(lldb_private::Thread &thread, +lldb_private::RegisterContext *regctx); + clayborg wrote: > Any reason we are pa

[Lldb-commits] [PATCH] D96637: Make sure the interpreter module was loaded before making checks against it

clayborg added a comment. In D96637#2567269 , @aadsm wrote: >> We should have a test for this. > > how do you recommend doing this? I spent a couple of hours on this but got no > where. From what I understood we should prefer lit tests, so I was thinking

[Lldb-commits] [PATCH] D96807: Modify TypePrinter to differentiate between anonymous struct and unnamed struct

shafik updated this revision to Diff 324431. shafik added a comment. - Went with unnamed enums Vs anonymous enums CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96807/new/ https://reviews.llvm.org/D96807 Files: clang/lib/AST/TypePrinter.cpp clang/test/AST/ast-dump-decl-json.c clan

[Lldb-commits] [PATCH] D96807: Modify TypePrinter to differentiate between anonymous struct and unnamed struct

shafik marked an inline comment as done. shafik added inline comments. Comment at: clang/lib/AST/TypePrinter.cpp:1308 +} else if ((isa(D) && cast(D)->isAnonymousStructOrUnion()) || +isa(D)) { OS << "anonymous"; aaron.ballman wrote: > I think `

[Lldb-commits] [PATCH] D96817: Fix deep copying for OptionValue classes

tatyana-krasnukha updated this revision to Diff 324435. tatyana-krasnukha added a comment. Removed explicit conversions to StringRef from the test with respect to D96861 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96817/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D96817: Fix deep copying for OptionValue classes

clayborg added a comment. In D96817#2569595 , @dblaikie wrote: >> CRTP was my first implementation, however, I discarded it as more bug-prone. >> Virtual Clone function at the interface is so common that, I believe, >> everyone knows it must be overridde

[Lldb-commits] [PATCH] D96680: [lldb-vscode] Emit the breakpoint changed event on location resolved

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. needs a test. Just make a test app with a shared library that gets dlopen'ed in the main function. At first the breakpoint in the shared library will be unresolved, then after st

[Lldb-commits] [PATCH] D96916: [lldb] Fix PushPlan to set subplan to private

kastiglione created this revision. kastiglione added a reviewer: jingham. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Call `SetPrivate(true)` for subplans pushed via `PushPlan()`, as described in its docstring. Repository

[Lldb-commits] [PATCH] D96917: [lldb] Rename {stop, run}_vote to report_{stop, run}_vote

kastiglione created this revision. kastiglione added a reviewer: jingham. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Rename `stop_vote` and `run_vote` to `report_stop_vote` and `report_run_vote` respectively. These variable

[Lldb-commits] [PATCH] D96817: Fix deep copying for OptionValue classes

dblaikie added a comment. In D96817#2569852 , @clayborg wrote: > In D96817#2569595 , @dblaikie wrote: > >>> CRTP was my first implementation, however, I discarded it as more >>> bug-prone. Virtual Clone function at

[Lldb-commits] [PATCH] D96917: [lldb] Rename {stop, run}_vote to report_{stop, run}_vote

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. Sure, that's clearer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96917/new/ https://reviews.llvm.o

[Lldb-commits] [lldb] fcdef15 - Add a new Row setting to mark all un-declared regs as Undefined

Author: Jason Molenda Date: 2021-02-17T23:52:28-08:00 New Revision: fcdef15d77bde8a200cd28242077cd2496f138a4 URL: https://github.com/llvm/llvm-project/commit/fcdef15d77bde8a200cd28242077cd2496f138a4 DIFF: https://github.com/llvm/llvm-project/commit/fcdef15d77bde8a200cd28242077cd2496f138a4.diff

[Lldb-commits] [PATCH] D96829: Add "Undeclared registers are marked as Undefined" to UnwindPlan, adopt it in arch default unwind plans

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfcdef15d77bd: Add a new Row setting to mark all un-declared regs a

[Lldb-commits] [PATCH] D96939: [lldb] Add a note to the core file loading error message that mentions archives

teemperor created this revision. teemperor added a reviewer: LLDB. teemperor added a project: LLDB. Herald added a subscriber: JDevlieghere. teemperor requested review of this revision. Core files are frequently compressed in some compressed archive and users aren't aware that LLDB can't extract