[Lldb-commits] [PATCH] D92759: [lldb] Introduce separate scratch ASTs for debug info types and types imported from C++ modules.

sylvestre.ledru added a comment. This change doesn't build with gcc 5.3.1. More details: https://bugs.llvm.org/show_bug.cgi?id=48869 It would be great if you have could have a look! thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92759/new/ h

Re: [Lldb-commits] [PATCH] D92759: [lldb] Introduce separate scratch ASTs for debug info types and types imported from C++ modules.

Yeah, that's an unfortunate bug in GCC 5.x. I actually just fixed that before the weekend in https://reviews.llvm.org/rG37510f69b4cb8d76064f108d57bebe95984a23ae +CC Tom (who is the release manager AFAIK), as that commit prob

[Lldb-commits] [lldb] e9a3fac - [LLDB] Skip TestPlatformProcessConnect on arm/aarch64 buildbot

Author: Muhammad Omair Javaid Date: 2021-01-25T20:48:16+05:00 New Revision: e9a3fac76cf199d902a746c2b2fc308dfe0ade26 URL: https://github.com/llvm/llvm-project/commit/e9a3fac76cf199d902a746c2b2fc308dfe0ade26 DIFF: https://github.com/llvm/llvm-project/commit/e9a3fac76cf199d902a746c2b2fc308dfe0ade

[Lldb-commits] [lldb] 2fd4d92 - [LLDB] Define AUXV_AT_HWCAP2 in AuxVector.h

Author: Muhammad Omair Javaid Date: 2021-01-25T20:48:16+05:00 New Revision: 2fd4d923a826c9563d587e1dafefe41b461ef3b8 URL: https://github.com/llvm/llvm-project/commit/2fd4d923a826c9563d587e1dafefe41b461ef3b8 DIFF: https://github.com/llvm/llvm-project/commit/2fd4d923a826c9563d587e1dafefe41b461ef3

[Lldb-commits] [lldb] b45020c - [LLDB] Remove leftovers and typos from RegisterInfos_arm64_sve.h

Author: Muhammad Omair Javaid Date: 2021-01-25T20:48:15+05:00 New Revision: b45020cf63f6f3a1de0f8d2b8be3c527f6cbdfd5 URL: https://github.com/llvm/llvm-project/commit/b45020cf63f6f3a1de0f8d2b8be3c527f6cbdfd5 DIFF: https://github.com/llvm/llvm-project/commit/b45020cf63f6f3a1de0f8d2b8be3c527f6cbdf

[Lldb-commits] [PATCH] D95261: [lldb/test] Reduce API test tools configuration boilerplate

stella.stamenova added inline comments. Comment at: lldb/utils/lldb-dotest/CMakeLists.txt:87 set(LLDB_LIBS_DIR_CONFIGURED "${LLDB_LIBS_DIR}") + set(LLVM_TOOLS_DIR_CONFIGURED "${LLVM_TOOLS_DIR_CONFIGURED}") labath wrote: > stella.stamenova wrote: > > I think

Re: [Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

lldb creates a single line table out of the debug_line input and the inlined_subroutine info from the debug_info. For instance, if you have a nested set of inlines that all have the same start address, they cannot be represented in the debug_line which requires monotonically increasing address

Re: [Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

> On Jan 24, 2021, at 8:30 PM, David Blaikie wrote: > > I guess lldb doesn't have a machine readable form, like gdb's machine > interface that might make for a more robust thing to test against most of the > time (& then leaving a limited number of tests that test the user-textual > output)?

[Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

wallace added inline comments. Comment at: lldb/test/API/functionalities/exec/TestExec.py:133-158 +exe = self.getBuildArtifact("a.out") +secondprog = self.getBuildArtifact("secondprog") + +# Create the target +target = self.dbg.CreateTarget(exe) +

[Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

wallace updated this revision to Diff 319069. wallace added a comment. apply suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93874/new/ https://reviews.llvm.org/D93874 Files: lldb/include/lldb/Target/Process.h lldb/include/lldb/Target

[Lldb-commits] [lldb] 4bb6244 - [ThreadPlan] fix exec on Linux

Author: Walter Erquinigo Date: 2021-01-25T11:30:48-08:00 New Revision: 4bb6244871c6914517a21f56830b3765495792f2 URL: https://github.com/llvm/llvm-project/commit/4bb6244871c6914517a21f56830b3765495792f2 DIFF: https://github.com/llvm/llvm-project/commit/4bb6244871c6914517a21f56830b3765495792f2.di

[Lldb-commits] [PATCH] D93421: Fix how ValueObject deals with getting unsigned values

shafik added a comment. landed this fix: https://reviews.llvm.org/rGdc057e87f6c18c24d17c7cae97ebe95f78b6d934 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93421/new/ https://reviews.llvm.org/D93421 ___ lldb-commits mailing list lldb-commits@

Re: [Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

On Mon, Jan 25, 2021 at 10:39 AM Jim Ingham wrote: > lldb creates a single line table out of the debug_line input and the > inlined_subroutine info from the debug_info. For instance, if you have a > nested set of inlines that all have the same start address, they cannot be > represented in the d

[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0f0462cacf34: [vscode] Improve runInTerminal and support linux (authored by wallace). Changed prior to commit: https://reviews.llvm.org/D93951?vs=

[Lldb-commits] [PATCH] D95164: Make SBDebugger::CreateTargetWithFileAndArch accept lldb.LLDB_DEFAULT_ARCH

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf05dc40c31d1: Fix SBDebugger::CreateTargetWithFileAndArch to accep

[Lldb-commits] [PATCH] D93649: [lldb/Lua] add support for Lua function breakpoint

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/test/Shell/ScriptInterpreter/Lua/breakpoint_function_callback.test:15 +r +# CHECK: +breakpoint command add -s lua -o "abc(frame, bp_loc, .

[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

stella.stamenova added a comment. It looks like this broke the windows lldb bot: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93951/new/ https://reviews.llvm.org/D93951 ___ lldb-commits mailing list lld

[Lldb-commits] [PATCH] D95297: [lldb] [Process/FreeBSDRemote] Introduce arm64 support

mgorny updated this revision to Diff 319121. mgorny added a comment. Removed unused `REG_CONTEXT_SIZE`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95297/new/ https://reviews.llvm.org/D95297 Files: lldb/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp lldb/source/Plugins/Proce

Re: [Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

I've already submitted a fix, let's see if the buildbot gets fixed Il giorno lun 25 gen 2021 alle ore 14:18 Stella Stamenova via Phabricator < revi...@reviews.llvm.org> ha scritto: > stella.stamenova added a comment. > > It looks like this broke the windows lldb bot: > > > Repository: > rG LLVM

[Lldb-commits] [PATCH] D93649: [lldb/Lua] add support for Lua function breakpoint

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG532e4203c5be: [lldb/Lua] add support for Lua function breakpoint (authored by tammela). Changed prior to commit: https://reviews.llvm.org/D93649?v

[Lldb-commits] [PATCH] D92957: ExpressionParser: Migrate to FileEntryRef in ParseInternal, NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8b6aedc4c99a: ExpressionParser: Migrate to FileEntryRef in ParseInternal, NFC (authored by dexonsmith). Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [PATCH] D95411: [lldb] Remove unused ThreadPlanStack::GetStackOfKind (NFC)

kastiglione created this revision. kastiglione added a reviewer: jingham. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This function isn't used. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D95411 Files:

[Lldb-commits] [PATCH] D95411: [lldb] Remove unused ThreadPlanStack::GetStackOfKind (NFC)

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. The inverse change to this would be to have all the places where we ask questions about the PlanStacks in a ThreadPlanStack through this API. I put i

[Lldb-commits] [PATCH] D95164: Make SBDebugger::CreateTargetWithFileAndArch accept lldb.LLDB_DEFAULT_ARCH

rsmith added a comment. I reverted this and the follow-up fix in rG8b1171488575bd0b5ccb23bc1a3d22e2aaccb244 , because it's introduced several test failures. Example: http://lab.llvm.org:8011/#/builders/96/builds/3777 It appe