[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

tammela updated this revision to Diff 308029. tammela marked 3 inline comments as done. tammela added a comment. Addressing review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91508/new/ https://reviews.llvm.org/D91508 Files: lldb/bind

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

tammela added inline comments. Comment at: lldb/bindings/lua/lua-wrapper.swig:21-22 +{ + lldb::SBFrame sb_frame(stop_frame_sp); + lldb::SBBreakpointLocation sb_bp_loc(bp_loc_sp); + labath wrote: > What's up with the copying? Is it to ensure the callback does

[Lldb-commits] [PATCH] D92223: [lldb] Add support for looking up static const members

werat created this revision. Herald added subscribers: lldb-commits, arphaman. Herald added a project: LLDB. werat requested review of this revision. Herald added a subscriber: JDevlieghere. Static const/constexpr members might have only DW_TAG_member entry with a DW_AT_const_value attribute. Sinc

[Lldb-commits] [PATCH] D92223: [lldb] Add support for looking up static const members

teemperor added reviewers: labath, jankratochvil. teemperor added a comment. Not sure who's the right person to review the SymbolFileDWARF.cpp/ManualDWARFIndex.cpp, but Pavel/Jan touched that not too long ago. (D81471 might also be an interested patch for you.

[Lldb-commits] [PATCH] D92223: [lldb] Add support for looking up static const members

werat added reviewers: jarin, aprantl, shafik. werat added a comment. Hi, please, take a look at this patch. It seems Pavel already did some work for class-level static const variables in https://reviews.llvm.org/D86615, although that didn't work the case I've encountered. In my example (which

[Lldb-commits] [PATCH] D92223: [lldb] Add support for looking up static const members

werat updated this revision to Diff 308052. werat added a comment. Simplified test according to teemperor's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92223/new/ https://reviews.llvm.org/D92223 Files: lldb/source/Plugins/SymbolFile/

[Lldb-commits] [PATCH] D92223: [lldb] Add support for looking up static const members

werat updated this revision to Diff 308053. werat added a comment. Remove unused field Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92223/new/ https://reviews.llvm.org/D92223 Files: lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp ll

[Lldb-commits] [PATCH] D92249: [LLDB/Python] Fix segfault on Python scripted breakpoints

tammela created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. tammela requested review of this revision. Herald added a subscriber: JDevlieghere. The code that calls into the ScriptInterpreter was not considering the case that it receives a Lua interpreter.