I already fixed that bug on Monday, so this is now just assigning a second
fallback value. See https://reviews.llvm.org/D86593
Cheers,
- Raphael
> On 3 Sep 2020, at 21:18, Luboš Luňák via lldb-commits
> wrote:
>
>
> Author: Luboš Luňák
> Date: 2020-09-03T21:18:17+02:00
> New Revision: f369d
Author: Raphael Isemann
Date: 2020-09-04T09:30:56+02:00
New Revision: bdc4c0bc5c5e522aa770363fa6f50a3d5a5eadc2
URL:
https://github.com/llvm/llvm-project/commit/bdc4c0bc5c5e522aa770363fa6f50a3d5a5eadc2
DIFF:
https://github.com/llvm/llvm-project/commit/bdc4c0bc5c5e522aa770363fa6f50a3d5a5eadc2.dif
Author: Raphael Isemann
Date: 2020-09-04T11:25:43+02:00
New Revision: f9ad112770ece2e3612ddcdd6a4157bc0b0faf31
URL:
https://github.com/llvm/llvm-project/commit/f9ad112770ece2e3612ddcdd6a4157bc0b0faf31
DIFF:
https://github.com/llvm/llvm-project/commit/f9ad112770ece2e3612ddcdd6a4157bc0b0faf31.dif
martong added a comment.
The key question is this: Why exactly does `1735: ExpectedDecl ImportedOrErr =
import(From);` fails to do the import properly when called from
ASTImporter::ImportDefinition? Would it be possible to debug that from your
LLDB test cases? Maybe starting with the simpler te
Author: Raphael Isemann
Date: 2020-09-04T13:45:42+02:00
New Revision: 101f37a1b330e3f0ae57762db47bba28f72cf50d
URL:
https://github.com/llvm/llvm-project/commit/101f37a1b330e3f0ae57762db47bba28f72cf50d
DIFF:
https://github.com/llvm/llvm-project/commit/101f37a1b330e3f0ae57762db47bba28f72cf50d.dif
teemperor added a comment.
I have to agree with @kastiglione that this isn't very intuitive. I doubt that
more than a handful of users are aware that "raw commands" are a thing, so I
think this inconsistency is for once in favor of the user. LLDB commands are
anyway not meant to be stable, so w
labath added a comment.
I'm not married to the current way we process commands, but I do value their
consistency (both between different commands, and between a command and their
documentation). This would make `script` behave differently than `expr` even
though they have identical modes of ope
ymandel updated this revision to Diff 289623.
ymandel added a comment.
Herald added a subscriber: JDevlieghere.
fix diff base; make small clang-tidy suggested change
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87031/new/
https://reviews.llvm.org/
luismarques updated this revision to Diff 289696.
luismarques added a comment.
- Fix list of callee saved registers;
- Fix typo;
- Fix trivial clang-format issue.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62732/new/
https://reviews.llvm.org/D62
luismarques added a comment.
@labath @jrtc27 @clayborg Now that we have at least 3 open-source debug servers
that we can use to test this with (OpenOCD, QEMU gdbstub, gdbserver) perhaps
this can be merged? I had very good results using this patch with OpenOCD. This
patch doesn't include automat
luismarques commandeered this revision.
luismarques added a reviewer: simoncook.
luismarques added a comment.
Commandeering the patch, as discussed in the last RISC-V sync-up call. I'll
update it with only minor changes; further development can be done in follow-up
patches.
Repository:
rG LL
wallace added a comment.
Fair enough. I'll work on a document. Hopefully the feedback is going to be
good :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86670/new/
https://reviews.llvm.org/D86670
___
aadsm created this revision.
aadsm added reviewers: clayborg, labath.
Herald added subscribers: lldb-commits, mgorny.
Herald added a project: LLDB.
aadsm requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added subscribers: sstefan1, JDevlieghere.
I found a few cases whe
aadsm added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:441
+ if (first_code_section_sp)
+m_first_code_address = first_code_section_sp->GetFileAddress();
+}
I'm actually not 100% sure about this, can there be new cod
aadsm created this revision.
aadsm added reviewers: clayborg, labath.
Herald added a reviewer: shafik.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
aadsm requested review of this revision.
Herald added a subscriber: JDevlieghere.
This is a similar patch to https://reviews
aadsm added inline comments.
Comment at: lldb/unittests/SymbolFile/DWARF/Inputs/test-invalid-offsets.yaml:1
+# int foo() {
+# return 42;
I should rename this to `test-invalid-addresses.yaml` instead.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
clayborg requested changes to this revision.
clayborg added inline comments.
This revision now requires changes to proceed.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:437-441
+ auto first_code_section_sp =
+ m_objfile_sp->GetModule()->GetSectionLis
clayborg added inline comments.
Comment at:
lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2265-2267
+auto base_address = func_range.GetBaseAddress();
+if (base_address.IsSectionOffset() &&
+base_address.GetSection()->GetType() == eSectionTypeCode)
aadsm added inline comments.
Comment at: lldb/unittests/SymbolFile/DWARF/Inputs/test-invalid-offsets.yaml:520
+ Data:0
+...
clayborg wrote:
> aadsm wrote:
> > I generated this yaml with the code that is at the top, and then changed it
> > to
aadsm added inline comments.
Comment at:
lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2265-2267
+auto base_address = func_range.GetBaseAddress();
+if (base_address.IsSectionOffset() &&
+base_address.GetSection()->GetType() == eSectionTypeCode) {
-
20 matches
Mail list logo
