[Lldb-commits] [PATCH] D85070: [intel-pt] Refactor 2: create a new folder structure

2020-08-01 Thread walter erquinigo via Phabricator via lldb-commits
wallace created this revision. wallace added a reviewer: clayborg. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. wallace requested review of this revision. Herald added a subscriber: JDevlieghere. Depends on D85068 . The existing fo

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

2020-08-01 Thread Shu Anzai via Phabricator via lldb-commits
gedatsu217 added a comment. Although I thought of how to clear all the following characters, I did not come up with it. So, I will try to fill the space. Should I add how many spaces? If I add too many spaces, sequences will be two lines, but if I add a few spaces, I can't handle some of the c

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

2020-08-01 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. In D81001#218 , @gedatsu217 wrote: > Although I thought of how to clear all the following characters, I did not > come up with it. So, I will try to fill the space. Should I add how many > spaces? If I add too many spaces,

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

2020-08-01 Thread Shu Anzai via Phabricator via lldb-commits
gedatsu217 added a comment. > Also could you rebase the diff here when you have time (e.g., regenerate the > diff from you changes on top of the latest master commit)? It no longer > applies at the moment without having to manually resolve a conflict. Does this mean that I should generate diff

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

2020-08-01 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. In D81001#2189008 , @gedatsu217 wrote: >> Also could you rebase the diff here when you have time (e.g., regenerate the >> diff from you changes on top of the latest master commit)? It no longer >> applies at the moment without

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

2020-08-01 Thread Shu Anzai via Phabricator via lldb-commits
gedatsu217 updated this revision to Diff 282430. gedatsu217 added a comment. Add spaces when a character is typed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81001/new/ https://reviews.llvm.org/D81001 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/Core/IOHandler.h