[Lldb-commits] [lldb] 1b2d2d7 - [LLDB][NFC] Remove redundant condition

Author: Adam Balogh Date: 2020-07-01T09:04:26+02:00 New Revision: 1b2d2d70e1ec161878a78d880fb8972550b88185 URL: https://github.com/llvm/llvm-project/commit/1b2d2d70e1ec161878a78d880fb8972550b88185 DIFF: https://github.com/llvm/llvm-project/commit/1b2d2d70e1ec161878a78d880fb8972550b88185.diff L

[Lldb-commits] [lldb] ff2d091 - [LLDB][Clang Integration][NFC] Remove redundant condition

Author: Adam Balogh Date: 2020-07-01T09:04:26+02:00 New Revision: ff2d09148c91784c35b43c52f14b1501f38dd4c5 URL: https://github.com/llvm/llvm-project/commit/ff2d09148c91784c35b43c52f14b1501f38dd4c5 DIFF: https://github.com/llvm/llvm-project/commit/ff2d09148c91784c35b43c52f14b1501f38dd4c5.diff L

[Lldb-commits] [PATCH] D82558: [LLDB][NFC] Remove redundant condition

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b2d2d70e1ec: [LLDB][NFC] Remove redundant condition (authored by baloghadamsoftware). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82558/new/ https://revi

[Lldb-commits] [PATCH] D82559: [LLDB][Clang Integration][NFC] Remove redundant condition

This revision was automatically updated to reflect the committed changes. Closed by commit rGff2d09148c91: [LLDB][Clang Integration][NFC] Remove redundant condition (authored by baloghadamsoftware). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82559

[Lldb-commits] [lldb] 8270a90 - [lldb] Scalar re-fix UB in float->int conversions

Author: Pavel Labath Date: 2020-07-01T10:29:42+02:00 New Revision: 8270a903baf55122289499ba00a979e9c04dcd44 URL: https://github.com/llvm/llvm-project/commit/8270a903baf55122289499ba00a979e9c04dcd44 DIFF: https://github.com/llvm/llvm-project/commit/8270a903baf55122289499ba00a979e9c04dcd44.diff

Re: [Lldb-commits] [lldb] 2501e86 - [lldb/Scalar] Fix undefined behavior

On 30/06/2020 21:42, Jonas Devlieghere via lldb-commits wrote: > + Pavel for post-commit review. > > I've reinstated the original behavior to fix the UBSan error on the bot. > Please let me know if you prefer a different approach.  > Thanks for catching that. In 8270a903b, I've extended this beh

[Lldb-commits] [lldb] 56bb1d1 - [lldb/api] Improve error reporting in SBBreakpoint::AddName (NFCI)

Author: Med Ismail Bennani Date: 2020-07-01T12:37:00+02:00 New Revision: 56bb1d1755ae38b4e7a67f775978b18a601f215f URL: https://github.com/llvm/llvm-project/commit/56bb1d1755ae38b4e7a67f775978b18a601f215f DIFF: https://github.com/llvm/llvm-project/commit/56bb1d1755ae38b4e7a67f775978b18a601f215f.

[Lldb-commits] [PATCH] D82879: [lldb/api] Improve error reporting in SBBreakpoint::AddName (NFCI)

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM with some minor nits. Comment at: lldb/include/lldb/API/SBBreakpoint.h:108 + SBError AddNameWithErrorHandling(const char *new_name); + I wish w

[Lldb-commits] [lldb] a61f62a - Revert "[lldb/api] Improve error reporting in SBBreakpoint::AddName (NFCI)"

Author: Med Ismail Bennani Date: 2020-07-01T12:41:32+02:00 New Revision: a61f62a7b605a9077672b4f49021d84ed0cf12d9 URL: https://github.com/llvm/llvm-project/commit/a61f62a7b605a9077672b4f49021d84ed0cf12d9 DIFF: https://github.com/llvm/llvm-project/commit/a61f62a7b605a9077672b4f49021d84ed0cf12d9.

[Lldb-commits] [lldb] f70cad2 - [lldb/api] Improve error reporting in SBBreakpoint::AddName (NFCI)

Author: Med Ismail Bennani Date: 2020-07-01T12:45:05+02:00 New Revision: f70cad26121543c0a29b9a2c400b02c659210d71 URL: https://github.com/llvm/llvm-project/commit/f70cad26121543c0a29b9a2c400b02c659210d71 DIFF: https://github.com/llvm/llvm-project/commit/f70cad26121543c0a29b9a2c400b02c659210d71.

[Lldb-commits] [PATCH] D82879: [lldb/api] Improve error reporting in SBBreakpoint::AddName (NFCI)

This revision was automatically updated to reflect the committed changes. mib marked an inline comment as done. Closed by commit rGf70cad261215: [lldb/api] Improve error reporting in SBBreakpoint::AddName (NFCI) (authored by mib). Changed prior to commit: https://reviews.llvm.org/D82879?vs=2746

[Lldb-commits] [PATCH] D81561: [lldb] Add basic -flimit-debug-info support to expression evaluator

labath marked an inline comment as done. labath added a comment. So, what do you make of this patch now, Raphael? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81561/new/ https://reviews.llvm.org/D81561 __

[Lldb-commits] [PATCH] D81561: [lldb] Add basic -flimit-debug-info support to expression evaluator

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM beside the `_check_type` check always passing as discussed on IRC. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81561/new/ h

[Lldb-commits] [PATCH] D81561: [lldb] Add basic -flimit-debug-info support to expression evaluator

labath updated this revision to Diff 274768. labath added a comment. - redo the sanity check in the test (get_field_array does not include inherited types) - skip gmodules test flavours due to pr46284 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[Lldb-commits] [lldb] a03dc8c - [lldb] Add basic -flimit-debug-info support to expression evaluator

Author: Pavel Labath Date: 2020-07-01T14:50:14+02:00 New Revision: a03dc8c9fa8e9c5cf8fac1a9ad0fdad7df41 URL: https://github.com/llvm/llvm-project/commit/a03dc8c9fa8e9c5cf8fac1a9ad0fdad7df41 DIFF: https://github.com/llvm/llvm-project/commit/a03dc8c9fa8e9c5cf8fac1a9ad0fdad7df41.diff

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

labath added a comment. There's always a chance for ODR violations, particularly with header files defining static objects. This looks better though what I really wanted was to keep the non-sve register info array (`g_register_infos_arm64_le`) completely out of the path of the sve header. Like,

[Lldb-commits] [PATCH] D81561: [lldb] Add basic -flimit-debug-info support to expression evaluator

This revision was automatically updated to reflect the committed changes. Closed by commit rGa03dc8c9fa8e: [lldb] Add basic -flimit-debug-info support to expression evaluator (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81561/n

[Lldb-commits] [lldb] f3b5bf3 - [lldb] Fix NSDate test after Scalar change

Author: Raphael Isemann Date: 2020-07-01T16:00:10+02:00 New Revision: f3b5bf3eb7029238cead637be2e285b443b2e141 URL: https://github.com/llvm/llvm-project/commit/f3b5bf3eb7029238cead637be2e285b443b2e141 DIFF: https://github.com/llvm/llvm-project/commit/f3b5bf3eb7029238cead637be2e285b443b2e141.dif

Re: [Lldb-commits] [lldb] f3b5bf3 - [lldb] Fix NSDate test after Scalar change

On 01/07/2020 16:02, Raphael Isemann via lldb-commits wrote: > > Author: Raphael Isemann > Date: 2020-07-01T16:00:10+02:00 > New Revision: f3b5bf3eb7029238cead637be2e285b443b2e141 > > URL: > https://github.com/llvm/llvm-project/commit/f3b5bf3eb7029238cead637be2e285b443b2e141 > DIFF: > https://g

[Lldb-commits] [lldb] 1276855 - [lldb] Attempt to fix TestLimitDebugInfo on windows

Author: Pavel Labath Date: 2020-07-01T16:56:56+02:00 New Revision: 1276855f2b4485ec312b379c1b8eaf5510d9b157 URL: https://github.com/llvm/llvm-project/commit/1276855f2b4485ec312b379c1b8eaf5510d9b157 DIFF: https://github.com/llvm/llvm-project/commit/1276855f2b4485ec312b379c1b8eaf5510d9b157.diff

[Lldb-commits] [lldb] 9010cef - [lldb] Replace StringConvert with llvm::to_integer when parsing integer values in CommandObjects

Author: Raphael Isemann Date: 2020-07-01T17:19:31+02:00 New Revision: 9010cef2af0affdef774a721f6adb52a40041da5 URL: https://github.com/llvm/llvm-project/commit/9010cef2af0affdef774a721f6adb52a40041da5 DIFF: https://github.com/llvm/llvm-project/commit/9010cef2af0affdef774a721f6adb52a40041da5.dif

[Lldb-commits] [PATCH] D82297: [lldb] Replace StringConvert with llvm::to_integer when parsing integer values in CommandObjects

This revision was automatically updated to reflect the committed changes. Closed by commit rG9010cef2af0a: [lldb] Replace StringConvert with llvm::to_integer when parsing integer values… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior

[Lldb-commits] [PATCH] D82616: Improve the detection of iOS/tvOS/watchOS simulator binaries in debugserver and lldb

teemperor added a comment. I guess this is breaking the Green Dragon tests as it's in the blame list: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/22121/ Failing Tests: lldb-api.tools/lldb-server.TestAppleSimulatorOSType.py lldb-api.tools/lldb-server.TestGdbRemoteAttach.py lld

[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

aprantl added inline comments. Comment at: lldb/include/lldb/Host/Host.h:231 + /// Check whether a process is translated (Rosetta). + /// \arg process_info The info structure for the process queried. labath wrote: > aprantl wrote: > > davide wrote: > > > apra

[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. From my side this is good to go once everybody else's concerns are addressed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82813/new/ https://reviews.llvm.org/D82813 ___

[Lldb-commits] [lldb] 98c3a38 - Revert "Improve the detection of iOS/tvOS/watchOS simulator binaries in"

Author: Jonas Devlieghere Date: 2020-07-01T10:46:19-07:00 New Revision: 98c3a38a1967ece4e70891aa188c51e29ca0f8d3 URL: https://github.com/llvm/llvm-project/commit/98c3a38a1967ece4e70891aa188c51e29ca0f8d3 DIFF: https://github.com/llvm/llvm-project/commit/98c3a38a1967ece4e70891aa188c51e29ca0f8d3.d

[Lldb-commits] [lldb] 116b103 - Revert "Revert "Improve the detection of iOS/tvOS/watchOS simulator binaries in""

Author: Adrian Prantl Date: 2020-07-01T11:06:15-07:00 New Revision: 116b1033738f9a409e502e270dbf1c9e04f5b1ad URL: https://github.com/llvm/llvm-project/commit/116b1033738f9a409e502e270dbf1c9e04f5b1ad DIFF: https://github.com/llvm/llvm-project/commit/116b1033738f9a409e502e270dbf1c9e04f5b1ad.diff

[Lldb-commits] [lldb] 278874f - debugserver: Return a nullptr in GetPlatformString()

Author: Adrian Prantl Date: 2020-07-01T11:06:25-07:00 New Revision: 278874f07f7315e0f7fda3202597e7ab2e94ed1a URL: https://github.com/llvm/llvm-project/commit/278874f07f7315e0f7fda3202597e7ab2e94ed1a DIFF: https://github.com/llvm/llvm-project/commit/278874f07f7315e0f7fda3202597e7ab2e94ed1a.diff

[Lldb-commits] [lldb] d9d992b - [lldb/API] Add missing LLDB_RECORD_RESULT

Author: Jonas Devlieghere Date: 2020-07-01T14:41:11-07:00 New Revision: d9d992bb8809820c50820b3e703d33d5fcb51385 URL: https://github.com/llvm/llvm-project/commit/d9d992bb8809820c50820b3e703d33d5fcb51385 DIFF: https://github.com/llvm/llvm-project/commit/d9d992bb8809820c50820b3e703d33d5fcb51385.d

[Lldb-commits] [PATCH] D82732: WIP: Use SB APIs in CommandObjects

JDevlieghere added a comment. Given that the SB API is stable I wonder if we should be proactive and have these new functions return `SBError` instead of a bool so that they can be extended if we ever to decide to return a useful error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D43048: [lldb-test/WIP] Allow a way to test autocompletion

davide abandoned this revision. davide added a comment. Cleaning up my queue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43048/new/ https://reviews.llvm.org/D43048 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [PATCH] D83008: Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source

shafik created this revision. shafik added reviewers: teemperor, jingham, jasonmolenda, friss. Herald added a subscriber: kristof.beyls. shafik marked an inline comment as done. shafik added a subscriber: rsmith. shafik added inline comments. Comment at: clang/lib/AST/RecordLayou

[Lldb-commits] [PATCH] D83008: Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source

shafik marked an inline comment as done. shafik added a subscriber: rsmith. shafik added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1190 if (UseExternalLayout) { -// FIXME: This appears to be reversed. if (Base->IsVirtual) @rsm

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

omjavaid marked 6 inline comments as done. omjavaid added a comment. In D77047#2125220 , @labath wrote: > There's always a chance for ODR violations, particularly with header files > defining static objects. This looks better though what I really wanted w

[Lldb-commits] [PATCH] D81697: Add support for batch-testing to the LLDB testsuite.

bbli added a comment. Hi, bumping my post from two weeks ago. The main question I had was: would it be ok if I just brought over the Outcome object for the time being? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81697/new/ https://reviews.llvm.o

[Lldb-commits] [lldb] c9f251a - [lldb/build.py] Always pass an SDK to the compiler on Darwin

Author: Fred Riss Date: 2020-07-01T20:27:38-07:00 New Revision: c9f251aa6f6221a45d926bc12bd25d1833e5d945 URL: https://github.com/llvm/llvm-project/commit/c9f251aa6f6221a45d926bc12bd25d1833e5d945 DIFF: https://github.com/llvm/llvm-project/commit/c9f251aa6f6221a45d926bc12bd25d1833e5d945.diff LOG

[Lldb-commits] [lldb] 61d22ef - [lldb/ObjCRuntime] Implement support for small method lists

Author: Fred Riss Date: 2020-07-01T20:27:37-07:00 New Revision: 61d22ef236206f17d7abcdcdf9da3c99074432d5 URL: https://github.com/llvm/llvm-project/commit/61d22ef236206f17d7abcdcdf9da3c99074432d5 DIFF: https://github.com/llvm/llvm-project/commit/61d22ef236206f17d7abcdcdf9da3c99074432d5.diff LOG

[Lldb-commits] [lldb] 4a674b6 - [lldb/ObjC] Add support for direct selector references

Author: Fred Riss Date: 2020-07-01T20:27:37-07:00 New Revision: 4a674b623796dc5c5778fc6998f788044137d61d URL: https://github.com/llvm/llvm-project/commit/4a674b623796dc5c5778fc6998f788044137d61d DIFF: https://github.com/llvm/llvm-project/commit/4a674b623796dc5c5778fc6998f788044137d61d.diff LOG

[Lldb-commits] [PATCH] D83023: [lldb/ObjectFileMachO] Fetch shared cache images from our own shared cache

friss created this revision. friss added reviewers: jasonmolenda, labath. Herald added projects: LLDB, LLVM. Herald added a subscriber: llvm-commits. On macOS 11, the libraries that have been integrated in the system shared cache are not present on the filesystem anymore. LLDB was using those file

[Lldb-commits] [PATCH] D83023: [lldb/ObjectFileMachO] Fetch shared cache images from our own shared cache

friss added a comment. @labath I tagged you mostly for the generic parts of the patch. I don't suppose you care a lot about `ObjectFileMachO.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83023/new/ https://reviews.llvm.org/D83023 _