Author: Kirill Bobyrev
Date: 2020-06-15T10:18:59+02:00
New Revision: 2d8f8c4de38e592eb4fcf6a4ed858763974f8b9f
URL:
https://github.com/llvm/llvm-project/commit/2d8f8c4de38e592eb4fcf6a4ed858763974f8b9f
DIFF:
https://github.com/llvm/llvm-project/commit/2d8f8c4de38e592eb4fcf6a4ed858763974f8b9f.diff
ukalnins created this revision.
ukalnins added a reviewer: jasonmolenda.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
When process, that debugserver is attached to, exits, there is a race condition
if the process STDIO will be consumed and appened to internal stdio buffer
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81783/new/
https://reviews.llvm.org/D81783
___
lldb-commits mailing list
lldb-c
ukalnins updated this revision to Diff 270732.
ukalnins added a comment.
Fixed merge conflict.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81838/new/
https://reviews.llvm.org/D81838
Files:
lldb/tools/debugserver/source/DNB.cpp
lldb/tools/debugserver/source/DNB.h
lldb/tools/debu
kwk marked an inline comment as done.
kwk added inline comments.
Comment at: lldb/source/Core/SearchFilter.cpp:732
+FileSpec cu_spec;
+if (sym_ctx.comp_unit) {
+ cu_spec = sym_ctx.comp_unit->GetPrimaryFile();
jankratochvil wrote:
> This condition is
jankratochvil marked an inline comment as done.
jankratochvil added inline comments.
Comment at: lldb/source/Core/SearchFilter.cpp:732
+FileSpec cu_spec;
+if (sym_ctx.comp_unit) {
+ cu_spec = sym_ctx.comp_unit->GetPrimaryFile();
kwk wrote:
> jankrato
Author: Jonas Devlieghere
Date: 2020-06-15T09:27:17-07:00
New Revision: d74323606d9c618a2a7c269b9ba3ffefa660cdc2
URL:
https://github.com/llvm/llvm-project/commit/d74323606d9c618a2a7c269b9ba3ffefa660cdc2
DIFF:
https://github.com/llvm/llvm-project/commit/d74323606d9c618a2a7c269b9ba3ffefa660cdc2.d
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd74323606d9c: [lldb] Remove indentation before help output.
(authored by JDevlieghere).
Herald added a project: LLDB.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llv
wallace updated this revision to Diff 270804.
wallace edited the summary of this revision.
wallace removed a reviewer: kusmour.
wallace added a comment.
The tests were weird indeed, I think I had to revisit them after making some
changes.
Anyway, I've updated the tests and they do make sense now.
teemperor added inline comments.
Comment at: lldb/source/Core/Debugger.cpp:349
+bool Debugger::GetUseAutosuggestion() const {
+ const uint32_t idx = ePropertyShowAutosuggestion;
gedatsu217 wrote:
> teemperor wrote:
> > You declared the function, but you don't
JDevlieghere added a comment.
I tried out the patch and I have a few observations:
- For me the faint modifier doesn't do anything. Of course it might just be my
shell/theme, but we should check whether this modifier is widely supported.
Additionally, this modified should be configurable.
- The
jingham added a comment.
Just to be clear, the lldb -> gdb command map doesn't prescribe behavior for
lldb commands. It just suggests the analogous command in gdb. We are still
free to implement lldb behavior however seems best to us.
The logic in lldb doesn't change the logic of the program'
clayborg added a comment.
Hey Jonas, any idea if this could be cherry picked into a 11.5.1 update at any
point? The performance is hindering 11.4.1 and 11.5 clients at Facebook.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81589/new/
https://revi
Author: Jonas Devlieghere
Date: 2020-06-15T15:38:28-07:00
New Revision: 64ec505dd46832880350e8b45316eaed30b458dc
URL:
https://github.com/llvm/llvm-project/commit/64ec505dd46832880350e8b45316eaed30b458dc
DIFF:
https://github.com/llvm/llvm-project/commit/64ec505dd46832880350e8b45316eaed30b458dc.d
Author: Jason Molenda
Date: 2020-06-15T16:37:56-07:00
New Revision: 480a383551e96d9f6fb0ddcdcc9d893faf37e5b3
URL:
https://github.com/llvm/llvm-project/commit/480a383551e96d9f6fb0ddcdcc9d893faf37e5b3
DIFF:
https://github.com/llvm/llvm-project/commit/480a383551e96d9f6fb0ddcdcc9d893faf37e5b3.diff
JDevlieghere created this revision.
JDevlieghere added reviewers: labath, teemperor.
JDevlieghere updated this revision to Diff 270924.
JDevlieghere added a comment.
Add test
This bug has been bothering me for a while. When you do something like the
commands below, you'd get bombarded by a wall
JDevlieghere updated this revision to Diff 270924.
JDevlieghere added a comment.
Add test
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81898/new/
https://reviews.llvm.org/D81898
Files:
lldb/source/Interpreter/embedded_interpreter.py
lldb/test/Shell/ScriptInterpreter/Python/eof.tes
Author: Jonas Devlieghere
Date: 2020-06-15T18:22:22-07:00
New Revision: 0965b59bf429630e6eafe725cc3444095ba0c222
URL:
https://github.com/llvm/llvm-project/commit/0965b59bf429630e6eafe725cc3444095ba0c222
DIFF:
https://github.com/llvm/llvm-project/commit/0965b59bf429630e6eafe725cc3444095ba0c222.d
Author: Jonas Devlieghere
Date: 2020-06-15T18:25:57-07:00
New Revision: 18e356b75d039a23c805c40d1ee2dbb387e40128
URL:
https://github.com/llvm/llvm-project/commit/18e356b75d039a23c805c40d1ee2dbb387e40128
DIFF:
https://github.com/llvm/llvm-project/commit/18e356b75d039a23c805c40d1ee2dbb387e40128.d
Author: Jonas Devlieghere
Date: 2020-06-15T20:48:55-07:00
New Revision: 8d2acfc40e3bbfa1e58da21870c61bddc7c9523f
URL:
https://github.com/llvm/llvm-project/commit/8d2acfc40e3bbfa1e58da21870c61bddc7c9523f
DIFF:
https://github.com/llvm/llvm-project/commit/8d2acfc40e3bbfa1e58da21870c61bddc7c9523f.d
Author: Jonas Devlieghere
Date: 2020-06-15T21:07:43-07:00
New Revision: 93571c3c3b2f67c8225861033239706ca950
URL:
https://github.com/llvm/llvm-project/commit/93571c3c3b2f67c8225861033239706ca950
DIFF:
https://github.com/llvm/llvm-project/commit/93571c3c3b2f67c8225861033239706ca950.d
Author: Jonas Devlieghere
Date: 2020-06-15T21:15:35-07:00
New Revision: 5ddd4fc5a65a452dffa2d27ad6a5c04d148d6234
URL:
https://github.com/llvm/llvm-project/commit/5ddd4fc5a65a452dffa2d27ad6a5c04d148d6234
DIFF:
https://github.com/llvm/llvm-project/commit/5ddd4fc5a65a452dffa2d27ad6a5c04d148d6234.d
Author: Jonas Devlieghere
Date: 2020-06-15T21:34:13-07:00
New Revision: 388afd8406a07817b8663281bf3d06f87d46dfd7
URL:
https://github.com/llvm/llvm-project/commit/388afd8406a07817b8663281bf3d06f87d46dfd7
DIFF:
https://github.com/llvm/llvm-project/commit/388afd8406a07817b8663281bf3d06f87d46dfd7.d
23 matches
Mail list logo
