[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 266463. kwk marked 3 inline comments as done. kwk added a comment. Herald added a subscriber: sstefan1. - rebase - Rename function in test from inlined_42 to function_in_header - Typo: compulation -> compilation Repository: rG LLVM Github Monorepo CHANGES SIN

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 266465. kwk marked 3 inline comments as done. kwk added a comment. - use %t in files created in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files: lldb/source/B

[Lldb-commits] [lldb] 019bd64 - [lldb] Don't complete ObjCInterfaceDecls in ClangExternalASTSourceCallbacks::FindExternalVisibleDeclsByName

Author: Raphael Isemann Date: 2020-05-27T12:39:24+02:00 New Revision: 019bd6485c52a62c008eacfdf0d13a26ca6b0a6f URL: https://github.com/llvm/llvm-project/commit/019bd6485c52a62c008eacfdf0d13a26ca6b0a6f DIFF: https://github.com/llvm/llvm-project/commit/019bd6485c52a62c008eacfdf0d13a26ca6b0a6f.dif

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk marked 2 inline comments as done. kwk added inline comments. Comment at: lldb/test/Shell/Breakpoint/Inputs/search-support-files.h:1 +int inlined_42() { return 42; } labath wrote: > Calling this `inlined` is misleading. The function won't get inlined anywhere

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 266472. kwk added a comment. - make test CHECKs less strict Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files: lldb/source/Breakpoint/BreakpointResolverName.cpp lld

[Lldb-commits] [PATCH] D80556: [lldb] Don't complete ObjCInterfaceDecls in ClangExternalASTSourceCallbacks::FindExternalVisibleDeclsByName

This revision was automatically updated to reflect the committed changes. Closed by commit rG019bd6485c52: [lldb] Don't complete ObjCInterfaceDecls in ClangExternalASTSourceCallbacks… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG

[Lldb-commits] [lldb] 18bb1f1 - [lldb] Fix a potential bug that may cause assert failure in CommandObject::CheckRequirements

Author: Raphael Isemann Date: 2020-05-27T14:05:17+02:00 New Revision: 18bb1f1067028fbeaf92774e640bd865c53e1ce1 URL: https://github.com/llvm/llvm-project/commit/18bb1f1067028fbeaf92774e640bd865c53e1ce1 DIFF: https://github.com/llvm/llvm-project/commit/18bb1f1067028fbeaf92774e640bd865c53e1ce1.dif

[Lldb-commits] [lldb] 763bc23 - [lldb] Tab completion for process plugin name

Author: Gongyu Deng Date: 2020-05-27T14:11:16+02:00 New Revision: 763bc2305797c980a4f4fa2f6314ed78a010678d URL: https://github.com/llvm/llvm-project/commit/763bc2305797c980a4f4fa2f6314ed78a010678d DIFF: https://github.com/llvm/llvm-project/commit/763bc2305797c980a4f4fa2f6314ed78a010678d.diff L

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 266493. kwk marked an inline comment as done. kwk added a comment. - don't hard-code --color and --dump-input on FileCheck invocation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D80447: [lldb] Fix a potential bug that may cause assert failure in CommandObject::CheckRequirements

This revision was automatically updated to reflect the committed changes. Closed by commit rG18bb1f106702: [lldb] Fix a potential bug that may cause assert failure in CommandObject… (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [PATCH] D79929: [lldb] Tab completion for process plugin name

This revision was automatically updated to reflect the committed changes. Closed by commit rG763bc2305797: [lldb] Tab completion for process plugin name (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Changed prior to commit: https://reviews.llvm.org/D7992

[Lldb-commits] [PATCH] D79929: [lldb] Tab completion for process plugin name

jingham added a comment. This change makes the eArgTypePlugin be the completion for process plugins. Shouldn't we change the enum name and completion name to indicate that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79929/new/ https://reviews.

[Lldb-commits] [lldb] 74a5175 - [lldb] Make order of completions for expressions deterministic and sorted by Clang's priority values.

Author: Raphael Isemann Date: 2020-05-27T19:22:01+02:00 New Revision: 74a51753a6c2c587f650174e19f99279e8e4ef35 URL: https://github.com/llvm/llvm-project/commit/74a51753a6c2c587f650174e19f99279e8e4ef35 DIFF: https://github.com/llvm/llvm-project/commit/74a51753a6c2c587f650174e19f99279e8e4ef35.dif

[Lldb-commits] [lldb] e7f1067 - [lldb/Reproducers] Skip API logging in the DUMMY macro

Author: Jonas Devlieghere Date: 2020-05-27T10:35:43-07:00 New Revision: e7f1067ad6f116ff1e4bfc0f7fe1977f172b0ea0 URL: https://github.com/llvm/llvm-project/commit/e7f1067ad6f116ff1e4bfc0f7fe1977f172b0ea0 DIFF: https://github.com/llvm/llvm-project/commit/e7f1067ad6f116ff1e4bfc0f7fe1977f172b0ea0.d

[Lldb-commits] [PATCH] D80292: [lldb] Make order of completions for expressions deterministic and sorted by Clang's priority values.

This revision was automatically updated to reflect the committed changes. Closed by commit rG74a51753a6c2: [lldb] Make order of completions for expressions deterministic and sorted by… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG

[Lldb-commits] [lldb] c30c236 - [lldb/Reproducers] Skip tests relying on timeouts

Author: Jonas Devlieghere Date: 2020-05-27T12:08:41-07:00 New Revision: c30c2368c77f05a1447bb7442c6ac2fad2912a57 URL: https://github.com/llvm/llvm-project/commit/c30c2368c77f05a1447bb7442c6ac2fad2912a57 DIFF: https://github.com/llvm/llvm-project/commit/c30c2368c77f05a1447bb7442c6ac2fad2912a57.d

[Lldb-commits] [lldb] fe9d844 - [lldb/Test] Generate YAML binary in build directory

Author: Jonas Devlieghere Date: 2020-05-27T12:08:41-07:00 New Revision: fe9d8442e0dfc8c83e9a0a31f5079e7a70b54d9d URL: https://github.com/llvm/llvm-project/commit/fe9d8442e0dfc8c83e9a0a31f5079e7a70b54d9d DIFF: https://github.com/llvm/llvm-project/commit/fe9d8442e0dfc8c83e9a0a31f5079e7a70b54d9d.d

[Lldb-commits] [lldb] 3345521 - Also cache negative results in GetXcodeSDKPath (NFC)

Author: Adrian Prantl Date: 2020-05-27T12:26:04-07:00 New Revision: 334552150770faaa407fecab42f5333bb2a898a6 URL: https://github.com/llvm/llvm-project/commit/334552150770faaa407fecab42f5333bb2a898a6 DIFF: https://github.com/llvm/llvm-project/commit/334552150770faaa407fecab42f5333bb2a898a6.diff

[Lldb-commits] [PATCH] D80595: Also cache negative results in GetXcodeSDKPath (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG334552150770: Also cache negative results in GetXcodeSDKPath (NFC) (authored by aprantl). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D80659: [lldb-vscode] Redirect stderr and stdout to DAPs console message

aadsm created this revision. aadsm added reviewers: clayborg, labath, rmaz. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Doing this for 2 main reasons: - Avoid stdout from corrupting DAP messages - Make sure we can see in VSCode (or any other DAP client) the same output

[Lldb-commits] [lldb] f9bea9b - [lldb/Reproducers] Skip & add FIXME to tests failing with unexpected packet.

Author: Jonas Devlieghere Date: 2020-05-27T13:52:48-07:00 New Revision: f9bea9bc4acf4c412eab4767c31674d0caa60322 URL: https://github.com/llvm/llvm-project/commit/f9bea9bc4acf4c412eab4767c31674d0caa60322 DIFF: https://github.com/llvm/llvm-project/commit/f9bea9bc4acf4c412eab4767c31674d0caa60322.d

[Lldb-commits] [lldb] 5f97a54 - [lldb/Reproducers] Differentiate active and passive replay unexpected packet.

Author: Jonas Devlieghere Date: 2020-05-27T13:52:38-07:00 New Revision: 5f97a540ad8dd4baac47873fa4bdfba2f37e0f82 URL: https://github.com/llvm/llvm-project/commit/5f97a540ad8dd4baac47873fa4bdfba2f37e0f82 DIFF: https://github.com/llvm/llvm-project/commit/5f97a540ad8dd4baac47873fa4bdfba2f37e0f82.d

[Lldb-commits] [PATCH] D79752: [lldb] Move ClangModulesDeclVendor ownership to ClangPersistentVariables

shafik added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp:854 - ClangModulesDeclVendor *modules_decl_vendor = - m_target->GetClangModulesDeclVendor(); + auto *persistent_vars = llvm::cast( + m_target->GetPersistentExpres

[Lldb-commits] [lldb] a57a67c - Fix a use-after-free in GetXcodeSDKPath

Author: Adrian Prantl Date: 2020-05-27T14:27:16-07:00 New Revision: a57a67c59b3f7529f4aa30009b214248772b544b URL: https://github.com/llvm/llvm-project/commit/a57a67c59b3f7529f4aa30009b214248772b544b DIFF: https://github.com/llvm/llvm-project/commit/a57a67c59b3f7529f4aa30009b214248772b544b.diff

[Lldb-commits] [PATCH] D80666: Fix a use-after-free in GetXcodeSDKPath

aprantl created this revision. aprantl added reviewers: JDevlieghere, friss. JDevlieghere accepted this revision. This revision is now accepted and ready to land. I'm sorry, I just introduced this in https://reviews.llvm.org/D80595. Thanks Jonas for noticing! https://reviews.llvm.org/D80666 Fi

[Lldb-commits] [PATCH] D80666: Fix a use-after-free in GetXcodeSDKPath

This revision was automatically updated to reflect the committed changes. Closed by commit rGa57a67c59b3f: Fix a use-after-free in GetXcodeSDKPath (authored by aprantl). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8066

[Lldb-commits] [PATCH] D80680: save_crashlog should not be using the load_addr property of an SBAddress

friss accepted this revision. friss added a comment. This revision is now accepted and ready to land. Thanks for adding a test! this LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80680/new/ https://reviews.llvm.org/D80680 __

[Lldb-commits] [PATCH] D80680: save_crashlog should not be using the load_addr property of an SBAddress

jingham created this revision. jingham added a reviewer: clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. friss accepted this revision. friss added a comment. This revision is now accepted and ready to land. Thanks for adding a test! this LGTM The load_addr proper

[Lldb-commits] [PATCH] D79929: [lldb] Tab completion for process plugin name

MrHate marked an inline comment as done. MrHate added a comment. That does make sense. I will split it into `eArgTypeProcessPlugin` and `eArgTypeDisassemblePlugin` along with the corresponding completion function names at the time I implement the `disassemble` related completion function. Repo

[Lldb-commits] [lldb] 5238b80 - [lldb/Reproducers] Skip or fix the remaining tests.

Author: Jonas Devlieghere Date: 2020-05-27T21:02:36-07:00 New Revision: 5238b80058a6d096220eb9fbf606d9d983f37b0b URL: https://github.com/llvm/llvm-project/commit/5238b80058a6d096220eb9fbf606d9d983f37b0b DIFF: https://github.com/llvm/llvm-project/commit/5238b80058a6d096220eb9fbf606d9d983f37b0b.d

[Lldb-commits] [lldb] e5bb542 - [lldb/Test] Import all decorators.

Author: Jonas Devlieghere Date: 2020-05-27T21:13:08-07:00 New Revision: e5bb542362dfbb6c57a597810d740987afbc4202 URL: https://github.com/llvm/llvm-project/commit/e5bb542362dfbb6c57a597810d740987afbc4202 DIFF: https://github.com/llvm/llvm-project/commit/e5bb542362dfbb6c57a597810d740987afbc4202.d