[Lldb-commits] [PATCH] D76188: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer

2020-03-15 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib marked 7 inline comments as done. mib added inline comments. Comment at: lldb/source/Target/StackFrameRecognizer.cpp:64-72 +m_recognizers.push_front({(uint32_t)m_recognizers.size(), + false, + recognizer, +

[Lldb-commits] [PATCH] D76188: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer

2020-03-15 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib updated this revision to Diff 250405. mib marked an inline comment as done. mib added a reviewer: friss. mib added a comment. Addressed Fred's comments. Added testing for multi-symbol frame recognizers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D76188: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer

2020-03-15 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib updated this revision to Diff 250412. mib added a comment. Add missing test annotation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76188/new/ https://reviews.llvm.org/D76188 Files: lldb/include/lldb/Target/StackFrameRecognizer.h lldb/pa

[Lldb-commits] [PATCH] D76188: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer

2020-03-15 Thread Frederic Riss via Phabricator via lldb-commits
friss added inline comments. Comment at: lldb/test/API/commands/frame/recognizer/TestFrameRecognizer.py:162-167 +lldbutil.run_break_set_by_symbol(self, "bar") +self.runCmd("c") + +process = target.GetProcess() +thread = process.GetSelectedThread()

[Lldb-commits] [PATCH] D76188: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer

2020-03-15 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib updated this revision to Diff 250446. mib added a comment. Refactored test to use `lldbutil.run_to_name_breakpoint`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76188/new/ https://reviews.llvm.org/D76188 Files: lldb/include/lldb/Target/Sta

[Lldb-commits] [lldb] 2059d28 - [lldb/Utils] Use PYTHON_EXECUTABLE to configure lldb-dotest's shebang

2020-03-15 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-03-15T20:34:17-07:00 New Revision: 2059d28bfd3cfedfcf7420f1c4627219811e81c4 URL: https://github.com/llvm/llvm-project/commit/2059d28bfd3cfedfcf7420f1c4627219811e81c4 DIFF: https://github.com/llvm/llvm-project/commit/2059d28bfd3cfedfcf7420f1c4627219811e81c4.d

[Lldb-commits] [lldb] 4c90a52 - [lldb/Process] Include Unwind.h in FreeBSDThread

2020-03-15 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-03-15T20:38:40-07:00 New Revision: 4c90a5297d11c241b00c1f6957d041c9986346ea URL: https://github.com/llvm/llvm-project/commit/4c90a5297d11c241b00c1f6957d041c9986346ea DIFF: https://github.com/llvm/llvm-project/commit/4c90a5297d11c241b00c1f6957d041c9986346ea.d

[Lldb-commits] [lldb] bfedb66 - [lldb/Host] s/FindProcesses/FindProcessesImpl/ in freebsd/Host.cpp

2020-03-15 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-03-15T20:36:40-07:00 New Revision: bfedb663ccf70b511b8f9fcef91ecdb063fd4ab5 URL: https://github.com/llvm/llvm-project/commit/bfedb663ccf70b511b8f9fcef91ecdb063fd4ab5 DIFF: https://github.com/llvm/llvm-project/commit/bfedb663ccf70b511b8f9fcef91ecdb063fd4ab5.d

[Lldb-commits] [PATCH] D76167: [lldb/Utils] Use PYTHON_EXECUTABLE to configurelldb-dotest's shebang

2020-03-15 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG2059d28bfd3c: [lldb/Utils] Use PYTHON_EXECUTABLE to configure lldb-dotest's shebang (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI