[Lldb-commits] [PATCH] D73018: [lldb] Add SystemInitializerAllPlugins and delete copy-pasted Init code in SystemInitializerFull and SystemInitializerTest

teemperor abandoned this revision. teemperor added a comment. This is no longer needed after Jonas' patches. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73018/new/ https://reviews.llvm.org/D73018 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [lldb] 56b03c3 - [lldb] Skip TestWasm.py on sanitized builds until D75200 has landed

Author: Raphael Isemann Date: 2020-02-27T10:45:42+01:00 New Revision: 56b03c35ddecf7d096a513b0633ddf6c49286784 URL: https://github.com/llvm/llvm-project/commit/56b03c35ddecf7d096a513b0633ddf6c49286784 DIFF: https://github.com/llvm/llvm-project/commit/56b03c35ddecf7d096a513b0633ddf6c49286784.dif

[Lldb-commits] [PATCH] D75200: AddressSanitizer failure in MemoryCache

teemperor added a comment. This fixes the asan failures for me, so LGTM. Don't really know that code so someone else should approve this. I skipped the test on the sanitizer build for now ( 56b03c35ddecf7d096a513b0633ddf6c49286784

[Lldb-commits] [lldb] 2affdce - [lldb][NFC] Fix several -Wdocumentation warnings

Author: Raphael Isemann Date: 2020-02-27T11:17:16+01:00 New Revision: 2affdcee615f7f96220fd7a5c4022203f1201822 URL: https://github.com/llvm/llvm-project/commit/2affdcee615f7f96220fd7a5c4022203f1201822 DIFF: https://github.com/llvm/llvm-project/commit/2affdcee615f7f96220fd7a5c4022203f1201822.dif

[Lldb-commits] [lldb] 4bb3cb2 - [lldb] Show the actual error when 'watchpoint set expression' failed

Author: Raphael Isemann Date: 2020-02-27T12:06:51+01:00 New Revision: 4bb3cb2bcb59d2139dfd9fbaa7c475dcf8507242 URL: https://github.com/llvm/llvm-project/commit/4bb3cb2bcb59d2139dfd9fbaa7c475dcf8507242 DIFF: https://github.com/llvm/llvm-project/commit/4bb3cb2bcb59d2139dfd9fbaa7c475dcf8507242.dif

[Lldb-commits] [PATCH] D75241: [lldb] Adjust TestExec code to be closer to real world code

teemperor created this revision. teemperor added reviewers: labath, JDevlieghere. Herald added subscribers: lldb-commits, abidh. Herald added a project: LLDB. For some reason the TestExec test on the macOS bots randomly fails with this error: output: * thread #2, stop reason = EXC_BAD_ACCESS (

[Lldb-commits] [PATCH] D75241: [lldb] Adjust TestExec code to be closer to real world code

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Linux seems to allow a NULL for envp, but it does caution about the unportability of that practice. I doubt changing the argv[0] would be a problem, as that is a fairly common practice, but we

[Lldb-commits] [PATCH] D75200: AddressSanitizer failure in MemoryCache

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Yea, I guess I spoke too soon when I said the fix is going to be easy -- this is quite messy. I believe I understand now why we haven't run into this problem before . Lldb default cache size

[Lldb-commits] [PATCH] D74255: [LLDB] Add support for AVR breakpoints

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. > As Dylan already mentioned, the opcode is indeed for the BREAK instruction. Ok, let's go with that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D74892: [lldb][cmake] Also use local submodule visibility on Darwin

aprantl added a comment. That's great progress! Is the idea to make local submodule visibility the default on Darwin at some point int the future? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74892/new/ https://reviews.llvm.org/D74892 _

[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

labath added a comment. In D74759#1893485 , @unnar wrote: > That should work...although I'm not sure how that is any different to the > range or data being public. If a user modifies anything then it has > essentially invalidated the whole structure anyw

[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

unnar added a comment. In D74759#1895748 , @labath wrote: > In D74759#1893485 , @unnar wrote: > > > That should work...although I'm not sure how that is any different to the > > range or data being public. If a use

[Lldb-commits] [lldb] 256e616 - [LLDB] Fix AddressSanitizer failure in MemoryCache

Author: Paolo Severini Date: 2020-02-27T11:17:10-08:00 New Revision: 256e61699b19c8e3545c948547c12872a8567250 URL: https://github.com/llvm/llvm-project/commit/256e61699b19c8e3545c948547c12872a8567250 DIFF: https://github.com/llvm/llvm-project/commit/256e61699b19c8e3545c948547c12872a8567250.diff

[Lldb-commits] [PATCH] D75275: [lldb/CMake] Use PYTHON_HOME as a hint to find Python 3.

JDevlieghere created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. JDevlieghere added reviewers: amccarth, stella.stamenova. amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. Thanks for helping

[Lldb-commits] [PATCH] D75279: Avoid SourceManager.h include in RawCommentList.h, add missing incs

rnk created this revision. rnk added reviewers: aaron.ballman, hans. Herald added a reviewer: teemperor. Herald added subscribers: lldb-commits, arphaman. Herald added projects: clang, LLDB. SourceManager.h includes FileManager.h, which is expensive due to dependencies on LLVM FS headers. Remove

[Lldb-commits] [PATCH] D75275: [lldb/CMake] Use PYTHON_HOME as a hint to find Python 3.

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. Thanks for helping figure this out! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75275/new/ https://reviews.llvm.org/D75275 _

[Lldb-commits] [PATCH] D75200: [LLDB] AddressSanitizer failure in MemoryCache

This revision was automatically updated to reflect the committed changes. Closed by commit rG256e61699b19: [LLDB] Fix AddressSanitizer failure in MemoryCache (authored by paolosev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75200/new/ https://re

[Lldb-commits] [PATCH] D75279: Avoid SourceManager.h include in RawCommentList.h, add missing incs

hans accepted this revision. hans added a comment. Nice, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75279/new/ https://reviews.llvm.org/D75279 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [PATCH] D75279: Avoid SourceManager.h include in RawCommentList.h, add missing incs

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75279/new/ https://reviews.llvm.org/D75279 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [lldb] 04a91de - [lldb/CMake] Use PYTHON_HOME as a hint to find Python 3.

Author: Jonas Devlieghere Date: 2020-02-27T13:17:49-08:00 New Revision: 04a91deebbb740afb98cc48f519c835fe98ce27b URL: https://github.com/llvm/llvm-project/commit/04a91deebbb740afb98cc48f519c835fe98ce27b DIFF: https://github.com/llvm/llvm-project/commit/04a91deebbb740afb98cc48f519c835fe98ce27b.d

[Lldb-commits] [PATCH] D75275: [lldb/CMake] Use PYTHON_HOME as a hint to find Python 3.

This revision was automatically updated to reflect the committed changes. Closed by commit rG04a91deebbb7: [lldb/CMake] Use PYTHON_HOME as a hint to find Python 3. (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75275/new/

[Lldb-commits] [PATCH] D75279: Avoid SourceManager.h include in RawCommentList.h, add missing incs

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG86565c130942: Avoid SourceManager.h include in RawCommentList.h, add missing incs (authored by rnk). Repository: rG LLV

[Lldb-commits] [lldb] 4c2a656 - Avoid ASTContext.h -> TargetInfo.h dep

Author: Reid Kleckner Date: 2020-02-27T14:35:00-08:00 New Revision: 4c2a6567bb12559cfc091bca2b25ae907cbd4e0f URL: https://github.com/llvm/llvm-project/commit/4c2a6567bb12559cfc091bca2b25ae907cbd4e0f DIFF: https://github.com/llvm/llvm-project/commit/4c2a6567bb12559cfc091bca2b25ae907cbd4e0f.diff

[Lldb-commits] [lldb] e3a9b0f - [Support] Remove byte swapping from MathExtras.h

Author: Reid Kleckner Date: 2020-02-27T17:23:48-08:00 New Revision: e3a9b0f35955ab0fdcba3da713bb2f4cd0b29680 URL: https://github.com/llvm/llvm-project/commit/e3a9b0f35955ab0fdcba3da713bb2f4cd0b29680 DIFF: https://github.com/llvm/llvm-project/commit/e3a9b0f35955ab0fdcba3da713bb2f4cd0b29680.diff

[Lldb-commits] [PATCH] D75330: [lldb] Remove checks behind LLDB_CONFIGURATION_DEBUG from TypeSystemClang

teemperor created this revision. teemperor added a reviewer: aprantl. Herald added subscribers: lldb-commits, JDevlieghere, abidh. Herald added a project: LLDB. This function is (supposed) to be a list of asserts that just do a generic sanity check on declarations we return. Right now this functi