[Lldb-commits] [lldb] 5ff4f88 - [lldb] Ignore type sugar in TypeSystemClang::GetPointerType

Author: Raphael Isemann Date: 2020-02-05T11:44:40+01:00 New Revision: 5ff4f881a7774b8ec8d4db40d2a6c95ddd8a5f21 URL: https://github.com/llvm/llvm-project/commit/5ff4f881a7774b8ec8d4db40d2a6c95ddd8a5f21 DIFF: https://github.com/llvm/llvm-project/commit/5ff4f881a7774b8ec8d4db40d2a6c95ddd8a5f21.dif

[Lldb-commits] [PATCH] D73952: [lldb] Ignore type sugar in TypeSystemClang::GetPointerType

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ff4f881a777: [lldb] Ignore type sugar in TypeSystemClang::GetPointerType (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73952/new/

[Lldb-commits] [PATCH] D74038: [lldb] Make TestDataFormatterObjCCF.py pass outside California

teemperor created this revision. teemperor added a reviewer: mib. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! This test creates its dates with `NSDate dateWithNatura

[Lldb-commits] [PATCH] D74038: [lldb] Make TestDataFormatterObjCCF.py pass outside California

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74038/new/ https://reviews.llvm.org/D74038 ___ lldb-commits mail

[Lldb-commits] [lldb] 8d8bd0d - [lldb] Make TestDataFormatterObjCCF.py pass outside California

Author: Raphael Isemann Date: 2020-02-05T13:24:06+01:00 New Revision: 8d8bd0d6548ed9d2482de341c1b0e53449e5c564 URL: https://github.com/llvm/llvm-project/commit/8d8bd0d6548ed9d2482de341c1b0e53449e5c564 DIFF: https://github.com/llvm/llvm-project/commit/8d8bd0d6548ed9d2482de341c1b0e53449e5c564.dif

[Lldb-commits] [PATCH] D74038: [lldb] Make TestDataFormatterObjCCF.py pass outside California

This revision was automatically updated to reflect the committed changes. Closed by commit rG8d8bd0d6548e: [lldb] Make TestDataFormatterObjCCF.py pass outside California (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74038/new

[Lldb-commits] [PATCH] D73802: [lldb] Introduce i386 support in NetBSD Process plugin

This revision was automatically updated to reflect the committed changes. Closed by commit rG5cc817be7501: [lldb] Introduce i386 support in NetBSD Process plugin (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [lldb] 7506ca3 - [lldb][NFC] Remove some unnecessary curly braces

Author: Raphael Isemann Date: 2020-02-05T13:47:09+01:00 New Revision: 7506ca3e8ccb75620a1987749f80d22bc87f246c URL: https://github.com/llvm/llvm-project/commit/7506ca3e8ccb75620a1987749f80d22bc87f246c DIFF: https://github.com/llvm/llvm-project/commit/7506ca3e8ccb75620a1987749f80d22bc87f246c.dif

[Lldb-commits] [lldb] 706256b - [lldb] Revert some change in data-formatter-objc/main.m that broke TestDataFormatterObjCNSDate.py

Author: Raphael Isemann Date: 2020-02-05T14:08:57+01:00 New Revision: 706256b6d3972dcfa2d3e888d0640e1689c4be95 URL: https://github.com/llvm/llvm-project/commit/706256b6d3972dcfa2d3e888d0640e1689c4be95 DIFF: https://github.com/llvm/llvm-project/commit/706256b6d3972dcfa2d3e888d0640e1689c4be95.dif

[Lldb-commits] [lldb] 2b7f328 - [lldb/Target] Add Assert StackFrame Recognizer

Author: Med Ismail Bennani Date: 2020-02-05T17:49:13+01:00 New Revision: 2b7f32892b76cdfbe075300a5bf4a52e1b674bc7 URL: https://github.com/llvm/llvm-project/commit/2b7f32892b76cdfbe075300a5bf4a52e1b674bc7 DIFF: https://github.com/llvm/llvm-project/commit/2b7f32892b76cdfbe075300a5bf4a52e1b674bc7.

[Lldb-commits] [PATCH] D73787: [NFC] Refactor `GetDWARFDeclContext` to return `DWARFDeclContext`

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Yes, I agree this is better. One way to this could be improved further is to change the recursion in `GetDWARFDeclContext` into a loop (then you wouldn't need the extra wrapper). Repository:

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Assert StackFrame Recognizer

This revision was automatically updated to reflect the committed changes. Closed by commit rG2b7f32892b76: [lldb/Target] Add Assert StackFrame Recognizer (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73303/new/ https://reviews.llv

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Assert StackFrame Recognizer

mib updated this revision to Diff 242634. mib marked 5 inline comments as done. mib added a comment. Fixed the corrupted stop reason description. Fixed linux support for public symbols. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73303/new/ https

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Assert StackFrame Recognizer

mib added inline comments. Comment at: lldb/source/Target/StackFrameRecognizer.cpp:95 const SymbolContext &symctx = -frame->GetSymbolContext(eSymbolContextModule | eSymbolContextFunction); +frame->GetSymbolContext(eSymbolContextEverything); ConstString f

[Lldb-commits] [PATCH] D73665: Stop emitting a breakpoint for each location in a breakpoint when responding to breakpoint commands.

labath added a comment. Sorry about the delay. I think this is better, but the handling of`eBreakpointEventTypeLocationsAdded/Removed` it still does not seem completely right. Though I don't really understand how VSCode works, if my understanding that we are now creating a "vscode" breakpoint f

[Lldb-commits] [PATCH] D74010: Fix BroadcasterManager::RemoveListener to really remove the listener

amccarth added a comment. Wow, cool bug. It's too bad the original code re-used an iterator variable instead of make a new name (which would have helped the compiler find the problem). Note that the one they used is shadowed just a couple lines later. It's too bad the original code feels it's

[Lldb-commits] [PATCH] D73952: [lldb] Ignore type sugar in TypeSystemClang::GetPointerType

davide added a comment. Good catch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73952/new/ https://reviews.llvm.org/D73952 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm

[Lldb-commits] [PATCH] D73860: [lldb/StringPrinter] Avoid reading garbage in uninitialized strings

vsk updated this revision to Diff 242661. vsk marked 4 inline comments as done. vsk added a comment. - `s/cap/capacity/` - Remove the `checkedAdd` pointer overflow check as it's not necessary. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73860/new/ https://reviews.llvm.org/D73860 File

[Lldb-commits] [PATCH] D73206: Pass `CompileUnit *` along `DWARFDIE` for DWZ

labath added a comment. Thanks for exploring this. From a high-level, this approach looks like it could be viable. However, you have taken this a lot further than I would have expected. What I was expecting to see would be that a bunch of the DWARF internal functions would get an extra argumen

[Lldb-commits] [PATCH] D73860: [lldb/StringPrinter] Avoid reading garbage in uninitialized strings

vsk added inline comments. Comment at: lldb/source/DataFormatters/StringPrinter.cpp:144 +return retval; + if (!llvm::checkedAdd(reinterpret_cast(buffer), +static_cast(utf8_encoded_len))) shafik wrote: > Wouldn't we want `checkedAddUns

[Lldb-commits] [PATCH] D73767: [lldb] [test] Pass LLVM_LIBS_DIR from CMake for linking liblldb

This revision was automatically updated to reflect the committed changes. Closed by commit rGdcab9736f01b: [lldb] [test] Pass LLVM_LIBS_DIR from CMake for linking liblldb (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [lldb] 77519b6 - [test] yaml2obj -docnum => --docnum=

Author: Fangrui Song Date: 2020-02-05T10:25:04-08:00 New Revision: 77519b60d99233ccea2622ea3e40b30018d2f228 URL: https://github.com/llvm/llvm-project/commit/77519b60d99233ccea2622ea3e40b30018d2f228 DIFF: https://github.com/llvm/llvm-project/commit/77519b60d99233ccea2622ea3e40b30018d2f228.diff

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Assert StackFrame Recognizer

max-kudr added a comment. This broke LLDB tests on Windows Build Bot http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/13415 Can you please fix it or revert it? Thank you! Failing Tests (4): lldb-api :: commands/watchpoints/step_over_watchpoint/TestStepOverWatchpoint.py

[Lldb-commits] [PATCH] D73969: [LLDB] Let DataExtractor deal with two-byte addresses

aykevl updated this revision to Diff 242694. aykevl set the repository for this revision to rG LLVM Github Monorepo. aykevl added a comment. > I do have one question though. Will the DataExtractor actually do something > reasonable for non-power-of-2 sizes (5,6,7) ? If yes, then great -- if not,

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Assert StackFrame Recognizer

labath added a comment. It looks like there is still some memory corruption going on: lldb) target create --core "../llvm-project/lldb/packages/Python/lldbsuite/test/functionalities/postmortem/minidump/fizzbuzz_no_heap.dmp" (lldb) bt * thread #1, stop reason = Exception 0xc005 encounte

[Lldb-commits] [PATCH] D73961: [LLDB] Addresses can be two bytes in size

aykevl added a comment. > How do you normally generate the binaries with these kinds of addresses? Can > they be produced with clang? Can they be produced with llvm-mc? Linked with > lld ? With `avr-gcc`. I think it's easiest to just generate a minimal binary using `yaml2obj`. For the rest I'

[Lldb-commits] [PATCH] D74084: [LLDB] Fix compilation with GCC 5

mstorsjo created this revision. mstorsjo added reviewers: labath, aprantl. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74084 Files: lldb/source/DataFormatters/FormatCache.cpp lldb/source/DataFormatters/LanguageCategory.cpp lldb/source/Inter

[Lldb-commits] [PATCH] D72513: Don't fail step out if remote server doesn't implement qMemoryRegionInfo

ted added a comment. @jingham friendly ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72513/new/ https://reviews.llvm.org/D72513 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/l

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

paolosev updated this revision to Diff 242733. paolosev added a comment. Fixing ObjectFile/wasm tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72751/new/ https://reviews.llvm.org/D72751 Files: lldb/packages/Python/lldbsuite/test/functiona

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Assert StackFrame Recognizer

friss added inline comments. Comment at: lldb/source/API/SBThread.cpp:328-329 if (stop_info_sp) { -const char *stop_desc = stop_info_sp->GetDescription(); +const char *stop_desc = +exe_ctx.GetThreadPtr()->GetStopDescription().data(); if

[Lldb-commits] [PATCH] D72513: Don't fail step out if remote server doesn't implement qMemoryRegionInfo

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Oops, sorry. Looks fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72513/new/ https://reviews.llvm.org/D72513 ___ lldb-commits ma

[Lldb-commits] [PATCH] D73961: [LLDB] Addresses can be two bytes in size

labath added a comment. In D73961#1860270 , @aykevl wrote: > > How do you normally generate the binaries with these kinds of addresses? > > Can they be produced with clang? Can they be produced with llvm-mc? Linked > > with lld ? > > With `avr-gcc`. I th

[Lldb-commits] [PATCH] D73969: [LLDB] Let DataExtractor deal with two-byte addresses

labath added a comment. In D73969#1860253 , @aykevl wrote: > > I do have one question though. Will the DataExtractor actually do something > > reasonable for non-power-of-2 sizes (5,6,7) ? If yes, then great -- if not, > > we should keep the assert as `2

[Lldb-commits] [lldb] 3ec28da - [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

Author: Paolo Severini Date: 2020-02-05T14:49:36-08:00 New Revision: 3ec28da6d6430a00b46780555a87acd43fcab790 URL: https://github.com/llvm/llvm-project/commit/3ec28da6d6430a00b46780555a87acd43fcab790 DIFF: https://github.com/llvm/llvm-project/commit/3ec28da6d6430a00b46780555a87acd43fcab790.diff

[Lldb-commits] [lldb] fefff97 - [lldb/debugserver] Link against Security

Author: Jonas Devlieghere Date: 2020-02-05T14:52:08-08:00 New Revision: fefff970321a4fe0b717f3679e291bd53ee82ef6 URL: https://github.com/llvm/llvm-project/commit/fefff970321a4fe0b717f3679e291bd53ee82ef6 DIFF: https://github.com/llvm/llvm-project/commit/fefff970321a4fe0b717f3679e291bd53ee82ef6.d

[Lldb-commits] [lldb] 6dccad7 - [lldb/Reproducers] (De)serialize char* like const char*

Author: Jonas Devlieghere Date: 2020-02-05T14:52:08-08:00 New Revision: 6dccad7517f83a069d9bfbf761b648b0e50870c2 URL: https://github.com/llvm/llvm-project/commit/6dccad7517f83a069d9bfbf761b648b0e50870c2 DIFF: https://github.com/llvm/llvm-project/commit/6dccad7517f83a069d9bfbf761b648b0e50870c2.d

[Lldb-commits] [PATCH] D74093: [lldb/tests] Correctly configure the lldb dotest arguments

stella.stamenova created this revision. stella.stamenova added a reviewer: JDevlieghere. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. When the generator used for CMake is a multi-configuration generator (such as VS), the arguments passed to dotest are not currentl

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ec28da6d643: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging (authored by paolosev, committed by dschuff). Changed prior to commit: https://reviews.llvm.org/D72751?vs=242733&id=242754

Re: [Lldb-commits] [lldb] 2b7f328 - [lldb/Target] Add Assert StackFrame Recognizer

Hi Ismail, I think we started picking up some failures on the greendragon lldb-cmake-sanitize bot with this commit, http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake-sanitized/ = ==55503==ERROR: AddressSanitizer: heap-use-afte

[Lldb-commits] [lldb] 5c15e8e - [lldb/CMake] Remove non-existing wasm-DYLD subdir

Author: Jonas Devlieghere Date: 2020-02-05T15:08:18-08:00 New Revision: 5c15e8e682e365b3a7fcf35200df79f3fb93b924 URL: https://github.com/llvm/llvm-project/commit/5c15e8e682e365b3a7fcf35200df79f3fb93b924 DIFF: https://github.com/llvm/llvm-project/commit/5c15e8e682e365b3a7fcf35200df79f3fb93b924.d

[Lldb-commits] [lldb] 42c906b - [lldb/API] Fix non null-terminated stop-reason in SBThread::GetStopDescription

Author: Med Ismail Bennani Date: 2020-02-06T00:20:33+01:00 New Revision: 42c906bceffaadeb704f2629d21f33aece831bc6 URL: https://github.com/llvm/llvm-project/commit/42c906bceffaadeb704f2629d21f33aece831bc6 DIFF: https://github.com/llvm/llvm-project/commit/42c906bceffaadeb704f2629d21f33aece831bc6.

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

JDevlieghere added a comment. It looks like the wasm-DYLD directory is missing. I removed it again from the CMake file but now it's failing to build. Can you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72751/new/ https://revi

Re: [Lldb-commits] [EXTERNAL] [lldb] 42c906b - [lldb/API] Fix non null-terminated stop-reason in SBThread::GetStopDescription

Does this fix the Windows failures that were reported this morning as well? -Original Message- From: lldb-commits On Behalf Of Med Ismail Bennani via lldb-commits Sent: Wednesday, February 5, 2020 3:21 PM To: lldb-commits@lists.llvm.org Subject: [EXTERNAL] [Lldb-commits] [lldb] 42c906b -

Re: [Lldb-commits] [EXTERNAL] [lldb] 42c906b - [lldb/API] Fix non null-terminated stop-reason in SBThread::GetStopDescription

On Wed, 5 Feb 2020 at 15:26, Stella Stamenova via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Does this fix the Windows failures that were reported this morning as well? > > I doubt that. In fact, I'm pretty sure it does not even fix the asan failure, but I cannot currently prove that bec

[Lldb-commits] [lldb] 4697e70 - Partially revert "[LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging"

Author: Jonas Devlieghere Date: 2020-02-05T15:32:54-08:00 New Revision: 4697e701b8cb40429818609814c7422e49b2ee07 URL: https://github.com/llvm/llvm-project/commit/4697e701b8cb40429818609814c7422e49b2ee07 DIFF: https://github.com/llvm/llvm-project/commit/4697e701b8cb40429818609814c7422e49b2ee07.d

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

JDevlieghere added a comment. In D72751#1860780 , @JDevlieghere wrote: > It looks like the wasm-DYLD directory is missing. I removed it again from the > CMake file but now it's failing to build. Can you please take a look? I've partially reverted your

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

dschuff added a comment. My bad, sorry about that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72751/new/ https://reviews.llvm.org/D72751 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [PATCH] D74096: [lldb/API] Fix the dangling pointer issue in SBThread::GetStopDescription

mib created this revision. mib added reviewers: friss, JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Instead of creating a char pointer to hold the stop reason description, the reason is stored in a std::string. Repository: rG LLVM Github Monorepo https:

[Lldb-commits] [lldb] f5f70d1 - Add missing directory from 3ec28da6

Author: Derek Schuff Date: 2020-02-05T15:49:48-08:00 New Revision: f5f70d1c8fbf12249b4b9598f10a10f12d4db029 URL: https://github.com/llvm/llvm-project/commit/f5f70d1c8fbf12249b4b9598f10a10f12d4db029 DIFF: https://github.com/llvm/llvm-project/commit/f5f70d1c8fbf12249b4b9598f10a10f12d4db029.diff

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

dschuff added a comment. fixed in rGf5f70d1c8 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72751/new/ https://reviews.llvm.org/D72751 ___

[Lldb-commits] [PATCH] D74096: [lldb/API] Fix the dangling pointer issue in SBThread::GetStopDescription

friss added inline comments. Comment at: lldb/source/API/SBThread.cpp:361-363 stop_desc = exe_ctx.GetProcessPtr()->GetUnixSignals()->GetSignalAsCString( stop_info_sp->GetValue()); I don't think this is generally

[Lldb-commits] [lldb] 98b273c - Revert "[lldb/Target] Add Assert StackFrame Recognizer"

Author: Pavel Labath Date: 2020-02-05T15:51:38-08:00 New Revision: 98b273c893b2c218c56fe5c03cbb6f082cce008c URL: https://github.com/llvm/llvm-project/commit/98b273c893b2c218c56fe5c03cbb6f082cce008c DIFF: https://github.com/llvm/llvm-project/commit/98b273c893b2c218c56fe5c03cbb6f082cce008c.diff

[Lldb-commits] [lldb] 5f1e45f - [lldb] pass --lldb-libs-dir argument to lldb-dotest

Author: Pavel Labath Date: 2020-02-05T15:51:38-08:00 New Revision: 5f1e45fd6764f9e31de1c9d6d7581645eea0c696 URL: https://github.com/llvm/llvm-project/commit/5f1e45fd6764f9e31de1c9d6d7581645eea0c696 DIFF: https://github.com/llvm/llvm-project/commit/5f1e45fd6764f9e31de1c9d6d7581645eea0c696.diff

Re: [Lldb-commits] [EXTERNAL] [lldb] 42c906b - [lldb/API] Fix non null-terminated stop-reason in SBThread::GetStopDescription

Hi, > On 6 Feb 2020, at 00:32, Pavel Labath wrote: > > > > On Wed, 5 Feb 2020 at 15:26, Stella Stamenova via lldb-commits > mailto:lldb-commits@lists.llvm.org>> wrote: > Does this fix the Windows failures that were reported this morning as well? > > > I doubt that. In fact, I'm pretty sure

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

JDevlieghere added a comment. In D72751#1860871 , @dschuff wrote: > fixed in rGf5f70d1c8 > Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D74096: [lldb/API] Fix the dangling pointer issue in SBThread::GetStopDescription

JDevlieghere added inline comments. Comment at: lldb/source/API/SBThread.cpp:357 stop_desc = wp_desc; stop_desc_len = sizeof(wp_desc); // Include the NULL byte for size } break; This looks like some "optimization" to not have

[Lldb-commits] [PATCH] D74096: [lldb/API] Fix the dangling pointer issue in SBThread::GetStopDescription

JDevlieghere added inline comments. Comment at: lldb/source/API/SBThread.cpp:361-363 stop_desc = exe_ctx.GetProcessPtr()->GetUnixSignals()->GetSignalAsCString( stop_info_sp->GetValue()); friss wrote: > I don't th

[Lldb-commits] [lldb] 97edc0d - [lldb/Test] Mark heap-cstr.test as requiring Python

Author: Jonas Devlieghere Date: 2020-02-05T16:05:54-08:00 New Revision: 97edc0dc9355be8771c3b6ae4efe19b23664d06d URL: https://github.com/llvm/llvm-project/commit/97edc0dc9355be8771c3b6ae4efe19b23664d06d DIFF: https://github.com/llvm/llvm-project/commit/97edc0dc9355be8771c3b6ae4efe19b23664d06d.d

[Lldb-commits] [lldb] 014ea93 - [lldb] Remove "print xml" from TestWasm.py

Author: Pavel Labath Date: 2020-02-05T16:09:34-08:00 New Revision: 014ea9337624fe20aca8892e73b6b3f741d8da9e URL: https://github.com/llvm/llvm-project/commit/014ea9337624fe20aca8892e73b6b3f741d8da9e DIFF: https://github.com/llvm/llvm-project/commit/014ea9337624fe20aca8892e73b6b3f741d8da9e.diff

[Lldb-commits] [PATCH] D74093: [lldb/tests] Correctly configure the lldb dotest arguments

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. I tried your patch with the Xcode generator and everything passes. Thanks for fixing this! Comment at: lldb/test/API/lit.site.cfg.py.in:51 +config.test

[Lldb-commits] [PATCH] D74096: [lldb/API] Fix the dangling pointer issue in SBThread::GetStopDescription

JDevlieghere added inline comments. Comment at: lldb/source/API/SBThread.cpp:361-363 stop_desc = exe_ctx.GetProcessPtr()->GetUnixSignals()->GetSignalAsCString( stop_info_sp->GetValue()); JDevlieghere wrote: > fri

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

paolosev added a comment. Thank you Derek, Jonas; I am sorry for all the trouble... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72751/new/ https://reviews.llvm.org/D72751 ___ lldb-commits mailing lis

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Assert StackFrame Recognizer

mib reopened this revision. mib added a comment. This revision is now accepted and ready to land. There are still some bugs on Windows and Linux that need to investigated ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73303/new/ https://reviews.

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

JDevlieghere added a comment. In D72751#1860901 , @paolosev wrote: > Thank you Derek, Jonas; I am sorry for all the trouble... No worries, thank you both for the quick turnaround time! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 40efa65 - Revert "[LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging"

Author: Pavel Labath Date: 2020-02-05T16:22:19-08:00 New Revision: 40efa65de804b42e14356fc8fcfaa79d9dbcdb02 URL: https://github.com/llvm/llvm-project/commit/40efa65de804b42e14356fc8fcfaa79d9dbcdb02 DIFF: https://github.com/llvm/llvm-project/commit/40efa65de804b42e14356fc8fcfaa79d9dbcdb02.diff

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

max-kudr added a comment. There is Windows Build Bot failure http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/13427. Can you please fix or revert it? Cannot open include file: 'Plugins/DynamicLoader/wasm-DYLD/DynamicLoaderWasmDYLD.h': No such file or directory Repository:

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

labath added a comment. I am afraid this isn't over yet. :( The tests with this patch don't seem to be compatible with python3 and are failing due to various errors: http://lab.llvm.org:8011/builders/lldb-x86_64-debian/builds/4419/steps/test/logs/stdio. Even when running the test with python2

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

paolosev added a comment. In D72751#1860950 , @max-kudr wrote: > There is Windows Build Bot failure > http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/13427. Can > you please fix or revert it? > > Cannot open include file: > 'Plugins/Dy

[Lldb-commits] [lldb] ccf900f - Two more small fixes for debugserver attach failure messaging.

Author: Jason Molenda Date: 2020-02-05T19:24:38-08:00 New Revision: ccf900fc932098c1bbaa6e43a94b4423c60bf53e URL: https://github.com/llvm/llvm-project/commit/ccf900fc932098c1bbaa6e43a94b4423c60bf53e DIFF: https://github.com/llvm/llvm-project/commit/ccf900fc932098c1bbaa6e43a94b4423c60bf53e.diff

[Lldb-commits] [lldb] 2f025bb - [lldb/Reproducers] Implement custom replayers for (char *, size_t)

Author: Jonas Devlieghere Date: 2020-02-05T19:59:38-08:00 New Revision: 2f025bb87c33a25e3a0d226cdb663f237ccd602e URL: https://github.com/llvm/llvm-project/commit/2f025bb87c33a25e3a0d226cdb663f237ccd602e DIFF: https://github.com/llvm/llvm-project/commit/2f025bb87c33a25e3a0d226cdb663f237ccd602e.d

[Lldb-commits] [lldb] e3aa062 - [lldb/DWARF] Don't assume that a SymbolFileDWARFDwo contains one compile unit

Author: Pavel Labath Date: 2020-02-05T20:37:56-08:00 New Revision: e3aa062ae957f61ee9f9e25f52bdb3c690c79fe3 URL: https://github.com/llvm/llvm-project/commit/e3aa062ae957f61ee9f9e25f52bdb3c690c79fe3 DIFF: https://github.com/llvm/llvm-project/commit/e3aa062ae957f61ee9f9e25f52bdb3c690c79fe3.diff

[Lldb-commits] [PATCH] D73781: [lldb/DWARF] Don't assume that a SymbolFileDWARFDwo contains one compile unit

This revision was automatically updated to reflect the committed changes. labath marked an inline comment as done. Closed by commit rGe3aa062ae957: [lldb/DWARF] Don't assume that a SymbolFileDWARFDwo contains one compile unit (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [PATCH] D73781: [lldb/DWARF] Don't assume that a SymbolFileDWARFDwo contains one compile unit

labath marked 2 inline comments as done. labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwoDwp.cpp:29 +: SymbolFileDWARFDwo(dwarf_cu.GetSymbolFileDWARF(), objfile, + dwarf_cu.GetID()), + m_dwp_symfile

[Lldb-commits] [PATCH] D73781: [lldb/DWARF] Don't assume that a SymbolFileDWARFDwo contains one compile unit

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwoDwp.cpp:29 +: SymbolFileDWARFDwo(dwarf_cu.GetSymbolFileDWARF(), objfile, + dwarf_cu.GetID()), + m_dwp_symfile(dwp_symfile), m_dwo_id(dwo_id) {}

[Lldb-commits] [lldb] 3da7dcf - [lldb/Reproducers] Serialize empty string for char* methods.

Author: Jonas Devlieghere Date: 2020-02-05T21:55:36-08:00 New Revision: 3da7dcf38a96b7ba8ba0cb61be40210ace3fd91f URL: https://github.com/llvm/llvm-project/commit/3da7dcf38a96b7ba8ba0cb61be40210ace3fd91f DIFF: https://github.com/llvm/llvm-project/commit/3da7dcf38a96b7ba8ba0cb61be40210ace3fd91f.d