[Lldb-commits] [PATCH] D73802: [lldb] Introduce i386 support in NetBSD Process plugin

2020-02-01 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterContextNetBSD_i386.cpp:62 + GPR gpr; + FPR_i386 i387; + uint32_t u_debugreg[8]; // Debug registers (DR0 - DR7). mgorny wrote: > krytarowski wrote: > > Please add `uint3

[Lldb-commits] [PATCH] D73802: [lldb] Introduce i386 support in NetBSD Process plugin

2020-02-01 Thread Michał Górny via Phabricator via lldb-commits
mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterContextNetBSD_i386.cpp:62 + GPR gpr; + FPR_i386 i387; + uint32_t u_debugreg[8]; // Debug registers (DR0 - DR7). krytarowski wrote: >

[Lldb-commits] [PATCH] D73802: [lldb] Introduce i386 support in NetBSD Process plugin

2020-02-01 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterContextNetBSD_i386.cpp:62 + GPR gpr; + FPR_i386 i387; + uint32_t u_debugreg[8]; // Debug registers (DR0 - DR7). mgorny wrote: > krytarowski wrote: > > mgorny wrote: > >

[Lldb-commits] [PATCH] D73839: [LLDB] Add missing declarations for linking to psapi

2020-02-01 Thread Martin Storsjö via Phabricator via lldb-commits
mstorsjo created this revision. mstorsjo added reviewers: labath, amccarth. Herald added a subscriber: mgorny. Herald added a project: LLDB. This fixes building for mingw with BUILD_SHARED_LIBS. In static builds, the psapi dependency gets linked in transitively from Support, but when linking Sup

[Lldb-commits] [PATCH] D73802: [lldb] Introduce i386 support in NetBSD Process plugin

2020-02-01 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterContextNetBSD_i386.cpp:62 + GPR gpr; + FPR_i386 i387; + uint32_t u_debugreg[8]; // Debug registers (DR0 - DR7). krytarowski wrote: > mgorny wrote: > > krytarowski wrote