[Lldb-commits] [lldb] 92211bf - [LLDB] Fix address computation for inline function

Author: Johannes Altmanninger Date: 2019-12-20T09:04:45+01:00 New Revision: 92211bf0f15ba46b5eeb88b7ea580ff539dcdd4e URL: https://github.com/llvm/llvm-project/commit/92211bf0f15ba46b5eeb88b7ea580ff539dcdd4e DIFF: https://github.com/llvm/llvm-project/commit/92211bf0f15ba46b5eeb88b7ea580ff539dcdd

[Lldb-commits] [PATCH] D71487: [LLDB] Fix address computation for inline function

This revision was automatically updated to reflect the committed changes. Closed by commit rG92211bf0f15b: [LLDB] Fix address computation for inline function (authored by johannes). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71487/new/ https://re

[Lldb-commits] [lldb] 4cc5659 - [lldb] Remove XFAIL from TestDeadStrip.py

Author: Pavel Labath Date: 2019-12-20T10:04:25+01:00 New Revision: 4cc5659a7a1f2fa3dcb3256fd3c3d07b2833b586 URL: https://github.com/llvm/llvm-project/commit/4cc5659a7a1f2fa3dcb3256fd3c3d07b2833b586 DIFF: https://github.com/llvm/llvm-project/commit/4cc5659a7a1f2fa3dcb3256fd3c3d07b2833b586.diff

[Lldb-commits] [PATCH] D71306: [RFC] Change how we deal with optional dependencies

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks fine to me. Just remove the redundant panel searching code, and please make sure this works correctly from a clean build, per the inline comment. Comment at: lldb/cmak

[Lldb-commits] [PATCH] D71630: [lldb] Add a SubsystemRAII that takes care of calling Initialize and Terminate in the unit tests

teemperor updated this revision to Diff 234839. teemperor added a comment. Herald added a subscriber: mgorny. - Add test - Move SubsystemRAIICase to ::detail I'll wait with landing this until HostInfo's Initialize/Terminate are fixed (calling Terminate and Initialize is currently breaking the wh

[Lldb-commits] [lldb] 29bd219 - [lldb] Added test for objc_direct calls with categories

Author: Raphael Isemann Date: 2019-12-20T11:07:30+01:00 New Revision: 29bd2194979c50097edb39a4beb714bff8c153a1 URL: https://github.com/llvm/llvm-project/commit/29bd2194979c50097edb39a4beb714bff8c153a1 DIFF: https://github.com/llvm/llvm-project/commit/29bd2194979c50097edb39a4beb714bff8c153a1.dif

[Lldb-commits] [PATCH] D71487: [LLDB] Fix address computation for inline function

johannes added a comment. I'm having some troubles fixing this build failure: http://lab.llvm.org:8011/builders/lldb-x86_64-debian/builds/1866/ `ninja check-lldb-api` fails but when I try to execute the offending test locally with a command equivalent to the one in the buildbot log, I get below

[Lldb-commits] [PATCH] D71748: [lldb] Make that we can call HostInfo::Initialize and HostInfo::Terminate multiple times

teemperor created this revision. teemperor added a reviewer: labath. Herald added subscribers: lldb-commits, JDevlieghere, abidh. Herald added a project: LLDB. HostInfo's state isn't actually fully rested after calling ::Terminate. Currently we only reset the values of all the `HostInfoBaseFields

Re: [Lldb-commits] [lldb] 22caa3c - [lldb] Add unit test for ClangASTImporter

Fixed by https://reviews.llvm.org/D71748. Will land this today. > On 18. Dec 2019, at 23:03, Raphael “Teemperor” Isemann > wrote: > > I’m actually already investigating that because I see the same failure when I > moved the ::Initialize and ::Terminate calls to SetUp and TearDown as part of >

[Lldb-commits] [PATCH] D71699: [lldb] Increase the rate at which ConstString's memory allocator scales the memory chunks it allocates

teemperor added a comment. (This patch is otherwise ready to land) Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71699/new/ https://reviews.llvm.org/D71699 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D71699: [lldb] Increase the rate at which ConstString's memory allocator scales the memory chunks it allocates

teemperor added a comment. @llunak can you test how this affects your runtime for the use case you wanted this for? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71699/new/ https://reviews.llvm.org/D71699 ___ lldb

[Lldb-commits] [PATCH] D71487: [LLDB] Fix address computation for inline function

labath added a comment. In D71487#1792391 , @johannes wrote: > I'm having some troubles fixing this build failure: > http://lab.llvm.org:8011/builders/lldb-x86_64-debian/builds/1866/ > > `ninja check-lldb-api` fails but when I try to execute the offendin

[Lldb-commits] [PATCH] D71748: [lldb] Make that we can call HostInfo::Initialize and HostInfo::Terminate multiple times

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Yeah, this code could use a rewrite, but this is definitely better... Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71748/new/ https://reviews.llvm.org/D7174

[Lldb-commits] [PATCH] D68464: [lldb][modern-type-lookup] Ask the ExternalASTMerger to lookup namespaces instead of using the old mechanism

teemperor abandoned this revision. teemperor added a comment. modern-type-lookup has been removed, closing this. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68464/new/ https://reviews.llvm.org/D68464 ___ lldb-com

[Lldb-commits] [PATCH] D71234: [lldb/Lua] Implement a Simple Lua Script Interpreter Prototype

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/unittests/ScriptInterpreter/Lua/CMakeLists.txt:14-15 + +target_include_directories(ScriptInterpreterLuaTests PRIVATE ${LUA_INCLUDE_DIR}) +target_link_li

[Lldb-commits] [lldb] b237179 - [lldb] Make that we can call HostInfo::Initialize and HostInfo::Terminate multiple times

Author: Raphael Isemann Date: 2019-12-20T12:52:06+01:00 New Revision: b2371791fc74b2ecad7f608ff8592ec512d098e6 URL: https://github.com/llvm/llvm-project/commit/b2371791fc74b2ecad7f608ff8592ec512d098e6 DIFF: https://github.com/llvm/llvm-project/commit/b2371791fc74b2ecad7f608ff8592ec512d098e6.dif

[Lldb-commits] [PATCH] D71748: [lldb] Make that we can call HostInfo::Initialize and HostInfo::Terminate multiple times

This revision was automatically updated to reflect the committed changes. Closed by commit rGb2371791fc74: [lldb] Make that we can call HostInfo::Initialize and HostInfo::Terminate… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [lldb] 04329db - [lldb] Fix test using lld on non-linux systems

Author: Johannes Altmanninger Date: 2019-12-20T13:27:40+01:00 New Revision: 04329dbfa6c219997ab72567842d81778f9f7f47 URL: https://github.com/llvm/llvm-project/commit/04329dbfa6c219997ab72567842d81778f9f7f47 DIFF: https://github.com/llvm/llvm-project/commit/04329dbfa6c219997ab72567842d81778f9f7f

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

labath added a comment. The main reason I don't want the Architecture class in ArchSpec is to keep the dependency graph of lldb-server clean (it's not very clean to begin with, but at least I want to avoid making it worse). lldb-server should not know anything about the Target class (that's a l

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

labath added a comment. In D70840#1791292 , @mstorsjo wrote: > And irrespectively if the ArchSpec vs Architecture design, can you (either of > you) comment on the updated form of the patch? The code still seems somewhat schizophrenic to me. :/ The line

[Lldb-commits] [PATCH] D71630: [lldb] Add a SubsystemRAII that takes care of calling Initialize and Terminate in the unit tests

teemperor updated this revision to Diff 234860. teemperor added a comment. - Migrated more tests to SubsystemRAII CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71630/new/ https://reviews.llvm.org/D71630 Files: lldb/unittests/Core/MangledTest.cpp lldb/unittests/Editline/EditlineTest

[Lldb-commits] [PATCH] D71750: [lldb/DWARF] Add is_dwo member to DWARFUnit

labath created this revision. labath added reviewers: JDevlieghere, aprantl, clayborg. Herald added a project: LLDB. A skeleton unit can easily be detected by checking the m_dwo_symbol_file member, but we cannot tell a split unit from a normal unit from the "inside", which is sometimes useful. Th

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

mstorsjo added a comment. In D70840#1792498 , @labath wrote: > In D70840#1791292 , @mstorsjo wrote: > > > And irrespectively if the ArchSpec vs Architecture design, can you (either > > of you) comment on the update

[Lldb-commits] [PATCH] D71751: [lldb/DWARF] Fix mixed v4+v5 location lists

labath created this revision. labath added reviewers: JDevlieghere, aprantl, clayborg. Herald added a project: LLDB. labath added a parent revision: D71750: [lldb/DWARF] Add is_dwo member to DWARFUnit. Our code was expecting that a single (symbol) file contains only one kind of location lists. Th

[Lldb-commits] [PATCH] D71699: [lldb] Increase the rate at which ConstString's memory allocator scales the memory chunks it allocates

llunak accepted this revision. llunak added a comment. This revision is now accepted and ready to land. I'm back at using gdb for the time being, so I'd have to build code with debuginfo suitable for lldb, which would take some time. But given that this is more or less the same as I did before,

[Lldb-commits] [lldb] 5f78b1d - [lldb] Add tests for ClangASTImporter's DeportType and DeportDecl methods

Author: Raphael Isemann Date: 2019-12-20T14:47:15+01:00 New Revision: 5f78b1d648240ba188d08ac1ce62fb7f68d41149 URL: https://github.com/llvm/llvm-project/commit/5f78b1d648240ba188d08ac1ce62fb7f68d41149 DIFF: https://github.com/llvm/llvm-project/commit/5f78b1d648240ba188d08ac1ce62fb7f68d41149.dif

[Lldb-commits] [lldb] b04b92c - [lldb/pexpect] Force-set the TERM environment variable

Author: Pavel Labath Date: 2019-12-20T15:19:41+01:00 New Revision: b04b92c3a4640417f2074e7e903df8c2b76eadfd URL: https://github.com/llvm/llvm-project/commit/b04b92c3a4640417f2074e7e903df8c2b76eadfd DIFF: https://github.com/llvm/llvm-project/commit/b04b92c3a4640417f2074e7e903df8c2b76eadfd.diff

[Lldb-commits] [lldb] 05c3b36 - [lldb] Fix a -Wreturn-type warning on gcc

Author: Pavel Labath Date: 2019-12-20T15:19:41+01:00 New Revision: 05c3b36bc9a35a8aa3ddd6a912ddceab90c39b4d URL: https://github.com/llvm/llvm-project/commit/05c3b36bc9a35a8aa3ddd6a912ddceab90c39b4d DIFF: https://github.com/llvm/llvm-project/commit/05c3b36bc9a35a8aa3ddd6a912ddceab90c39b4d.diff

[Lldb-commits] [PATCH] D71761: [lldb] Add a setting to not install the main executable

danielkiss created this revision. danielkiss added reviewers: omjavaid, JDevlieghere, srhines. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add setting target.auto-install-main-executable that controls whether the main executable should be automatically installed when con

[Lldb-commits] [lldb] a9c8453 - [lldb] Put the headers in unittests/TestingSupport/ into modules

Author: Raphael Isemann Date: 2019-12-20T15:43:53+01:00 New Revision: a9c845395f827055b951532451df1ea50184c21d URL: https://github.com/llvm/llvm-project/commit/a9c845395f827055b951532451df1ea50184c21d DIFF: https://github.com/llvm/llvm-project/commit/a9c845395f827055b951532451df1ea50184c21d.dif

[Lldb-commits] [lldb] aaa34bc - [lldb][NFC] Move utility functions from ClangASTImporter and ClangExpressionDeclMap to own header

Author: Raphael Isemann Date: 2019-12-20T16:13:24+01:00 New Revision: aaa34bc0bd1aeb7271ba0ce2c4f3dfba5dbae8e2 URL: https://github.com/llvm/llvm-project/commit/aaa34bc0bd1aeb7271ba0ce2c4f3dfba5dbae8e2 DIFF: https://github.com/llvm/llvm-project/commit/aaa34bc0bd1aeb7271ba0ce2c4f3dfba5dbae8e2.dif

[Lldb-commits] [PATCH] D70846: Expression eval lookup speedup by not returning methods in ManualDWARFIndex::GetFunctions

PatriosTheGreat updated this revision to Diff 234899. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70846/new/ https://reviews.llvm.org/D70846 Files: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp lldb

[Lldb-commits] [PATCH] D71770: [lldb] Don't process symlinks deep inside DWARFUnit

labath created this revision. labath added reviewers: JDevlieghere, aprantl, clayborg. Herald added a reviewer: jdoerfert. Herald added a project: LLDB. This code is handling debug info paths starting with /proc/self/cwd, which is one of the mechanisms people use to obtain "relocatable" debug info

[Lldb-commits] [lldb] ca567ad - [lldb/cmake] Remove support for LLDB_DISABLE_CURSES

Author: Pavel Labath Date: 2019-12-20T16:50:06+01:00 New Revision: ca567ad6ffc1fbbd5e354ab80e426c052d027811 URL: https://github.com/llvm/llvm-project/commit/ca567ad6ffc1fbbd5e354ab80e426c052d027811 DIFF: https://github.com/llvm/llvm-project/commit/ca567ad6ffc1fbbd5e354ab80e426c052d027811.diff

[Lldb-commits] [lldb] 32a3428 - [lldb] Fix an unused variable warning

Author: Pavel Labath Date: 2019-12-20T16:51:25+01:00 New Revision: 32a34289597c7b0cc60b6c90b4222b44bef302d5 URL: https://github.com/llvm/llvm-project/commit/32a34289597c7b0cc60b6c90b4222b44bef302d5 DIFF: https://github.com/llvm/llvm-project/commit/32a34289597c7b0cc60b6c90b4222b44bef302d5.diff

[Lldb-commits] [lldb] 40aa418 - [lldb/cmake] Delete LLDB_LINKER_SUPPORTS_GROUPS

Author: Pavel Labath Date: 2019-12-20T16:58:58+01:00 New Revision: 40aa418223f36e0b9bfa457606e0d8f50aa4fe66 URL: https://github.com/llvm/llvm-project/commit/40aa418223f36e0b9bfa457606e0d8f50aa4fe66 DIFF: https://github.com/llvm/llvm-project/commit/40aa418223f36e0b9bfa457606e0d8f50aa4fe66.diff

[Lldb-commits] [PATCH] D71232: [lldb/Lua] Add Boilerplate for a Lua Script Interpreter

labath added inline comments. Comment at: lldb/cmake/modules/LLDBConfig.cmake:62 option(LLDB_ENABLE_PYTHON "Enable Python scripting integration." ${default_enable_python}) +option(LLDB_ENABLE_PYTHON "Enable Lua scripting integration." ${default_enable_lua}) option(LLDB_ENABLE

[Lldb-commits] [PATCH] D71482: [lldb/CMake] Rename LLDB_DISABLE_PYTHON to LLDB_ENABLE_PYTHON

labath added inline comments. Comment at: lldb/cmake/modules/LLDBConfig.cmake:43 + else() +set(default_enable_python ON) + endif() labath wrote: > JDevlieghere wrote: > > mgorny wrote: > > > JDevlieghere wrote: > > > > mgorny wrote: > > > > > JDevlieghere w

Re: [Lldb-commits] [lldb] 22caa3c - [lldb] Add unit test for ClangASTImporter

Nice, thanks! On Fri, Dec 20, 2019 at 2:53 AM Raphael “Teemperor” Isemann < teempe...@gmail.com> wrote: > Fixed by https://reviews.llvm.org/D71748. Will land this today. > > On 18. Dec 2019, at 23:03, Raphael “Teemperor” Isemann < > teempe...@gmail.com> wrote: > > I’m actually already investigati

[Lldb-commits] [lldb] 6be76f4 - [lldb][NFC] Remove redundant ASTContext args to CopyDecl/DeportDecl

Author: Raphael Isemann Date: 2019-12-20T18:45:14+01:00 New Revision: 6be76f491fcbb2a8476e58cb8d3310155c71e74a URL: https://github.com/llvm/llvm-project/commit/6be76f491fcbb2a8476e58cb8d3310155c71e74a DIFF: https://github.com/llvm/llvm-project/commit/6be76f491fcbb2a8476e58cb8d3310155c71e74a.dif

[Lldb-commits] [PATCH] D71306: [RFC] Change how we deal with optional dependencies

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/cmake/modules/FindCursesAndPanel.cmake:8 +if(CURSES_INCLUDE_DIRS AND CURSES_LIBRARIES AND PANEL_LIBRARIES) + set(CURSES_PANEL_FOUND TRUE) +else() labath wrote: >

[Lldb-commits] [PATCH] D71575: [LLDB] Add ObjectFileWasm plugin for WebAssembly debugging

paolosev updated this revision to Diff 234920. paolosev marked 7 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71575/new/ https://reviews.llvm.org/D71575 Files: lldb/include/lldb/Utility/ArchSpec.h lldb/source/API/System

[Lldb-commits] [PATCH] D71575: [LLDB] Add ObjectFileWasm plugin for WebAssembly debugging

paolosev added inline comments. Comment at: lldb/source/Plugins/ObjectFile/wasm/ObjectFileWasm.cpp:45 + +/// Reads a LEB128 variable-length unsigned integer, limited to 7 bits. +llvm::Optional GetVaruint7(DataExtractor §ion_header_data, aprantl wrote: > The LLVM

[Lldb-commits] [PATCH] D71514: Minor fixes of signed pointers for 32-bit hosts on top of D71498

jankratochvil abandoned this revision. jankratochvil added a comment. I will merge this with D71498 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71514/new/ https://reviews.llvm.org/D71514 _

[Lldb-commits] [lldb] a805e0f - [lldb][NFC] Remove utility methods in TestClangASTImporter

Author: Raphael Isemann Date: 2019-12-20T19:39:49+01:00 New Revision: a805e0fb18ca3b85712a587b72e5048e78d8f1da URL: https://github.com/llvm/llvm-project/commit/a805e0fb18ca3b85712a587b72e5048e78d8f1da DIFF: https://github.com/llvm/llvm-project/commit/a805e0fb18ca3b85712a587b72e5048e78d8f1da.dif

[Lldb-commits] [lldb] 810c3cf - ThreadPlanTracer::TracingStarted can't call virtual methods on Thread.

Author: Jim Ingham Date: 2019-12-20T10:56:39-08:00 New Revision: 810c3cfa664b38b27bc30afaadab3d775cb17922 URL: https://github.com/llvm/llvm-project/commit/810c3cfa664b38b27bc30afaadab3d775cb17922 DIFF: https://github.com/llvm/llvm-project/commit/810c3cfa664b38b27bc30afaadab3d775cb17922.diff LO

[Lldb-commits] [lldb] 2a42a5a - In 'thread step-out' command, only insert a breakpoint in executable memory.

Author: Jim Ingham Date: 2019-12-20T11:02:24-08:00 New Revision: 2a42a5a2f4144cd99812ad0d230480f94a1d1c92 URL: https://github.com/llvm/llvm-project/commit/2a42a5a2f4144cd99812ad0d230480f94a1d1c92 DIFF: https://github.com/llvm/llvm-project/commit/2a42a5a2f4144cd99812ad0d230480f94a1d1c92.diff LO

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a42a5a2f414 (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71372/new/ https://reviews.llvm.org/D71372 Files: lldb/include/lldb/Targ

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

jingham added a comment. I committed this (2a42a5a2f4144cd99812ad0d230480f94a1d1c92 ) but I forgot to attribute the patch to Mark in the commit message. My apologies! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] 2861324 - [lldb/Lua] Implement a Simple Lua Script Interpreter Prototype

Author: Jonas Devlieghere Date: 2019-12-20T11:19:47-08:00 New Revision: 2861324208e13846eb306f01b32448f94177cc3b URL: https://github.com/llvm/llvm-project/commit/2861324208e13846eb306f01b32448f94177cc3b DIFF: https://github.com/llvm/llvm-project/commit/2861324208e13846eb306f01b32448f94177cc3b.d

[Lldb-commits] [PATCH] D71234: [lldb/Lua] Implement a Simple Lua Script Interpreter Prototype

This revision was automatically updated to reflect the committed changes. Closed by commit rG2861324208e1: [lldb/Lua] Implement a Simple Lua Script Interpreter Prototype (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D71234?vs=234798&id=234934#toc Repository: r

[Lldb-commits] [PATCH] D71770: [lldb] Don't process symlinks deep inside DWARFUnit

aprantl added a comment. Does the mean these mappings will show up in the settings command? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71770/new/ https://reviews.llvm.org/D71770 ___ lldb-commits mai

[Lldb-commits] [PATCH] D71575: [LLDB] Add ObjectFileWasm plugin for WebAssembly debugging

aprantl added inline comments. Comment at: lldb/source/Plugins/ObjectFile/wasm/ObjectFileWasm.cpp:45 + +/// Reads a LEB128 variable-length unsigned integer, limited to 7 bits. +llvm::Optional GetVaruint7(DataExtractor §ion_header_data, paolosev wrote: > aprantl w

[Lldb-commits] [lldb] 44b4b83 - Rename DW_AT_LLVM_isysroot to DW_AT_LLVM_sysroot

Author: Adrian Prantl Date: 2019-12-20T13:11:17-08:00 New Revision: 44b4b833ad76fc61e43473c581a557f72a4ed8f4 URL: https://github.com/llvm/llvm-project/commit/44b4b833ad76fc61e43473c581a557f72a4ed8f4 DIFF: https://github.com/llvm/llvm-project/commit/44b4b833ad76fc61e43473c581a557f72a4ed8f4.diff

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols with the same address range but different binding

omjavaid added a comment. @jankratochvil @labath Some new information below: ProcessGDBRemote::DoAllocateMemory fails when it is called for expression evaluation preparation. This happens when both lldb and lldb-server are running on 32-bit arm host (various distros verified). If we debug usi

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

jingham added a comment. Hey, Mark... The test you added is failing on the Debian bots, e.g.: http://lab.llvm.org:8011/builders/lldb-x86_64-debian/builds/1903 Could you take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71372/new/ https:/

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

stella.stamenova added a comment. It looks like this also caused a failure on the Windows LLDB bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/11896 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71372/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D71575: [LLDB] Add ObjectFileWasm plugin for WebAssembly debugging

labath added inline comments. Comment at: lldb/source/Plugins/ObjectFile/wasm/ObjectFileWasm.cpp:40 + + const uint32_t *version = reinterpret_cast( + data_sp->GetBytes() + sizeof(llvm::wasm::WasmMagic)); This looks like it will cause problems on big endian

[Lldb-commits] [PATCH] D71784: Fedora Linux fails `Unwind/thread-step-out-ret-addr-check.test`

jankratochvil created this revision. jankratochvil added reviewers: jingham, labath, clayborg, mossberg. jankratochvil added a project: LLDB. Herald added a subscriber: kristof.beyls. D71372 introduced: `Unwind/thread-step-out-ret-addr-check.test` failing on Fedo

Re: [Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

Yes, and Fedora Linux too. Jan added a partial fix but that doesn't get the test passing IIUC. I think Mark only had a Darwin machine to test this on. I'm going to limit the test to darwin for now to give Mark a chance to analyze the failures. Jim > On Dec 20, 2019, at 1:25 PM, Stella Stame

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

mossberg added a comment. Took a quick look, and I think the good news is that the failure looks fairly superficial. > clang-10: warning: argument unused during compilation: > '-fmodules-cache-path=/home/worker/lldb-x86_64-debian/lldb-x86_64-debian/build/lldb-test-build.noindex/module-cache-cla

[Lldb-commits] [lldb] 41d7c22 - [lldb/CMake] Change how we deal with optional dependencies

Author: Jonas Devlieghere Date: 2019-12-20T14:13:28-08:00 New Revision: 41d7c227b38cce397e0402765593158f4bdf2dee URL: https://github.com/llvm/llvm-project/commit/41d7c227b38cce397e0402765593158f4bdf2dee DIFF: https://github.com/llvm/llvm-project/commit/41d7c227b38cce397e0402765593158f4bdf2dee.d

[Lldb-commits] [PATCH] D71306: [RFC] Change how we deal with optional dependencies

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rG41d7c227b38c: [lldb/CMake] Change how we deal with optional dependencies (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D713

[Lldb-commits] [lldb] 05b2c6a - Temporarily restrict the test for D71372 to darwin till we fix it on other systems.

Author: Jim Ingham Date: 2019-12-20T14:31:41-08:00 New Revision: 05b2c6a52cc79916beb4cad820a4b5e0ddfd2c4e URL: https://github.com/llvm/llvm-project/commit/05b2c6a52cc79916beb4cad820a4b5e0ddfd2c4e DIFF: https://github.com/llvm/llvm-project/commit/05b2c6a52cc79916beb4cad820a4b5e0ddfd2c4e.diff LO

Re: [Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

Okay, I pushed a change to the test to only run on darwin. When you have a patch for the other systems, we can take that out again. Jim > On Dec 20, 2019, at 2:08 PM, Mark Mossberg via Phabricator > wrote: > > mossberg added a comment. > > Took a quick look, and I think the good news is th

[Lldb-commits] [PATCH] D71784: Fedora Linux fails `Unwind/thread-step-out-ret-addr-check.test`

mossberg added a comment. Thanks for looking into this @jankratochvil! > Another problem is that Fedora Linux has executable stack by default and all > programs indicate non-executable stack by PT_GNU_STACK, after fixing the > underscore I was getting: > > (lldb) thread step-out > Process 222

[Lldb-commits] [PATCH] D71306: [RFC] Change how we deal with optional dependencies

stella.stamenova added a comment. This broke the Windows LLDB bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/11903 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71306/new/ https://reviews.llvm.org/D71306 __

[Lldb-commits] [PATCH] D71789: [lldb] Refactor thread-step-out-ret-addr-check test to use .data instead of stack variable

mossberg created this revision. mossberg added reviewers: jingham, jankratochvil, labath, clayborg, stella.stamenova. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Original diff: D71372 Related diff: D71784

[Lldb-commits] [PATCH] D71784: Fedora Linux fails `Unwind/thread-step-out-ret-addr-check.test`

mossberg added a comment. The Windows failure (https://reviews.llvm.org/D71372#1793371) seems like it may also be caused by the underscore symbol issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71784/new/ https://reviews.llvm.org/D71784 __

[Lldb-commits] [lldb] fe86289 - Revert "[lldb/CMake] Change how we deal with optional dependencies"

Author: Jonas Devlieghere Date: 2019-12-20T15:35:43-08:00 New Revision: fe86289bf19b165e34f66d9411469131a77d0110 URL: https://github.com/llvm/llvm-project/commit/fe86289bf19b165e34f66d9411469131a77d0110 DIFF: https://github.com/llvm/llvm-project/commit/fe86289bf19b165e34f66d9411469131a77d0110.d

[Lldb-commits] [lldb] 94b1bc0 - Re-land "[lldb/CMake] Change how we deal with optional dependencies"

Author: Jonas Devlieghere Date: 2019-12-20T20:05:04-08:00 New Revision: 94b1bc0fb86a081caae0a919c0ecdb732a84e8ad URL: https://github.com/llvm/llvm-project/commit/94b1bc0fb86a081caae0a919c0ecdb732a84e8ad DIFF: https://github.com/llvm/llvm-project/commit/94b1bc0fb86a081caae0a919c0ecdb732a84e8ad.d

[Lldb-commits] [lldb] c51ad1f - [lldb/CMake] Don't use return() from macro()

Author: Jonas Devlieghere Date: 2019-12-20T20:53:33-08:00 New Revision: c51ad1f836bffb4e431eb9f948ee3a32902ba6d2 URL: https://github.com/llvm/llvm-project/commit/c51ad1f836bffb4e431eb9f948ee3a32902ba6d2 DIFF: https://github.com/llvm/llvm-project/commit/c51ad1f836bffb4e431eb9f948ee3a32902ba6d2.d

[Lldb-commits] [lldb] 6cc3ee1 - [lldb] Expose more optional dependencies through GetBuildConfiguration()

Author: Jonas Devlieghere Date: 2019-12-20T21:01:08-08:00 New Revision: 6cc3ee17a018d916459a4f59a77c75d0b7e191a0 URL: https://github.com/llvm/llvm-project/commit/6cc3ee17a018d916459a4f59a77c75d0b7e191a0 DIFF: https://github.com/llvm/llvm-project/commit/6cc3ee17a018d916459a4f59a77c75d0b7e191a0.d

[Lldb-commits] [lldb] a32f8dd - [lldb/test] Skip editline tests when LLDB_ENABLE_LIBEDIT is off.

Author: Jonas Devlieghere Date: 2019-12-20T21:01:23-08:00 New Revision: a32f8dd195866c2be95d7e71f311a805a6fed4cd URL: https://github.com/llvm/llvm-project/commit/a32f8dd195866c2be95d7e71f311a805a6fed4cd DIFF: https://github.com/llvm/llvm-project/commit/a32f8dd195866c2be95d7e71f311a805a6fed4cd.d

[Lldb-commits] [lldb] 3fa39c3 - [lldb/test] Update !DIModule for isysroot rename

Author: Jonas Devlieghere Date: 2019-12-20T21:11:50-08:00 New Revision: 3fa39c3a79a3b1a88d2da0b3992089e9134fb87f URL: https://github.com/llvm/llvm-project/commit/3fa39c3a79a3b1a88d2da0b3992089e9134fb87f DIFF: https://github.com/llvm/llvm-project/commit/3fa39c3a79a3b1a88d2da0b3992089e9134fb87f.d