[Lldb-commits] [PATCH] D71398: [lldb] Remove RTTI in ClangExternalASTSourceCommon based on a global map of known instances

teemperor created this revision. teemperor added reviewers: labath, aprantl. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. Currently we do our RTTI check for ClangExternalASTSourceCommon by using this global map of ClangExternalASTSourceCommon where every ins

[Lldb-commits] [PATCH] D71398: [lldb] Remove RTTI in ClangExternalASTSourceCommon based on a global map of known instances

teemperor updated this revision to Diff 233526. teemperor added a comment. Ran clang-format on the patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71398/new/ https://reviews.llvm.org/D71398 Files: lldb/include/lldb/Symbol/ClangExternalASTSourceCommon.h lldb/source/Symbol/Clang

[Lldb-commits] [lldb] 2aec4b4 - [lldb][NFC] Don't implement ClangASTContext::SetMetadata again as a static method

Author: Raphael Isemann Date: 2019-12-12T11:14:26+01:00 New Revision: 2aec4b4863f883e1e9e8e0362b85d37fc5fc0545 URL: https://github.com/llvm/llvm-project/commit/2aec4b4863f883e1e9e8e0362b85d37fc5fc0545 DIFF: https://github.com/llvm/llvm-project/commit/2aec4b4863f883e1e9e8e0362b85d37fc5fc0545.dif

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

labath added a comment. I'm not sure how easy it is to do that here, but it would certainly be nice to include these error messages in the actual error output from the "finish" command so that they are visible even without logging enabled. As for the test, you should be able to do something sim

[Lldb-commits] [PATCH] D71380: [lldb/CMake] Rename LLDB_DISABLE_LIBEDIT to LLDB_ENABLE_LIBEDIT

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. cool Comment at: lldb/docs/resources/build.rst:405 -DLLDB_DISABLE_PYTHON=1 + -DLLDB_ENABLE_LIBEDIT=1 -DLLDB_ENABLE_CURSES=1 this should be zero now

[Lldb-commits] [PATCH] D71377: [lldb/CMake] Rename LLDB_DISABLE_CURSES to LLDB_ENABLE_CURSES

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/docs/resources/build.rst:406 -DLLDB_DISABLE_PYTHON=1 + -DLLDB_ENABLE_CURSES=1 -DLLVM_ENABLE_TERMINFO=0 `=0` also ==

[Lldb-commits] [PATCH] D71398: [lldb] Remove RTTI in ClangExternalASTSourceCommon based on a global map of known instances

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. yay CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71398/new/ https://reviews.llvm.org/D71398 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

labath added a comment. In D70840#1779077 , @mstorsjo wrote: > In D70840#1763639 , @labath wrote: > > > - I think we ought to have some kind of a utility function to hold the > > logic for the `&~1` stuff. there is

[Lldb-commits] [lldb] d6d36ae - [lldb] "See through" atomic types in ClangASTContext

Author: Pavel Labath Date: 2019-12-12T11:45:03+01:00 New Revision: d6d36ae4a052e9fefd2926005a69f6cebfa5832b URL: https://github.com/llvm/llvm-project/commit/d6d36ae4a052e9fefd2926005a69f6cebfa5832b DIFF: https://github.com/llvm/llvm-project/commit/d6d36ae4a052e9fefd2926005a69f6cebfa5832b.diff

[Lldb-commits] [lldb] e39cb48 - [lldb] Remove ClangASTMetrics

Author: Raphael Isemann Date: 2019-12-12T11:46:25+01:00 New Revision: e39cb48cd0bdf9157b57c4616c821488f7b6d7c4 URL: https://github.com/llvm/llvm-project/commit/e39cb48cd0bdf9157b57c4616c821488f7b6d7c4 DIFF: https://github.com/llvm/llvm-project/commit/e39cb48cd0bdf9157b57c4616c821488f7b6d7c4.dif

[Lldb-commits] [PATCH] D71262: [lldb] "See through" atomic types in ClangASTContext

This revision was automatically updated to reflect the committed changes. Closed by commit rGd6d36ae4a052: [lldb] "See through" atomic types in ClangASTContext (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71262/new/ https://re

[Lldb-commits] [PATCH] D71336: [lldb] Remove ClangASTMetrics

This revision was automatically updated to reflect the committed changes. Closed by commit rGe39cb48cd0bd: [lldb] Remove ClangASTMetrics (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71336/new/ https://reviews.llvm.org/D7133

[Lldb-commits] [PATCH] D71405: [lldb] Centralize desugaring of decltype-like types in ClangASTContext

labath created this revision. labath added reviewers: teemperor, shafik. Herald added a project: LLDB. These types were handled in some places, but not others. This resulted in (for example) not being able to display members of structs whose types were defined using these constructs. Using getLoc

[Lldb-commits] [PATCH] D70846: Expression eval lookup speedup by not returning methods in ManualDWARFIndex::GetFunctions

labath added a comment. I wouldn't want to do (3). I think the ideal solution would be (2). AppleIndex should also be able to do this kind of filtering, only it'd have to be done differently -- after looking up the name in the accelerator table, it would go to the debug info, and check what ex

[Lldb-commits] [PATCH] D71409: [lldb][NFC] Make metadata tracking type safe

teemperor created this revision. teemperor added reviewers: labath, shafik, aprantl. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. teemperor added a comment. teemperor edited the summary of this revision. (I'm aware that a lot of the touched code here could be

[Lldb-commits] [PATCH] D71409: [lldb][NFC] Make metadata tracking type safe

teemperor added a comment. (I'm aware that a lot of the touched code here could be improved, but I would prefer that I at least can trust my compiler before I refactor the remaining Metadata stuff...) Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71409/new/ h

[Lldb-commits] [PATCH] D71378: Modifying ImportDeclContext(...) to ensure that we complete each FieldDecl of a RecordDecl when we are importing the definiton

teemperor added a comment. I wonder if we have a way to fix this from with LLDB. Having Clang code that is only tested in LLDB is always a bit weird. Otherwise the idea itself LGTM, thanks for working on this (and reducing the test case to that!) Comment at: clang/lib/AST/AS

[Lldb-commits] [PATCH] D71409: [lldb][NFC] Make metadata tracking type safe

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Yes this is definitely better. If storing metadata for QualTypes is important (my impression is it's the opposite), then you could do that (while maintaining a decent amount of type safety) by

[Lldb-commits] [PATCH] D71378: Modifying ImportDeclContext(...) to ensure that we complete each FieldDecl of a RecordDecl when we are importing the definiton

martong added a comment. Thanks for the patch! It look almost good to me, but I have a comment about the error handling. Comment at: clang/lib/AST/ASTImporter.cpp:1707 +if (Err) + return Err; +} Rather than just simply retu

[Lldb-commits] [PATCH] D71378: Modifying ImportDeclContext(...) to ensure that we complete each FieldDecl of a RecordDecl when we are importing the definiton

martong added a comment. Just one more thing, maybe that is too overkill, but I think on a long term we could benefit from a unittest for this case. You could create a test similar to `LLDBLookupTest` in ASTImporterTest.cpp. In that Fixture we use Minimal import and the regular lookup (that is

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

mstorsjo updated this revision to Diff 233586. mstorsjo edited the summary of this revision. mstorsjo added a comment. Added ArchSpec::GetOpcodeLoadAddress() (didn't refactor Architecture to use it yet, so this is still duplicated code with the ArchitectureArm and ArchitectureMips plugins, but p

[Lldb-commits] [lldb] a4304f9 - [lldb/CMake] Rename LLDB_DISABLE_CURSES to LLDB_ENABLE_CURSES

Author: Jonas Devlieghere Date: 2019-12-12T09:13:31-08:00 New Revision: a4304f96d6baba92baa9db1eef0ed647f76306f6 URL: https://github.com/llvm/llvm-project/commit/a4304f96d6baba92baa9db1eef0ed647f76306f6 DIFF: https://github.com/llvm/llvm-project/commit/a4304f96d6baba92baa9db1eef0ed647f76306f6.d

[Lldb-commits] [PATCH] D71409: [lldb][NFC] Make metadata tracking type safe

aprantl added inline comments. Comment at: lldb/source/Symbol/ClangExternalASTSourceCommon.cpp:64 +ClangExternalASTSourceCommon::GetMetadata(const clang::Type *object) { + auto It = m_type_metadata.find(object); + if (It != m_type_metadata.end()) .lookup(), ass

[Lldb-commits] [PATCH] D71377: [lldb/CMake] Rename LLDB_DISABLE_CURSES to LLDB_ENABLE_CURSES

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4304f96d6ba: [lldb/CMake] Rename LLDB_DISABLE_CURSES to LLDB_ENABLE_CURSES (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D71377?vs=233456&id=233640#toc Repository: rG

[Lldb-commits] [lldb] 62456e5 - [lldb/CMake] Rename LLDB_DISABLE_LIBEDIT to LLDB_ENABLE_LIBEDIT

Author: Jonas Devlieghere Date: 2019-12-12T09:23:06-08:00 New Revision: 62456e579eebe012e5a6ebcf9960aef9d7babf87 URL: https://github.com/llvm/llvm-project/commit/62456e579eebe012e5a6ebcf9960aef9d7babf87 DIFF: https://github.com/llvm/llvm-project/commit/62456e579eebe012e5a6ebcf9960aef9d7babf87.d

[Lldb-commits] [PATCH] D71380: [lldb/CMake] Rename LLDB_DISABLE_LIBEDIT to LLDB_ENABLE_LIBEDIT

This revision was automatically updated to reflect the committed changes. Closed by commit rG62456e579eeb: [lldb/CMake] Rename LLDB_DISABLE_LIBEDIT to LLDB_ENABLE_LIBEDIT (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D71380?vs=233471&id=233645#toc Repository:

[Lldb-commits] [lldb] 4b15c6e - [lldb/Host] Use cmakedefine01 for LLDB_ENABLE_LIBXML2

Author: Jonas Devlieghere Date: 2019-12-12T09:28:56-08:00 New Revision: 4b15c6e2a15f9d1d7c2586af8a7811e7b43ac799 URL: https://github.com/llvm/llvm-project/commit/4b15c6e2a15f9d1d7c2586af8a7811e7b43ac799 DIFF: https://github.com/llvm/llvm-project/commit/4b15c6e2a15f9d1d7c2586af8a7811e7b43ac799.d

[Lldb-commits] [lldb] 61a2bda - [lldb/Host] Use cmakedefine01 for LLDB_ENABLE_TERMIOS

Author: Jonas Devlieghere Date: 2019-12-12T09:34:11-08:00 New Revision: 61a2bdadb33166950f768ad2c764d2940b9466fb URL: https://github.com/llvm/llvm-project/commit/61a2bdadb33166950f768ad2c764d2940b9466fb DIFF: https://github.com/llvm/llvm-project/commit/61a2bdadb33166950f768ad2c764d2940b9466fb.d

[Lldb-commits] [lldb] babbd55 - [lldb/Core] Add missing include

Author: Jonas Devlieghere Date: 2019-12-12T09:55:11-08:00 New Revision: babbd554b8db7744a6829f7180e195db018ef6a7 URL: https://github.com/llvm/llvm-project/commit/babbd554b8db7744a6829f7180e195db018ef6a7 DIFF: https://github.com/llvm/llvm-project/commit/babbd554b8db7744a6829f7180e195db018ef6a7.d

[Lldb-commits] [lldb] 7ffe7d5 - [lldb/Core] Add missing include (2/2)

Author: Jonas Devlieghere Date: 2019-12-12T10:05:30-08:00 New Revision: 7ffe7d5ed73e917dffb34a3cbb60231338b95d28 URL: https://github.com/llvm/llvm-project/commit/7ffe7d5ed73e917dffb34a3cbb60231338b95d28 DIFF: https://github.com/llvm/llvm-project/commit/7ffe7d5ed73e917dffb34a3cbb60231338b95d28.d

[Lldb-commits] [lldb] 7eaae93 - [FormatEntity] Add mangled function name support

Author: Med Ismail Bennani Date: 2019-12-12T10:22:57-08:00 New Revision: 7eaae939b9bb294d029d212d768bb38272c00936 URL: https://github.com/llvm/llvm-project/commit/7eaae939b9bb294d029d212d768bb38272c00936 DIFF: https://github.com/llvm/llvm-project/commit/7eaae939b9bb294d029d212d768bb38272c00936.

[Lldb-commits] [PATCH] D71237: [FormatEntity] Add mangled function name support

This revision was automatically updated to reflect the committed changes. Closed by commit rG7eaae939b9bb: [FormatEntity] Add mangled function name support (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71237/new/ https://reviews.l

[Lldb-commits] [PATCH] D71378: Modifying ImportDeclContext(...) to ensure that we complete each FieldDecl of a RecordDecl when we are importing the definiton

shafik added a comment. In D71378#1781616 , @teemperor wrote: > I wonder if we have a way to fix this from with LLDB. Having Clang code that > is only tested in LLDB is always a bit weird. > > Otherwise the idea itself LGTM, thanks for working on this (an

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

mossberg added a comment. In D71372#1781316 , @labath wrote: > I'm not sure how easy it is to do that here, but it would certainly be nice > to include these error messages in the actual error output from the "finish" > command so that they are visible e

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

jingham added a comment. In D71372#1781316 , @labath wrote: > I'm not sure how easy it is to do that here, but it would certainly be nice > to include these error messages in the actual error output from the "finish" > command so that they are visible ev

[Lldb-commits] [PATCH] D71310: RFC: Remove "Validators"

vsk added a comment. Just a heads up while I investigate, I'm starting to see this on the sanitizer bot: /Users/buildslave/jenkins/workspace/lldb-cmake-sanitized/llvm-project/lldb/include/lldb/DataFormatters/TypeCategory.h:278:35: runtime error: load of value 190, which is not a valid value

[Lldb-commits] [PATCH] D71310: RFC: Remove "Validators"

vsk added a comment. I believe this change is responsible: - m_validator_cont("validator", "regex-validator", clist), m_enabled(false), @aprantl was the `m_enabled` initialization supposed to be deleted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [lldb] 46d970c - TypeCategory: Initialize m_enabled to false

Author: Vedant Kumar Date: 2019-12-12T11:39:41-08:00 New Revision: 46d970cc436068af826e5f6a59033dd0f10c570d URL: https://github.com/llvm/llvm-project/commit/46d970cc436068af826e5f6a59033dd0f10c570d DIFF: https://github.com/llvm/llvm-project/commit/46d970cc436068af826e5f6a59033dd0f10c570d.diff

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

mossberg added a comment. > So just add a std::string to ThreadPlanStepOut, and cons up your error > message there. Then in ThreadPlanStepOut::ValidatePlan, instead of doing: > > if (m_return_bp_id == LLDB_INVALID_BREAK_ID) { > if (error) > error->PutCString("Could not create return

[Lldb-commits] [lldb] 3031818 - [Target] Remove Target::GetScratchClangASTContext

Author: Alex Langford Date: 2019-12-12T11:53:24-08:00 New Revision: 3031818a2e9fca1e53cd882ccfcc371861b4 URL: https://github.com/llvm/llvm-project/commit/3031818a2e9fca1e53cd882ccfcc371861b4 DIFF: https://github.com/llvm/llvm-project/commit/3031818a2e9fca1e53cd882ccfcc371861b4.diff

[Lldb-commits] [PATCH] D64844: [Target] Remove Target::GetScratchClangASTContext

xiaobai added a comment. Landed as commit 3031818a2e9fca1e53cd882ccfcc371861b4 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64844/new/ https://reviews.llvm.org/D64844 __

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

mossberg updated this revision to Diff 233673. mossberg added a comment. Output error messages to console in addition to logging. I wasn't sure, but decided to unconditionally output the `Could not create return address breakpoint.` message for UX reasons. That message provides a bit of contex

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

mossberg added a comment. Screenshots with new error messages. F11034423: image.png F11034433: image.png (I artificially forced this branch to execute, still unable to make it execute at runtime) F11034446: image.png

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

jingham added a comment. In D71372#1782512 , @mossberg wrote: > Screenshots with new error messages. > > F11034423: image.png > > F11034433: image.png > > (I artificially forced this

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

clayborg added a comment. I believe it is ok for permissions to succeed as long as they don't return invalid permissions. For any address outside any mapped ranges, we should have zero as the permissions. Looking up address mappings for zero will return [0x - 0x1) --- no permis

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

jingham added a comment. In D71372#1782536 , @clayborg wrote: > I believe it is ok for permissions to succeed as long as they don't return > invalid permissions. For any address outside any mapped ranges, we should > have zero as the permissions. Looking

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

clayborg added a comment. In D71372#1782538 , @jingham wrote: > In D71372#1782536 , @clayborg wrote: > > > I believe it is ok for permissions to succeed as long as they don't return > > invalid permissions. For any

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

mossberg added a comment. In D71372#1782536 , @clayborg wrote: > I believe it is ok for permissions to succeed as long as they don't return > invalid permissions. For any address outside any mapped ranges, we should > have zero as the permissions. Lookin

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

jingham added a comment. In D71372#1782549 , @clayborg wrote: > In D71372#1782538 , @jingham wrote: > > > In D71372#1782536 , @clayborg > > wrote: > > > > > I believe it is

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

clayborg added a comment. In D71372#1782567 , @jingham wrote: > In D71372#1782549 , @clayborg wrote: > > > In D71372#1782538 , @jingham wrote: > > > > > In D71372#1782536

[Lldb-commits] [PATCH] D71440: Extending step-over range past calls was causing deadlocks, fix that.

jingham created this revision. jingham added a reviewer: clayborg. jingham added a project: LLDB. Herald added subscribers: lldb-commits, jfb. This change: https://reviews.llvm.org/D58678 made lldb extend it's "next branch breakpoint" over IsCall instructions as a way to speed up stepping. How

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

mossberg updated this revision to Diff 233708. mossberg added a comment. Add test. I wasn't sure where to put it, so I left it in the `Unwind/` directory since the `call-asm.c` infrastructure is already there, and this fix is *kind of* vaguely related to unwinding. Please let me know if there's

[Lldb-commits] [PATCH] D71440: Extending step-over range past calls was causing deadlocks, fix that.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. That must have been fun to find! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71440/new/ https://reviews.llvm.org/D71440 _

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

mossberg added a comment. I noticed some other tests specify the OS's they apply to-- I wasn't sure if there were any restrictions I should put on this one. I only tested on MacOS, and I imagine it should work on Linux. Not sure about Windows. Repository: rG LLVM Github Monorepo CHANGES SIN

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

clayborg added a comment. Sorry for the delay. I have had medical issues going on for the past month. The hard part about Architecture vs ArchSpec is the architecture of the target doesn't always exactly match the arch of each module. But I agree that we need to be able to do more with ArchSpec

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

mstorsjo added a comment. In D70840#1782951 , @clayborg wrote: > So my idea would be: > 1 - add all virtual functions to from lldb_private::Architecture as normal > members of ArchSpec. > 2 - have ArchSpec grap the the lldb_private::Architecture using

[Lldb-commits] [lldb] 5536c62 - [lldb] Remove xpasses after pr44037 fix committed

Author: Muhammad Omair Javaid Date: 2019-12-13T12:30:58+05:00 New Revision: 5536c62f3c35015802dd59150d422c4ab79db581 URL: https://github.com/llvm/llvm-project/commit/5536c62f3c35015802dd59150d422c4ab79db581 DIFF: https://github.com/llvm/llvm-project/commit/5536c62f3c35015802dd59150d422c4ab79db5