[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

jankratochvil added a comment. @omjavaid I do not have the regression reproducible, could you provide more info? Having on both hosts trunk `54a9b4c02ff57e9847e0c501578e51db6f73d3be` having applied your D69904 , having reverted your revert (=reapplied) of this m

[Lldb-commits] [PATCH] D70137: [lldb][Editline] Support ctrl+left/right arrow word navigation.

labath accepted this revision. labath added a comment. Looks good. Thanks for adding the test. See inline comment for possible simplification. Comment at: lldb/packages/Python/lldbsuite/test/terminal/TestEditline.py:22 + +Note: just sending escape characters to pexpect

[Lldb-commits] [PATCH] D70177: [lldb] Fix that trailing backslashes in source lines break the Clang highlighter

teemperor created this revision. teemperor added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Clang's raw Lexer doesn't produce any tokens for trailing backslashes in a line. This doesn't work with LLDB's Clang highlighter which builds the sourc

[Lldb-commits] [PATCH] D70155: [LLDB] Avoid triple corruption while merging core info from platform and target triples

labath added a comment. Can you add a test case for this? I assuming it could be similar to one of the existing ArchSpec::MergeFrom tests in https://github.com/llvm/llvm-project/blob/7dd7a3607596a51044b8706ebf6df2e613ce1e9b/lldb/unittests/Utility/ArchSpecTest.cpp#L137 CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D70177: [lldb] Fix that trailing backslashes in source lines break the Clang highlighter

labath added inline comments. Comment at: lldb/source/Plugins/Language/ClangCommon/ClangHighlighter.cpp:150 + const bool line_had_lf = line.endswith("\n") && !line_had_cr_lf; + line = line.trim("\r\n"); + technically, this `trim` might remove additional spuriou

[Lldb-commits] [PATCH] D70154: [LLDB] Fix whitespace/tabs mismatch in lldbsuite Makefile.rules

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. It looks like you're replacing everything with tabs. I suppose that's fine, as that is the prevalent local convention, but it might be better to go for spaces, as we don't use tabs anywhere el

[Lldb-commits] [PATCH] D70177: [lldb] Fix that trailing backslashes in source lines break the Clang highlighter

teemperor updated this revision to Diff 229087. teemperor added a comment. - Moved to `consume_back` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70177/new/ https://reviews.llvm.org/D70177 Files: lldb/source/Plugins/Language/ClangCommon/ClangHighlighter.cpp lldb/unittests/Language

[Lldb-commits] [PATCH] D70127: [lldb-vscode] Fix a race in test_extra_launch_commands

labath added a comment. In D70127#1743077 , @clayborg wrote: > --stop-at-entry only really works for Darwin That's not true. :) The reason this works on linux (and elsewhere) is that we don't use posix_spawn, but instead we launch the process (fork+exec

[Lldb-commits] [PATCH] D69704: [lldb] Add IsDebugInfoCompatible method to SBModule to allow checking compatibility between language versions

teemperor updated this revision to Diff 229092. teemperor added a comment. - Simplified error handling (Thanks Pavel) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69704/new/ https://reviews.llvm.org/D69704 Files: lldb/include/lldb/API/SBError.h lldb/include/lldb/API/SBModule.h l

[Lldb-commits] [PATCH] D70177: [lldb] Fix that trailing backslashes in source lines break the Clang highlighter

labath added inline comments. Comment at: lldb/source/Plugins/Language/ClangCommon/ClangHighlighter.cpp:149 + const bool line_had_lf = line.consume_back("\n"); + const bool line_had_cr_lf = line.consume_back("\r"); + `= line_had_lf && consume_back(\r)` CHANGE

[Lldb-commits] [PATCH] D69704: [lldb] Add IsDebugInfoCompatible method to SBModule to allow checking compatibility between language versions

labath added a comment. In D69704#1742638 , @jingham wrote: > It doesn't seem like these are mutually exclusive. If we were being > exhaustive about this we would have two levels of test, (1) is all the debug > information in the module uningestible and

[Lldb-commits] [PATCH] D51830: Add a way to make scripted breakpoints

kwk added inline comments. Comment at: source/Core/SearchFilter.cpp:757 + } + if (m_cu_spec_list.FindFileIndex(0, sym_ctx.comp_unit, false) == UINT32_MAX) +return false; // Fails the file check @jingham Do you know why you check for the CU again here? I

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

jankratochvil added a comment. It is still the same (no arm32 regression) with `16bdcc809c72c639a2888b6b859dca88453e3c28` and this patch reapplied. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63540/new/ https://reviews.llvm.org/D63540 ___

[Lldb-commits] [PATCH] D70177: [lldb] Fix that trailing backslashes in source lines break the Clang highlighter

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM with Pavel's comment. Thanks for the quick turnaround on this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70177/new/ https://reviews.llvm.org/D70177 ___ lldb-commits

[Lldb-commits] [PATCH] D51830: Add a way to make scripted breakpoints

jingham marked an inline comment as done. jingham added inline comments. Comment at: source/Core/SearchFilter.cpp:757 + } + if (m_cu_spec_list.FindFileIndex(0, sym_ctx.comp_unit, false) == UINT32_MAX) +return false; // Fails the file check kwk wrote: >

[Lldb-commits] [lldb] ad88277 - [LLDB] Fix a bunch of -Wdocumentation warnings

Author: Jonas Devlieghere Date: 2019-11-13T12:28:10-08:00 New Revision: ad882774fe4ee9b37ffcf35d86303c265bbc585a URL: https://github.com/llvm/llvm-project/commit/ad882774fe4ee9b37ffcf35d86303c265bbc585a DIFF: https://github.com/llvm/llvm-project/commit/ad882774fe4ee9b37ffcf35d86303c265bbc585a.d

[Lldb-commits] [lldb] 7858677 - Rename ParseTypeFromDWO to ParseTypeFromClangModule (NFC)

Author: Adrian Prantl Date: 2019-11-13T13:37:43-08:00 New Revision: 78586775f7b26813740096024949907848e7ccc1 URL: https://github.com/llvm/llvm-project/commit/78586775f7b26813740096024949907848e7ccc1 DIFF: https://github.com/llvm/llvm-project/commit/78586775f7b26813740096024949907848e7ccc1.diff

[Lldb-commits] [lldb] 3d30c14 - Rename clang-module-related *DWO* functions to *ClangModule* (NFC)

Author: Adrian Prantl Date: 2019-11-13T14:07:20-08:00 New Revision: 3d30c142e147b772463f99a81b106898a9f04971 URL: https://github.com/llvm/llvm-project/commit/3d30c142e147b772463f99a81b106898a9f04971 DIFF: https://github.com/llvm/llvm-project/commit/3d30c142e147b772463f99a81b106898a9f04971.diff

[Lldb-commits] [lldb] 7f9d36e - Use cheaper, equivalent predicate. (NFC)

Author: Adrian Prantl Date: 2019-11-13T14:16:40-08:00 New Revision: 7f9d36e2db05a7e4646972a88f5b6946c2f343e3 URL: https://github.com/llvm/llvm-project/commit/7f9d36e2db05a7e4646972a88f5b6946c2f343e3 DIFF: https://github.com/llvm/llvm-project/commit/7f9d36e2db05a7e4646972a88f5b6946c2f343e3.diff

[Lldb-commits] [lldb] 9072f01 - Remove redundant check. (NFC)

Author: Adrian Prantl Date: 2019-11-13T14:19:01-08:00 New Revision: 9072f0103b3d54a0db76c881edce03fbe7cb973c URL: https://github.com/llvm/llvm-project/commit/9072f0103b3d54a0db76c881edce03fbe7cb973c DIFF: https://github.com/llvm/llvm-project/commit/9072f0103b3d54a0db76c881edce03fbe7cb973c.diff

[Lldb-commits] [lldb] 8df482e - [LLDB] Fix a bunch of -Wdocumentation warnings in ExpressionParser

Author: Jonas Devlieghere Date: 2019-11-13T14:40:55-08:00 New Revision: 8df482e51c5508203af348589391c776ba8112f8 URL: https://github.com/llvm/llvm-project/commit/8df482e51c5508203af348589391c776ba8112f8 DIFF: https://github.com/llvm/llvm-project/commit/8df482e51c5508203af348589391c776ba8112f8.d

[Lldb-commits] [lldb] 294ef76 - [RegisterContext] Remove now unneded vestiges.

Author: Davide Italiano Date: 2019-11-13T14:53:13-08:00 New Revision: 294ef766e8f13818369c22fbad47283c84d87c2f URL: https://github.com/llvm/llvm-project/commit/294ef766e8f13818369c22fbad47283c84d87c2f DIFF: https://github.com/llvm/llvm-project/commit/294ef766e8f13818369c22fbad47283c84d87c2f.dif

[Lldb-commits] [lldb] 95807cb - [LLDB] Remove dead code from StreamFile

Author: Jonas Devlieghere Date: 2019-11-13T15:08:51-08:00 New Revision: 95807cb039c96323570e0d16a8cbafbf759f7141 URL: https://github.com/llvm/llvm-project/commit/95807cb039c96323570e0d16a8cbafbf759f7141 DIFF: https://github.com/llvm/llvm-project/commit/95807cb039c96323570e0d16a8cbafbf759f7141.d

[Lldb-commits] [lldb] 9634064 - [LLDB] Fix another set of -Wdocumentation warnings

Author: Jonas Devlieghere Date: 2019-11-13T15:13:06-08:00 New Revision: 9634064cfa1b9bf7b70e1cdf1f4e52a25d6184e7 URL: https://github.com/llvm/llvm-project/commit/9634064cfa1b9bf7b70e1cdf1f4e52a25d6184e7 DIFF: https://github.com/llvm/llvm-project/commit/9634064cfa1b9bf7b70e1cdf1f4e52a25d6184e7.d

[Lldb-commits] [lldb] 33c3e0b - [LLDB] Implement pure virtual method in MockConnection

Author: Jonas Devlieghere Date: 2019-11-13T15:37:57-08:00 New Revision: 33c3e0b96c14e5986fec778625c1e2a37b452956 URL: https://github.com/llvm/llvm-project/commit/33c3e0b96c14e5986fec778625c1e2a37b452956 DIFF: https://github.com/llvm/llvm-project/commit/33c3e0b96c14e5986fec778625c1e2a37b452956.d

[Lldb-commits] [lldb] bfe663c - Revert a hunk from 9634064cfa1b9bf7b7

Author: Reid Kleckner Date: 2019-11-13T15:43:54-08:00 New Revision: bfe663ce22db6697459510ae5c139da2197df56c URL: https://github.com/llvm/llvm-project/commit/bfe663ce22db6697459510ae5c139da2197df56c DIFF: https://github.com/llvm/llvm-project/commit/bfe663ce22db6697459510ae5c139da2197df56c.diff

[Lldb-commits] [lldb] 8ac053e - [LLDB] Cleanup the DataEncoder utility. (NFC)

Author: Jonas Devlieghere Date: 2019-11-13T15:44:51-08:00 New Revision: 8ac053eea20b56f80653191a210682f8bd6fc10d URL: https://github.com/llvm/llvm-project/commit/8ac053eea20b56f80653191a210682f8bd6fc10d DIFF: https://github.com/llvm/llvm-project/commit/8ac053eea20b56f80653191a210682f8bd6fc10d.d

[Lldb-commits] [lldb] a36f316 - Forward declare Optional in STLExtras.h

Author: Reid Kleckner Date: 2019-11-13T16:34:00-08:00 New Revision: a36f316390d4bc1bcb0e9de0f55831385ab24099 URL: https://github.com/llvm/llvm-project/commit/a36f316390d4bc1bcb0e9de0f55831385ab24099 DIFF: https://github.com/llvm/llvm-project/commit/a36f316390d4bc1bcb0e9de0f55831385ab24099.diff

[Lldb-commits] [lldb] 5565d36 - Revert "Forward declare Optional in STLExtras.h"

Author: Reid Kleckner Date: 2019-11-13T16:36:21-08:00 New Revision: 5565d365f2af0f6d17f12ed1a980e6d9415a6607 URL: https://github.com/llvm/llvm-project/commit/5565d365f2af0f6d17f12ed1a980e6d9415a6607 DIFF: https://github.com/llvm/llvm-project/commit/5565d365f2af0f6d17f12ed1a980e6d9415a6607.diff

[Lldb-commits] [PATCH] D70215: Use ForEachExternalModule in ParseTypeFromClangModule (NFC)

aprantl created this revision. aprantl added a reviewer: teemperor. Herald added a reviewer: jdoerfert. Herald added a reviewer: shafik. I wanted to further simplify ParseTypeFromClangModule by replacing the hand-rolled loop with ForEachExternalModule, and then realized that ForEachExternalModul

[Lldb-commits] [lldb] fa6984a - [LLDB] Don't install the pretty stack trace handler twice.

Author: Jonas Devlieghere Date: 2019-11-13T17:35:58-08:00 New Revision: fa6984a3de81b74bf03325bea71416d8bf483efb URL: https://github.com/llvm/llvm-project/commit/fa6984a3de81b74bf03325bea71416d8bf483efb DIFF: https://github.com/llvm/llvm-project/commit/fa6984a3de81b74bf03325bea71416d8bf483efb.d

[Lldb-commits] [PATCH] D70216: [LLDB] Don't install the pretty backtrace handlers twice.

JDevlieghere updated this revision to Diff 229212. JDevlieghere added a comment. Fold `ToolName` into `printHelp` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70216/new/ https://reviews.llvm.org/D70216 Files: lldb/tools/driver/Driver.cpp Index: lldb/tools/driver/Driver.cpp ===

[Lldb-commits] [PATCH] D70216: [LLDB] Don't install the pretty backtrace handlers twice.

JDevlieghere created this revision. JDevlieghere added reviewers: vsk, labath. Herald added a reviewer: jfb. Herald added a project: LLDB. JDevlieghere added a subscriber: friss. Herald added a subscriber: dexonsmith. JDevlieghere updated this revision to Diff 229212. JDevlieghere added a comment.

[Lldb-commits] [PATCH] D70216: [LLDB] Don't install the pretty backtrace handlers twice.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfa6984a3de81: [LLDB] Don't install the pretty stack trace handler twice. (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70216/new/

[Lldb-commits] [PATCH] D70216: [LLDB] Don't install the pretty backtrace handlers twice.

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Looks good to me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70216/new/ https://reviews.llvm.org/D70216 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D68179: [lldb] Fix JSON parser to allow empty arrays

tetsuo-cpp added a comment. Friendly ping. Could I please get this looked at? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68179/new/ https://reviews.llvm.org/D68179 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [PATCH] D68179: [lldb] Fix JSON parser to allow empty arrays

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Thanks for adding the tests. I took a look at the patch and it seems fine to me. Do you need somebody to commit this for you? @jingham or @labath may want to have another look. CHANGES SINCE

[Lldb-commits] [PATCH] D69820: [Symbol] Add TypeSystem::GetClassName

teemperor added a comment. Some minor comments to make this more NFC. Comment at: lldb/source/Core/ValueObject.cpp:2028 + + // TODO: Don't make this specific to C++. + auto type_system_or_err = Can't you just call `GetCompilerType().GetTypeSystem()`? This way

[Lldb-commits] [PATCH] D70216: [LLDB] Don't install the pretty backtrace handlers twice.

labath added a comment. Cool. I saw that we print stack trace twice, but I thought that was because of the whole liblldb+lldb signal double installation. Thanks for fixing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70216/new/ https://revi