[Lldb-commits] [PATCH] D68179: [lldb] Fix JSON parser to allow empty arrays

tetsuo-cpp updated this revision to Diff 228561. Herald added a subscriber: mgorny. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68179/new/ https://reviews.llvm.org/D68179 Files: lldb/tools/debugserver/source/JSON.cpp lldb/tools/debugserver/source/JSON.h lldb/unittests/debugserver

[Lldb-commits] [PATCH] D68179: [lldb] Fix JSON parser to allow empty arrays

tetsuo-cpp added a comment. I've had a try at writing some unit tests for the JSON parser in `debugserver`, including the empty array case which I'm fixing in this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68179/new/ https://reviews.llvm.org/D68179 ___

[Lldb-commits] [PATCH] D70022: [lldb] [Process/NetBSD] Improve threading support

mgorny marked 7 inline comments as done. mgorny added a comment. I've made the changes locally, I'll test and reupload when I finish updating the whole batch. Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:241 case TRAP_BRKPT: -for (const auto &t

[Lldb-commits] [PATCH] D70025: [lldb] [Process/NetBSD] Fix handling concurrent watchpoint events

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86_64.cpp:899 + (dr7_value.GetAsUInt64() & bit_mask) != (rw_bits | size_bits)) { +// for watchpoints 0, 1, 2, or 3, respect

[Lldb-commits] [PATCH] D70023: [lldb] [Process/NetBSD] Copy watchpoints to newly-created threads

mgorny added a comment. In D70023#1739356 , @krytarowski wrote: > How does it deal with `security.models.extensions.user_set_dbregs`? If there > is a handled error than it's fine. I need to test it. Might turn out it's so broken it's better to address i

[Lldb-commits] [PATCH] D70025: [lldb] [Process/NetBSD] Fix handling concurrent watchpoint events

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:334 thread->SetStoppedByTrace(); SetState(StateType::eStateStopped, true); krytarowski wrote: > I presume tha

[Lldb-commits] [PATCH] D70025: [lldb] [Process/NetBSD] Fix handling concurrent watchpoint events

mgorny updated this revision to Diff 228568. mgorny added a comment. Updated as noted in comments, particularly reuse `ClearWatchpointHit()` when setting new wp. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70025/new/ https://reviews.llvm.org/D70025 Files: lldb/source/Plugins/Proce

[Lldb-commits] [PATCH] D70022: [lldb] [Process/NetBSD] Improve threading support

mgorny updated this revision to Diff 228567. mgorny marked 2 inline comments as done. mgorny added a comment. Update wrt comments. Also remove non-working hardware breakpoint boilerplate as noted. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70022/new/ https://reviews.llvm.org/D70022

Re: [Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

On Sat, 09 Nov 2019 03:25:51 +0100, Jason Molenda via lldb-commits wrote: > I'm switching the default for at least the weekend via > 60ab30ebce833c87bd4776f67cd9a82fe162ef9c / > https://reviews.llvm.org/rG60ab30ebce83 so the bots aren't failing because of > this, we can all look into this next w