[Lldb-commits] [lldb] ae10661 - [lldb] Provide a getter for m_materializer_up in LLVMUserExpression instead of relying on it being accessible.

Author: Raphael Isemann Date: 2019-11-04T09:05:24+01:00 New Revision: ae10661a8121558679463a57dd8661c81895f3ff URL: https://github.com/llvm/llvm-project/commit/ae10661a8121558679463a57dd8661c81895f3ff DIFF: https://github.com/llvm/llvm-project/commit/ae10661a8121558679463a57dd8661c81895f3ff.dif

[Lldb-commits] [PATCH] D69714: [lldb] Provide a getter for m_materializer_up in LLVMUserExpression instead of relying on it being accessible.

This revision was automatically updated to reflect the committed changes. Closed by commit rGae10661a8121: [lldb] Provide a getter for m_materializer_up in LLVMUserExpression instead of… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [lldb] df12a75 - [lldb] Also disable de-registration of EHFrames in IRExecutionUnit

Author: Raphael Isemann Date: 2019-11-04T09:23:37+01:00 New Revision: df12a75a19682cfeee12c38ae5113043dddffda8 URL: https://github.com/llvm/llvm-project/commit/df12a75a19682cfeee12c38ae5113043dddffda8 DIFF: https://github.com/llvm/llvm-project/commit/df12a75a19682cfeee12c38ae5113043dddffda8.dif

[Lldb-commits] [lldb] 848007c - [lldb][NFC] Make test/python_api/module_section test smaller

Author: Raphael Isemann Date: 2019-11-04T09:25:01+01:00 New Revision: 848007cfbc7509543c5b8604ae063bb6c8ffa0a9 URL: https://github.com/llvm/llvm-project/commit/848007cfbc7509543c5b8604ae063bb6c8ffa0a9 DIFF: https://github.com/llvm/llvm-project/commit/848007cfbc7509543c5b8604ae063bb6c8ffa0a9.dif

[Lldb-commits] [PATCH] D69713: [lldb] Also disable de-registration of EHFrames in IRExecutionUnit

This revision was automatically updated to reflect the committed changes. Closed by commit rGdf12a75a1968: [lldb] Also disable de-registration of EHFrames in IRExecutionUnit (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69713

[Lldb-commits] [PATCH] D69705: [lldb][NFC] Make test/python_api/module_section test smaller

This revision was automatically updated to reflect the committed changes. Closed by commit rG848007cfbc75: [lldb][NFC] Make test/python_api/module_section test smaller (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69705/new/

[Lldb-commits] [lldb] 25b486a - [lldb][NFC] Remove unused ExpressionParser::Parse

Author: Raphael Isemann Date: 2019-11-04T11:12:27+01:00 New Revision: 25b486ac4f335fc51240888d6cfbc9c3c211536a URL: https://github.com/llvm/llvm-project/commit/25b486ac4f335fc51240888d6cfbc9c3c211536a DIFF: https://github.com/llvm/llvm-project/commit/25b486ac4f335fc51240888d6cfbc9c3c211536a.dif

[Lldb-commits] [PATCH] D69710: [lldb][NFC] Remove unused ExpressionParser::Parse

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG25b486ac4f33: [lldb][NFC] Remove unused ExpressionParser::Parse (authored by teemperor). Repository: rG LLVM Github Mon

[Lldb-commits] [lldb] bc728d5 - [lldb][NFC] Remove Ocaml from TypeSystem::LLVMCastKind

Author: Raphael Isemann Date: 2019-11-04T11:14:29+01:00 New Revision: bc728d584242946ba59d6bea0cf8c749dcf07248 URL: https://github.com/llvm/llvm-project/commit/bc728d584242946ba59d6bea0cf8c749dcf07248 DIFF: https://github.com/llvm/llvm-project/commit/bc728d584242946ba59d6bea0cf8c749dcf07248.dif

[Lldb-commits] [PATCH] D69793: Bundle libedit-compatible readline replacement

serge-sans-paille created this revision. serge-sans-paille added reviewers: labath, JDevlieghere. serge-sans-paille added a project: LLDB. Herald added subscribers: lldb-commits, mgorny. Fix https://bugs.llvm.org/show_bug.cgi?id=43830 while avoiding polluting the global Python namespace. This bo

[Lldb-commits] [PATCH] D69793: Bundle libedit-compatible readline replacement

mgorny added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonReadline.cpp:8 + +#ifndef LLDB_DISABLE_LIBEDIT +#include If libedit is disabled, shouldn't you disable building the whole module altogether? I suppose then the standard

[Lldb-commits] [PATCH] D69793: Bundle libedit-compatible readline replacement

serge-sans-paille updated this revision to Diff 227695. serge-sans-paille edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69793/new/ https://reviews.llvm.org/D69793 Files: lldb/source/Plugins/ScriptInterpreter/Py

[Lldb-commits] [PATCH] D69704: [lldb] Add IsTypeSystemCompatible method to SBModule to allow checking compatibility between language versions

labath added a comment. The part that bothers me here is that this assumes that the entirety of a module (or an least the portion of it written in the same language) uses the same version of the language. Is that true for swift? Because it definitely isn't true for c++, as you can easily mix co

[Lldb-commits] [PATCH] D69793: Bundle libedit-compatible readline replacement

labath added a comment. Thanks for doing this. I really like how you've implemented this. Just some small stylistic comments inline. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonReadline.cpp:1 +#ifdef LLDB_DISABLE_LIBEDIT + Should this also b

[Lldb-commits] [PATCH] D69503: [LLDB] [Windows] Don't crash if the debugged process is unable to start up

amccarth added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69503/new/ https://reviews.llvm.org/D69503 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.o

[Lldb-commits] [PATCH] D69273: ValueObject: Fix a crash related to children address type computation

jingham added a comment. In Swift you have to ask the runtime for most of the layout details of objects so getting a const result object, stepping, then asking it to reevaluate itself would lead to passing the runtime incorrect data and potentially undoing a correct type decision that you had m

[Lldb-commits] [PATCH] D69793: Bundle libedit-compatible readline replacement

JDevlieghere added a comment. +1 on everything Pavel said :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69793/new/ https://reviews.llvm.org/D69793 ___ lldb-commits mailing list lldb-commits@lists.l

[Lldb-commits] [PATCH] D69667: [lldb] [Process/NetBSD] Add register info for missing register sets

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This seems reasonable to me. I take it there is already some logic which will make the MPX registers not show up when the machine does not support them (i.e., never on netbsd)? CHANGES SINCE

[Lldb-commits] [PATCH] D69742: [LLDB][Python] remove ArgInfo::count

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. At this point, should we just delete the ArgInfo struct altogether, and replace it with a plain `unsigned`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D69742: [LLDB][Python] remove ArgInfo::count

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM modulo inline comment. Comment at: lldb/unittests/ScriptInterpreter/Python/PythonDataObjectsTests.cpp:764 } #if PY_MAJOR_VERSION >= 3 && PY_MINOR_VERSION >= 3 Should we check `has_va

[Lldb-commits] [PATCH] D69273: ValueObject: Fix a crash related to children address type computation

labath added a comment. In D69273#1732582 , @jingham wrote: > In Swift you have to ask the runtime for most of the layout details of > objects so getting a const result object, stepping, then asking it to > reevaluate itself would lead to passing the run

[Lldb-commits] [PATCH] D65363: [lldb-vscode] add `launchCommands` to handle launch specific commands

wallace added inline comments. Comment at: lldb/trunk/tools/lldb-vscode/lldb-vscode.cpp:1280 // Reenable async events and start the event thread to catch async events. - g_vsc.debugger.SetAsync(true); + // g_vsc.debugger.SetAsync(true); } was this intention

[Lldb-commits] [PATCH] D69667: [lldb] [Process/NetBSD] Add register info for missing register sets

mgorny added a comment. In D69667#1732595 , @labath wrote: > I take it there is already some logic which will make the MPX registers not > show up when the machine does not support them (i.e., never on netbsd)? To be honest, I don't think so. I know tha

[Lldb-commits] [PATCH] D69667: [lldb] [Process/NetBSD] Add register info for missing register sets

This revision was automatically updated to reflect the committed changes. Closed by commit rG6eca4f46912a: [lldb] [Process/NetBSD] Add register info for missing register sets (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[Lldb-commits] [PATCH] D69742: [LLDB][Python] remove ArgInfo::count

lawrence_danna marked 2 inline comments as done. lawrence_danna added inline comments. Comment at: lldb/unittests/ScriptInterpreter/Python/PythonDataObjectsTests.cpp:764 } #if PY_MAJOR_VERSION >= 3 && PY_MINOR_VERSION >= 3 JDevlieghere wrote: > Should we c

[Lldb-commits] [PATCH] D69742: [LLDB][Python] remove ArgInfo::count

JDevlieghere added inline comments. Comment at: lldb/unittests/ScriptInterpreter/Python/PythonDataObjectsTests.cpp:764 } #if PY_MAJOR_VERSION >= 3 && PY_MINOR_VERSION >= 3 lawrence_danna wrote: > JDevlieghere wrote: > > Should we check `has_varargs` here a

[Lldb-commits] [PATCH] D65363: [lldb-vscode] add `launchCommands` to handle launch specific commands

kusmour marked an inline comment as done. kusmour added inline comments. Comment at: lldb/trunk/tools/lldb-vscode/lldb-vscode.cpp:1280 // Reenable async events and start the event thread to catch async events. - g_vsc.debugger.SetAsync(true); + // g_vsc.debugger.SetAsync(tru

[Lldb-commits] [lldb] adbf64c - [LLDB][Python] remove ArgInfo::count

Author: Lawrence D'Anna Date: 2019-11-04T12:48:49-08:00 New Revision: adbf64ccc9e18278600ebaeadd8f0117eb8e64b1 URL: https://github.com/llvm/llvm-project/commit/adbf64ccc9e18278600ebaeadd8f0117eb8e64b1 DIFF: https://github.com/llvm/llvm-project/commit/adbf64ccc9e18278600ebaeadd8f0117eb8e64b1.dif

[Lldb-commits] [PATCH] D69742: [LLDB][Python] remove ArgInfo::count

lawrence_danna marked 2 inline comments as done. lawrence_danna added a comment. In D69742#1732608 , @labath wrote: > At this point, should we just delete the ArgInfo struct altogether, and > replace it with a plain `unsigned`? Sounds like a good idea t

[Lldb-commits] [PATCH] D69742: [LLDB][Python] remove ArgInfo::count

This revision was automatically updated to reflect the committed changes. Closed by commit rGadbf64ccc9e1: [LLDB][Python] remove ArgInfo::count (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69742/new/ https://reviews.ll

[Lldb-commits] [PATCH] D69820: [Symbol] Add TypeSystem::GetClassName

xiaobai created this revision. xiaobai added reviewers: JDevlieghere, labath, compnerd, teemperor. Herald added a project: LLDB. This will generalize some behavior in ValueObject. Although this code path is still specific to C++, it no longer references ClangASTContext directly. This will allow us

[Lldb-commits] [PATCH] D69820: [Symbol] Add TypeSystem::GetClassName

shafik added a comment. As far as I can tell we don't have coverage for `GetBaseClassPath` it would be good to add it while we are refactoring this code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69820/new/ https://reviews.llvm.org/D69820 _

[Lldb-commits] [PATCH] D69738: Fix handling for the clang name mangling extension for block invocations

shafik updated this revision to Diff 227786. shafik marked 12 inline comments as done. shafik added a comment. Updating based on comments - Adding documentation - using startswith(...) - Updating initialization to use = instead of {} CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69738/n

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

hhb added a comment. In D69589#1731782 , @aadsm wrote: > I fixed this locally by doing this (this fix doesn't really feel good but not > sure what's the best way to do it): I found it confusing too. So finish_swig should depends on liblldb, because at

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

hhb added a comment. Alternatively we should not depends on install-liblldb to install python packages, but have a install command similar to what we did below for other platforms. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69589/new/ https://

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

hhb added a comment. See D68370 . We probably need to do the same thing for darwin... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69589/new/ https://reviews.llvm.org/D69589

[Lldb-commits] [PATCH] D69834: [lldb] Add a install target for lldb python on darwin

hhb created this revision. hhb added a reviewer: aadsm. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Similar to D68370 but for darwin framework build. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69834 Files

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

hhb added a comment. Sent D69834 . Haven't get a chance to test but you can see the idea... Also please add lldb-python-scripts to your LLVM_DISTRIBUTION_COMPONENTS when testing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [lldb] 610f80f - [cmake] Add an option to skip stripping before install

Author: Vedant Kumar Date: 2019-11-04T17:38:13-08:00 New Revision: 610f80f7baea5e46c0ccd4cbb905a679c7c56a05 URL: https://github.com/llvm/llvm-project/commit/610f80f7baea5e46c0ccd4cbb905a679c7c56a05 DIFF: https://github.com/llvm/llvm-project/commit/610f80f7baea5e46c0ccd4cbb905a679c7c56a05.diff

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

aadsm accepted this revision. aadsm added a comment. This revision is now accepted and ready to land. This is great! it's so much better. Thank so much for looking into this and fixing it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69589/new/ h

[Lldb-commits] [PATCH] D69793: Bundle libedit-compatible readline replacement

serge-sans-paille marked 2 inline comments as done. serge-sans-paille added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonReadline.h:13-15 +#ifndef LLDB_DISABLE_LIBEDIT +extern "C" PyMODINIT_FUNC initlldb_readline(void); +#endif

[Lldb-commits] [PATCH] D69793: Bundle libedit-compatible readline replacement

serge-sans-paille updated this revision to Diff 227821. serge-sans-paille marked 4 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69793/new/ https://reviews.llvm.org/D69793 Files: lldb/source/Plugins/ScriptInterpreter/Pytho

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

aadsm added a comment. @hhb fwiw, I still get the same error with this diff (after applying it on top of D69834 ). But D69834 by itself works great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [PATCH] D69793: Bundle libedit-compatible readline replacement

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. LGTM. Thanks for doing this. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonReadline.cpp:17 +// implementing any of the readline module methods. This is meant