[Lldb-commits] [PATCH] D69425: [lldb] Fix broken -D option for breakpoint set command

poya updated this revision to Diff 227406. poya added a comment. Added a test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69425/new/ https://reviews.llvm.org/D69425 Files: lldb/source/Commands/CommandObjectBreakpoint.cpp lldb/test/Shell/Breakpoint/Inputs/dummy-target.c lldb/tes

[Lldb-commits] [PATCH] D67227: [lldb] Extend and document TestIRInterpreter.py

jankratochvil requested changes to this revision. jankratochvil added a comment. This revision now requires changes to proceed. On Fedora 31 x86_64 (that is with `python3-3.7.4-5.fc31.x86_64`) I get: FAIL: LLDB (/quad/home/jkratoch/redhat/llvm-monorepo-clangassertpython3/bin/clang-10-x86_64)

[Lldb-commits] [PATCH] D69704: Add IsTypeSystemCompatible method to SBModule to allow checking compatibility between language versions

teemperor created this revision. teemperor added a reviewer: davide. teemperor added a project: Upstreaming LLDB's downstream patches. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. In Swift there is a check if the compiled module actually fits to our Swift ve

[Lldb-commits] [PATCH] D69705: [lldb][NFC] Make test/python_api/module_section test smaller

teemperor created this revision. teemperor added reviewers: labath, davide, JDevlieghere. Herald added subscribers: lldb-commits, jfb. Herald added a project: LLDB. I don't see why this test needs to compile this rather complicated file for just testing module sections. This just removes all this

[Lldb-commits] [PATCH] D69710: [lldb][NFC] Remove unused ExpressionParser::Parse

teemperor created this revision. teemperor added a reviewer: davide. teemperor added a project: Upstreaming LLDB's downstream patches. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. This function is only used internally by ClangExpressionParser. By putting it

[Lldb-commits] [PATCH] D69710: [lldb][NFC] Remove unused ExpressionParser::Parse

teemperor updated this revision to Diff 227438. teemperor added a comment. - Uploaded full diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69710/new/ https://reviews.llvm.org/D69710 Files: lldb/include/lldb/Expression/ExpressionParser.h lldb/source/Plugins/ExpressionParser/Clan

[Lldb-commits] [PATCH] D69713: [lldb] Also disable de-registration of EHFrames in IRExecutionUnit

teemperor created this revision. teemperor added a reviewer: davide. teemperor added a project: Upstreaming LLDB's downstream patches. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. We disabled registration by providing an empty `registerEHFrames`, so we should

[Lldb-commits] [PATCH] D69714: [lldb] Provide a getter for m_materializer_up in LLVMUserExpression instead of relying on it being accessible.

teemperor created this revision. teemperor added a reviewer: davide. teemperor added a project: Upstreaming LLDB's downstream patches. Herald added subscribers: lldb-commits, JDevlieghere, abidh. Herald added a project: LLDB. Motivated by Swift using the materializer in a few places which requires

[Lldb-commits] [PATCH] D67227: [lldb] Extend and document TestIRInterpreter.py

tatyana-krasnukha added a comment. Another problem of the `test_ir_interpreter` is that it fails even when JIT fails despite it should test the interpreter. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67227/new/ https://reviews.llvm.org/D67227 _

[Lldb-commits] [PATCH] D67227: [lldb] Extend and document TestIRInterpreter.py

teemperor added a comment. In D67227#1730144 , @tatyana-krasnukha wrote: > Another problem of the `test_ir_interpreter` is that it fails even when JIT > fails despite it should test the interpreter. Well, it also tests that the IRInterpreter is equival

[Lldb-commits] [PATCH] D69717: [lldb] Add trailing dots to comments in Value.cpp

teemperor created this revision. teemperor added a project: Upstreaming LLDB's downstream patches. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D69717 Files: lldb/source/Core/Value.cpp Index: lldb/source

[Lldb-commits] [PATCH] D67227: [lldb] Extend and document TestIRInterpreter.py

tatyana-krasnukha added a comment. I mean, when a process is not able to allocate memory, it cannot JIT, but still can interpret. Should the test report failure in this case? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67227/new/ https://reviews.llvm.org/D67227 ___

[Lldb-commits] [PATCH] D69425: [lldb] Fix broken -D option for breakpoint set command

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69425/new/ https://reviews.llvm.org/D69425 ___ lldb-commits mailing list l

[Lldb-commits] [PATCH] D69714: [lldb] Provide a getter for m_materializer_up in LLVMUserExpression instead of relying on it being accessible.

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69714/new/ https://reviews.llvm.org/D69714 ___ lldb-commit

[Lldb-commits] [PATCH] D69738: Fix handling for the clang name mangling extension for block invocations

shafik created this revision. shafik added reviewers: aprantl, jingham. clang has a mangling extension for block invocations and currently lldb does not handle it correctly. https://reviews.llvm.org

[Lldb-commits] [PATCH] D69738: Fix handling for the clang name mangling extension for block invocations

jingham added inline comments. Comment at: lldb/source/Core/Mangled.cpp:99 + + if (s.size() >= 2 && (s[0] == '_' && s[1] == 'Z')) +return Mangled::eManglingSchemeItanium; StringRef has a startswith. That might be easier to read. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D69738: Fix handling for the clang name mangling extension for block invocations

aprantl added inline comments. Comment at: lldb/include/lldb/Core/Mangled.h:264 + static Mangled::ManglingScheme GetManglingScheme(llvm::StringRef s); + Doxygen comment? Comment at: lldb/source/Core/Mangled.cpp:99 + + if (s.size() >= 2 && (

[Lldb-commits] [PATCH] D69667: [lldb] [Process/NetBSD] Add register info for missing register sets

mgorny updated this revision to Diff 227545. mgorny added a comment. Include reenabling fixed test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69667/new/ https://reviews.llvm.org/D69667 Files: lldb/packages/Python/lldbsuite/test/commands/register/register/register_command/TestReg

[Lldb-commits] [lldb] 81cc5d1 - Don't assume that __cxa_current_exception_type exists.

Author: Jim Ingham Date: 2019-11-01T17:20:31-07:00 New Revision: 81cc5d1c7d3f7292e82e8611fcd4a2889278a218 URL: https://github.com/llvm/llvm-project/commit/81cc5d1c7d3f7292e82e8611fcd4a2889278a218 DIFF: https://github.com/llvm/llvm-project/commit/81cc5d1c7d3f7292e82e8611fcd4a2889278a218.diff LO

[Lldb-commits] [PATCH] D69742: [LLDB][Python] remove ArgInfo::count

lawrence_danna created this revision. lawrence_danna added reviewers: labath, mgorny, JDevlieghere. Herald added a project: LLDB. This patch updates the last user of ArgInfo::count and deletes it. I also delete `GetNumInitArguments()` and `GetInitArgInfo()`. Classess are callables and `GetArgI