[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

tatyana-krasnukha added inline comments. Comment at: lldb/CMakeLists.txt:228 +function(create_relative_symlink target dest_file output_dir output_name) + get_filename_component(dest_file ${dest_file} ABSOLUTE) + get_filename_component(output_dir ${output_dir} ABSOLU

[Lldb-commits] [PATCH] D68657: Update MinidumpYAML to use minidump::Exception for exception stream

grimar added inline comments. Comment at: llvm/include/llvm/ObjectYAML/MinidumpYAML.h:113-114 + ExceptionStream() + : Stream(StreamKind::Exception, minidump::StreamType::Exception) { +memset(&MDExceptionStream, 0, sizeof(minidump::ExceptionStream)); + } ---

[Lldb-commits] [PATCH] D68908: remove somewhat dangerous 'd'(etach) and 'k'(ill) shortcuts

llunak created this revision. llunak added a reviewer: clayborg. llunak added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere. 'd' would be much better used for up/down shortcuts, and this also removes the possibility of ruining the whole debugging session by accidentally

[Lldb-commits] [PATCH] D68909: change shortcut for 'step out' from 'o' to 'f'

llunak created this revision. llunak added a reviewer: clayborg. llunak added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere. This makes it consistent with gdb tui, where 'f' is 'finish'. See the discussion at https://reviews.llvm.org/D68541 . Repository: rLLDB LLDB htt

[Lldb-commits] [PATCH] D68910: use LLVM_LIBDIR_SUFFIX for python lib path

llunak created this revision. llunak added reviewers: clayborg, labath. llunak added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere, mgorny. On 64bit linux python is in lib64/python. Repository: rLLDB LLDB https://reviews.llvm.org/D68910 Files: lldb/scripts/CMakeList

[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui

llunak updated this revision to Diff 224737. llunak edited the summary of this revision. llunak added a comment. Added a unittest. Also, the other discussed changes are at https://reviews.llvm.org/D68908 and https://reviews.llvm.org/D68909 . CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D68910: use LLVM_LIBDIR_SUFFIX for python lib path

mgorny requested changes to this revision. mgorny added a comment. This revision now requires changes to proceed. No, it isn't. Some distros patch some Python versions for that but it's not a rule. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68910/new/ https

[Lldb-commits] [PATCH] D68910: use LLVM_LIBDIR_SUFFIX for python lib path

llunak updated this revision to Diff 224739. llunak edited the summary of this revision. llunak added a comment. Updated misleading description. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68910/new/ https://reviews.llvm.org/D68910 Files: lldb/scripts/CMak

[Lldb-commits] [PATCH] D67954: [LLDB] [Windows] Initial support for ARM64 register contexts

mstorsjo updated this revision to Diff 224757. mstorsjo retitled this revision from "[LLDB] [Windows] Initial support for ARM64 debugging" to "[LLDB] [Windows] Initial support for ARM64 register contexts". mstorsjo edited the summary of this revision. mstorsjo added a reviewer: aleksandr.urakov.

[Lldb-commits] [PATCH] D68918: eliminate virtual methods from PythonDataObjects

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath, zturner. Herald added a project: LLDB. This patch eliminates a bunch of boilerplate from PythonDataObjects, as well as the use of virtual methods. In my opinion it also makes the Reset logic