[Lldb-commits] [PATCH] D68096: ProcessMinidump: Suppress reporting stop for signal '0'

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. We need to grab the address from the exception info and pass that along for linux. Comment at: lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp:264 +

[Lldb-commits] [PATCH] D68671: Add the ability to pass extra args to a Python breakpoint command function

clayborg added a comment. Looks good overall. A few questions: - should we do a global "s/extra_args/args/" edit in this patch? Not sure what "extra_" is adding? Can we remove? - Can the structured data not be a dictionary? Valid StructuredData could be "malloc" or "[0x1000, 0x2000]" or "true",

[Lldb-commits] [PATCH] D68657: Update MinidumpYAML to use minidump::Exception for exception stream

JosephTremoulet updated this revision to Diff 224469. JosephTremoulet added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. - Update test input yaml Exception stream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D686

[Lldb-commits] [PATCH] D68096: ProcessMinidump: Suppress reporting stop for signal '0'

clayborg added a comment. We should add a test that has no exception info and verify we get a stopped process if we don't already have a test like this. LLDB doesn't like it when there is no stop reason and might try to resume the process and might not print out the stop and backtrace? Reposi

[Lldb-commits] [lldb] r374451 - TestMTCSimple: Make Makefile portable.

Author: friss Date: Thu Oct 10 14:21:16 2019 New Revision: 374451 URL: http://llvm.org/viewvc/llvm-project?rev=374451&view=rev Log: TestMTCSimple: Make Makefile portable. r374262 left out the Makefile changes needed to cross compile this test. Modified: lldb/trunk/packages/Python/lldbsuite/

[Lldb-commits] [PATCH] D67994: Modify lldb-test to print out ASTs from symbol file

shafik updated this revision to Diff 224479. shafik marked 2 inline comments as done. shafik added a comment. - Simplified DumpFromSymbolFile() based on comments - Reused -name option in lldb-test and to replace -symbol-name CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67994/new/ https

[Lldb-commits] [PATCH] D67994: Modify lldb-test to print out ASTs from symbol file

shafik added inline comments. Comment at: source/Symbol/ClangASTContext.cpp:9195 + GetAsEnumDecl(type->GetFullCompilerType())) + enum_decl->dump(s.AsRawOstream()); +else { teemperor wrote: > shafik wrote: > > aprantl wrote: > > > is an En

[Lldb-commits] [PATCH] D68719: Fix issue when building with Visual Studio

hhb added inline comments. Comment at: finishSwigPythonLLDB.py:380 -strSrc = os.path.normcase(os.path.join(strPrefix, vstrSrcFile)) -strRelSrc = os.path.relpath(strSrc, os.path.dirname(strTarget)) hhb wrote: > tatyana-krasnukha wrote: > > This command p

[Lldb-commits] [lldb] r374461 - [test] Reduce inconsistency between lit configuration files.

Author: jdevlieghere Date: Thu Oct 10 14:49:22 2019 New Revision: 374461 URL: http://llvm.org/viewvc/llvm-project?rev=374461&view=rev Log: [test] Reduce inconsistency between lit configuration files. Add the Python extension to the configuration files in the API directory to match the other test

[Lldb-commits] [lldb] r374462 - [Make] Remove spurious line break

Author: jdevlieghere Date: Thu Oct 10 14:49:25 2019 New Revision: 374462 URL: http://llvm.org/viewvc/llvm-project?rev=374462&view=rev Log: [Make] Remove spurious line break This test is disabled upstream and therefore this went unnoticed. Modified: lldb/trunk/packages/Python/lldbsuite/test/m

[Lldb-commits] [PATCH] D68655: Trust the arange accelerator tables in dSYMs

aprantl added a comment. I wouldn't call it a bug, but if we changed dsymutil to always rewrite DW_AT_low_pc into DW_AT_ranges, we could trust the .debug_ranges section to be complete. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68655/new/ http

[Lldb-commits] [PATCH] D68737: SBFile::GetFile: convert SBFile back into python native files.

lawrence_danna marked an inline comment as done. lawrence_danna added inline comments. Comment at: lldb/include/lldb/Host/File.h:56 static bool DescriptorIsValid(int descriptor) { return descriptor >= 0; }; + static const char *GetStreamOpenModeFromOptions(uint32_t options);

[Lldb-commits] [lldb] r374468 - [lldb-test] Remove unused header

Author: xiaobai Date: Thu Oct 10 15:43:03 2019 New Revision: 374468 URL: http://llvm.org/viewvc/llvm-project?rev=374468&view=rev Log: [lldb-test] Remove unused header Modified: lldb/trunk/tools/lldb-test/lldb-test.cpp Modified: lldb/trunk/tools/lldb-test/lldb-test.cpp URL: http://llvm.org/v

[Lldb-commits] [PATCH] D68842: Clean up format in cmake file

hhb created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Makes the indent consistent to other part of the file. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68842 Files: lldb/CMakeLists.txt Index: lldb/CMakeLists.txt ===

[Lldb-commits] [lldb] r374483 - Clean up format in cmake file

Author: hhb Date: Thu Oct 10 17:12:20 2019 New Revision: 374483 URL: http://llvm.org/viewvc/llvm-project?rev=374483&view=rev Log: Clean up format in cmake file Summary: Makes the indent consistent to other part of the file. Subscribers: mgorny, lldb-commits Tags: #lldb Differential Revision: h

[Lldb-commits] [PATCH] D68842: Clean up format in cmake file

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG7b9900dff3c0: Clean up format in cmake file (authored by hhb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D68671: Add the ability to pass extra args to a Python breakpoint command function

jingham added a comment. In D68671#1704803 , @clayborg wrote: > Looks good overall. A few questions: > > - should we do a global "s/extra_args/args/" edit in this patch? Not sure > what "extra_" is adding? Can we remove? Since we still support the form

[Lldb-commits] [PATCH] D68737: SBFile::GetFile: convert SBFile back into python native files.

lawrence_danna updated this revision to Diff 224527. lawrence_danna marked 7 inline comments as done. lawrence_danna added a comment. review fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68737/new/ https://reviews.llvm.org/D68737 Files: ll

[Lldb-commits] [PATCH] D68853: uint32_t options -> File::OpenOptions options

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. This patch re-types everywhere that passes a File::OpenOptions as a uint32_t so it actually uses File::OpenOptions. It also converts some OpenOptions related fun

[Lldb-commits] [PATCH] D68737: SBFile::GetFile: convert SBFile back into python native files.

lawrence_danna added a comment. I split off the OpenOptions enum stuff into a separate patch, because changing it from uint32_t to the enum is kind of viral Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:674-682 + PythonFile(File &file, const ch

[Lldb-commits] [PATCH] D68856: convert SBDebugger::***FileHandle() wrappers to native files.

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added subscribers: dexonsmith, mehdi_amini. Herald added a project: LLDB. This patch converts the swig wrappers for SetInputFileHandle() and friends to emulate the old behavior using Se

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Thanks for all of the work on this patch Aleksandr, I really appreciate the work and this will be a nice addition to lldb. Apologies again for not looking over the revised patch e

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

aleksandr.urakov added a comment. Thanks a lot for the review! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67347/new/ https://reviews.llvm.org/D67347 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb updated this revision to Diff 224545. hhb added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68858/new/ https://reviews.llvm.org/D68858 Files: lldb/CMakeLists.txt lldb/scripts/Python/finishSwigPythonLLDB.py Index: lldb/

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb updated this revision to Diff 224544. hhb added a comment. Fix format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68858/new/ https://reviews.llvm.org/D68858 Files: lldb/CMakeLists.txt lldb/scripts/Python/finishSwigPythonLLDB.py Index: l

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb created this revision. hhb added a project: LLDB. hhb updated this revision to Diff 224544. hhb added a comment. hhb updated this revision to Diff 224545. Fix format hhb added a comment. Rebase This is another attempt of D67993 . This change removed hard

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb updated this revision to Diff 224546. hhb added a comment. Remove tailing whitespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68858/new/ https://reviews.llvm.org/D68858 Files: lldb/CMakeLists.txt lldb/scripts/Python/finishSwigPythonLL

<    1   2