[Lldb-commits] [PATCH] D68737: SBFile::GetFile: convert SBFile back into python native files.

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. This makes SBFile::GetFile public and adds a SWIG typemap to convert the result back into a python native file. If the underlying File itself came from a python

[Lldb-commits] [PATCH] D68106: Fix a crasher due to an assert when two files have the same UUID but different paths.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0156be59b45d: Fix a crasher due to an assert when two files have the same UUID but different… (authored by clayborg). Changed prior to commit: https://reviews.llvm.org/D68106?vs=222032&id=224185#toc Re

[Lldb-commits] [lldb] r374244 - [CMake] Use the correct lit.cfg.py

Author: jdevlieghere Date: Wed Oct 9 15:09:57 2019 New Revision: 374244 URL: http://llvm.org/viewvc/llvm-project?rev=374244&view=rev Log: [CMake] Use the correct lit.cfg.py Modified: lldb/trunk/test/CMakeLists.txt Modified: lldb/trunk/test/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-pr

[Lldb-commits] [lldb] r374246 - Set eRegisterKindEHFrame register numbers for 32 bit ARM register contexts in minidumps

Author: gclayton Date: Wed Oct 9 15:16:12 2019 New Revision: 374246 URL: http://llvm.org/viewvc/llvm-project?rev=374246&view=rev Log: Set eRegisterKindEHFrame register numbers for 32 bit ARM register contexts in minidumps Stack unwinding was sometimes failing when trying to unwind stacks in 32

[Lldb-commits] [PATCH] D68734: update SBDebugger::SetInputFile() etc to work on native Files

lawrence_danna marked an inline comment as done. lawrence_danna added inline comments. Comment at: lldb/include/lldb/API/SBDebugger.h:97-102 + SBError SetInputFile(FileSP file); + + SBError SetOutputFile(FileSP file); + + SBError SetErrorFile(FileSP file); + c

[Lldb-commits] [PATCH] D68734: update SBDebugger::SetInputFile() etc to work on native Files

lawrence_danna marked an inline comment as done. lawrence_danna added inline comments. Comment at: lldb/include/lldb/API/SBDebugger.h:97-102 + SBError SetInputFile(FileSP file); + + SBError SetOutputFile(FileSP file); + + SBError SetErrorFile(FileSP file); + l

[Lldb-commits] [PATCH] D68088: Set eRegisterKindEHFrame register numbers for 32 bit ARM register contexts in minidumps

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc9276b7d723: Set eRegisterKindEHFrame register numbers for 32 bit ARM register contexts in… (authored by clayborg). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

Re: [Lldb-commits] [PATCH] D68606: [test] Split LLDB tests into filecheck, unittest and dotest.

On Wed, 09 Oct 2019 21:21:44 +0200, Jonas Devlieghere wrote: > I finally managed to reproduce and check-lldb was indeed broken. I've > fixed it when re-landing the patch in r374201. Yes, it does check-lldb now (47363a148f1d3003f0dd1cce234b60cdc8cc48bd). Thanks, Jan -

[Lldb-commits] [lldb] r374250 - [lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR

Author: hhb Date: Wed Oct 9 15:34:55 2019 New Revision: 374250 URL: http://llvm.org/viewvc/llvm-project?rev=374250&view=rev Log: [lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR Summary: Fixes issue like D68719 Reviewers: tatyana-krasnukha Subscribers: mgorny, lldb-commits Tags: #l

[Lldb-commits] [lldb] r374251 - Makefile.rules: add missing CODESIGN call

Author: friss Date: Wed Oct 9 15:35:56 2019 New Revision: 374251 URL: http://llvm.org/viewvc/llvm-project?rev=374251&view=rev Log: Makefile.rules: add missing CODESIGN call When building an executable and a shared library at the same time (yes, Makefile.rules is setup to do this!) the executable

[Lldb-commits] [PATCH] D68728: [lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG1a509417714d: [lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR (authored by hhb). Repository: rG LLVM Github

[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

aprantl updated this revision to Diff 224193. aprantl added a comment. Address feedback from Jonas. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68678/new/ https://reviews.llvm.org/D68678 Files: lldb/packages/Python/lldbsuite/test/lang/cpp/accelerator-table/Makefile lldb/packages

[Lldb-commits] [lldb] r374256 - TestIndirectSymbols: Modernize the Makefile

Author: friss Date: Wed Oct 9 15:47:28 2019 New Revision: 374256 URL: http://llvm.org/viewvc/llvm-project?rev=374256&view=rev Log: TestIndirectSymbols: Modernize the Makefile This old test used a completely hand-rolled Makefile. Modernize so that it's able to cross-compile. And XFAIL the test as

[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

aprantl added a comment. In D68678#1702418 , @clayborg wrote: > That qualified name hash the Apple tables used to avoid pulling in DWARF for > stuff that didn't match. Did this functionality stop working when accelerator > tables got refactored? The .app

[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

aprantl added a comment. (and my patch is meant primarily for the non-dsym case) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68678/new/ https://reviews.llvm.org/D68678 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://list

[Lldb-commits] [PATCH] D68734: update SBDebugger::SetInputFile() etc to work on native Files

lawrence_danna marked an inline comment as done. lawrence_danna added inline comments. Comment at: lldb/include/lldb/API/SBDebugger.h:97-102 + SBError SetInputFile(FileSP file); + + SBError SetOutputFile(FileSP file); + + SBError SetErrorFile(FileSP file); + l

[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

aprantl updated this revision to Diff 224197. aprantl added a comment. Added a `if (!has_qualified_name_hash)`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68678/new/ https://reviews.llvm.org/D68678 Files: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp Index: lldb/sourc

[Lldb-commits] [PATCH] D68745: TestFileHandle.py: fix for Python 3.6

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. Python 3.6 stringifies exceptions as `ExceptionClass("foo",)` instead of `ExceptionClass("foo")`. This patch makes the test assertions a little more flexible so

[Lldb-commits] [lldb] r374262 - TestMTCSimple.py: allow the test to run on Darwin embedded platforms

Author: friss Date: Wed Oct 9 16:52:31 2019 New Revision: 374262 URL: http://llvm.org/viewvc/llvm-project?rev=374262&view=rev Log: TestMTCSimple.py: allow the test to run on Darwin embedded platforms The test needed some updates to run using a different UI toolkit and with a different libMTC, bu

[Lldb-commits] [lldb] r374264 - Change debugserver to use the brk #0 for breakpoints.

Author: jmolenda Date: Wed Oct 9 17:12:05 2019 New Revision: 374264 URL: http://llvm.org/viewvc/llvm-project?rev=374264&view=rev Log: Change debugserver to use the brk #0 for breakpoints. debugserver had been using an instruction that would work for armv7 or aarch64 processes, but we don't h

[Lldb-commits] [PATCH] D68750: Implement serialization and deserialization of scripted points

jingham created this revision. jingham added a reviewer: teemperor. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. This allows you to use "break read" and "break write" for scripted breakpoints. This is the test Raphael was offering to have Jan write in, plus

[Lldb-commits] [PATCH] D68755: [test] Use a different module cache for Shell and API tests.

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:316 -# Use a shared module cache when building in the default test build directory. -CLANG_MODULE_CACHE_DIR := $(shell echo "$(

[Lldb-commits] [PATCH] D68755: [test] Use a different module cache for Shell and API tests.

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, labath. Herald added subscribers: teemperor, mgorny. Herald added a project: LLDB. JDevlieghere added a reviewer: friss. JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. C

[Lldb-commits] [PATCH] D68762: [LLDB] Fix when building with strict LLVM assertion checking on FreeBSD

devnexen created this revision. devnexen added reviewers: dim, jbeich. devnexen created this object with visibility "All Users". Herald added subscribers: lldb-commits, JDevlieghere, emaste. Herald added a project: LLDB. devnexen added a comment. With this I do not get segfault anymore. @dim I jus

[Lldb-commits] [PATCH] D68762: [LLDB] Fix when building with strict LLVM assertion checking on FreeBSD

devnexen added a comment. With this I do not get segfault anymore. @dim I just looked up the patch on FreeBSD, if this approach is preferred, I ll go along. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68762/new/ https://reviews.llvm.org/D68762 ___

[Lldb-commits] [PATCH] D68723: Fix process launch failure on FreeBSD after r365761

MaskRay added a comment. This was probably due to: Expected(Error Err) : HasError(true) #if LLVM_ENABLE_ABI_BREAKING_CHECKS // Expected is unchecked upon construction in Debug builds. , Unchecked(true) #endif { assert(Err && "Cannot create Expected fr

[Lldb-commits] [PATCH] D68762: [LLDB] Fix when building with strict LLVM assertion checking on FreeBSD

devnexen updated this revision to Diff 224256. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68762/new/ https://reviews.llvm.org/D68762 Files: lldb/source/Plugins/Process/FreeBSD/ProcessMonitor.cpp Index: lldb/source/Plugins/Process/FreeBSD/ProcessMonitor.cpp

[Lldb-commits] [PATCH] D68762: [LLDB] Fix when building with strict LLVM assertion checking on FreeBSD

devnexen abandoned this revision. devnexen added a comment. Just realised there was an existing PR addressing it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68762/new/ https://reviews.llvm.org/D68762 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D68723: Fix process launch failure on FreeBSD after r365761

devnexen accepted this revision. devnexen added a comment. This revision is now accepted and ready to land. LGTM otherwise. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68723/new/ https://reviews.llvm.org/D68723 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D68723: Fix process launch failure on FreeBSD after r365761

devnexen added inline comments. Comment at: source/Plugins/Process/FreeBSD/ProcessMonitor.cpp:733 // Finally, start monitoring the child process for change in state. - m_monitor_thread = Host::StartMonitoringChildProcess( + auto monitor_thread = Host::StartMonitoringChildPro

[Lldb-commits] [PATCH] D68727: Allow pexpect tests to work in remote testsuite runs

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I don't see harm in adding this, but I am curious about what are you planning to use this for. My takeaway from all of the pexpect discussions we've had in the past was that pexpect should onl

<    1   2