[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

labath added subscribers: amccarth, zturner. labath added a comment. Thanks. I was just about to hit approve, but then I noticed one other thing... :/ It seems that somebody (I guess it was @zturner) spent a lot of time in creating the whole PythonObject hierarchy, and it's (worthwhile) goal see

[Lldb-commits] [lldb] r373711 - [lldb][modern-type-lookup] No longer import temporary declarations into the persistent AST

Author: teemperor Date: Fri Oct 4 01:26:17 2019 New Revision: 373711 URL: http://llvm.org/viewvc/llvm-project?rev=373711&view=rev Log: [lldb][modern-type-lookup] No longer import temporary declarations into the persistent AST Summary: As we figured out in D67803, importing declarations from a t

[Lldb-commits] [PATCH] D68326: [lldb][modern-type-lookup] No longer import temporary declarations into the persistent AST

This revision was automatically updated to reflect the committed changes. Closed by commit rL373711: [lldb][modern-type-lookup] No longer import temporary declarations into the… (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[Lldb-commits] [PATCH] D68433: SBFile: add a bunch of tests that should eventually work.

labath added a comment. Makes sense. Would it make sense to use `@expectedFailure` instead of `@skipIf`? That way you'll get an notification once a test actually starts passing... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68433/new/ https://r

[Lldb-commits] [PATCH] D68444: remove a smattering of isolated, unnecessary uses of FILE*

labath added inline comments. Comment at: lldb/source/Core/IOHandler.cpp:332 + if (m_output_sp) { +m_output_sp->GetFile().Printf("%s", prompt); +m_output_sp->Flush(); It looks like this could actually use the `Stream` interface to

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

labath added inline comments. Comment at: lldb/include/lldb/Utility/ReproducerInstrumentation.h:19 +#include "lldb/API/SBFile.h" + This is definitely not right. `Utility` should never include other lldb libraries. I think this stuff should be defined in the AP

[Lldb-commits] [lldb] r373719 - [lldb] Fix typo in r373675

Author: sammccall Date: Fri Oct 4 02:33:04 2019 New Revision: 373719 URL: http://llvm.org/viewvc/llvm-project?rev=373719&view=rev Log: [lldb] Fix typo in r373675 Modified: lldb/trunk/scripts/Python/python-wrapper.swig Modified: lldb/trunk/scripts/Python/python-wrapper.swig URL: http://llvm

[Lldb-commits] [PATCH] D68069: Explicitly set entry point arch when it's thumb

labath added a comment. Yea, I see what you mean. I wouldn't spend too much time on fixing that though. The ability for SymbolFiles to add symtab entries is a fairly new thing. Not all issues with it have been ironed out, and I don't think it's up to you to fix them. The same kind of conflict c

[Lldb-commits] [lldb] r373721 - [lldb] Fix -Wreorder-ctor in r373673

Author: sammccall Date: Fri Oct 4 02:41:43 2019 New Revision: 373721 URL: http://llvm.org/viewvc/llvm-project?rev=373721&view=rev Log: [lldb] Fix -Wreorder-ctor in r373673 Modified: lldb/trunk/source/Commands/CommandObjectBreakpoint.cpp Modified: lldb/trunk/source/Commands/CommandObjectBrea

[Lldb-commits] [lldb] r373723 - [lldb] Fix that 'ninja clean' breaks the build by deleting debugserver_vers.c

Author: teemperor Date: Fri Oct 4 02:52:26 2019 New Revision: 373723 URL: http://llvm.org/viewvc/llvm-project?rev=373723&view=rev Log: [lldb] Fix that 'ninja clean' breaks the build by deleting debugserver_vers.c Summary: We mark debugserver_vers.c as a generated file in CMake. This means that w

[Lldb-commits] [PATCH] D68376: [lldb] Fix that 'ninja clean' breaks the build by deleting debugserver_vers.c

This revision was automatically updated to reflect the committed changes. Closed by commit rL373723: [lldb] Fix that 'ninja clean' breaks the build by deleting debugserver_vers.c (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[Lldb-commits] [lldb] r373725 - [lldb] Get the TargetAPI lock in SBProcess::IsInstrumentationRuntimePresent

Author: teemperor Date: Fri Oct 4 02:54:58 2019 New Revision: 373725 URL: http://llvm.org/viewvc/llvm-project?rev=373725&view=rev Log: [lldb] Get the TargetAPI lock in SBProcess::IsInstrumentationRuntimePresent Summary: We should get the TargetAPI lock here to prevent the process of being destro

[Lldb-commits] [PATCH] D67831: [lldb] Get the TargetAPI lock in SBProcess::IsInstrumentationRuntimePresen

This revision was automatically updated to reflect the committed changes. Closed by commit rL373725: [lldb] Get the TargetAPI lock in SBProcess::IsInstrumentationRuntimePresent (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[Lldb-commits] [PATCH] D68299: [JSON] Use LLVM's library for encoding JSON in GDBRemoteCommunicationServerLLGS

labath added a comment. Yeah, that's definitely python-related, but it's hard to say how exactly without knowing more details. Also note that there have been some changes in how the python stuff is used/built in the last couple of weeks so it's possible this was not caused by a change on your s

[Lldb-commits] [PATCH] D68299: [JSON] Use LLVM's library for encoding JSON in GDBRemoteCommunicationServerLLGS

labath added a comment. TBE, this happens when lldb is not able to find the python package files (which should normally be in `$BUILD/libXY/pythonA.B/site-packages`). Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68299/new/ https://reviews.llvm.org/D68299

[Lldb-commits] [PATCH] D68454: Fix the unwinding plan augmentation from x86 assembly

jarin created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Unwind plan augmentation should compute the plan row at offset x from the instruction before offset x, but currently we compute it from the instruction at offset x. Note that this behavior is a re

[Lldb-commits] [PATCH] D68456: [lldb] [cmake] Support linking against clang-cpp dylib

mgorny created this revision. mgorny added reviewers: labath, compnerd, phosek, beanz. Link against clang-cpp dylib rather than split libs when CLANG_LINK_CLANG_DYLIB is enabled. https://reviews.llvm.org/D68456 Files: lldb/cmake/modules/AddLLDB.cmake lldb/source/Core/CMakeLists.txt lldb/s

[Lldb-commits] [PATCH] D68456: [lldb] [cmake] Support linking against clang-cpp dylib

mgorny added a comment. FTR, I'm getting missing LD_LIBRARY_PATH problems when running `check-llvm` with dylibs. However, it also happens with plain `LLVM_LINK_LLVM_DYLIB`, so I don't think it needs to be addressed with this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68456/ne

[Lldb-commits] [PATCH] D68456: [lldb] [cmake] Support linking against clang-cpp dylib

labath added a comment. Seems reasonable. Just one quick question about the implementation. Comment at: lldb/cmake/modules/AddLLDB.cmake:94-99 + +if(CLANG_LINK_CLANG_DYLIB) + target_link_libraries(${name} PRIVATE clang-cpp) +else() + target_link_libraries(${na

[Lldb-commits] [PATCH] D68456: [lldb] [cmake] Support linking against clang-cpp dylib

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/cmake/modules/AddLLDB.cmake:94-99 + +if(CLANG_LINK_CLANG_DYLIB) + target_link_libraries(${name} PRIVATE clang-cpp) +else() + target_link_libraries(${name} PRIVATE ${PARAM_CLA

[Lldb-commits] [PATCH] D68456: [lldb] [cmake] Support linking against clang-cpp dylib

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/cmake/modules/AddLLDB.cmake:94-99 + +if(CLANG_LINK_CLANG_DYLIB) + target_link_libraries(${name} PRIVATE clang-cpp) +else() + target_lin

[Lldb-commits] [lldb] r373734 - [lldb] [cmake] Support linking against clang-cpp dylib

Author: mgorny Date: Fri Oct 4 05:03:03 2019 New Revision: 373734 URL: http://llvm.org/viewvc/llvm-project?rev=373734&view=rev Log: [lldb] [cmake] Support linking against clang-cpp dylib Link against clang-cpp dylib rather than split libs when CLANG_LINK_CLANG_DYLIB is enabled. Differential Rev

[Lldb-commits] [PATCH] D68456: [lldb] [cmake] Support linking against clang-cpp dylib

This revision was automatically updated to reflect the committed changes. Closed by commit rL373734: [lldb] [cmake] Support linking against clang-cpp dylib (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:

[Lldb-commits] [PATCH] D68270: DWARFDebugLoc: Add a function to get the address range of an entry

labath updated this revision to Diff 223193. labath added a comment. Upload a new version of the patch. This isn't fully ready for submission, but I am putting it up anyway, to get some feedback on the direction I am taking this, and ask some questions. First I tried to do a complete rewrite of

[Lldb-commits] [PATCH] D68270: DWARFDebugLoc: Add a function to get the address range of an entry

labath marked 8 inline comments as done. labath added inline comments. Comment at: include/llvm/DebugInfo/DWARF/DWARFDebugLoc.h:91 + class EntryIterator { + public: I went for an iterator-like approach (instead of a callback or direct materialization) becaus

[Lldb-commits] [PATCH] D68464: [lldb][modern-type-lookup] Ask the ExternalASTMerger to lookup namespaces instead of using the old mechanism

teemperor created this revision. teemperor added a reviewer: shafik. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. With this patch LLDB starts querying the ExternalASTMerger when we look up a namespace in the translation unit context. Because Clang's FindExte

[Lldb-commits] [PATCH] D68069: Explicitly set entry point arch when it's thumb

aadsm added a comment. Ok. Initially I thought that with the entry point we were making big assumptions there but after reading the parse unwind symbols I guess it's really no big difference. I guess my main concern is that the user can no longer create symbols within the span of the entry poi

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna added a comment. In D68188#1694276 , @labath wrote: > Most of your interactions seem to be about calling methods. Would it be > possible to add a PythonDataObject wrapper for this (and any other frequently > used python API)? I'm hoping th

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

JDevlieghere added inline comments. Comment at: lldb/source/Utility/ReproducerInstrumentation.cpp:38 +template <> lldb::SBFile Deserializer::Deserialize() { +//@JDevlieghere I'm pretty sure this is not the right thing to labath wrote: > lawrence_danna wrote

[Lldb-commits] [PATCH] D68444: remove a smattering of isolated, unnecessary uses of FILE*

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM modulo the stream changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68444/new/ https://reviews.llvm.org/D68444

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes by relaxing some checks

wallace updated this revision to Diff 223235. wallace added a comment. last nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68289/new/ https://reviews.llvm.org/D68289 Files: lldb/source/Host/linux/Host.cpp Index: lldb/source/Host/linux/Host.c

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223234. lawrence_danna marked 4 inline comments as done. lawrence_danna added a comment. minor fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lld

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp:1369 +const char *utf8 = PyUnicode_AsUTF8AndSize(pystring.get(), &size); +if (!utf8 || PyErr_Occurred()) + return Status(llvm::make_error("Read")); -

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes by relaxing some checks

wallace updated this revision to Diff 223236. wallace added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68289/new/ https://reviews.llvm.org/D68289 Files: lldb/source/Host/linux/Host.cpp Index: lldb/source/Host/linux/Host.cpp

[Lldb-commits] [lldb] r373758 - [lldb-server/android] Show more processes and package name when necessary

Author: wallace Date: Fri Oct 4 09:35:59 2019 New Revision: 373758 URL: http://llvm.org/viewvc/llvm-project?rev=373758&view=rev Log: [lldb-server/android] Show more processes and package name when necessary Summary: By default `platform process list` only shows the processes of the current user

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes by relaxing some checks

This revision was automatically updated to reflect the committed changes. Closed by commit rL373758: [lldb-server/android] Show more processes and package name when necessary (authored by wallace, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[Lldb-commits] [PATCH] D68433: SBFile: add a bunch of tests that should eventually work.

lawrence_danna updated this revision to Diff 223238. lawrence_danna added a comment. use expectedFailure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68433/new/ https://reviews.llvm.org/D68433 Files: lldb/packages/Python/lldbsuite/test/python_a

[Lldb-commits] [lldb] r373760 - [process info] Remove assert in DoGetGroupName

Author: wallace Date: Fri Oct 4 09:56:23 2019 New Revision: 373760 URL: http://llvm.org/viewvc/llvm-project?rev=373760&view=rev Log: [process info] Remove assert in DoGetGroupName Summary: Disabling this assert prevents lldb-server from crashing, which prevents it from finding the user and grou

[Lldb-commits] [PATCH] D68314: [process info] Remove assert in DoGetGroupName

wallace closed this revision. wallace added a comment. This has been committed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68314/new/ https://reviews.llvm.org/D68314 ___ lldb-commits mailing list lld

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

lawrence_danna updated this revision to Diff 223248. lawrence_danna added a comment. a different deserializer fix for SBFile Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68434/new/ https://reviews.llvm.org/D68434 Files: lldb/include/lldb/API/SB

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

lawrence_danna marked 4 inline comments as done. lawrence_danna added inline comments. Comment at: lldb/source/Utility/ReproducerInstrumentation.cpp:38 +template <> lldb::SBFile Deserializer::Deserialize() { +//@JDevlieghere I'm pretty sure this is not the right thing to --

[Lldb-commits] [PATCH] D68370: Componentize lldb/scripts to use with LLVM_DISTRIBUTION_COMPONENTS

This revision was automatically updated to reflect the committed changes. Closed by commit rL373768: Componentize lldb/scripts to use with LLVM_DISTRIBUTION_COMPONENTS (authored by aadsm, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

[Lldb-commits] [PATCH] D68444: remove a smattering of isolated, unnecessary uses of FILE*

lawrence_danna added a comment. fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68444/new/ https://reviews.llvm.org/D68444 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [PATCH] D68444: remove a smattering of isolated, unnecessary uses of FILE*

lawrence_danna updated this revision to Diff 223254. lawrence_danna marked 3 inline comments as done. lawrence_danna added a comment. fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68444/new/ https://reviews.llvm.org/D68444 Files: lldb/sour

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

labath added a comment. I agree about the separate patch stuff, but it seems to be that this should be done before this one. After all, all (most?) of the existing code has already been DataObject-ized and this patch is the thing that's deviating from that practice. I don't think you should rew

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

labath added inline comments. Comment at: lldb/source/Utility/ReproducerInstrumentation.cpp:38 +template <> lldb::SBFile Deserializer::Deserialize() { +//@JDevlieghere I'm pretty sure this is not the right thing to lawrence_danna wrote: > JDevlieghere wrote

[Lldb-commits] [lldb] r361898 - Fix IPv6 support on lldb-server platform

Author: aadsm Date: Tue May 28 16:26:32 2019 New Revision: 361898 URL: http://llvm.org/viewvc/llvm-project?rev=361898&view=rev Log: Fix IPv6 support on lldb-server platform Summary: This is a general fix for the ConnectionFileDescriptor class but my main motivation was to make lldb-server workin

[Lldb-commits] [lldb] r351504 - Use llvm::VersionTuple instead of manual version marshalling

Author: brad Date: Thu Jan 17 17:36:58 2019 New Revision: 351504 URL: http://llvm.org/viewvc/llvm-project?rev=351504&view=rev Log: Use llvm::VersionTuple instead of manual version marshalling Modified: lldb/trunk/include/lldb/Host/openbsd/HostInfoOpenBSD.h lldb/trunk/source/Host/openbsd/H

[Lldb-commits] [lldb] r361295 - Fix LLDB warnings when compiling with Clang 8.0

Author: aganea Date: Tue May 21 12:35:06 2019 New Revision: 361295 URL: http://llvm.org/viewvc/llvm-project?rev=361295&view=rev Log: Fix LLDB warnings when compiling with Clang 8.0 Differential Revision: https://reviews.llvm.org/D62021 Modified: lldb/trunk/source/Host/common/GetOptInc.cpp

[Lldb-commits] [lldb] r343810 - The Python 3 part of the script was missed when adding OpenBSD support.

Author: brad Date: Thu Oct 4 13:34:58 2018 New Revision: 343810 URL: http://llvm.org/viewvc/llvm-project?rev=343810&view=rev Log: The Python 3 part of the script was missed when adding OpenBSD support. Modified: lldb/trunk/scripts/utilsOsType.py Modified: lldb/trunk/scripts/utilsOsType.py U

[Lldb-commits] [lldb] r361531 - Test commit access by removing a empty line

Author: aadsm Date: Thu May 23 11:35:54 2019 New Revision: 361531 URL: http://llvm.org/viewvc/llvm-project?rev=361531&view=rev Log: Test commit access by removing a empty line Modified: lldb/trunk/source/Core/ModuleList.cpp Modified: lldb/trunk/source/Core/ModuleList.cpp URL: http://llvm.or

[Lldb-commits] [lldb] r359966 - [lldb] Fix buildbot failure due to clang AST change.

Author: rakete Date: Sat May 4 03:21:50 2019 New Revision: 359966 URL: http://llvm.org/viewvc/llvm-project?rev=359966&view=rev Log: [lldb] Fix buildbot failure due to clang AST change. In r359949 several AST node constructors were modified without the corresponding change in lldb, which caus

[Lldb-commits] [lldb] r362173 - Make ConnectionFileDescription work with all sockets

Author: aadsm Date: Thu May 30 16:30:35 2019 New Revision: 362173 URL: http://llvm.org/viewvc/llvm-project?rev=362173&view=rev Log: Make ConnectionFileDescription work with all sockets Summary: My main goal here is to make lldb-server work with Android Studio. This is currently not the case beca

[Lldb-commits] [lldb] r362619 - [DynamicLoader] Make sure we always set the rendezvous breakpoint

Author: aadsm Date: Wed Jun 5 09:22:33 2019 New Revision: 362619 URL: http://llvm.org/viewvc/llvm-project?rev=362619&view=rev Log: [DynamicLoader] Make sure we always set the rendezvous breakpoint Summary: Once we've attached to the process we load all current modules and also set a breakpoint

[Lldb-commits] [lldb] r362107 - Remove length modifier when using assignment suppression in TimerTest

Author: aadsm Date: Thu May 30 08:38:05 2019 New Revision: 362107 URL: http://llvm.org/viewvc/llvm-project?rev=362107&view=rev Log: Remove length modifier when using assignment suppression in TimerTest Summary: This is useless and it's giving warnings in the build bots: /home/motus/netbsd8/netbsd

[Lldb-commits] [lldb] r361861 - Fix 'warning: format specifies type 'int' but the argument has type 'MIuint' (aka 'unsigned long long') [-Wformat]' with Clang 8.0

Author: aganea Date: Tue May 28 11:36:11 2019 New Revision: 361861 URL: http://llvm.org/viewvc/llvm-project?rev=361861&view=rev Log: Fix 'warning: format specifies type 'int' but the argument has type 'MIuint' (aka 'unsigned long long') [-Wformat]' with Clang 8.0 Modified: lldb/trunk/tools/l

[Lldb-commits] [lldb] r363098 - Add support to read aux vector values

Author: aadsm Date: Tue Jun 11 13:16:13 2019 New Revision: 363098 URL: http://llvm.org/viewvc/llvm-project?rev=363098&view=rev Log: Add support to read aux vector values Summary: This is the second patch to improve module loading in a series that started here (where I explain the motivation and

[Lldb-commits] [lldb] r347721 - Remove dead code from IOHandler

Author: xiaobai Date: Tue Nov 27 15:37:47 2018 New Revision: 347721 URL: http://llvm.org/viewvc/llvm-project?rev=347721&view=rev Log: Remove dead code from IOHandler This has been dead since 2014 according to the blame Modified: lldb/trunk/source/Core/IOHandler.cpp Modified: lldb/trunk/sour

[Lldb-commits] [lldb] r361987 - Add more information to the log timer dump

Author: aadsm Date: Wed May 29 09:31:32 2019 New Revision: 361987 URL: http://llvm.org/viewvc/llvm-project?rev=361987&view=rev Log: Add more information to the log timer dump Summary: The `log timer dump` is showing the time of the function itself minus any function that is called from this one

[Lldb-commits] [lldb] r363458 - Implement GetSharedLibraryInfoAddress

Author: aadsm Date: Fri Jun 14 14:15:08 2019 New Revision: 363458 URL: http://llvm.org/viewvc/llvm-project?rev=363458&view=rev Log: Implement GetSharedLibraryInfoAddress Summary: This is the third patch to improve module loading in a series that started here (where I explain the motivation and s

[Lldb-commits] [lldb] r365059 - Add plugin.process.gdb-remote.use-libraries-svr4 option

Author: aadsm Date: Wed Jul 3 10:30:07 2019 New Revision: 365059 URL: http://llvm.org/viewvc/llvm-project?rev=365059&view=rev Log: Add plugin.process.gdb-remote.use-libraries-svr4 option Summary: This option allow the toggling of the libraries-svr4 usage in ProcessGDBRemote. It's a follow up of

[Lldb-commits] [lldb] r362406 - [lldb-server unittest] Add missing teardown logic

Author: aadsm Date: Mon Jun 3 08:18:15 2019 New Revision: 362406 URL: http://llvm.org/viewvc/llvm-project?rev=362406&view=rev Log: [lldb-server unittest] Add missing teardown logic Summary: This test base class is missing the teardown making the second set of tests extending it to fail in an as

[Lldb-commits] [lldb] r362437 - Silence 'warning C4305: 'initializing': truncation from 'double' to 'float'' with MSVC 19.16.27021.1 (VS2017 15.9.12)

Author: aganea Date: Mon Jun 3 11:46:30 2019 New Revision: 362437 URL: http://llvm.org/viewvc/llvm-project?rev=362437&view=rev Log: Silence 'warning C4305: 'initializing': truncation from 'double' to 'float'' with MSVC 19.16.27021.1 (VS2017 15.9.12) Modified: lldb/trunk/unittests/Utility/Re

[Lldb-commits] [lldb] r364355 - Revert "Add ReadCStringFromMemory for faster string reads"

Author: aadsm Date: Tue Jun 25 15:22:13 2019 New Revision: 364355 URL: http://llvm.org/viewvc/llvm-project?rev=364355&view=rev Log: Revert "Add ReadCStringFromMemory for faster string reads" This reverts commit a7335393f50246b59db450dc6005f7c8f29e73a6. It seems this is breaking a bunch of tests

[Lldb-commits] [lldb] r363750 - Add ReadCStringFromMemory for faster string reads

Author: aadsm Date: Tue Jun 18 16:27:57 2019 New Revision: 363750 URL: http://llvm.org/viewvc/llvm-project?rev=363750&view=rev Log: Add ReadCStringFromMemory for faster string reads Summary: This is the fifth patch to improve module loading in a series that started here (where I explain the moti

[Lldb-commits] [lldb] r362982 - Create a generic handler for Xfer packets

Author: aadsm Date: Mon Jun 10 13:59:58 2019 New Revision: 362982 URL: http://llvm.org/viewvc/llvm-project?rev=362982&view=rev Log: Create a generic handler for Xfer packets Summary: This is the first of a few patches I have to improve the performance of dynamic module loading on Android. In th

[Lldb-commits] [lldb] r363707 - Implement xfer:libraries-svr4:read packet

Author: aadsm Date: Tue Jun 18 10:51:56 2019 New Revision: 363707 URL: http://llvm.org/viewvc/llvm-project?rev=363707&view=rev Log: Implement xfer:libraries-svr4:read packet Summary: This is the fourth patch to improve module loading in a series that started here (where I explain the motivation

[Lldb-commits] [lldb] r367020 - Correctly use GetLoadedModuleList to take advantage of libraries-svr4

Author: aadsm Date: Thu Jul 25 07:28:21 2019 New Revision: 367020 URL: http://llvm.org/viewvc/llvm-project?rev=367020&view=rev Log: Correctly use GetLoadedModuleList to take advantage of libraries-svr4 Summary: Here's a replacement for D62504. I thought I could use LoadModules to implement this

[Lldb-commits] [lldb] r373687 - Revert "Explicitly set entry point arch when it's thumb"

Author: aadsm Date: Thu Oct 3 18:45:58 2019 New Revision: 373687 URL: http://llvm.org/viewvc/llvm-project?rev=373687&view=rev Log: Revert "Explicitly set entry point arch when it's thumb" Backing out because SymbolFile/Breakpad/symtab.test is failing and it seems to be a legit issue. Will inves

[Lldb-commits] [lldb] r367247 - Test load unloading of modules with libraries-svr4

Author: aadsm Date: Mon Jul 29 11:12:55 2019 New Revision: 367247 URL: http://llvm.org/viewvc/llvm-project?rev=367247&view=rev Log: Test load unloading of modules with libraries-svr4 Summary: This doubles the 3 tests running right now on linux by also executing each test with libraries-svr4 enab

[Lldb-commits] [lldb] r367052 - [LLDB] Find debugserver in Command Line Tools as well

Author: aadsm Date: Thu Jul 25 13:53:00 2019 New Revision: 367052 URL: http://llvm.org/viewvc/llvm-project?rev=367052&view=rev Log: [LLDB] Find debugserver in Command Line Tools as well Summary: This might be an edge case in regular use but if you're shipping an lldb version with no debugserver

[Lldb-commits] [lldb] r373680 - Explicitly set entry point arch when it's thumb

Author: aadsm Date: Thu Oct 3 17:11:22 2019 New Revision: 373680 URL: http://llvm.org/viewvc/llvm-project?rev=373680&view=rev Log: Explicitly set entry point arch when it's thumb Summary: I found a case where the main android binary (app_process32) had thumb code at its entry point but no entry

[Lldb-commits] [lldb] r366956 - [Support] move FileCollector from LLDB to llvm/Support

Author: arphaman Date: Wed Jul 24 15:59:20 2019 New Revision: 366956 URL: http://llvm.org/viewvc/llvm-project?rev=366956&view=rev Log: [Support] move FileCollector from LLDB to llvm/Support The file collector class is useful for creating reproducers, not just for LLDB, but for other tools as well

[Lldb-commits] [lldb] r373768 - Componentize lldb/scripts to use with LLVM_DISTRIBUTION_COMPONENTS

Author: aadsm Date: Fri Oct 4 11:10:42 2019 New Revision: 373768 URL: http://llvm.org/viewvc/llvm-project?rev=373768&view=rev Log: Componentize lldb/scripts to use with LLVM_DISTRIBUTION_COMPONENTS Summary: I'd like to install lldb using the install-distribution target with LLVM_DISTRIBUTION_CO

[Lldb-commits] [lldb] r366848 - Revert "Revert "Add ReadCStringFromMemory for faster string reads""

Author: aadsm Date: Tue Jul 23 13:40:37 2019 New Revision: 366848 URL: http://llvm.org/viewvc/llvm-project?rev=366848&view=rev Log: Revert "Revert "Add ReadCStringFromMemory for faster string reads"" This reverts commit 9c10b620c0619611dfe062216459431955ac4801. Modified: lldb/trunk/include/l

[Lldb-commits] [lldb] r366847 - Revert "Revert "Implement xfer:libraries-svr4:read packet""

Author: aadsm Date: Tue Jul 23 13:40:30 2019 New Revision: 366847 URL: http://llvm.org/viewvc/llvm-project?rev=366847&view=rev Log: Revert "Revert "Implement xfer:libraries-svr4:read packet"" This reverts commit 08c38f77c5fb4d3735ec215032fed8ee6730b3db. Added: lldb/trunk/packages/Python/lldb

[Lldb-commits] [lldb] r341320 - [PseudoTerminal][NFC] Use llvm errno helpers

Author: xbolva00 Date: Mon Sep 3 07:59:57 2018 New Revision: 341320 URL: http://llvm.org/viewvc/llvm-project?rev=341320&view=rev Log: [PseudoTerminal][NFC] Use llvm errno helpers Summary: LLVM provide (str)errno helpers, so convert code to use it. Also fixes warning: /home/xbolva00/LLVM/llvm/to

[Lldb-commits] [lldb] r341340 - [NFC] Fixed enum constant in boolean context error

Author: xbolva00 Date: Mon Sep 3 15:09:08 2018 New Revision: 341340 URL: http://llvm.org/viewvc/llvm-project?rev=341340&view=rev Log: [NFC] Fixed enum constant in boolean context error Summary: /home/xbolva00/LLVM/llvm/tools/lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKern

[Lldb-commits] [lldb] r341339 - [NFC] Use llvm_unreachable instead of lldb::assert

Author: xbolva00 Date: Mon Sep 3 15:08:30 2018 New Revision: 341339 URL: http://llvm.org/viewvc/llvm-project?rev=341339&view=rev Log: [NFC] Use llvm_unreachable instead of lldb::assert Summary: Fixes implicit fall through warnings Reviewers: JDevlieghere, teemperor Reviewed By: teemperor Sub

[Lldb-commits] [lldb] r341334 - [ClangUserExpression][NFC] Removed unused code

Author: xbolva00 Date: Mon Sep 3 11:21:21 2018 New Revision: 341334 URL: http://llvm.org/viewvc/llvm-project?rev=341334&view=rev Log: [ClangUserExpression][NFC] Removed unused code Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp Modified: lldb/trunk/sourc

[Lldb-commits] [lldb] r341387 - Terminate debugger if an assert was hit

Author: xbolva00 Date: Tue Sep 4 10:19:15 2018 New Revision: 341387 URL: http://llvm.org/viewvc/llvm-project?rev=341387&view=rev Log: Terminate debugger if an assert was hit Reviewers: JDevlieghere, teemperor, #lldb Reviewed By: JDevlieghere Subscribers: clayborg, lemo, lldb-commits Different

[Lldb-commits] [lldb] r341746 - Check if a terminal supports colors on Windows properly

Author: xbolva00 Date: Sat Sep 8 00:15:56 2018 New Revision: 341746 URL: http://llvm.org/viewvc/llvm-project?rev=341746&view=rev Log: Check if a terminal supports colors on Windows properly Summary: Previously we SetUseColor(true) wrongly when output was not a terminal so it broken some (not pu

[Lldb-commits] [lldb] r357336 - [CMake] Add missing test dep

Author: davezarzycki Date: Fri Mar 29 17:00:19 2019 New Revision: 357336 URL: http://llvm.org/viewvc/llvm-project?rev=357336&view=rev Log: [CMake] Add missing test dep lit/SymbolFile/NativePDB/globals-bss.cpp needs llvm-readobj Modified: lldb/trunk/lit/CMakeLists.txt Modified: lldb/trunk/li

[Lldb-commits] [lldb] r341315 - [Symtab][NFC] Added llvm_unreachable to supress compiler warning

Author: xbolva00 Date: Mon Sep 3 05:57:54 2018 New Revision: 341315 URL: http://llvm.org/viewvc/llvm-project?rev=341315&view=rev Log: [Symtab][NFC] Added llvm_unreachable to supress compiler warning Reviewers: JDevlieghere Reviewed By: JDevlieghere Subscribers: lldb-commits Differential Revis

[Lldb-commits] [lldb] r345637 - NFC: Remove the ObjC1/ObjC2 distinction from clang (and related projects)

Author: epilk Date: Tue Oct 30 13:31:30 2018 New Revision: 345637 URL: http://llvm.org/viewvc/llvm-project?rev=345637&view=rev Log: NFC: Remove the ObjC1/ObjC2 distinction from clang (and related projects) We haven't supported compiling ObjC1 for a long time (and never will again), so there isn't

[Lldb-commits] [lldb] r342075 - Do not create new terminals when launching process on Windows with --no-stdio

Author: xbolva00 Date: Wed Sep 12 12:50:45 2018 New Revision: 342075 URL: http://llvm.org/viewvc/llvm-project?rev=342075&view=rev Log: Do not create new terminals when launching process on Windows with --no-stdio Summary: Partially fixes PR38222 Reviewers: teemperor, zturner, stella.stamenova R

[Lldb-commits] [lldb] r341497 - Set Windows console mode to enable support for ansi escape codes

Author: xbolva00 Date: Wed Sep 5 15:06:58 2018 New Revision: 341497 URL: http://llvm.org/viewvc/llvm-project?rev=341497&view=rev Log: Set Windows console mode to enable support for ansi escape codes Summary: Windows console now supports supports ANSI escape codes, but we need to enable it using

[Lldb-commits] [lldb] r366912 - [AIX][lit] Don't depend on psutil on AIX

Author: daltenty Date: Wed Jul 24 08:04:27 2019 New Revision: 366912 URL: http://llvm.org/viewvc/llvm-project?rev=366912&view=rev Log: [AIX][lit] Don't depend on psutil on AIX Summary: On AIX psutil can run into problems with permissions to read the process tree, which causes problems for python

[Lldb-commits] [lldb] r373074 - [lldb] Disable testing entry values as memory location

Author: djtodoro Date: Fri Sep 27 05:16:29 2019 New Revision: 373074 URL: http://llvm.org/viewvc/llvm-project?rev=373074&view=rev Log: [lldb] Disable testing entry values as memory location The D67717 excludes such locations for now. Modified: lldb/trunk/packages/Python/lldbsuite/test/funct

[Lldb-commits] [lldb] r345755 - [NFC] Fixed -Wsign-compare warning

Author: xbolva00 Date: Wed Oct 31 11:03:36 2018 New Revision: 345755 URL: http://llvm.org/viewvc/llvm-project?rev=345755&view=rev Log: [NFC] Fixed -Wsign-compare warning Modified: lldb/trunk/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp Modified: lldb/trunk/source/Plu

[Lldb-commits] [lldb] r373775 - [lldb] Fix crash on SBCommandReturnObject & assignment

Author: jankratochvil Date: Fri Oct 4 12:32:57 2019 New Revision: 373775 URL: http://llvm.org/viewvc/llvm-project?rev=373775&view=rev Log: [lldb] Fix crash on SBCommandReturnObject & assignment I was writing an SB API client and it was crashing on: bool DoExecute(SBDebugger dbg, char **c

[Lldb-commits] [PATCH] D67589: Fix crash on SBCommandReturnObject & assignment

This revision was automatically updated to reflect the committed changes. Closed by commit rL373775: [lldb] Fix crash on SBCommandReturnObject & assignment (authored by jankratochvil, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r373777 - [MachO] Reformat before making changes to this file (NFC)

Author: jdevlieghere Date: Fri Oct 4 12:37:52 2019 New Revision: 373777 URL: http://llvm.org/viewvc/llvm-project?rev=373777&view=rev Log: [MachO] Reformat before making changes to this file (NFC) Modified: lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp Modified: lldb/trunk/

[Lldb-commits] [lldb] r373776 - [Host] Don't discard return value from RunShellCommand

Author: jdevlieghere Date: Fri Oct 4 12:37:46 2019 New Revision: 373776 URL: http://llvm.org/viewvc/llvm-project?rev=373776&view=rev Log: [Host] Don't discard return value from RunShellCommand The recent change to expand arguments with the user's shell sometimes caused a timeout and the error wa

Re: [Lldb-commits] [lldb] r373776 - [Host] Don't discard return value from RunShellCommand

On 04/10/2019 21:37, Jonas Devlieghere via lldb-commits wrote: + error.SetErrorString(e.AsCString()); + return error; +} return e; ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[Lldb-commits] [lldb] r344119 - [LLDB] - Add basic support for .debug_rnglists section (DWARF5)

Author: grimar Date: Wed Oct 10 01:11:15 2018 New Revision: 344119 URL: http://llvm.org/viewvc/llvm-project?rev=344119&view=rev Log: [LLDB] - Add basic support for .debug_rnglists section (DWARF5) This adds a basic support of the .debug_rnglists section. Only the DW_RLE_start_length and DW_RLE_en

[Lldb-commits] [lldb] r336846 - [FileCheck] Add -allow-deprecated-dag-overlap to failing lldb tests

Author: jdenny Date: Wed Jul 11 13:27:05 2018 New Revision: 336846 URL: http://llvm.org/viewvc/llvm-project?rev=336846&view=rev Log: [FileCheck] Add -allow-deprecated-dag-overlap to failing lldb tests See https://reviews.llvm.org/D47106 for details. Reviewed By: probinson Differential Revision:

[Lldb-commits] [lldb] r345016 - [LLDB] - Implement the support for the .debug_loclists section.

Author: grimar Date: Tue Oct 23 02:46:15 2018 New Revision: 345016 URL: http://llvm.org/viewvc/llvm-project?rev=345016&view=rev Log: [LLDB] - Implement the support for the .debug_loclists section. This implements the support for .debug_loclists section, which is DWARF 5 version of .debug_loc. Cu

[Lldb-commits] [lldb] r344674 - [LLDB] - Add support for DW_RLE_start_end entries (.debug_rnglists)

Author: grimar Date: Wed Oct 17 00:37:26 2018 New Revision: 344674 URL: http://llvm.org/viewvc/llvm-project?rev=344674&view=rev Log: [LLDB] - Add support for DW_RLE_start_end entries (.debug_rnglists) DWARF5 describes DW_RLE_start_end as: This is a form of bounded range entry that has two target

[Lldb-commits] [lldb] r344122 - [LLDB] - Simplify. NFC.

Author: grimar Date: Wed Oct 10 01:49:17 2018 New Revision: 344122 URL: http://llvm.org/viewvc/llvm-project?rev=344122&view=rev Log: [LLDB] - Simplify. NFC. There are several places that call `FindRanges`, all of them use `Slide` to adjust the ranges found by the base address. All except one, wh

  1   2   3   4   >