[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

2019-09-29 Thread Lawrence D'Anna via Phabricator via lldb-commits
lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. This patch adds SWIG typemaps that can convert arbitrary python file objects into lldb_private::File. A SBFile may be initialized from a python file using the co

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

2019-09-29 Thread Hal Gentz via Phabricator via lldb-commits
ZeGentzy added a comment. I'm a tad late, but I just wanted to confirm for everyone that this works. Thanks everybody! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67890/new/ https://reviews.llvm.org/D67890 ___ lldb

[Lldb-commits] [PATCH] D68160: File::Clear() -> File::TakeStreamAndClear()

2019-09-29 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Sounds good. If this were a more permanent interface, I'd argue that the function should be called `TakeStream` (in analogy with `llvm::Expected::takeError`), but for a temporary thing that do

[Lldb-commits] [PATCH] D68130: [lldb] Don't emit artificial constructor declarations as global functions

2019-09-29 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D68130#1686184 , @vsk wrote: > Great find. The changes in this patch makes sense to me locally, but I'm > having trouble picking up on the context necessary to confidently 'lgtm'. + > @JDevlieghere & @labath to get some more ex