[Lldb-commits] [PATCH] D68181: SBDebugger::SetInputFile, SetOutputFile, etc.

2019-09-28 Thread Lawrence D'Anna via Phabricator via lldb-commits
lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. Add new methods to SBDebugger to set IO files as SBFiles instead of as FILE* streams. In future commits, the FILE* methods will be deprecated and these will bec

[Lldb-commits] [PATCH] D68181: SBDebugger::SetInputFile, SetOutputFile, etc.

2019-09-28 Thread Lawrence D'Anna via Phabricator via lldb-commits
lawrence_danna updated this revision to Diff 85. lawrence_danna added a comment. clang-format fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68181/new/ https://reviews.llvm.org/D68181 Files: lldb/include/lldb/API/SBDebugger.h lldb/inclu

[Lldb-commits] [lldb] r373144 - [LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api. NFC.

2019-09-28 Thread Martin Storsjo via lldb-commits
Author: mstorsjo Date: Sat Sep 28 02:33:44 2019 New Revision: 373144 URL: http://llvm.org/viewvc/llvm-project?rev=373144&view=rev Log: [LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api. NFC. If there's any testcases that only do demangling (I didn't find any), they could

[Lldb-commits] [PATCH] D68134: [LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api

2019-09-28 Thread Martin Storsjö via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL373144: [LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api. NFC. (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chang

[Lldb-commits] [lldb] r373146 - Revert "[LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api. NFC."

2019-09-28 Thread Martin Storsjo via lldb-commits
Author: mstorsjo Date: Sat Sep 28 03:25:22 2019 New Revision: 373146 URL: http://llvm.org/viewvc/llvm-project?rev=373146&view=rev Log: Revert "[LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api. NFC." This reverts SVN r373144, as it changed the demangled output a little,

[Lldb-commits] [PATCH] D68134: [LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api

2019-09-28 Thread Nico Weber via Phabricator via lldb-commits
thakis added a comment. We can add flags for omitting access specifiers etc if it's critical for lldb. Or maybe we can just change the test that caused the revert. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68134/new/ https://reviews.llvm.org/D68134 ___

[Lldb-commits] [PATCH] D68134: [LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api

2019-09-28 Thread Martin Storsjö via Phabricator via lldb-commits
mstorsjo added a comment. In D68134#1686970 , @thakis wrote: > We can add flags for omitting access specifiers etc if it's critical for > lldb. Or maybe we can just change the test that caused the revert. Yeah I doubt it's critical to maintain the exact