[Lldb-commits] [lldb] r372799 - [CMake] Don't modify LLVM_DISTRIBUTION_COMPONENTS if it's not set

Author: jdevlieghere Date: Tue Sep 24 18:23:05 2019 New Revision: 372799 URL: http://llvm.org/viewvc/llvm-project?rev=372799&view=rev Log: [CMake] Don't modify LLVM_DISTRIBUTION_COMPONENTS if it's not set Don't try to remove debugserver from LLVM_DISTRIBUTION_COMPONENTS if the list is not set. M

[Lldb-commits] [PATCH] D68003: [dotest] Support specifying a version for skipIfOutOfTreeDebugserver

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Herald added a subscriber: dexonsmith. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/TestConcurrentManyBreakpoints.py:18 @expectedFailureNetBSD -

[Lldb-commits] [lldb] r372800 - remove unused method ResetOutputFileHandle()

Author: jdevlieghere Date: Tue Sep 24 18:29:41 2019 New Revision: 372800 URL: http://llvm.org/viewvc/llvm-project?rev=372800&view=rev Log: remove unused method ResetOutputFileHandle() ResetOutputFileHandle() isn't being used by anything. Also it's using FILE*, which is something we should be doin

[Lldb-commits] [PATCH] D68001: remove unused method ResetOutputFileHandle()

This revision was automatically updated to reflect the committed changes. Closed by commit rL372800: remove unused method ResetOutputFileHandle() (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[Lldb-commits] [PATCH] D67892: [LLDB] Fix typo in RegisterContextDarwin_arm64

jasonmolenda added a comment. In D67892#1680317 , @labath wrote: > In either case, it's sad that there are no tests breaking due to this. > Ideally we'd have a small arm64 macho core file with well known register > values that we could just assert are re

[Lldb-commits] [lldb] r372801 - [Make] Revert some changes from r372795.

Author: jdevlieghere Date: Tue Sep 24 18:39:13 2019 New Revision: 372801 URL: http://llvm.org/viewvc/llvm-project?rev=372801&view=rev Log: [Make] Revert some changes from r372795. These changes cause the corresponding test to fail on the Linux bots. Modified: lldb/trunk/packages/Python/lldb

[Lldb-commits] [PATCH] D67984: Canonicalize variable usage in testsuite Makefiles

JDevlieghere added a comment. Hey Adrian, I've reverted two changes in r372801 that appear to break the linux bots: http://lab.llvm.org:8014/builders/lldb-x86_64-fedora/builds/2405 http://lab.llvm.org:8014/builders/lldb-x86_64-debian/builds/4417 Can you have a look? Repository: rL LLVM CHA

[Lldb-commits] [PATCH] D67965: Have ABI plugins vend llvm MCRegisterInfo data

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks for the explanation. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67965/new/ https://reviews.llvm.org/D67965 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [PATCH] D68005: Make dw_tag_t a llvm::dwarf::Tag

JDevlieghere created this revision. JDevlieghere added reviewers: labath, clayborg, shafik. Herald added a subscriber: aprantl. Herald added a project: LLDB. When talking to Shafik about D67994 , we discovered that `dw_tag_t` is a typedef for `uint16_t`. I believe

[Lldb-commits] [PATCH] D68007: [lldb] Move swig call from python code to cmake

hhb created this revision. hhb added reviewers: labath, mgorny. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Elimiates lots of unused code. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68007 Files: lldb/scripts/CMakeLists.txt lldb/scripts/Python

[Lldb-commits] [PATCH] D68007: [lldb] Move swig call from python code to cmake

hhb updated this revision to Diff 221664. hhb added a comment. Fix a typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68007/new/ https://reviews.llvm.org/D68007 Files: lldb/scripts/CMakeLists.txt lldb/scripts/Python/prepare_binding_Python.py

[Lldb-commits] [PATCH] D68007: [lldb] Move swig call from python code to cmake

hhb updated this revision to Diff 221667. hhb added a comment. Format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68007/new/ https://reviews.llvm.org/D68007 Files: lldb/scripts/CMakeLists.txt lldb/scripts/Python/prepare_binding_Python.py l

[Lldb-commits] [PATCH] D67222: [Windows] Added support of watchpoints to `NativeProcessWindows`

aleksandr.urakov updated this revision to Diff 221671. aleksandr.urakov added a comment. Update the patch due to Pavel's request. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67222/new/ https://reviews.llvm.org/D67222 Files: lldb/source/Plugins/Process/Wind

[Lldb-commits] [PATCH] D67222: [Windows] Added support of watchpoints to `NativeProcessWindows`

aleksandr.urakov added a reviewer: labath. aleksandr.urakov added a comment. In D67222#1680613 , @labath wrote: > Btw, in the context of D67954 , I realized > that I don't know how to actually enable the usage of lldb-serv

[Lldb-commits] [PATCH] D67988: [lldb] clean up lldb/scripts a little bit

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Without testing, the changes LGTM. However, please wait for Pavel to review this as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67988/ne

[Lldb-commits] [PATCH] D67954: [LLDB] [Windows] Initial support for ARM64 debugging

aleksandr.urakov added a subscriber: leonid.mashinskiy. aleksandr.urakov added a comment. In D67954#1680536 , @labath wrote: > Have you considered going the "native" route directly? My understanding is > that this route is already functional on x86 (modul

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

aleksandr.urakov added a comment. Gentle ping! What do you think of this? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67347/new/ https://reviews.llvm.org/D67347 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [PATCH] D67993: [lldb] Calculate relative path for symbol links

mgorny added a comment. Yep, that's a change in the right direction. Have you (at least mentally) verified that it produces the correct path in all cases? I wouldn't trust the inputs being entirely correct. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D68007: [lldb] Move swig call from python code to cmake

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Thanks! That's a great job, and certainly saves me some trouble in pushing my patch forward, though I'm kinda surprised we don't need site-packages path there after all. Please wait for other

[Lldb-commits] [PATCH] D67993: [lldb] Calculate relative path for symbol links

hhb added a comment. In D67993#1681901 , @mgorny wrote: > Yep, that's a change in the right direction. Have you (at least mentally) > verified that it produces the correct path in all cases? I wouldn't trust the > inputs being entirely correct. So far

[Lldb-commits] [PATCH] D68007: [lldb] Move swig call from python code to cmake

hhb added a comment. In D68007#1681908 , @mgorny wrote: > I'm kinda surprised we don't need site-packages path there after all. Yes that's surprising. Seems like it is better to move the install() call in your change to lldb/CMakeLists.txt. To be togeth

<    1   2