[Lldb-commits] [PATCH] D65646: [lldb] Print better diagnostics for user expressions and modules

teemperor updated this revision to Diff 220439. teemperor retitled this revision from "[lldb] Print better diagnostics for user expressions." to "[lldb] Print better diagnostics for user expressions and modules". teemperor added a comment. Herald added a subscriber: usaxena95. - Rebased test. -

[Lldb-commits] [lldb] r372077 - Reland "[lldb][NFC] Make ApplyObjcCastHack less scary"

Author: teemperor Date: Tue Sep 17 00:58:01 2019 New Revision: 372077 URL: http://llvm.org/viewvc/llvm-project?rev=372077&view=rev Log: Reland "[lldb][NFC] Make ApplyObjcCastHack less scary" First version had a typo. Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUserExpress

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk added a comment. @clayborg thank you for this explanation. My patch for minidebuginfo is already done in D66791 . But this one here I was asked to pull out as a separate patch. For good reasons as we see. I wonder how this extra parameter `SymbolMapType` of

[Lldb-commits] [lldb] r372090 - [lldb] [Process/gdb-remote] Fix defaulting signal to invalid in action list

Author: mgorny Date: Tue Sep 17 02:31:00 2019 New Revision: 372090 URL: http://llvm.org/viewvc/llvm-project?rev=372090&view=rev Log: [lldb] [Process/gdb-remote] Fix defaulting signal to invalid in action list Fix processing of "C" packet with signal for the whole process to default signal value f

[Lldb-commits] [PATCH] D67625: [lldb] [Process/gdb-remote] Fix defaulting signal to invalid in action list

This revision was automatically updated to reflect the committed changes. Closed by commit rL372090: [lldb] [Process/gdb-remote] Fix defaulting signal to invalid in action list (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prio

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

labath added a comment. In D67390#1672210 , @kwk wrote: > So my point of this whole question is: What makes a symbol unique in the > sense that it shouldn't be added to the symtab if it is already there? A symbol name is not unique because you can have

[Lldb-commits] [PATCH] D67589: Fix crash on SBCommandReturnObject & assignment

jankratochvil marked 3 inline comments as done. jankratochvil added a comment. In D67589#1670966 , @labath wrote: > I agree that this approach isn't nice, but probably there isn't a nice > approach to this at this point. One possibility you could consider

[Lldb-commits] [PATCH] D67589: Fix crash on SBCommandReturnObject & assignment

jankratochvil updated this revision to Diff 220505. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67589/new/ https://reviews.llvm.org/D67589 Files: lldb/include/lldb/API/SBCommandReturnObject.h lldb/packages/Python/lldbsuite/test/api/command-return-object/Ma

[Lldb-commits] [PATCH] D67589: Fix crash on SBCommandReturnObject & assignment

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/api/command-return-object/main.cpp:18 +result = subcommand(dbg, "help"); +result = result; +if (!result.Succeeded())

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

clayborg added a comment. In D67390#1672210 , @kwk wrote: > @clayborg thank you for this explanation. My patch for minidebuginfo is > already done in D66791 . But this one here > I was asked to pull out as a separate pat

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

clayborg added a comment. In D67390#1672254 , @labath wrote: > In D67390#1672210 , @kwk wrote: > > > So my point of this whole question is: What makes a symbol unique in the > > sense that it shouldn't be added to

[Lldb-commits] [PATCH] D67589: Fix crash on SBCommandReturnObject & assignment

clayborg added inline comments. Comment at: lldb/include/lldb/API/SBCommandReturnObject.h:22-27 +namespace lldb_private { +// Wrap SBCommandReturnObject::ref() so that any LLDB internal function can +// call it but still no SB API users can call it. +CommandReturnObject & +SBComm

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67641/new/ https://reviews.llvm.org/D67641 __

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

hhb updated this revision to Diff 220584. hhb added a comment. Turns out I still need to change previous lines to remove PARENT_SCOPE. Otherwise local value will still be used even if a different value is set in the cache. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D67685: [ScriptInterpreter] Make sure LLDB's global variables are only available in interactive mode.

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. Jim pointed out that the LLDB global variables should only be available in interactive mode. When used from a command, their values might be stale or not at all what the user expects. Therefore we want to explicitly make

[Lldb-commits] [lldb] r372190 - [ScriptInterpreter] Remove ScriptInterpreterPythonImpl::Clear() (NFC)

Author: jdevlieghere Date: Tue Sep 17 17:01:52 2019 New Revision: 372190 URL: http://llvm.org/viewvc/llvm-project?rev=372190&view=rev Log: [ScriptInterpreter] Remove ScriptInterpreterPythonImpl::Clear() (NFC) This method is never called. Modified: lldb/trunk/source/Plugins/ScriptInterpreter

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

hhb updated this revision to Diff 220589. hhb added a comment. Add CACHE PATH again. I think this is the only way to go. With PARENT_SCOPE: Tthe local detected value is always used, even if a different value is set in cache. With no parameter: Always the value in cache is used. If a value is not

[Lldb-commits] [PATCH] D67685: [ScriptInterpreter] Make sure LLDB's global variables are only available in interactive mode.

JDevlieghere updated this revision to Diff 220588. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67685/new/ https://reviews.llvm.org/D67685 Files: lldb/lit/Commands/Inputs/frame.py lldb/lit/Commands/command-script-import.test lldb/source/Plugins/ScriptInterpreter/Python/ScriptInter

[Lldb-commits] [PATCH] D67685: [ScriptInterpreter] Make sure LLDB's global variables are only available in interactive mode.

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This looks right. EnterSession always initializes lldb.debugger, even when it isn't going to set the other globals. That's because one debugger owns one ScriptInterpreter and lldb.debugger

[Lldb-commits] [lldb] r372192 - [ScriptInterpreter] Limit LLDB's globals to interactive mode.

Author: jdevlieghere Date: Tue Sep 17 17:30:01 2019 New Revision: 372192 URL: http://llvm.org/viewvc/llvm-project?rev=372192&view=rev Log: [ScriptInterpreter] Limit LLDB's globals to interactive mode. Jim pointed out that the LLDB global variables should only be available in interactive mode. Whe

[Lldb-commits] [PATCH] D67685: [ScriptInterpreter] Make sure LLDB's global variables are only available in interactive mode.

This revision was automatically updated to reflect the committed changes. Closed by commit rL372192: [ScriptInterpreter] Limit LLDB's globals to interactive mode. (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[Lldb-commits] [lldb] r372193 - TestFoundationDisassembly.py is not dependent on debug information.

Author: jingham Date: Tue Sep 17 17:40:49 2019 New Revision: 372193 URL: http://llvm.org/viewvc/llvm-project?rev=372193&view=rev Log: TestFoundationDisassembly.py is not dependent on debug information. This test is about disassembling symbols in a framework without debug information. So we don't

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

JDevlieghere accepted this revision. JDevlieghere added a comment. Hmm, that's unfortunately but I guess it makes sense. Let's remove the `mark_as_advanced` as it doesn't really serve a purpose anymore. Apologies about the churn! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D67583: Fix swig python package path

ZeGentzy reopened this revision. ZeGentzy added a comment. This revision is now accepted and ready to land. Hello folks, These changes break running `ninja install` when building with `-D LLVM_LIBDIR_SUFFIX=32`. [...] -- Up-to-date: /build/llvm-git-gentz/pkg/lib32-llvm-git-gentz/opt/llvm32

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

hhb updated this revision to Diff 220594. hhb added a comment. Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67641/new/ https://reviews.llvm.org/D67641 Files: lldb/cmake/modules/LLDBConfig.cmake Index: lldb/cmake/modules/LLDBConfig

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL372194: Cache PYTHON_EXECUTABLE for windows (authored by hhb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D67

[Lldb-commits] [lldb] r372196 - Clean up this test.

Author: jingham Date: Tue Sep 17 18:53:52 2019 New Revision: 372196 URL: http://llvm.org/viewvc/llvm-project?rev=372196&view=rev Log: Clean up this test. I don't know what the intent of parts of this test were. We set a bunch of breakpoints and ran from one to the other, doing "self.runCmd("thre