[Lldb-commits] [lldb] r371017 - Breakpad: Basic support for STACK WIN unwinding

Author: labath Date: Thu Sep 5 00:05:15 2019 New Revision: 371017 URL: http://llvm.org/viewvc/llvm-project?rev=371017&view=rev Log: Breakpad: Basic support for STACK WIN unwinding Summary: This patch makes it possible to unwind via breakpad STACK WIN records. It is "basic" because two important

[Lldb-commits] [PATCH] D67067: Breakpad: Basic support for STACK WIN unwinding

This revision was automatically updated to reflect the committed changes. Closed by commit rL371017: Breakpad: Basic support for STACK WIN unwinding (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revie

[Lldb-commits] [PATCH] D67067: Breakpad: Basic support for STACK WIN unwinding

labath marked an inline comment as done. labath added inline comments. Comment at: source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:549 + llvm::Optional record = StackWinRecord::parse(*It); + assert(record.hasValue()); + amccarth wrote: > labath wrote:

[Lldb-commits] [lldb] r371018 - Obliterate LLDB_CONFIGURATION_BUILDANDINTEGRATION

Author: labath Date: Thu Sep 5 00:09:31 2019 New Revision: 371018 URL: http://llvm.org/viewvc/llvm-project?rev=371018&view=rev Log: Obliterate LLDB_CONFIGURATION_BUILDANDINTEGRATION Summary: With the XCode project gone, there doesn't seem to be anything setting this macro anymore -- and the macr

[Lldb-commits] [PATCH] D66742: Obliterate LLDB_CONFIGURATION_BUILDANDINTEGRATION

This revision was automatically updated to reflect the committed changes. Closed by commit rL371018: Obliterate LLDB_CONFIGURATION_BUILDANDINTEGRATION (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE L

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Make the RedirectingFileSystem hold on to its own working directory.

labath added a comment. Though I am not very familiar VFS, this seems like the most intuitive solution out of everything that we had so far. But... shouldn't you also check that the directory you're `chdir`-ing into "exists" before you actually change the cwd? Also, the chdir operation should p

[Lldb-commits] [PATCH] D67173: [dotest] Centralize initialization commands even more

labath marked an inline comment as done. labath added inline comments. Comment at: packages/Python/lldbsuite/test/lldbtest.py:709 +if lldbtest_config.inferior_env: +commands.append('settings set target.env-vars ' + +lldbtest_config.inferior

[Lldb-commits] [lldb] r371019 - [dotest] Centralize initialization commands even more

Author: labath Date: Thu Sep 5 00:35:45 2019 New Revision: 371019 URL: http://llvm.org/viewvc/llvm-project?rev=371019&view=rev Log: [dotest] Centralize initialization commands even more Summary: In r367234 we introduced a central place to hold the set up commands for the various ways we have of

[Lldb-commits] [PATCH] D67173: [dotest] Centralize initialization commands even more

This revision was automatically updated to reflect the committed changes. Closed by commit rL371019: [dotest] Centralize initialization commands even more (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[Lldb-commits] [lldb] r371020 - [dotest] Remove top-level Makefile

Author: labath Date: Thu Sep 5 00:38:55 2019 New Revision: 371020 URL: http://llvm.org/viewvc/llvm-project?rev=371020&view=rev Log: [dotest] Remove top-level Makefile This appears to be a really ancient way of running the test suite. It is also completely disfunctional now, and probably has bee

[Lldb-commits] [lldb] r371028 - [lldb][NFC] Stabilize gui/basic test by waiting on prompt

Author: teemperor Date: Thu Sep 5 01:45:20 2019 New Revision: 371028 URL: http://llvm.org/viewvc/llvm-project?rev=371028&view=rev Log: [lldb][NFC] Stabilize gui/basic test by waiting on prompt We should wait on the GUI to exit before tearing down the test. Modified: lldb/trunk/packages/Pyth

[Lldb-commits] [PATCH] D66994: [lldb][CMake] Fix windows-x86-debug compilation with python enabled using multi-target generator

leonid.mashinskiy updated this revision to Diff 218877. leonid.mashinskiy added a comment. Extracted python lookup logic into function Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66994/new/ https://reviews.llvm.org/D66994 Files: cmake/modules/LLDBConfig.cm

[Lldb-commits] [PATCH] D66994: [lldb][CMake] Fix windows-x86-debug compilation with python enabled using multi-target generator

labath added a comment. Thanks. The new version seems fine to me. I'll leave it for the windows folks to have the final say on this.. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66994/new/ https://reviews.llvm.org/D66994 __

[Lldb-commits] [PATCH] D67022: Enhance SymbolFileDWARF::ParseDeclsForContext performance

labath added a comment. Thanks. The code looks fine to me. Losing the ability to unit test is a bit of a pity, but since test was pretty icky to begin with, I can't say I'm going to miss it too much... One way we could possibly test this is with a full scale test via the "target modules dump as

[Lldb-commits] [PATCH] D67222: [Windows] Added support of watchpoints to `NativeProcessWindows`

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: asmith, amccarth, stella.stamenova. aleksandr.urakov added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere, jfb. This patch adds support of watchpoints to the new `NativeProcessWindows` plugin. The sam

[Lldb-commits] [PATCH] D67168: [Windows] Add support of watchpoints to `ProcessWindows`

aleksandr.urakov updated this revision to Diff 218897. aleksandr.urakov added a comment. Determine whether 8-byte watchpoints are supported or not statically. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67168/new/ https://reviews.llvm.org/D67168 Files: ll

[Lldb-commits] [PATCH] D67168: [Windows] Add support of watchpoints to `ProcessWindows`

aleksandr.urakov marked 3 inline comments as done. aleksandr.urakov added inline comments. Comment at: lldb/source/Plugins/Process/Windows/Common/RegisterContextWindows.cpp:82 -bool RegisterContextWindows::ClearHardwareBreakpoint(uint32_t hw_idx) { - return false; -} + if (!

[Lldb-commits] [lldb] r371077 - [lldb][NFC] Add dimensions to pexpect tests failing on sanitizer bot

Author: teemperor Date: Thu Sep 5 07:51:23 2019 New Revision: 371077 URL: http://llvm.org/viewvc/llvm-project?rev=371077&view=rev Log: [lldb][NFC] Add dimensions to pexpect tests failing on sanitizer bot I'm still unable to reproduce this locally, so let's see if this is enough to make the bots

[Lldb-commits] [PATCH] D67227: [lldb] Extend and document TestIRInterpreter.py

teemperor created this revision. teemperor added a reviewer: davide. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. There are a bunch of arithmetic and comparison instructions supported by the IRInterpreter and we currently don't test these at all in the test

[Lldb-commits] [PATCH] D66994: [lldb][CMake] Fix windows-x86-debug compilation with python enabled using multi-target generator

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. Thanks for factoring out the duplication. Fingers crossed. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66994/new/ https://reviews.llvm.org/D66994 _

[Lldb-commits] [PATCH] D66994: [lldb][CMake] Fix windows-x86-debug compilation with python enabled using multi-target generator

leonid.mashinskiy added a comment. Thanks for the review! Can somebody commit this please because I don't have commit access? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66994/new/ https://reviews.llvm.org/D66994 __

[Lldb-commits] [PATCH] D67227: [lldb] Extend and document TestIRInterpreter.py

shafik added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/commands/expression/ir-interpreter/TestIRInterpreter.py:54 +# Shifting longer than size of a type also doesn't work. +if rhs.value <= 0 or rhs.value >= 7: +

[Lldb-commits] [PATCH] D66994: [lldb][CMake] Fix windows-x86-debug compilation with python enabled using multi-target generator

amccarth added a comment. Yes, I can commit it for you soon. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66994/new/ https://reviews.llvm.org/D66994 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [PATCH] D67230: Remove call to obsolete gethostbyname, using getaddrinfo

serge-sans-paille created this revision. serge-sans-paille added a reviewer: k8stone. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. >From the man page: > The gethostbyname*() and gethostbyaddr*() functions are obsolete. > Applications should use getaddrinfo(3) and

[Lldb-commits] [lldb] r371090 - Fix windows-x86-debug compilation with python enabled using multi-target generator

Author: amccarth Date: Thu Sep 5 10:22:30 2019 New Revision: 371090 URL: http://llvm.org/viewvc/llvm-project?rev=371090&view=rev Log: Fix windows-x86-debug compilation with python enabled using multi-target generator [Patch by Leonid Mashinskiy] Visual Studio CMake generator is multi-target an

[Lldb-commits] [PATCH] D66994: [lldb][CMake] Fix windows-x86-debug compilation with python enabled using multi-target generator

This revision was automatically updated to reflect the committed changes. Closed by commit rL371090: Fix windows-x86-debug compilation with python enabled using multi-target… (authored by amccarth, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prio

[Lldb-commits] [PATCH] D67227: [lldb] Extend and document TestIRInterpreter.py

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/commands/expression/ir-interpreter/TestIRInterpreter.py:54 +# Shifting longer than size of a type also doesn't work. +if r

[Lldb-commits] [PATCH] D67022: Enhance SymbolFileDWARF::ParseDeclsForContext performance

guiandrade added a comment. In D67022#1659155 , @labath wrote: > Thanks. The code looks fine to me. Losing the ability to unit test is a bit > of a pity, but since test was pretty icky to begin with, I can't say I'm > going to miss it too much... > One

[Lldb-commits] [PATCH] D65469: Remove `bugreport` command

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. We don't need to keep this command around. It was originated by Tamas in 2015, https://reviews.llvm.org/D10868 but never got used for anything - Tamas was working on unwind things b

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Make the RedirectingFileSystem hold on to its own working directory.

JDevlieghere updated this revision to Diff 218979. JDevlieghere added a comment. Thanks for the feedback, Pavel. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65677/new/ https://reviews.llvm.org/D65677 Files: llvm/include/llvm/Support/VirtualFileSystem.h llvm/lib/Support/VirtualFil

[Lldb-commits] [PATCH] D67227: [lldb] Extend and document TestIRInterpreter.py

shafik added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/commands/expression/ir-interpreter/TestIRInterpreter.py:54 +# Shifting longer than size of a type also doesn't work. +if rhs.value <= 0 or rhs.value >= 7: +

[Lldb-commits] [PATCH] D67239: [Core] Remove use of ClangASTContext in DumpDataExtractor

xiaobai created this revision. xiaobai added reviewers: clayborg, JDevlieghere, jingham. Herald added a project: LLDB. DumpDataExtractor uses ClangASTContext in order to get the proper llvm fltSemantics for the type it needs so that it can dump floats in a more precise way. However, there's no rea

[Lldb-commits] [lldb] r371132 - Remove `bugreport` command

Author: jdevlieghere Date: Thu Sep 5 14:43:32 2019 New Revision: 371132 URL: http://llvm.org/viewvc/llvm-project?rev=371132&view=rev Log: Remove `bugreport` command The bugreport command exists to create domain-specific bug reports. Currently it has one implementation for filing bugs on the unwi

[Lldb-commits] [PATCH] D65469: Remove `bugreport` command

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5687d7c1257: Remove `bugreport` command (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D65469?vs=212406&id=218989#toc Repository: rG LLVM Github Monorepo CHANGES SINC

[Lldb-commits] [PATCH] D66638: Unwind: Add a stack scanning mechanism to support win32 unwinding

amccarth added a comment. I don't have any specific code comments, but I do have a couple general questions and points to consider. 1. `isFoundHeuristically` is very generic. It's true that it's a heuristic approach, but it's a very specific heuristic. Might there be other heuristic approach

[Lldb-commits] [PATCH] D67239: [Core] Remove use of ClangASTContext in DumpDataExtractor

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Looks like a good improvement. Does the `APFloatBase::Bogus` result of `GetFloatTypeSemantics` affect the functional behavior of the `DumpDataExtractor ` or does `GetAPInt` just re

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Make the RedirectingFileSystem hold on to its own working directory.

vsapsai added a subscriber: Bigcheese. vsapsai added a comment. Adding Michael Spencer as he was doing some work for a working directory in VFS. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65677/new/ https://reviews.llvm.org/D65677 ___ ll

[Lldb-commits] [PATCH] D67168: [Windows] Add support of watchpoints to `ProcessWindows`

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. Thanks for the changes! I think this looks good now. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67168/new/ https://reviews.llvm.org/D67168 ___

[Lldb-commits] [PATCH] D67239: [Core] Remove use of ClangASTContext in DumpDataExtractor

xiaobai added a comment. Hmm, good question. If you call `GetAPInt` with a `byte_size` of 0, it should assert when trying to read 0 bytes with the `DataExtractor`. In the worst case, it gives you a broken APInt. I think guarded the call to `GetAPInt` to protect against this, but I think that it

[Lldb-commits] [lldb] r371144 - [Reproducer] Add a `cont` to ModuleCXX.test

Author: jdevlieghere Date: Thu Sep 5 16:36:57 2019 New Revision: 371144 URL: http://llvm.org/viewvc/llvm-project?rev=371144&view=rev Log: [Reproducer] Add a `cont` to ModuleCXX.test On more than one occasion I've found this test got stuck during replay while waiting for a packet from debugserver

[Lldb-commits] [lldb] r371166 - [Windows] Add support of watchpoints to `ProcessWindows`

Author: aleksandr.urakov Date: Thu Sep 5 22:37:03 2019 New Revision: 371166 URL: http://llvm.org/viewvc/llvm-project?rev=371166&view=rev Log: [Windows] Add support of watchpoints to `ProcessWindows` Summary: This patch adds support of watchpoints to the old `ProcessWindows` plugin. The `Process

[Lldb-commits] [PATCH] D67168: [Windows] Add support of watchpoints to `ProcessWindows`

aleksandr.urakov added a comment. Thanks all! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67168/new/ https://reviews.llvm.org/D67168 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [PATCH] D67168: [Windows] Add support of watchpoints to `ProcessWindows`

This revision was automatically updated to reflect the committed changes. Closed by commit rL371166: [Windows] Add support of watchpoints to `ProcessWindows` (authored by aleksandr.urakov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm