[Lldb-commits] [PATCH] D66654: Prevent D66398 `TestDataFormatterStdList`-like regressions in the future

jankratochvil marked 5 inline comments as done. jankratochvil added a comment. In D66654#1643082 , @JDevlieghere wrote: > How much work would it be to return an `llvm::Expected` from > `Get_Impl`? I'd really prefer that over the current approach. Done.

[Lldb-commits] [PATCH] D66654: Prevent D66398 `TestDataFormatterStdList`-like regressions in the future

jankratochvil updated this revision to Diff 217052. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66654/new/ https://reviews.llvm.org/D66654 Files: lldb/include/lldb/Core/ValueObject.h lldb/include/lldb/DataFormatters/FormatClasses.h lldb/include/lldb/Data

[Lldb-commits] [PATCH] D66654: Prevent D66398 `TestDataFormatterStdList`-like regressions in the future

jankratochvil updated this revision to Diff 217053. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66654/new/ https://reviews.llvm.org/D66654 Files: lldb/include/lldb/Core/ValueObject.h lldb/include/lldb/DataFormatters/FormatClasses.h lldb/include/lldb/Data

[Lldb-commits] [PATCH] D66654: Prevent D66398 `TestDataFormatterStdList`-like regressions in the future

jankratochvil updated this revision to Diff 217079. jankratochvil added a comment. Testcase for the regex sanity check is failing - `ValueObject::m_error` remains set even after `type summary clear`. `ValueObject::UpdateValueIfNeeded` will find `did_change_formats==true` but it does not help it.

[Lldb-commits] [PATCH] D66634: Postfix: move more code out of the PDB plugin

aleksandr.urakov accepted this revision. aleksandr.urakov added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:58 llvm::BumpPtrAllocator