[Lldb-commits] [lldb] r369235 - [lldb] Remove unused inheritance in RegularExpression

Author: jankratochvil Date: Mon Aug 19 00:06:56 2019 New Revision: 369235 URL: http://llvm.org/viewvc/llvm-project?rev=369235&view=rev Log: [lldb] Remove unused inheritance in RegularExpression D66174 left inherited llvm::Regex which is now a member variable there. Approved as a part of: https:/

[Lldb-commits] [lldb] r369237 - [lldb][NFC] Address review comments to StringList for-loop support

Author: teemperor Date: Mon Aug 19 00:22:19 2019 New Revision: 369237 URL: http://llvm.org/viewvc/llvm-project?rev=369237&view=rev Log: [lldb][NFC] Address review comments to StringList for-loop support Modified: lldb/trunk/include/lldb/Utility/StringList.h lldb/trunk/source/Commands/Comm

[Lldb-commits] [PATCH] D60963: Fix dereferencing null pointer

kwk marked an inline comment as done. kwk added inline comments. Comment at: llvm/lib/Demangle/MicrosoftDemangle.cpp:737 TagTypeNode *Demangler::parseTagUniqueName(StringView &MangledName) { + if (!MangledName.consumeFront(".?A")) { thakis wrote: > kwk wrote:

[Lldb-commits] [PATCH] D66345: [lldb][NFC] Allow for-range iterating over StringList

teemperor closed this revision. teemperor marked 5 inline comments as done. teemperor added a comment. In D66345#1633172 , @labath wrote: > In D66345#1633118 , @teemperor wrote: > > > Not sure if we can get rid of S

[Lldb-commits] [lldb] r369240 - [lldb][NFC] Use GetMaxStringLength in CommandObjectApropos::DoExecute

Author: teemperor Date: Mon Aug 19 00:59:44 2019 New Revision: 369240 URL: http://llvm.org/viewvc/llvm-project?rev=369240&view=rev Log: [lldb][NFC] Use GetMaxStringLength in CommandObjectApropos::DoExecute Modified: lldb/trunk/source/Commands/CommandObjectApropos.cpp Modified: lldb/trunk/sou

[Lldb-commits] [lldb] r369242 - [lldb][NFC] Remove StringList::AutoComplete

Author: teemperor Date: Mon Aug 19 01:15:46 2019 New Revision: 369242 URL: http://llvm.org/viewvc/llvm-project?rev=369242&view=rev Log: [lldb][NFC] Remove StringList::AutoComplete We don't need this very specific function in StringList that we only call once in LLDB. Modified: lldb/trunk/inc

[Lldb-commits] [lldb] r369249 - [lldb][NFC] Add a few more completion tests to increase test coverage

Author: teemperor Date: Mon Aug 19 03:46:38 2019 New Revision: 369249 URL: http://llvm.org/viewvc/llvm-project?rev=369249&view=rev Log: [lldb][NFC] Add a few more completion tests to increase test coverage These tests are mostly trying to reach the different completion functions in CommandComplet

[Lldb-commits] [lldb] r369252 - [lldb][NFC] Use CompletionRequest in Variable::AutoComplete

Author: teemperor Date: Mon Aug 19 04:49:43 2019 New Revision: 369252 URL: http://llvm.org/viewvc/llvm-project?rev=369252&view=rev Log: [lldb][NFC] Use CompletionRequest in Variable::AutoComplete Modified: lldb/trunk/source/Symbol/Variable.cpp Modified: lldb/trunk/source/Symbol/Variable.cpp

[Lldb-commits] [PATCH] D66370: [dotest] Add a dotest flag `--force-dwarf` to override the tested DWARF version.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This looks fine to me. We spoke about this on irc, but I'll just repeat what I said here for the record. Running the dotest tests with different compilers/architectures/dwarf versions/etc. is

[Lldb-commits] [PATCH] D66345: [lldb][NFC] Allow for-range iterating over StringList

labath added a comment. In D66345#1634800 , @teemperor wrote: > In D66345#1633172 , @labath wrote: > > > In D66345#1633118 , @teemperor > > wrote: > > > > > Not sure if we c

[Lldb-commits] [PATCH] D66357: Fix GetDIEForDeclContext so it only returns entries matching the provided context

clayborg added a comment. In D66357#1634175 , @guiandrade wrote: > In D66357#1633461 , @clayborg wrote: > > > Needs a test, but looks good. > > > Sure, I agree. Though, it's not total clear to me how we could do tha

[Lldb-commits] [PATCH] D66345: [lldb][NFC] Allow for-range iterating over StringList

clayborg added a comment. The other thing to think about is the SB layer must be thread safe. StringList is not thread safe right now, but it probably should be. We might need to keep the internal version of StringList and make sure it is thread safe. That will ensure that our buildbots always

[Lldb-commits] [PATCH] D66392: 1/2: D66174 `RegularExpression` cleanup

jankratochvil updated this revision to Diff 215890. jankratochvil retitled this revision from "1/2: D66174 `RegularExpression` follow-up/cleanup" to "1/2: D66174 `RegularExpression` cleanup". jankratochvil added a comment. In D66392#1634575 , @JDevlieghere

[Lldb-commits] [PATCH] D66357: Fix GetDIEForDeclContext so it only returns entries matching the provided context

labath added a comment. If you're in a position to control how the class gets created, you can just make a new test class which inherits from `DWARFASTParserClang` and increases the visibility of that method. (Though I am somewhat doubtful you'll be able to construct this class without any of t

[Lldb-commits] [PATCH] D66398: 2/2: Fix `TestDataFormatterStdList` regression

jankratochvil updated this revision to Diff 215895. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66398/new/ https://reviews.llvm.org/D66398 Files: lldb/include/lldb/Breakpoint/BreakpointResolverName.h lldb/include/lldb/DataFormatters/FormattersContainer.h

[Lldb-commits] [PATCH] D66392: 1/2: D66174 `RegularExpression` cleanup

jankratochvil added a comment. In D66392#1634575 , @JDevlieghere wrote: > I am aware the `llvm/` part of this patch needs an extra approval and this is > why @jdevlieghere had there that: > > std::string discarded; > return m_regex.isValid(discarded)

[Lldb-commits] [PATCH] D66392: 1/2: D66174 `RegularExpression` cleanup

jankratochvil updated this revision to Diff 215897. jankratochvil added a comment. (comment typo fixed) Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66392/new/ https://reviews.llvm.org/D66392 Files: lldb/include/lldb/Interpreter/OptionValueRegex.h lldb/in

[Lldb-commits] [lldb] r369267 - [lldb][NFC] Stop using GetNumberOfMatches in CompletionRequest test

Author: teemperor Date: Mon Aug 19 07:52:48 2019 New Revision: 369267 URL: http://llvm.org/viewvc/llvm-project?rev=369267&view=rev Log: [lldb][NFC] Stop using GetNumberOfMatches in CompletionRequest test This function is just a wrapper for GetNumberOfResults and will be removed soon. This patch j

[Lldb-commits] [PATCH] D66392: 1/2: D66174 `RegularExpression` cleanup

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I agree that it is better to have just one way to initialize the regex object. This looks good to me modulo the llvm parts. I'd suggest just dropping those, or creating a separate patch for th

[Lldb-commits] [PATCH] D66398: 2/2: Fix `TestDataFormatterStdList` regression

jankratochvil added a comment. From IRC: In fact the whole patch is a oneliner (+`operator<` for `RegularExpression.h`): - typedef FormattersContainer RegexMatchContainer; + typedef FormattersContainer RegexMatchContainer; The rest of the patch is just a mechanical update to make it comp

[Lldb-commits] [PATCH] D66398: 2/2: Fix `TestDataFormatterStdList` regression

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I very much support getting rid of shared pointers, and for this is I am inclined to accept this. However, I don't think it was ever really intended to use the sorting order of the regex text

[Lldb-commits] [PATCH] D66392: 1/2: D66174 `RegularExpression` cleanup

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks, Jan. This LGTM with Pavel's comments addressed. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66392/new/ https://reviews.llvm.org/D66392 __

[Lldb-commits] [lldb] r369272 - [dotest] Add --dwarf-version to override the tested DWARF version.

Author: jdevlieghere Date: Mon Aug 19 09:04:21 2019 New Revision: 369272 URL: http://llvm.org/viewvc/llvm-project?rev=369272&view=rev Log: [dotest] Add --dwarf-version to override the tested DWARF version. On the matrix bot on GreenDragon [1] we want to run the test suite against different DWARF

[Lldb-commits] [PATCH] D66370: [dotest] Add a dotest flag `--force-dwarf` to override the tested DWARF version.

This revision was automatically updated to reflect the committed changes. Closed by commit rL369272: [dotest] Add --dwarf-version to override the tested DWARF version. (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior t

[Lldb-commits] [PATCH] D66345: [lldb][NFC] Allow for-range iterating over StringList

jingham added a comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66345/new/ https://reviews.llvm.org/D66345 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D66429: [CMake] Remove LLDB_TEST_USE_CUSTOM_C(XX)_COMPILER

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added subscribers: teemperor, mgorny. Herald added a project: LLDB. Given that `LLDB_TEST_USE_CUSTOM_C_COMPILER` and `LLDB_TEST_C_COMPILER` are both set at configuration time, I don't really see the point of having th

[Lldb-commits] [lldb] r369293 - [lldb] Make TestIOHandlerCompletion more stable and document it

Author: teemperor Date: Mon Aug 19 12:13:26 2019 New Revision: 369293 URL: http://llvm.org/viewvc/llvm-project?rev=369293&view=rev Log: [lldb] Make TestIOHandlerCompletion more stable and document it Instead of relying that three tabs show all completions, we should show all remaining completions

[Lldb-commits] [PATCH] D66357: Fix GetDIEForDeclContext so it only returns entries matching the provided context

guiandrade updated this revision to Diff 215966. guiandrade added a comment. Herald added a subscriber: mgorny. I tried to write a unit test following @labath's suggestion of creating a test class that inherits from `DWARFASTParserClang`. Please let me know what you guys think. Thanks! Reposi

[Lldb-commits] [lldb] r369296 - [lldb-vscode] add `launchCommands` to handle launch specific commands

Author: xiaobai Date: Mon Aug 19 13:17:27 2019 New Revision: 369296 URL: http://llvm.org/viewvc/llvm-project?rev=369296&view=rev Log: [lldb-vscode] add `launchCommands` to handle launch specific commands Summary: This can help `lldb-vscode` handle launch commands associate with remote platform a

[Lldb-commits] [PATCH] D65363: [lldb-vscode] add `launchCommands` to handle launch specific commands

This revision was automatically updated to reflect the committed changes. Closed by commit rL369296: [lldb-vscode] add `launchCommands` to handle launch specific commands (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [PATCH] D66357: Fix GetDIEForDeclContext so it only returns entries matching the provided context

clayborg added a comment. Pavel, any comments on the testing code? LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66357/new/ https://reviews.llvm.org/D66357 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D66442: Fix use-after-free

mgehre created this revision. mgehre added reviewers: jingham, JDevlieghere. Herald added a project: LLDB. The warning lldb/source/Core/FormatEntity.cpp:2350:25: warning: object backing the pointer will be destroyed at the end of the full-expression [-Wdangling] is emitted after annotating `l

[Lldb-commits] [PATCH] D66442: Fix use-after-free

This revision was automatically updated to reflect the committed changes. Closed by commit rL369304: Fix use-after-free (authored by mgehre, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D66442?vs=215985&

[Lldb-commits] [PATCH] D66445: Explicitly Cast Constants to DWORD

jmittert created this revision. jmittert added reviewers: xiaobai, labath, JDevlieghere, asmith. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. STATUS_SINGLE_STEP and STATUS_BREAKPOINT are defined as 0x8-- which is negative and thus can't be implicitly narrowed to a DWO

[Lldb-commits] [PATCH] D66447: Add char8_t support (C++20)

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added a subscriber: teemperor. Herald added a project: LLDB. This patch adds support for C++20 char8_t, as well as dlang's char/wchar/dchar types. Original patch by James Blachly, modified by me. Repository: rLLD

[Lldb-commits] [PATCH] D66447: Add char8_t support (C++20)

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lang/cpp/char8_t/TestCxxChar8_t.py:26 + +@skipIf(compiler="clang", compiler_version=['<', '5.0']) +def test(self): This sho

[Lldb-commits] [PATCH] D66447: Add char8_t support (C++20)

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/include/lldb/lldb-enumerations.h:170 // etc... + eFormatUnicode8, eFormatUnicode16, add to the end,

[Lldb-commits] [PATCH] D66448: Include "windows" Instead of "Windows"

gmittert created this revision. gmittert added reviewers: xiaobai, JDevlieghere, labath, asmith. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The actual include directory is `lldb/Host/windows` not `lldb/Host/Windows` which breaks on case sensitive file systems Reposito

[Lldb-commits] [PATCH] D66448: Include "windows" Instead of "Windows"

xiaobai accepted this revision. xiaobai added a comment. Case-sensitive filesystems lol Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66448/new/ https://reviews.llvm.org/D66448 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [lldb] r369307 - Windows: Include "windows" Instead of "Windows"

Author: compnerd Date: Mon Aug 19 15:45:01 2019 New Revision: 369307 URL: http://llvm.org/viewvc/llvm-project?rev=369307&view=rev Log: Windows: Include "windows" Instead of "Windows" The actual include directory is lldb/Host/windows not lldb/Host/Windows which breaks on case sensitive file system

[Lldb-commits] [PATCH] D66447: Add char8_t support (C++20)

JDevlieghere updated this revision to Diff 216008. JDevlieghere added a comment. - Feedback Greg. - Remove dlang types. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66447/new/ https://reviews.llvm.org/D66447 Files: lldb/include/lldb/lldb-enumerations.h lldb/packages/Python/lldbsui

[Lldb-commits] [PATCH] D66448: Include "windows" Instead of "Windows"

compnerd closed this revision. compnerd added a comment. SVN r369307 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66448/new/ https://reviews.llvm.org/D66448 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [PATCH] D66248: [JIT][Command] Add "inject-condition" flag to conditional breakpoints

mib marked 18 inline comments as done. mib added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/fast_conditional_breakpoints/TestFastConditionalBreakpoints.py:51 +if cli == True: +lldbutil.run_break_set_by_source_r

[Lldb-commits] [PATCH] D66451: [ClangExpressionParser] Add ClangDeclVendor

xiaobai created this revision. xiaobai added reviewers: JDevlieghere, clayborg, jingham, labath. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: LLDB. This introduces a layer between DeclVendor and the currently implemented DeclVendors (ClangM

[Lldb-commits] [PATCH] D66248: [JIT][Command] Add "inject-condition" flag to conditional breakpoints

mib updated this revision to Diff 216014. mib marked an inline comment as done. mib added a comment. Moved NFC changes to separate patch. Updated test to suit LLVM's style. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66248/new/ https://reviews.l

[Lldb-commits] [PATCH] D66452: [lldb] Fix typo on the BreakpointLocation header and the lldbtest.py (NFC)

mib created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This commit fixes some typo I found while exploring LLDB's codebase. Signed-off-by: Med Ismail Bennani Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66452 Files: lldb/include

[Lldb-commits] [PATCH] D66452: [lldb] Fix typo on the BreakpointLocation header and the lldbtest.py (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks, Ismail. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66452/new/ https://reviews.llvm.org/D66452 __

[Lldb-commits] [PATCH] D66451: [ClangExpressionParser] Add ClangDeclVendor

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Symbol/DeclVendor.h:27 +eAppleObjCDeclVendor, +eLastClangDeclVendor, + }; What's `eLastClangDeclVendor` and where is it used? Comment at: lldb/source/Plugins/ExpressionP

[Lldb-commits] [PATCH] D66451: [ClangExpressionParser] Add ClangDeclVendor

xiaobai marked an inline comment as done. xiaobai added inline comments. Comment at: lldb/include/lldb/Symbol/DeclVendor.h:27 +eAppleObjCDeclVendor, +eLastClangDeclVendor, + }; JDevlieghere wrote: > What's `eLastClangDeclVendor` and where is it used? Fol

[Lldb-commits] [PATCH] D66453: Make the FindTypes(std::vector, ...) API testable in lldb-test

aprantl created this revision. aprantl added reviewers: jasonmolenda, JDevlieghere, labath, clayborg. I'm planning to modify this API shortly and thought best to first make it independently testable. This adds a -compiler-context=<...> option to lldb-test that translates a JSON-formatted string

[Lldb-commits] [PATCH] D66452: [lldb] Fix typo on the BreakpointLocation header and the lldbtest.py (NFC)

mib updated this revision to Diff 216022. mib added a comment. updated version of the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66452/new/ https://reviews.llvm.org/D66452 Files: lldb/include/lldb/Breakpoint/BreakpointLocation.h lldb

[Lldb-commits] [PATCH] D66452: [lldb] Fix typo on the BreakpointLocation header and the lldbtest.py (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rL369313: [lldb] Fix typo on the BreakpointLocation header and the lldbtest.py (NFC) (authored by mib, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [PATCH] D66453: Make the FindTypes(std::vector, ...) API testable in lldb-test

JDevlieghere added inline comments. Comment at: lldb/tools/lldb-test/lldb-test.cpp:145 +"compiler-context", +cl::desc("Specify a compiler context as \"[(type,name),...]\"."), +cl::value_desc("context"), cl::sub(SymbolsSubcommand)); > ...as a JSON arra

[Lldb-commits] [PATCH] D66453: Make the FindTypes(std::vector, ...) API testable in lldb-test

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: lldb/tools/lldb-test/lldb-test.cpp:145 +"compiler-context", +cl::desc("Specify a compiler context as \"[(type,name),...]\"."), +cl::value_desc("context"), cl::sub(SymbolsSubcommand));

[Lldb-commits] [PATCH] D66451: [ClangExpressionParser] Add ClangDeclVendor

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Symbol/DeclVendor.h:27 +eAppleObjCDeclVendor, +eLastClangDeclVendor, + }; xiaobai wrote: > JDevlieghere wrote: > > What's `eLastClangDeclVendor` and where is it used? > Following the advic

[Lldb-commits] [PATCH] D66453: Make the FindTypes(std::vector, ...) API testable in lldb-test

JDevlieghere added inline comments. Comment at: lldb/tools/lldb-test/lldb-test.cpp:145 +"compiler-context", +cl::desc("Specify a compiler context as \"[(type,name),...]\"."), +cl::value_desc("context"), cl::sub(SymbolsSubcommand)); aprantl wrote: > JD

[Lldb-commits] [PATCH] D66447: Add char8_t support (C++20)

jblachly added a comment. Thank you for creating a revision and reviewing this. I made inline comments on the test harness and Dlang types / qualifiers. With removal of the Dlang types, where is the appropriate place to put them? It is not clear to me whether language plugins can replace the fun