[Lldb-commits] [lldb] r368975 - [lldb] Let LLDB depend on intrinsics_gen to fix non-deterministic module build failures

Author: teemperor Date: Thu Aug 15 00:29:53 2019 New Revision: 368975 URL: http://llvm.org/viewvc/llvm-project?rev=368975&view=rev Log: [lldb] Let LLDB depend on intrinsics_gen to fix non-deterministic module build failures Summary: When building with modules we currently fail randomly to build

[Lldb-commits] [PATCH] D66208: [lldb] Let LLDB depend on intrinsics_gen to fix non-deterministic module build failures

This revision was automatically updated to reflect the committed changes. Closed by commit rL368975: [lldb] Let LLDB depend on intrinsics_gen to fix non-deterministic module build… (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chang

[Lldb-commits] [PATCH] D66174: [Utility] Reimplement RegularExpression on top of llvm::Regex

labath added a comment. I was unhappy with the `()` workaround, so I did some investigation. Now, I am even more unhappy, but at least better educated. :P Basically, what I've learned is that according to POSIX https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap09.html an empty s

[Lldb-commits] [PATCH] D66250: [JIT][Unwinder] Add Trampoline ObjectFile and UnwindPlan support for FCB

labath added a comment. I have one high-level question. Who is generating the code inside the "trampoline" object file? Couldn't we have him generate proper unwind information so that the regular unwind machinery "just works"? I imagine all it would take is a couple of well-placed `.cfi` assemb

[Lldb-commits] [PATCH] D66249: [JIT][Breakpoint] Add "BreakpointInjectedSite" and FCB Trampoline

labath added a comment. I didn't go into all the details of this patch, as I am guessing this will still go through a number of revisions, but I did make a couple notes of things that caught my eye while glancing over it. Comment at: lldb/include/lldb/Breakpoint/BreakpointInj

[Lldb-commits] [lldb] r369000 - [lldb][NFC] Refactor remaining completion logic to use CompletionRequests

Author: teemperor Date: Thu Aug 15 06:14:10 2019 New Revision: 369000 URL: http://llvm.org/viewvc/llvm-project?rev=369000&view=rev Log: [lldb][NFC] Refactor remaining completion logic to use CompletionRequests This patch moves the remaining completion functions from the old completion API (that u

[Lldb-commits] [PATCH] D66241: stop-hooks don't fire on "step-out"

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Better. Might be good to put a comment inside CalculatePublicStopInfo() regarding why the "SetStopInfo(GetStopInfo());" is needed. Seems like you could just remove the code from the sight

[Lldb-commits] [PATCH] D66174: [Utility] Reimplement RegularExpression on top of llvm::Regex

JDevlieghere added a comment. In D66174#1631055 , @labath wrote: > I was unhappy with the `()` workaround, so I did some investigation. Now, I > am even more unhappy, but at least better educated. :P > > Basically, what I've learned is that according to P

[Lldb-commits] [PATCH] D66248: [JIT][Command] Add "inject-condition" flag to conditional breakpoints

shafik added inline comments. Comment at: lldb/include/lldb/Breakpoint/BreakpointOptions.h:120 + /// BreakpointOptions(const char *condition, bool enabled = true, int32_t ignore = 0, bool one_shot = false, You have a lot of `bool` paramet

[Lldb-commits] [lldb] r369034 - Change test to use uint64_t to support compiling for 32-bit architectures.

Author: adrian Date: Thu Aug 15 11:37:11 2019 New Revision: 369034 URL: http://llvm.org/viewvc/llvm-project?rev=369034&view=rev Log: Change test to use uint64_t to support compiling for 32-bit architectures. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/bitfields/main.c Modified

[Lldb-commits] [PATCH] D66241: stop-hooks don't fire on "step-out"

jingham added a comment. In D66241#1631426 , @clayborg wrote: > Better. Might be good to put a comment inside CalculatePublicStopInfo() > regarding why the "SetStopInfo(GetStopInfo());" is needed. Seems like you > could just remove the code from the sigh

[Lldb-commits] [lldb] r369052 - Stop-hooks weren't getting called on step-out. Fix that.

Author: jingham Date: Thu Aug 15 14:37:52 2019 New Revision: 369052 URL: http://llvm.org/viewvc/llvm-project?rev=369052&view=rev Log: Stop-hooks weren't getting called on step-out. Fix that. There was a little bit of logic in the StopInfoBreakpoint::PerformAction that would null out the StopInfo

[Lldb-commits] [PATCH] D66241: stop-hooks don't fire on "step-out"

This revision was automatically updated to reflect the committed changes. Closed by commit rL369052: Stop-hooks weren't getting called on step-out. Fix that. (authored by jingham, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: htt

[Lldb-commits] [PATCH] D66250: [JIT][Unwinder] Add Trampoline ObjectFile and UnwindPlan support for FCB

jasonmolenda added a comment. In D66250#1631200 , @labath wrote: > I have one high-level question. Who is generating the code inside the > "trampoline" object file? Couldn't we have him generate proper unwind > information so that the regular unwind mach

[Lldb-commits] [lldb] r369072 - [DebugLine] Don't try to guess the path style

Author: jdevlieghere Date: Thu Aug 15 16:53:15 2019 New Revision: 369072 URL: http://llvm.org/viewvc/llvm-project?rev=369072&view=rev Log: [DebugLine] Don't try to guess the path style In r368879 I made an attempt to guess the path style from the files in the line table. After some consideration

[Lldb-commits] [PATCH] D66327: [dotest] Make it possible to forward CCC_OVERRIDE_OPTIONS to Make

JDevlieghere created this revision. JDevlieghere added reviewers: labath, aprantl, davide. Herald added a project: LLDB. Setting `CCC_OVERRIDE_OPTIONS ` is a powerful way to change the behavior of the compiler. It's especially convenient for modifying how we build test inferiors. However, this i

[Lldb-commits] [PATCH] D66331: Save / restore selected platform in tests that may change it

jasonmolenda created this revision. jasonmolenda added a reviewer: labath. Herald added a subscriber: abidh. Herald added a project: LLDB. Running the testsuite against an iOS device, it seems like I can lose the remote platform when certain tests run (and running in single-threaded mode aka no-

[Lldb-commits] [lldb] r369083 - [lldb-server] Disable a test on Windows until it can be fixed

Author: asmith Date: Thu Aug 15 20:49:41 2019 New Revision: 369083 URL: http://llvm.org/viewvc/llvm-project?rev=369083&view=rev Log: [lldb-server] Disable a test on Windows until it can be fixed Modified: lldb/trunk/unittests/tools/lldb-server/tests/LLGSTest.cpp Modified: lldb/trunk/unittest