[Lldb-commits] [PATCH] D66174: [Utility] Reimplement RegularExpression on top of llvm::Regex

labath added a comment. Overall, I am very supportive of this, though I have some comments inline. The interface seems ok, though maybe you could add a couple of quick unit tests to show how the class is meant to be used. Comment at: lldb/source/Commands/CommandObjectBreakpoi

[Lldb-commits] [PATCH] D62570: Use LLVM's debug line parser in LLDB

labath added a comment. Thank you for working on this. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62570/new/ https://reviews.llvm.org/D62570 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [lldb] r368806 - [API] Have SBCommandReturnObject::GetOutput/Error return "" instead of nullptr

Author: labath Date: Wed Aug 14 01:11:20 2019 New Revision: 368806 URL: http://llvm.org/viewvc/llvm-project?rev=368806&view=rev Log: [API] Have SBCommandReturnObject::GetOutput/Error return "" instead of nullptr Summary: It seems this was an unintended side-effect of D26698. AFAICT, these functio

[Lldb-commits] [PATCH] D65739: [API] Have SBCommandReturnObject::GetOutput/Error return "" instead of nullptr

This revision was automatically updated to reflect the committed changes. Closed by commit rL368806: [API] Have SBCommandReturnObject::GetOutput/Error return "" instead of nullptr (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repositor

[Lldb-commits] [PATCH] D66208: [lldb] Let LLDB depend on intrinsics_gen to fix non-deterministic module build failures

teemperor created this revision. teemperor added reviewers: sgraenitz, aprantl, JDevlieghere. Herald added subscribers: lldb-commits, mgrang, kristof.beyls, javed.absar, mgorny. Herald added a project: LLDB. When building with modules we currently fail randomly to build LLDB's modules and get er

[Lldb-commits] [lldb] r368838 - Revert "Minidump/Windows: Fix module lookup"

Author: labath Date: Wed Aug 14 05:26:51 2019 New Revision: 368838 URL: http://llvm.org/viewvc/llvm-project?rev=368838&view=rev Log: Revert "Minidump/Windows: Fix module lookup" Although there is nothing wrong with this patch, the test added here uncovers a problem in other parts of the code whic

[Lldb-commits] [lldb] r368852 - Add missing SetID method to fix Windows build

Author: asmith Date: Wed Aug 14 06:49:52 2019 New Revision: 368852 URL: http://llvm.org/viewvc/llvm-project?rev=368852&view=rev Log: Add missing SetID method to fix Windows build Modified: lldb/trunk/include/lldb/Host/common/NativeProcessProtocol.h Modified: lldb/trunk/include/lldb/Host/comm

[Lldb-commits] [PATCH] D56233: [lldb-server] Add initial support for lldb-server on Windows

asmith abandoned this revision. asmith added a comment. This was split into separate patches and committed. No longer need this review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56233/new/ https://reviews.llvm.org/D56233 ___ lldb-commit

[Lldb-commits] [PATCH] D66208: [lldb] Let LLDB depend on intrinsics_gen to fix non-deterministic module build failures

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. Out of curiosity, do you know why we don't see this on the CMake bot on GreenDragon, which is a modules build? Is this so infrequent that I might have missed it? http://gre

[Lldb-commits] [PATCH] D66227: [DebugLine] Improve path handling.

JDevlieghere added a comment. This should fix the following two test failures on the Windows LLDB bot (http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja) LLDB :: SymbolFile/DWARF/debug-line-basic.s LLDB :: SymbolFile/DWARF/dir-separator-posix.s Unfortunately I don't have access to a

[Lldb-commits] [PATCH] D66227: [DebugLine] Improve path handling.

JDevlieghere created this revision. JDevlieghere added reviewers: labath, wolfgangp, stella.stamenova. Herald added subscribers: llvm-commits, hiraditya, aprantl. Herald added projects: LLDB, LLVM. JDevlieghere added a comment. This should fix the following two test failures on the Windows LLDB bo

[Lldb-commits] [lldb] r368872 - Add missing NativeProcessFactory for lldb-server on Windows

Author: asmith Date: Wed Aug 14 09:39:41 2019 New Revision: 368872 URL: http://llvm.org/viewvc/llvm-project?rev=368872&view=rev Log: Add missing NativeProcessFactory for lldb-server on Windows Modified: lldb/trunk/tools/lldb-server/lldb-gdbserver.cpp Modified: lldb/trunk/tools/lldb-server/ll

[Lldb-commits] [PATCH] D66227: [DebugLine] Improve path handling.

aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:183 + llvm::Optional style = FileSpec::GuessPathStyle(p); + return style ? *style : FileSpec::Style::native; +} you can just use llvm::Optional::getValueOr(FileS

[Lldb-commits] [PATCH] D66227: [DebugLine] Improve path handling.

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. LGTM with some minor details addressed, thanks! Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp:1044 +/// Guess the path style from the given absolute path. +stat

[Lldb-commits] [lldb] r368879 - [DebugLine] Improve path handling.

Author: jdevlieghere Date: Wed Aug 14 10:00:10 2019 New Revision: 368879 URL: http://llvm.org/viewvc/llvm-project?rev=368879&view=rev Log: [DebugLine] Improve path handling. After switching over LLDB's line table parser to libDebugInfo, we noticed two regressions on the Windows bot. The problem i

[Lldb-commits] [PATCH] D66227: [DebugLine] Improve path handling.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368879: [DebugLine] Improve path handling. (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D66227?vs=215142&id=215151#toc Repository: rL LLVM CHANGES SIN

[Lldb-commits] [PATCH] D66174: [Utility] Reimplement RegularExpression on top of llvm::Regex

xiaobai added a comment. I like the idea of using something from llvm instead of rolling our own. The code changes look relatively simple and straightforward, so that's good. Comment at: lldb/source/Commands/CommandObjectBreakpoint.cpp:685 RegularExpression regexp(m_o

[Lldb-commits] [PATCH] D66174: [Utility] Reimplement RegularExpression on top of llvm::Regex

jingham added a comment. I think we need to fix the behavior for "", other than that, this looks fine to me. Comment at: lldb/source/Host/common/Socket.cpp:287 + if (g_regex.Execute(host_and_port, &matches)) { +if (matches.size() >= 3) { + host_str = matches[1].str()

[Lldb-commits] [lldb] r368904 - [lldb][NFC] Remove unused function

Author: rupprecht Date: Wed Aug 14 12:31:56 2019 New Revision: 368904 URL: http://llvm.org/viewvc/llvm-project?rev=368904&view=rev Log: [lldb][NFC] Remove unused function Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp Modified: lldb/trunk/source/Plugins/SymbolFile/D

[Lldb-commits] [PATCH] D66241: stop-hooks don't fire on "step-out"

jingham created this revision. jingham added a reviewer: clayborg. Herald added subscribers: lldb-commits, abidh. Herald added a project: LLDB. Step hooks were not firing when you did a "step out". This was because, when a breakpoint's PerformAction observes that the breakpoint has completed a p

[Lldb-commits] [PATCH] D66241: stop-hooks don't fire on "step-out"

davide added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/stop-hooks/Makefile:4 +C_SOURCES := main.c +CFLAGS_EXTRAS += -std=c99 + Forgive my ignorance, but why you need this? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D66175: Improve anonymous class heuristic in ClangASTContext::CreateRecordType

shafik added a comment. @aprantl @teemperor Good catches, I have updated the review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66175/new/ https://reviews.llvm.org/D66175 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://

[Lldb-commits] [PATCH] D66175: Improve anonymous class heuristic in ClangASTContext::CreateRecordType

shafik updated this revision to Diff 215228. shafik marked 7 inline comments as done. shafik added a comment. Addressing comments: - Rewording comments - Moving test location - Adding test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66175/new/ https://reviews.llvm.org/D66175 Fi

[Lldb-commits] [PATCH] D66175: Improve anonymous class heuristic in ClangASTContext::CreateRecordType

aprantl added inline comments. Comment at: source/Symbol/ClangASTContext.cpp:1509 *ast, (TagDecl::TagKind)kind, decl_ctx, SourceLocation(), SourceLocation(), is_anonymous ? nullptr : &ast->Idents.get(name)); aprantl wrote: > `has_name ? &ast->Iden

[Lldb-commits] [PATCH] D66175: Improve anonymous class heuristic in ClangASTContext::CreateRecordType

aprantl added inline comments. Comment at: source/Symbol/ClangASTContext.cpp:1505 - bool is_anonymous = (!name) || (!name[0]); + bool has_name = (!name) || (!name[0]); aprantl wrote: > aprantl wrote: > > The condition needs to be reversed now to match the n

[Lldb-commits] [PATCH] D66175: Improve anonymous class heuristic in ClangASTContext::CreateRecordType

aprantl added inline comments. Comment at: source/Symbol/ClangASTContext.cpp:1505 - bool is_anonymous = (!name) || (!name[0]); + bool has_name = (!name) || (!name[0]); aprantl wrote: > The condition needs to be reversed now to match the new name. `bool has_

[Lldb-commits] [PATCH] D66175: Improve anonymous class heuristic in ClangASTContext::CreateRecordType

shafik updated this revision to Diff 215243. shafik marked 6 inline comments as done. shafik added a comment. Fixing `has_name` to better reflect the condition. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66175/new/ https://reviews.llvm.org/D66175 Files: packages/Python/lldbsuite/

[Lldb-commits] [lldb] r368920 - Revert "[lldb] Reinstate original guard variable check"

Author: teemperor Date: Wed Aug 14 14:21:14 2019 New Revision: 368920 URL: http://llvm.org/viewvc/llvm-project?rev=368920&view=rev Log: Revert "[lldb] Reinstate original guard variable check" It seems this breaks the following tests: lldb-Suite :: expression_command/call-function/TestCallUse

[Lldb-commits] [PATCH] D66241: stop-hooks don't fire on "step-out"

jingham marked an inline comment as done. jingham added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/stop-hooks/Makefile:4 +C_SOURCES := main.c +CFLAGS_EXTRAS += -std=c99 + davide wrote: > Forgive my ignorance, but why you need this

[Lldb-commits] [PATCH] D66174: [Utility] Reimplement RegularExpression on top of llvm::Regex

JDevlieghere added inline comments. Comment at: lldb/unittests/Utility/NameMatchesTest.cpp:52-53 EXPECT_TRUE(NameMatches("foobar", NameMatch::RegularExpression, "f[oa]o")); - EXPECT_TRUE(NameMatches("foo", NameMatch::RegularExpression, "")); - EXPECT_TRUE(NameMatches("", Nam

[Lldb-commits] [PATCH] D66174: [Utility] Reimplement RegularExpression on top of llvm::Regex

JDevlieghere updated this revision to Diff 215248. JDevlieghere marked 7 inline comments as done. JDevlieghere added a comment. Herald added a subscriber: mgorny. - Cleanup interface - Return llvm::Error - Remove size comparison - Add empty regex workaround - Add unit tests CHANGES SINCE LAST AC

[Lldb-commits] [PATCH] D66208: [lldb] Let LLDB depend on intrinsics_gen to fix non-deterministic module build failures

teemperor added a comment. In D66208#1629378 , @JDevlieghere wrote: > LGTM. > > Out of curiosity, do you know why we don't see this on the CMake bot on > GreenDragon, which is a modules build? Is this so infrequent that I might > have missed it? > > htt

[Lldb-commits] [PATCH] D66241: stop-hooks don't fire on "step-out"

davide added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/stop-hooks/Makefile:4 +C_SOURCES := main.c +CFLAGS_EXTRAS += -std=c99 + jingham wrote: > davide wrote: > > Forgive my ignorance, but why you need this? > That's how the dotes

[Lldb-commits] [PATCH] D66208: [lldb] Let LLDB depend on intrinsics_gen to fix non-deterministic module build failures

JDevlieghere added a comment. In D66208#1630327 , @teemperor wrote: > In D66208#1629378 , @JDevlieghere > wrote: > > > LGTM. > > > > Out of curiosity, do you know why we don't see this on the CMake bot on > > Gree

Re: [Lldb-commits] [PATCH] D66241: stop-hooks don't fire on "step-out"

Ah, that's just from the template test's Makefile, which I constructed by cribbing from a bunch of other tests which all did that. It probably isn't always necessary, but shouldn't do any harm either. Jim > On Aug 14, 2019, at 2:31 PM, Davide Italiano via Phabricator > wrote: > > davide ad

[Lldb-commits] [PATCH] D66174: [Utility] Reimplement RegularExpression on top of llvm::Regex

clayborg added a comment. Looks fine to me. A few nits. Comment at: lldb/include/lldb/Utility/RegularExpression.h:98 + /// The compiled regular expression. + mutable llvm::Regex m_regex; }; Why does this need to be mutable? Comment at: lld

[Lldb-commits] [PATCH] D66241: stop-hooks don't fire on "step-out"

clayborg added inline comments. Comment at: source/Target/StopInfo.cpp:550 thread_sp->ResetStopInfo(); +thread_sp->SetStopInfo(thread_sp->GetStopInfo()); } Can you clarify what is going on here? Does this force a recalculation of the stop

[Lldb-commits] [PATCH] D66241: stop-hooks don't fire on "step-out"

jingham marked an inline comment as done. jingham added a comment. Do you think I should put more verbiage in the comment, or would this have been clear if you were actually working on the code? Comment at: source/Target/StopInfo.cpp:550 thread_sp->ResetStopInfo(); +

[Lldb-commits] [lldb] r368933 - [LLDB] Migrate llvm::make_unique to std::make_unique

Author: jdevlieghere Date: Wed Aug 14 15:19:23 2019 New Revision: 368933 URL: http://llvm.org/viewvc/llvm-project?rev=368933&view=rev Log: [LLDB] Migrate llvm::make_unique to std::make_unique Now that we've moved to C++14, we no longer need the llvm::make_unique implementation from STLExtras.h. T

[Lldb-commits] [lldb] r368937 - Improve anonymous class heuristic in ClangASTContext::CreateRecordType

Author: shafik Date: Wed Aug 14 15:30:29 2019 New Revision: 368937 URL: http://llvm.org/viewvc/llvm-project?rev=368937&view=rev Log: Improve anonymous class heuristic in ClangASTContext::CreateRecordType Summary: Currently the heuristic used in ClangASTContext::CreateRecordType to identify an an

[Lldb-commits] [PATCH] D66175: Improve anonymous class heuristic in ClangASTContext::CreateRecordType

This revision was automatically updated to reflect the committed changes. Closed by commit rL368937: Improve anonymous class heuristic in ClangASTContext::CreateRecordType (authored by shafik, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [PATCH] D66174: [Utility] Reimplement RegularExpression on top of llvm::Regex

JDevlieghere marked 4 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/include/lldb/Utility/RegularExpression.h:98 + /// The compiled regular expression. + mutable llvm::Regex m_regex; }; clayborg wrote: > Why does this need to be

[Lldb-commits] [PATCH] D66241: stop-hooks don't fire on "step-out"

clayborg added inline comments. Comment at: source/Target/StopInfo.cpp:550 thread_sp->ResetStopInfo(); +thread_sp->SetStopInfo(thread_sp->GetStopInfo()); } jingham wrote: > clayborg wrote: > > Can you clarify what is going on here? Does th

[Lldb-commits] [PATCH] D56010: [NativePDB] Fix setting breakpoint by file and line

amccarth added a comment. It turns out these tests all seem to exist, so I guess Zachary submitted them as part of other CLs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56010/new/ https://reviews.llvm.org/D56010 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D66241: stop-hooks don't fire on "step-out"

jingham updated this revision to Diff 215280. jingham added a comment. Does this seem clearer? We use the language of Private and Public StopInfo's in a bunch of places, even though at present that's more about "How" you get them than actual separate entities. But still, this seems like it fol

[Lldb-commits] [PATCH] D66248: [JIT][Command] Add "inject-condition" flag to conditional breakpoints

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Breakpoint/BreakpointLocation.h:70 - /// If \a enable is \b true, enable the breakpoint, if \b false disable it. + /// If \a enabled is \b true, enable the breakpoint, if \b false disable it. void SetEnabled

[Lldb-commits] [PATCH] D66174: [Utility] Reimplement RegularExpression on top of llvm::Regex

JDevlieghere updated this revision to Diff 215287. JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. Undo typ in `CommandObjectFrame.cpp` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66174/new/ https://reviews.llvm.org/D66174 Files: lldb/include/lldb/Inter

[Lldb-commits] [PATCH] D66250: [JIT][Unwinder] Add Trampoline ObjectFile and UnwindPlan support for FCB

jasonmolenda added a comment. Overall this changeset looks good to me. A few small comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/fast_conditional_breakpoints/TestFastConditionalBreakpoints.py:142 +expected_fn_name = "$__lldb_jitt

[Lldb-commits] [lldb] r368959 - [NFC] Fix documentation for some utility classes.

Author: jdevlieghere Date: Wed Aug 14 21:35:46 2019 New Revision: 368959 URL: http://llvm.org/viewvc/llvm-project?rev=368959&view=rev Log: [NFC] Fix documentation for some utility classes. This fixes a few warnings emitted when compiling with -Wdocumentation. Modified: lldb/trunk/include/lld

[Lldb-commits] [lldb] r368962 - Fix variable mismatch between signature and body

Author: jdevlieghere Date: Wed Aug 14 22:09:09 2019 New Revision: 368962 URL: http://llvm.org/viewvc/llvm-project?rev=368962&view=rev Log: Fix variable mismatch between signature and body I updated the signature to conform to the LLDB coding style but accidentally forgot to update the function bo