[Lldb-commits] [PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

martong added a comment. @shafik @jingham This is a polite Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61333/new/ https://reviews.llvm.org/D61333 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D63813: Adjust variable formatting table

lubgr added a comment. Gentle ping... Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63813/new/ https://reviews.llvm.org/D63813 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[Lldb-commits] [lldb] r365908 - [lldb] Let table gen create command option initializers.

Author: teemperor Date: Fri Jul 12 08:30:55 2019 New Revision: 365908 URL: http://llvm.org/viewvc/llvm-project?rev=365908&view=rev Log: [lldb] Let table gen create command option initializers. Summary: We currently have man large arrays containing initializers for our command options. These tabl

[Lldb-commits] [PATCH] D64365: [lldb] Let table gen create command option initializers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL365908: [lldb] Let table gen create command option initializers. (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[Lldb-commits] [PATCH] D64159: [Core] Generalize ValueObject::MaybeCalculateCompleteType

compnerd accepted this revision. compnerd added a comment. Seems that all the comments have been addressed and this is purely code motion. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64159/new/ https://reviews.llvm.org/D64159 ___ l

[Lldb-commits] [PATCH] D64647: [lldb] [Process/NetBSD] Implement per-thread executation control

mgorny created this revision. mgorny added reviewers: krytarowski, labath. Herald added subscribers: teemperor, abidh. Herald added a project: LLDB. Implement the full logic providing the ability to run, single-step or suspend each thread separately. This replaces the old code that propagated the

[Lldb-commits] [PATCH] D64647: [lldb] [Process/NetBSD] Implement per-thread execution control

krytarowski added a comment. I think it looks OK. there are some nits that could be optimized in future or handled additionally.. but for now it should be fine. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64647/new/ https://reviews.llvm.org/D64647 ___

[Lldb-commits] [PATCH] D64647: [lldb] [Process/NetBSD] Implement per-thread execution control

labath added a comment. Shouldn't there be some tests that come along with this patch? Comment at: lldb/source/Plugins/Process/NetBSD/NativeThreadNetBSD.cpp:56 + ret = NativeProcessNetBSD::PtraceWrapper(PT_SETSTEP, m_process.GetID(), +

[Lldb-commits] [PATCH] D64647: [lldb] [Process/NetBSD] Implement per-thread execution control

mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/NetBSD/NativeThreadNetBSD.cpp:56 + ret = NativeProcessNetBSD::PtraceWrapper(PT_SETSTEP, m_process.GetID(), + nullptr, -GetID()

[Lldb-commits] [PATCH] D64647: [lldb] [Process/NetBSD] Implement per-thread execution control

mgorny updated this revision to Diff 209537. mgorny marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64647/new/ https://reviews.llvm.org/D64647 Files: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp lldb/source/Plugins/Process/NetBSD/NativeTh

[Lldb-commits] [PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

teemperor added a comment. @martong Sorry for the delay, feel free to ping me in the future about these patches. I'll review them ASAP now that I'm back in office, so these delay's hopefully won't happen again. I tried applying this patch and it seems it needs to be rebased. I would do it myse

[Lldb-commits] [PATCH] D64647: [lldb] [Process/NetBSD] Implement per-thread execution control

mgorny added a comment. In D64647#1583125 , @labath wrote: > Shouldn't there be some tests that come along with this patch? I was actually hoping that the test suite already covers what needs to be covered, and buildbot would tell me which tests were fi

[Lldb-commits] [PATCH] D64647: [lldb] [Process/NetBSD] Implement per-thread execution control

labath added a comment. In D64647#1583178 , @mgorny wrote: > In D64647#1583125 , @labath wrote: > > > Shouldn't there be some tests that come along with this patch? > > > I was actually hoping that the test suite al

[Lldb-commits] [lldb] r365939 - [Core] Generalize ValueObject::MaybeCalculateCompleteType

Author: xiaobai Date: Fri Jul 12 11:34:37 2019 New Revision: 365939 URL: http://llvm.org/viewvc/llvm-project?rev=365939&view=rev Log: [Core] Generalize ValueObject::MaybeCalculateCompleteType Summary: Instead of hardcoding ClangASTContext and ObjCLanguageRuntime, we can generalize this by creatin

[Lldb-commits] [PATCH] D64159: [Core] Generalize ValueObject::MaybeCalculateCompleteType

This revision was automatically updated to reflect the committed changes. Closed by commit rL365939: [Core] Generalize ValueObject::MaybeCalculateCompleteType (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGE

[Lldb-commits] [PATCH] D64647: [lldb] [Process/NetBSD] Implement per-thread execution control

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:354 + if (signal != LLDB_INVALID_SIGNAL_NUMBER && signal != action->signal) +return Status("NetBSD does not support passing m

[Lldb-commits] [PATCH] D64647: [lldb] [Process/NetBSD] Implement per-thread execution control

krytarowski added inline comments. Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:354 + if (signal != LLDB_INVALID_SIGNAL_NUMBER && signal != action->signal) +return Status("NetBSD does not support passing multiple signals simultaneously");

[Lldb-commits] [PATCH] D64647: [lldb] [Process/NetBSD] Implement per-thread execution control

krytarowski added a comment. Something that we do not cover here is that once a tracee reports a signal (like someone poked it with SIGUSR1) and we want to pass it over to the tracee, we will reset siginfo. This scenario should be covered by a test and we should handle it properly.. The soluti

[Lldb-commits] [PATCH] D64647: [lldb] [Process/NetBSD] Implement per-thread execution control

labath added inline comments. Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:354 + if (signal != LLDB_INVALID_SIGNAL_NUMBER && signal != action->signal) +return Status("NetBSD does not support passing multiple signals simultaneously");

[Lldb-commits] [PATCH] D64661: [ObjectContainerBSDArchive] Simplify a few things (NFC)

JDevlieghere created this revision. JDevlieghere added reviewers: labath, xiaobai. JDevlieghere added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D64661 Files: lldb/source/Plugins/ObjectContainer/BSD-Archive/ObjectContainerBSDArchive.cpp lldb/source/Plugins/ObjectConta

[Lldb-commits] [PATCH] D64661: [ObjectContainerBSDArchive] Simplify a few things (NFC)

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64661/new/ https://reviews.llvm.org/D64661 ___ lldb-commi

[Lldb-commits] [lldb] r365950 - [ObjectContainerBSDArchive] Simplify a few things (NFC)

Author: jdevlieghere Date: Fri Jul 12 13:08:41 2019 New Revision: 365950 URL: http://llvm.org/viewvc/llvm-project?rev=365950&view=rev Log: [ObjectContainerBSDArchive] Simplify a few things (NFC) Differential revision: https://reviews.llvm.org/D64661 Modified: lldb/trunk/source/Plugins/Objec

[Lldb-commits] [lldb] r365951 - [LanguageRuntime] Move CPPLanguageRuntime into a plugin

Author: xiaobai Date: Fri Jul 12 13:09:32 2019 New Revision: 365951 URL: http://llvm.org/viewvc/llvm-project?rev=365951&view=rev Log: [LanguageRuntime] Move CPPLanguageRuntime into a plugin Summary: This seems better suited to be in a plugin. Reviewers: JDevlieghere, clayborg, jingham, compnerd,

[Lldb-commits] [PATCH] D64661: [ObjectContainerBSDArchive] Simplify a few things (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rL365950: [ObjectContainerBSDArchive] Simplify a few things (NFC) (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D64599: [LanguageRuntime] Move CPPLanguageRuntime into a plugin

This revision was automatically updated to reflect the committed changes. Closed by commit rL365951: [LanguageRuntime] Move CPPLanguageRuntime into a plugin (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: http

[Lldb-commits] [PATCH] D64670: [lldb][doc] Document how our LLDB table gen initialized options

teemperor created this revision. teemperor added a reviewer: jingham. Herald added subscribers: lldb-commits, abidh. Herald added a project: LLDB. This patch adds documentation that should make it easier to migrate from using the old initializers to the table gen format. Repository: rLLDB LLD

[Lldb-commits] [PATCH] D64251: Don't depend on psutil on AIX

daltenty marked 6 inline comments as done. daltenty added inline comments. Comment at: llvm/utils/lit/lit/util.py:426 +def killProcessAndChildrenIsSupported(llvm_config): +""" delcypher wrote: > I don't really like how we're now coupling this function with

[Lldb-commits] [PATCH] D64251: Don't depend on psutil on AIX

daltenty updated this revision to Diff 209619. daltenty marked an inline comment as done. daltenty added a comment. - Address review comments round 3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64251/new/ https://reviews.llvm.org/D64251 Files:

[Lldb-commits] [PATCH] D64251: Don't depend on psutil on AIX

daltenty updated this revision to Diff 209621. daltenty added a comment. - Add a space to warning in LLDB lit config Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64251/new/ https://reviews.llvm.org/D64251 Files: libcxx/utils/libcxx/util.py ll

[Lldb-commits] [PATCH] D64670: [lldb][doc] Document how our LLDB table gen initialized options

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Thanks for writing this up! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64670/new/ https://reviews.llvm.org/D64670 ___

[Lldb-commits] [PATCH] D63813: Adjust variable formatting table

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. That looks good. Note that the "address" format does more than show symbol/file/line offset, it will also print the string for addresses that point into the string pool. Might be worth men

[Lldb-commits] [lldb] r365978 - [DWARFContext] Strip leading dot in section names

Author: jdevlieghere Date: Fri Jul 12 17:12:22 2019 New Revision: 365978 URL: http://llvm.org/viewvc/llvm-project?rev=365978&view=rev Log: [DWARFContext] Strip leading dot in section names The LLVM context doesn't expect the leading dot in the section name. Modified: lldb/trunk/source/Plugin

[Lldb-commits] [PATCH] D62570: [WIP] Use LLVM's debug line parser in LLDB

JDevlieghere updated this revision to Diff 209648. JDevlieghere added a comment. - Rebase on current master - Fix bug where we weren't actually creating any sections in the LLVM DWARF Context - Don't create an LLVM DWARFUnit - Get rid of `(*line_table)->` - Add logging instead of swallowing error

[Lldb-commits] [PATCH] D62570: [WIP] Use LLVM's debug line parser in LLDB

JDevlieghere marked 7 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/include/lldb/Core/FileSpecList.h:29 + typedef std::vector collection; + typedef collection::iterator iterator; + typedef collection::const_iterator const_iterator; -

[Lldb-commits] [PATCH] D62570: [WIP] Use LLVM's debug line parser in LLDB

JDevlieghere updated this revision to Diff 209650. JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. - Address remaining comment from George CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62570/new/ https://reviews.llvm.org/D62570 Files: lldb/include/lldb/Co

[Lldb-commits] [lldb] r365988 - Make Python version setting actually effective

Author: jdevlieghere Date: Fri Jul 12 20:30:55 2019 New Revision: 365988 URL: http://llvm.org/viewvc/llvm-project?rev=365988&view=rev Log: Make Python version setting actually effective This needs to be outside the if to actually work. Also, this adjusts the list of versions to match LLVM. Patch

[Lldb-commits] [lldb] r365991 - [lldb] [test] Un-XFAIL TestFormattersSBAPI on NetBSD

Author: mgorny Date: Fri Jul 12 23:24:14 2019 New Revision: 365991 URL: http://llvm.org/viewvc/llvm-project?rev=365991&view=rev Log: [lldb] [test] Un-XFAIL TestFormattersSBAPI on NetBSD Modified: lldb/trunk/packages/Python/lldbsuite/test/python_api/formatters/TestFormattersSBAPI.py Modified

[Lldb-commits] [PATCH] D64647: [lldb] [Process/NetBSD] Implement per-thread execution control

mgorny marked an inline comment as done. mgorny added a comment. In D64647#1583429 , @krytarowski wrote: > Something that we do not cover here is that once a tracee reports a signal > (like someone poked it with SIGUSR1) and we want to pass it over to the