[Lldb-commits] [PATCH] D61212: [lldb] [lit] Add tests for reading ZMM registers (AVX512)

mgorny added a comment. For the record, GCC refuses to build this with: Inputs/x86-zmm-read.cpp: In function ‘int main()’: Inputs/x86-zmm-read.cpp:193:4: error: more than 30 operands in ‘asm’ ); ^ Not sure if we care about it though; clang doesn't seem to have this limitation. C

[Lldb-commits] [PATCH] D61210: [lldb] [lit] Introduce tests for reading x86 general purpose registers

mgorny added a comment. GCC refuses to build this with: Inputs/x86-64-gp-read.cpp: In function ‘int main()’: Inputs/x86-64-gp-read.cpp:31:1: error: bp cannot be used in asm here } ^ Inputs/x86-gp-read.cpp: In function ‘int main()’: Inputs/x86-gp-read.cpp:31:1: error: bp cannot be us

[Lldb-commits] [PATCH] D61210: [lldb] [lit] Introduce tests for reading x86 general purpose registers

mgorny added a comment. Oh wait, that push/pop doesn't really work when I modify the stack pointer ;-). I suppose this doesn't really cause any problems because we don't continue the program past `int3` though. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61210/new/ https://reviews.l

[Lldb-commits] [lldb] r359375 - [lldb] [lit] Cleanly terminate Register tests

Author: mgorny Date: Sat Apr 27 00:43:29 2019 New Revision: 359375 URL: http://llvm.org/viewvc/llvm-project?rev=359375&view=rev Log: [lldb] [lit] Cleanly terminate Register tests Continue the Register test processes, and let them terminate cleanly rather than implicitly terminating them along wit

[Lldb-commits] [PATCH] D61212: [lldb] [lit] Add tests for reading ZMM registers (AVX512)

mgorny updated this revision to Diff 196951. mgorny added a comment. Included verification that the program terminates successfully. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61212/new/ https://reviews.llvm.org/D61212 Files: lldb/lit/Register/Inputs/x86-zmm-read.cpp lldb/lit/Re

[Lldb-commits] [PATCH] D61210: [lldb] [lit] Introduce tests for reading x86 general purpose registers

mgorny updated this revision to Diff 196950. mgorny added a comment. Updated to avoid returning to the program with corrupt RSP/RBP. In the 64-bit version, I'm saving the initial values in %r8 and %r9; in the 32-bit version, I'm using %mm0 and %mm1. CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D61210: [lldb] [lit] Introduce tests for reading x86 general purpose registers

mgorny updated this revision to Diff 196952. mgorny added a comment. Also included `-fomit-frame-pointer`, for CLI compatibility with gcc (i.e. in case clang becomes more strict in the future). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61210/new/ https://reviews.llvm.org/D61210 Fi

[Lldb-commits] [PATCH] D61221: [lldb] [lit] Introduce tests for writing x86 general-purpose registers

mgorny created this revision. mgorny added reviewers: labath, JDevlieghere, krytarowski. Introduce two initial tests for 'register write' command. The tests first clobber x86 general purpose registers, then call int3 to let lldb write to them, then print the new values. FileCheck takes care of v

[Lldb-commits] [PATCH] D59485: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior.

teemperor updated this revision to Diff 196955. teemperor retitled this revision from "[ASTImporter] Add an ImportInternal method to allow customizing Import behavior." to "[ASTImporter] Add an ImportImpl method to allow customizing Import behavior.". teemperor edited the summary of this revision

[Lldb-commits] [PATCH] D59537: Instantiate 'std' templates explicitly in the expression evaluator

teemperor updated this revision to Diff 196962. teemperor edited the summary of this revision. teemperor added a comment. - Renamed to CxxModuleHandler as I want to reuse most of code later for decl importing from generic modules. - Moved declaration construction into it's own templated method si

[Lldb-commits] [PATCH] D59537: Instantiate 'std' templates explicitly in the expression evaluator

teemperor marked 2 inline comments as done. teemperor added a comment. @martong See D59485 for the new ASTImporter method for registering imported decls. I created the method in the ASTImporter as the only dependency on the ASTNodeImporter is `InitializeImported

[Lldb-commits] [PATCH] D46551: Inject only relevant local variables in the expression evaluation context

teemperor commandeered this revision. teemperor added a reviewer: friss. teemperor added a comment. Shafik asked me to take a look at this and see if I can fix the completion tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46551/new/ https://reviews.llvm.org/D46551

[Lldb-commits] [PATCH] D46551: Inject only relevant local variables in the expression evaluation context

teemperor updated this revision to Diff 196965. teemperor added a comment. - Disable the variable filtering when during tab completion for now, as it seems our Clang lookup doesn't pull in external types which breaks the completion tests (and others too). This is only a temporary fix to unblock

[Lldb-commits] [PATCH] D60654: Fix UNPREDICTABLE check in EmulateInstructionARM::EmulateADDRegShift

This revision was automatically updated to reflect the committed changes. Closed by commit rL359387: Fix UNPREDICTABLE check in EmulateInstructionARM::EmulateADDRegShift (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior t

[Lldb-commits] [lldb] r359387 - Fix UNPREDICTABLE check in EmulateInstructionARM::EmulateADDRegShift

Author: teemperor Date: Sat Apr 27 11:15:35 2019 New Revision: 359387 URL: http://llvm.org/viewvc/llvm-project?rev=359387&view=rev Log: Fix UNPREDICTABLE check in EmulateInstructionARM::EmulateADDRegShift Summary: As reported in LLVM bug 41487, the check in this function is wrong and should be th

[Lldb-commits] [PATCH] D57880: Add assert for 'bad' code path in GetUniqueNamespaceDeclaration

teemperor added a comment. Friendly ping @shafik Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57880/new/ https://reviews.llvm.org/D57880 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm

[Lldb-commits] [PATCH] D61231: Add 'oneOf' utility function for comparing a ConstString against a set of strings

teemperor created this revision. teemperor added a reviewer: JDevlieghere. Herald added subscribers: lldb-commits, MaskRay, arichardson, emaste. Herald added a reviewer: espindola. Herald added a project: LLDB. We have a few checks in LLDB where we compare a single ConstString against a hardcoded

[Lldb-commits] [PATCH] D60968: WIP, RFC: Add an example of how LLDB python plug-in could look like

apolyakov added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60968/new/ https://reviews.llvm.org/D60968 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [PATCH] D61233: Refactor ObjectFile::GetSDKVersion

teemperor updated this revision to Diff 196987. teemperor added a comment. - Added documentation on the return value. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61233/new/ https://reviews.llvm.org/D61233 Files: lldb/include/lldb/Symbol/ObjectFile.h lldb/source/Plugins/ObjectFile

[Lldb-commits] [PATCH] D61233: Refactor ObjectFile::GetSDKVersion

teemperor created this revision. teemperor added reviewers: aprantl, jasonmolenda. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch modernizes the GetSDKVersion API and hopefully prevents problems such as the ones discovered in D61218

[Lldb-commits] [PATCH] D61233: Refactor ObjectFile::GetSDKVersion

teemperor added a comment. I decided to go for a vector because otherwise the implementation in ObjectFileMachO gets a bit awkward. But I have no problem with doing a VersionTuple instead and adding some manual translation to version tuple in ObjectFileMachO. CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D61235: Add more information to the log timer dump

aadsm created this revision. aadsm added a reviewer: clayborg. Herald added subscribers: lldb-commits, abidh, jfb, erik.pilkington, aprantl. Herald added a project: LLDB. The `log timer dump` is showing the time of the function itself minus any function that is called from this one that also happ