[Lldb-commits] [PATCH] D60648: [lldb] [lit/SymbolFile] Avoid -nostdlib in target-symbols-add-unwind.test

mgorny created this revision. mgorny added reviewers: labath, zturner, krytarowski. Do not use -nostdlib in target-symbols-add-unwind.test. NetBSD uses startup files to provide obligatory ELF notes in executables, and therefore using -nostdlib requires providing specially tailored input. Otherwi

[Lldb-commits] [lldb] r358329 - [lldb] [lit/SymbolFile] Avoid -nostdlib in target-symbols-add-unwind.test

Author: mgorny Date: Sat Apr 13 02:49:39 2019 New Revision: 358329 URL: http://llvm.org/viewvc/llvm-project?rev=358329&view=rev Log: [lldb] [lit/SymbolFile] Avoid -nostdlib in target-symbols-add-unwind.test Do not use -nostdlib in target-symbols-add-unwind.test. NetBSD uses startup files to prov

[Lldb-commits] [PATCH] D60648: [lldb] [lit/SymbolFile] Avoid -nostdlib in target-symbols-add-unwind.test

This revision was automatically updated to reflect the committed changes. Closed by commit rGfb70bc65fe18: [lldb] [lit/SymbolFile] Avoid -nostdlib in target-symbols-add-unwind.test (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D60653: Correctly check if a warning message lacks a trailing new line

teemperor created this revision. teemperor added a reviewer: clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fixes LLVM bug 41489. Repository: rLLDB LLDB https://reviews.llvm.org/D60653 Files: lldb/source/Core/Module.cpp Index: lldb/source/Core/Module.cpp

[Lldb-commits] [PATCH] D60654: Fix UNPREDICTABLE check in EmulateInstructionARM::EmulateADDRegShift

teemperor created this revision. teemperor added a reviewer: LLDB. Herald added subscribers: lldb-commits, kristof.beyls, javed.absar. Herald added a project: LLDB. As reported in LLVM bug 41487, the check in this function is wrong and should be the same as the described check in the comment (whic

[Lldb-commits] [PATCH] D60655: Fix typo in ArmUnwindInfo::GetUnwindPlan

teemperor created this revision. teemperor added a reviewer: LLDB. Herald added subscribers: lldb-commits, kristof.beyls, javed.absar. Herald added a project: LLDB. As reported in LLVM bug 41486, the check `(byte1 & 0xf8) == 0xc0` is wrong. We want to check for `11010nnn`, so the proper value we

[Lldb-commits] [PATCH] D60655: Fix typo in ArmUnwindInfo::GetUnwindPlan

teemperor added a comment. Don't have the test for this and probably can't write one for it (as I don't have access to an ARM device for testing and don't really know the code so well). If anyone feels like providing a test, feel free to link it to this revision. Repository: rLLDB LLDB CHA

[Lldb-commits] [PATCH] D60654: Fix UNPREDICTABLE check in EmulateInstructionARM::EmulateADDRegShift

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Add an unittest maybe? otherwise, seems to match the ISA so LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60654/new/ https://reviews.llvm.org/D60654