[Lldb-commits] [PATCH] D60034: [lldb] [Process/elf-core] Support aarch64 NetBSD core dumps

2019-03-31 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski accepted this revision. krytarowski added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp:657 } break; + case llvm::Triple::aarch64: { +// Assume order PT_GETREGS

[Lldb-commits] [PATCH] D60034: [lldb] [Process/elf-core] Support aarch64 NetBSD core dumps

2019-03-31 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/postmortem/netbsd-core/TestNetBSDCore.py:236 + +@skipIfLLVMTargetMissing("AArch64") +def test_aarch64(self): I would move it above X86. Repository: rLL

[Lldb-commits] [PATCH] D60034: [lldb] [Process/elf-core] Support aarch64 NetBSD core dumps

2019-03-31 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 193020. mgorny added a comment. Reordered as requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60034/new/ https://reviews.llvm.org/D60034 Files: lldb/packages/Python/lldbsuite/test/functionalities/postmortem/netbsd-core/1lwp_SIGSEGV.aarch6