[Lldb-commits] [PATCH] D59359: Safer casting in ClangExpressionParser code completion

teemperor created this revision. teemperor added reviewers: aprantl, jingham. Herald added subscribers: lldb-commits, jdoerfert. Herald added a project: LLDB. Makes the code a bit safer in the unlikely situation that we don't get a ClangUserExpression when doing code completion. Repository: r

[Lldb-commits] [PATCH] D59359: Safer casting in ClangExpressionParser code completion

labath added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:860-861 // as we always have a ClangUserExpression whenever we call this. - LLVMUserExpression &llvm_expr = *static_cast(&m_expr); - CodeComplete CC(request, m_com

[Lldb-commits] [PATCH] D59359: Safer casting in ClangExpressionParser code completion

teemperor updated this revision to Diff 190612. teemperor added a comment. - Changed to llvm::cast (even though the assert message is a bit generic now). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59359/new/ https://reviews.llvm.org/D59359 Files: lldb/source/Plugins/ExpressionPars

[Lldb-commits] [PATCH] D59291: [Object] Add basic minidump support

labath updated this revision to Diff 190638. labath added a comment. - remove yaml stuff, making this patch only about BinaryFormat&Object changes - Add unit tests for the object layer - Add a bunch of doxygen comments - a couple of tiny implementation tweaks Repository: rL LLVM CHANGES SINCE

[Lldb-commits] [lldb] r356160 - Fix a double-overrelease in the TestDataFormatterObjC test program.

Author: adrian Date: Thu Mar 14 08:58:21 2019 New Revision: 356160 URL: http://llvm.org/viewvc/llvm-project?rev=356160&view=rev Log: Fix a double-overrelease in the TestDataFormatterObjC test program. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-for

[Lldb-commits] [PATCH] D59370: Return llvm::Error and llvm::Expected from some DWARF parsing functions

zturner created this revision. zturner added reviewers: labath, clayborg, aprantl, probinson. Herald added a subscriber: jdoerfert. The goal here is to improve our error handling and error recovery while parsing DWARF, while at the same time getting us closer to being able to merge LLDB's DWARF

[Lldb-commits] [PATCH] D59370: Return llvm::Error and llvm::Expected from some DWARF parsing functions

aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.h:50 + + /// Extract one a + llvm::Expected half-finished comment? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59370/new/ https://reviews.

[Lldb-commits] [PATCH] D59370: Return llvm::Error and llvm::Expected from some DWARF parsing functions

zturner updated this revision to Diff 190654. zturner added a comment. Fix half-written comment and add comments to other extraction function declarations. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59370/new/ https://reviews.llvm.org/D59370 Files: lldb/source/Plugins/SymbolFile/

[Lldb-commits] [lldb] r356168 - [Reproducers] Fix data race found by tsan

Author: jdevlieghere Date: Thu Mar 14 10:19:34 2019 New Revision: 356168 URL: http://llvm.org/viewvc/llvm-project?rev=356168&view=rev Log: [Reproducers] Fix data race found by tsan This fixes a data race uncovered by tsan during destruction of the GDBRemoteReplay server. The solution is to lock t

[Lldb-commits] [lldb] r356171 - [Python] Start eradicating unneeded LLDB_DISABLE_PYTHON guards.

Author: davide Date: Thu Mar 14 10:23:08 2019 New Revision: 356171 URL: http://llvm.org/viewvc/llvm-project?rev=356171&view=rev Log: [Python] Start eradicating unneeded LLDB_DISABLE_PYTHON guards. While we don't have a bot, I'm testing by hand that this configuration compiles. We'll probably set

[Lldb-commits] [PATCH] D59291: [Object] Add basic minidump support

jhenderson added a comment. I haven't really looked at the behaviour to make sure it makes sense, but I've made a number of comments on the comments and one or two other things. Comment at: include/llvm/Object/Minidump.h:25 + /// Construct a new MinidumpFile object from the g

[Lldb-commits] [PATCH] D59291: [Object] Add basic minidump support

zturner added inline comments. Comment at: include/llvm/Object/Minidump.h:77 + ArrayRef Streams, + std::unordered_map StreamMap) + : Binary(ID_Minidump, Source), Header(Header), Streams(Streams), jhenderson wrote: > Are you delibe

Re: [Lldb-commits] [lldb] r356171 - [Python] Start eradicating unneeded LLDB_DISABLE_PYTHON guards.

Make sure to run the test suite after these kinds of changes. You might be surprised. On Thu, Mar 14, 2019 at 10:21 AM Davide Italiano via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: davide > Date: Thu Mar 14 10:23:08 2019 > New Revision: 356171 > > URL: http://llvm.org/viewvc/l

Re: [Lldb-commits] [lldb] r356171 - [Python] Start eradicating unneeded LLDB_DISABLE_PYTHON guards.

On Thu, Mar 14, 2019 at 10:30 AM Zachary Turner wrote: > > Make sure to run the test suite after these kinds of changes. You might be > surprised. > I tested both configurations of course :) ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [lldb] r356174 - Safer casting in ClangExpressionParser code completion

Author: teemperor Date: Thu Mar 14 10:39:39 2019 New Revision: 356174 URL: http://llvm.org/viewvc/llvm-project?rev=356174&view=rev Log: Safer casting in ClangExpressionParser code completion Summary: Makes the code a bit safer in the unlikely situation that we don't get a ClangUserExpression whe

[Lldb-commits] [PATCH] D59359: Safer casting in ClangExpressionParser code completion

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB356174: Safer casting in ClangExpressionParser code completion (authored by teemperor, committed by ). Changed prior to commit: https://reviews.llvm.org/D59359?vs=190612&id=190664#toc Repository:

[Lldb-commits] [lldb] r356176 - [DataFormatters] Delete unused code. Not even exposed in the API.

Author: davide Date: Thu Mar 14 10:41:29 2019 New Revision: 356176 URL: http://llvm.org/viewvc/llvm-project?rev=356176&view=rev Log: [DataFormatters] Delete unused code. Not even exposed in the API. I stumbled upon this while removing LLDB_DISABLE_PYTHON when not needed. Modified: lldb/trunk

[Lldb-commits] [PATCH] D59370: Return llvm::Error and llvm::Expected from some DWARF parsing functions

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. As long as there is not a large performance regress when parsing large DWARF files this looks good to me. Abbreviation declarations are small, so I don't expect one. Co

[Lldb-commits] [lldb] r356190 - Return llvm::Error and llvm::Expected from DWARF parsing code.

Author: zturner Date: Thu Mar 14 12:05:55 2019 New Revision: 356190 URL: http://llvm.org/viewvc/llvm-project?rev=356190&view=rev Log: Return llvm::Error and llvm::Expected from DWARF parsing code. The goal here is to improve our error handling and error recovery while parsing DWARF, while at the

[Lldb-commits] [PATCH] D59370: Return llvm::Error and llvm::Expected from some DWARF parsing functions

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB356190: Return llvm::Error and llvm::Expected from DWARF parsing code. (authored by zturner, committed by ). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D59370?vs=

Re: [Lldb-commits] [PATCH] D59370: Return llvm::Error and llvm::Expected from some DWARF parsing functions

On Thu, Mar 14, 2019 at 11:48 AM Greg Clayton via Phabricator < revi...@reviews.llvm.org> wrote: > clayborg accepted this revision. > clayborg added a comment. > This revision is now accepted and ready to land. > > As long as there is not a large performance regress when parsing large > DWARF file

[Lldb-commits] [PATCH] D59381: Change CompileUnit and ARanges interfaces to propagate errors

zturner created this revision. zturner added reviewers: clayborg, labath, aprantl. Herald added a subscriber: jdoerfert. This is a continuation of D59370 for compile units and aranges. https://reviews.llvm.org/D59381 Files: lldb/source/Plugins/SymbolFile/DWA

Re: [Lldb-commits] [lldb] r355103 - [cmake] Move LLDB_DISABLE_LIBEDIT handling code into a central place

I tried LLVM_ENABLE_PROJECTS=all today, and it fails with CMake Error: The following variables are used in this project, but they are set to NOTFOUND. Please set them or make sure they are set and tested correctly in the CMake files: libedit_INCLUDE_DIRS used as include directory in directory /

[Lldb-commits] [lldb] r356210 - [ObjCLanguage] Remove LLDB_DISABLE_PYTHON markers from the formatters.

Author: davide Date: Thu Mar 14 15:12:59 2019 New Revision: 356210 URL: http://llvm.org/viewvc/llvm-project?rev=356210&view=rev Log: [ObjCLanguage] Remove LLDB_DISABLE_PYTHON markers from the formatters. Modified: lldb/trunk/source/Plugins/Language/ObjC/ObjCLanguage.cpp Modified: lldb/trunk/

[Lldb-commits] [PATCH] D59381: Change CompileUnit and ARanges interfaces to propagate errors

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Must fix logic error as mentioned in inlined comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp:25 + lldb:

[Lldb-commits] [PATCH] D59381: Change CompileUnit and ARanges interfaces to propagate errors

zturner marked 2 inline comments as done. zturner added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp:25 + lldb::offset_t *offset_ptr) { + assert(debug_info.ValidOffset(*offset_ptr)); + clayborg w

[Lldb-commits] [lldb] r356225 - [DataFormatters] Remove LLDB_DISABLE_PYTHON from FormatManager.

Author: davide Date: Thu Mar 14 17:45:57 2019 New Revision: 356225 URL: http://llvm.org/viewvc/llvm-project?rev=356225&view=rev Log: [DataFormatters] Remove LLDB_DISABLE_PYTHON from FormatManager. And DataVisualization. One step closer. Modified: lldb/trunk/include/lldb/DataFormatters/DataVi

[Lldb-commits] [PATCH] D59400: [lldb-vscode] Fix dangling pointer in request_evaluate.

jgorbe created this revision. jgorbe added reviewers: zturner, clayborg. Herald added a project: LLDB. SBError::GetCString() returns a pointer to a string owned by the SBError object. The code here was calling GetCString on a temporary and using the returned pointer after the temporary was destroy

[Lldb-commits] [PATCH] D59400: [lldb-vscode] Fix dangling pointer in request_evaluate.

zturner added a comment. Another option would be to just assign it to a `std::string`, but this is fine too. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59400/new/ https://reviews.llvm.org/D59400 ___ lldb-commit

[Lldb-commits] [PATCH] D59400: [lldb-vscode] Fix dangling pointer in request_evaluate.

jgorbe added a comment. I considered assigning it to a `std::string`, but `GetCString()` can return a null pointer and I'm not sure you can construct a `std::string` directly from that. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59400/new/ https://reviews.

[Lldb-commits] [lldb] r356227 - [lldb-vscode] Fix dangling pointer in request_evaluate.

Author: jgorbe Date: Thu Mar 14 18:46:50 2019 New Revision: 356227 URL: http://llvm.org/viewvc/llvm-project?rev=356227&view=rev Log: [lldb-vscode] Fix dangling pointer in request_evaluate. SBError::GetCString() returns a pointer to a string owned by the SBError object. The code here was calling G

[Lldb-commits] [PATCH] D59400: [lldb-vscode] Fix dangling pointer in request_evaluate.

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB356227: [lldb-vscode] Fix dangling pointer in request_evaluate. (authored by jgorbe, committed by ). Changed prior to commit: https://reviews.llvm.org/D59400?vs=190764&id=190769#toc Repository: rL

[Lldb-commits] [PATCH] D59381: Change CompileUnit and ARanges interfaces to propagate errors

clayborg added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp:25 + lldb::offset_t *offset_ptr) { + assert(debug_info.ValidOffset(*offset_ptr)); + zturner wrote: > clayborg wrote: > > We have error