[Lldb-commits] [lldb] r355388 - Fix embedded Python initialization according to changes in version 3.7

Author: tkrasnukha Date: Tue Mar 5 03:18:45 2019 New Revision: 355388 URL: http://llvm.org/viewvc/llvm-project?rev=355388&view=rev Log: Fix embedded Python initialization according to changes in version 3.7 Differential Revision: https://reviews.llvm.org/D58833 Modified: lldb/trunk/source/

[Lldb-commits] [PATCH] D58833: Fix embedded Python initialization according to changes in version 3.7

This revision was automatically updated to reflect the committed changes. Closed by commit rL355388: Fix embedded Python initialization according to changes in version 3.7 (authored by tkrasnukha, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[Lldb-commits] [lldb] r355392 - [lldb] Fix linux host build after r355342

Author: alexfh Date: Tue Mar 5 04:05:35 2019 New Revision: 355392 URL: http://llvm.org/viewvc/llvm-project?rev=355392&view=rev Log: [lldb] Fix linux host build after r355342 Modified: lldb/trunk/source/Host/linux/Host.cpp Modified: lldb/trunk/source/Host/linux/Host.cpp URL: http://llvm.org

[Lldb-commits] [PATCH] D58946: [SBAPI] Don't check IsValid in constructor

labath added a comment. The copy constructors and assignment operators are very repetitive. What would you say to a function like template void clone(std::unique_ptr &dest, const std::unique_ptr &src) { if (&dest == &src) return; if (src) dest = llvm::make_unique(*src); else

[Lldb-commits] [lldb] r355398 - One more UserIDResolver fix

Author: labath Date: Tue Mar 5 04:51:20 2019 New Revision: 355398 URL: http://llvm.org/viewvc/llvm-project?rev=355398&view=rev Log: One more UserIDResolver fix The intention in r355323 has been to implement a no-op resolver in the HostInfoBase class, which will then be shadowed a an implementati

[Lldb-commits] [PATCH] D55376: Generate LLDB website/documentation from rst with Sphinx

labath added a comment. Herald added a subscriber: jdoerfert. Herald added a project: LLVM. So, what's the state of this now? The rst files have been committed, but we seem to still have the old html files lying around (and AFAICT, http://lldb.llvm.org is still serving from those). I am trying m

[Lldb-commits] [PATCH] D58962: Sanity check --max-gdbserver-port

jankratochvil created this revision. jankratochvil added a reviewer: LLDB. jankratochvil added a project: LLDB. Herald added subscribers: jdoerfert, abidh. In mail lldb-dev: Remote debugging a docker process user was confused by

[Lldb-commits] [PATCH] D58930: Add XCOFF triple object format type for AIX

apaprocki added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2079 + if (log) +log->Printf("sorry: unimplemented for XCOFF"); + return false; No need to be `sorry:` :) This shou

[Lldb-commits] [PATCH] D58962: Sanity check --max-gdbserver-port

labath added a comment. Perhaps it would be nice to write a test-case for that. It should be as simple as running `not lldb-server --whatever` and FileChecking the output. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58962/new/ https://reviews.llvm.org/D58962

[Lldb-commits] [PATCH] D57689: Adds property to force enabling of GDB JIT loader for MacOS

This revision was automatically updated to reflect the committed changes. Closed by commit rL355402: Adds property to force enabling of GDB JIT loader for MacOS (authored by yurydelendik, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

[Lldb-commits] [lldb] r355406 - Revert "Fix embedded Python initialization according to changes in version 3.7"

Author: tkrasnukha Date: Tue Mar 5 07:27:33 2019 New Revision: 355406 URL: http://llvm.org/viewvc/llvm-project?rev=355406&view=rev Log: Revert "Fix embedded Python initialization according to changes in version 3.7" Testsuite hangs on Windows likely due to these changes. Modified: lldb/tru

[Lldb-commits] [PATCH] D58946: [SBAPI] Don't check IsValid in constructor

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. lgtm Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58946/new/ https://reviews.llvm.org/D58946 ___ lldb-com

Re: [Lldb-commits] [lldb] r355406 - Revert "Fix embedded Python initialization according to changes in version 3.7"

This is unfortunate, because I think it's the correct path forward. Stella, do you know why this is failing on Windows? Thanks, -- Davide On Tue, Mar 5, 2019 at 7:26 AM Tatyana Krasnukha via lldb-commits wrote: > > Author: tkrasnukha > Date: Tue Mar 5 07:27:33 2019 > New Revision: 355406 > >

Re: [Lldb-commits] [lldb] r355406 - Revert "Fix embedded Python initialization according to changes in version 3.7"

I'm also at a loss trying to understand how this particular change could've caused the tests to hang. __VSCMD_PREINIT_PATH=C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python36_64\Scripts\;C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python36_64\;C:\Windows\system32;C:\Windows

[Lldb-commits] [PATCH] D58970: Move RangeMap.h into Utility

labath created this revision. labath added reviewers: zturner, jingham, JDevlieghere, clayborg. Herald added subscribers: MaskRay, arichardson, javed.absar, mgorny, emaste. Herald added a reviewer: espindola. This file implements some general purpose data structures, and so it belongs to the Utili

Re: [Lldb-commits] [PATCH] D58946: [SBAPI] Don't check IsValid in constructor

Sounds good, I’ll make this change before landing, unless you have further comments? On Tue, Mar 5, 2019 at 4:29 AM Pavel Labath via Phabricator < revi...@reviews.llvm.org> wrote: > labath added a comment. > > The copy constructors and assignment operators are very repetitive. What > would you sa

[Lldb-commits] [PATCH] D58971: Move MemoryRegionInfo into the Utility module

labath created this revision. labath added reviewers: zturner, jingham, JDevlieghere, clayborg. Herald added a subscriber: mgorny. labath added a parent revision: D58970: Move RangeMap.h into Utility. MemoryRegionInfo describes the region of memory in a process, but this does not have to be the li

[Lldb-commits] [PATCH] D58972: Introduce the "Formats" module and move LinuxProcMaps parser to it

labath created this revision. labath added reviewers: zturner, jingham, JDevlieghere, clayborg, teemperor. Herald added subscribers: arphaman, aprantl, mgorny. This patch introduces a "Formats" library, whose goal is to contain serialization and deserialization code for various textual and binary

[Lldb-commits] [PATCH] D58973: Move the minidump parser into the Formats module

labath created this revision. labath added reviewers: zturner, lemo, clayborg, JDevlieghere. Herald added subscribers: javed.absar, mgorny. the parser was already independent from the lldb Process classes, but it was living in source/Plugins/Process/minidump, because we did not have a good place t

[Lldb-commits] [PATCH] D58970: Move RangeMap.h into Utility

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. This looks like a no-brainer. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58970/new/ https://reviews.llvm.org/D58970 ___

Re: [Lldb-commits] [lldb] r355406 - Revert "Fix embedded Python initialization according to changes in version 3.7"

After the revert the testsuite doesn't hang anymore, so, it looks like this was responsible. Stella, is the bot actually running python 3.6 ? Can you make sure there's no python 3.7 installed somewhere in the system that gets picked by accident? On Tue, Mar 5, 2019 at 7:59 AM Davide Italiano wrot

[Lldb-commits] [PATCH] D58975: Introduce MinidumpEnums.def textual header

labath created this revision. labath added reviewers: zturner, lemo, clayborg, JDevlieghere, teemperor. Herald added subscribers: fedor.sergeev, dschuff, srhines. labath added a parent revision: D58973: Move the minidump parser into the Formats module. The goal of this header is to reduce code du

[Lldb-commits] [PATCH] D58976: Introduce core2yaml tool

labath created this revision. labath added reviewers: zturner, lemo, clayborg, JDevlieghere. Herald added a subscriber: mgorny. This patch introduces the core2yaml tool, whose purpose is to dump core files in a human readable (and, ideally, editable) format. It's very similar to llvm's obj2yaml, e

[Lldb-commits] [PATCH] D58962: Sanity check --max-gdbserver-port

jankratochvil updated this revision to Diff 189333. jankratochvil added a comment. Herald added a reviewer: serge-sans-paille. There is no `not` as `lldb-server` still had+has exit code 0 during this error. I have no idea what to put to the `FIXME` string there. Failure (with old `lldb-server`) l

[Lldb-commits] [PATCH] D58971: Move MemoryRegionInfo into the Utility module

JDevlieghere added a comment. I like the idea of having a separate module for this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58971/new/ https://reviews.llvm.org/D58971 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://l

Re: [Lldb-commits] [lldb] r355406 - Revert "Fix embedded Python initialization according to changes in version 3.7"

The bot is running 3.6.6 and it does not have python 3.7 installed (it does have python 2.7 which is needed to run Buildbot). The change that was pushed, though, did not only impact python 3.7: m_was_already_initialized == PyGILState_UNLOCKED ? "un" : ""); m_gil_s

Re: [Lldb-commits] [PATCH] D58946: [SBAPI] Don't check IsValid in constructor

On 05/03/2019 17:19, Jonas Devlieghere wrote: Sounds good, I’ll make this change before landing, unless you have further comments? On Tue, Mar 5, 2019 at 4:29 AM Pavel Labath via Phabricator mailto:revi...@reviews.llvm.org>> wrote: labath added a comment. The copy constructors and a

[Lldb-commits] [PATCH] D58976: Introduce core2yaml tool

clayborg added a comment. Do we want this in LLVM instead of lldb? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58976/new/ https://reviews.llvm.org/D58976 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi

Re: [Lldb-commits] [lldb] r355406 - Revert "Fix embedded Python initialization according to changes in version 3.7"

On Tue, Mar 5, 2019 at 8:39 AM Stella Stamenova wrote: > > The bot is running 3.6.6 and it does not have python 3.7 installed (it does > have python 2.7 which is needed to run Buildbot). > > The change that was pushed, though, did not only impact python 3.7: > > m_was_already_init

[Lldb-commits] [PATCH] D57689: Adds property to force enabling of GDB JIT loader for MacOS

stella.stamenova added a comment. This is causing a failure on the Windows Bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/2299/steps/test/logs/stdio It was broken because of another change which is why you probably didn't get a notification. Please, fix this quickly or rev

[Lldb-commits] [PATCH] D58962: Sanity check --max-gdbserver-port

labath added inline comments. Comment at: lldb/lit/helper/toolchain.py:19 dsargs = [] if platform.system() in ['Darwin'] else ['gdbserver'] +psargs = ['FIXME'] if platform.system() in ['Darwin'] else ['platform'] lldbmi = ToolSubst('%lldbmi', For th

[Lldb-commits] [PATCH] D58976: Introduce core2yaml tool

labath added a comment. In D58976#1418596 , @clayborg wrote: > Do we want this in LLVM instead of lldb? The thought has crossed my mind, but for that I would have to also move the minidump parser into llvm. It's already pretty standalone, so it shouldn'

Re: [Lldb-commits] [PATCH] D58946: [SBAPI] Don't check IsValid in constructor

On Tue, Mar 5, 2019 at 8:41 AM Pavel Labath wrote: > On 05/03/2019 17:19, Jonas Devlieghere wrote: > > Sounds good, I’ll make this change before landing, unless you have > > further comments? > > > > On Tue, Mar 5, 2019 at 4:29 AM Pavel Labath via Phabricator > > mailto:revi...@reviews.llvm.org>>

[Lldb-commits] [PATCH] D58962: Sanity check --max-gdbserver-port

jankratochvil updated this revision to Diff 189338. jankratochvil marked an inline comment as done. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58962/new/ https://reviews.llvm.org/D58962 Files: lldb/lit/Driver/TestGdbserverPort.test lldb/lit/helper/toolcha

[Lldb-commits] [PATCH] D58976: Introduce core2yaml tool

clayborg added inline comments. Comment at: include/lldb/Formats/MinidumpParser.h:105 private: - lldb::DataBufferSP m_data_sp; + llvm::ArrayRef m_data; + const MinidumpHeader *m_header; I worry about this going stale when the owner of the data lets it go and

[Lldb-commits] [PATCH] D58976: Introduce core2yaml tool

clayborg added a comment. Strong ownership is needed for this class IMHO because it hands out pointers to native data CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58976/new/ https://reviews.llvm.org/D58976 ___ lldb-commits mailing list ll

[Lldb-commits] [lldb] r355415 - Revert "[lldbtest] Check against the correct name for libcxxabi (macOS)."

Author: davide Date: Tue Mar 5 09:21:55 2019 New Revision: 355415 URL: http://llvm.org/viewvc/llvm-project?rev=355415&view=rev Log: Revert "[lldbtest] Check against the correct name for libcxxabi (macOS)." This passes locally but breaks on the bots. Maybe an SDK difference. Reverting while I inv

[Lldb-commits] [PATCH] D58962: Sanity check --max-gdbserver-port

jasonmolenda added a comment. LGTM fwiw I think the --min-gdbserver-port and --max-gdbserver-port options were primarily/only used for iOS etc testsuite runs, where a fixed set of ports is relayed between the devices. I was having some problems with lldb-server in platform mode on these device

[Lldb-commits] [PATCH] D58976: Introduce core2yaml tool

zturner added a comment. In D58976#1418621 , @clayborg wrote: > Strong ownership is needed for this class IMHO because it hands out pointers > to native data I disagree here, see my previous comment. Binaries grow large very quickly, and if we always

Re: [Lldb-commits] [lldb] r355375 - [Expression] Remove unused parameter from Evaluate

If you don't mind, I would like to revert this patch. Though the parameter is currently unused on the llvm.org side, it is used in the Swift REPL, so removing it causes unnecessary conflicts. Also, it will be necessary to support any kind of REPL - Sean gave a talk a couple of years ago at the

Re: [Lldb-commits] [lldb] r355406 - Revert "Fix embedded Python initialization according to changes in version 3.7"

I ran the tests without that line on a machine that is equivalent to the Buildbot and they ran correctly, but I just noticed that while the Buildbot has had several runs that did not time out since the revert, there was also one that did time out. I am going to let the current build on the Buil

Re: [Lldb-commits] [lldb] r355375 - [Expression] Remove unused parameter from Evaluate

Eh, I take that back. We switched to injecting #file and #line into the body text to do the same job, so this is indeed no longer needed. Jim > On Mar 5, 2019, at 10:21 AM, Jim Ingham via lldb-commits > wrote: > > If you don't mind, I would like to revert this patch. Though the parameter

[Lldb-commits] [lldb] r355422 - [DataFormatters] Fix regression in libc++ std::atomic formatter caused by https://reviews.llvm.org/D56913

Author: shafik Date: Tue Mar 5 10:34:35 2019 New Revision: 355422 URL: http://llvm.org/viewvc/llvm-project?rev=355422&view=rev Log: [DataFormatters] Fix regression in libc++ std::atomic formatter caused by https://reviews.llvm.org/D56913 rdar://problem/48568543 Modified: lldb/trunk/source/

Re: [Lldb-commits] [PATCH] D58976: Introduce core2yaml tool

Does objdump not read core files? Jim > On Mar 5, 2019, at 8:53 AM, Pavel Labath via Phabricator via lldb-commits > wrote: > > labath added a comment. > > In D58976#1418596 , @clayborg wrote: > >> Do we want this in LLVM instead of lldb? > > > The

Re: [Lldb-commits] [PATCH] D58946: [SBAPI] Don't check IsValid in constructor

On 05/03/2019 17:58, Jonas Devlieghere wrote: On Tue, Mar 5, 2019 at 8:41 AM Pavel Labath > wrote: On 05/03/2019 17:19, Jonas Devlieghere wrote: > Sounds good, I’ll make this change before landing, unless you have > further comments? > > On Tue,

[Lldb-commits] [PATCH] D58630: [lldb] [test] Pass appropriate -L&-Wl, -rpath for libc++ on NetBSD

mgorny updated this revision to Diff 189364. mgorny retitled this revision from "[lldb] [test] Pass appropriate -L&-Wl,-rpath for just-built libc++" to "[lldb] [test] Pass appropriate -L&-Wl,-rpath for libc++ on NetBSD". mgorny edited the summary of this revision. mgorny added a comment. Updated

[Lldb-commits] [PATCH] D58985: Fix core files for 32 bit architectures that are supported in ProcessELFCore.cpp

clayborg created this revision. clayborg added reviewers: labath, hhellyer, omjavaid, tberghammer. Herald added subscribers: kristof.beyls, javed.absar. Herald added a reviewer: serge-sans-paille. Core files need to know the size of the PRSTATUS header so that we can grab the register values that

[Lldb-commits] [PATCH] D58972: Introduce the "Formats" module and move LinuxProcMaps parser to it

zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. Great idea, this is a nice analogue to LLVM/BinaryFormat. But, "Formats" is a little generic. What about FileFormats or something? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D589

[Lldb-commits] [PATCH] D58971: Move MemoryRegionInfo into the Utility module

zturner added a comment. One idea for a new module name could be `AbstractProcess`, but I can't think of anything else better at the moment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58971/new/ https://reviews.llvm.org/D58971 ___ lldb-

[Lldb-commits] [PATCH] D58985: Fix core files for 32 bit architectures that are supported in ProcessELFCore.cpp

zturner added inline comments. Comment at: source/Plugins/Process/elf-core/ThreadElfCore.cpp:276 +else + return sizeof(ELFLinuxPrStatus) - 10 * 4; } subtracting 40 from the header size seems a bit magical to those not in the know (such as myself). C

[Lldb-commits] [PATCH] D58985: Fix core files for 32 bit architectures that are supported in ProcessELFCore.cpp

clayborg updated this revision to Diff 189374. clayborg added a comment. Fix zturner's suggestion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58985/new/ https://reviews.llvm.org/D58985 Files: packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py p

[Lldb-commits] [PATCH] D58946: [SBAPI] Don't check IsValid in constructor

JDevlieghere updated this revision to Diff 189377. JDevlieghere added a comment. - Add clone utility. - Updated other SB classes to make use of the clone function as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58946/new/ https://reviews.llvm.org/D58946 Files: lldb/source/API/

[Lldb-commits] [PATCH] D58930: Add XCOFF triple object format type for AIX

jasonliu marked 2 inline comments as done. jasonliu added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2079 + if (log) +log->Printf("sorry: unimplemented for XCOFF"); + return false; --

[Lldb-commits] [lldb] r355435 - Add logging to SBCompileUnit::GetNumLineEntries.

Author: jmolenda Date: Tue Mar 5 11:43:56 2019 New Revision: 355435 URL: http://llvm.org/viewvc/llvm-project?rev=355435&view=rev Log: Add logging to SBCompileUnit::GetNumLineEntries. Modified: lldb/trunk/source/API/SBCompileUnit.cpp Modified: lldb/trunk/source/API/SBCompileUnit.cpp URL: ht

[Lldb-commits] [PATCH] D58748: [ExpressionParser] Test GetClangResourceDir

xiaobai added a comment. @aprantl: Do you mind taking a look at this when you get a moment? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58748/new/ https://reviews.llvm.org/D58748 ___ lldb-commits mailing list lldb-commits@lists.llvm.org h

[Lldb-commits] [PATCH] D58972: Introduce the "Formats" module and move LinuxProcMaps parser to it

labath added a comment. FileFormats wouldn't be generic enough to capture the gdb-remote or debug-info-server protocol code. However, even calling gdb-remote protocol a "format" is still a bit of a stretch. I think there is enough similarity between gdb-remote and minidump code for them to be i

[Lldb-commits] [PATCH] D58748: [ExpressionParser] Test GetClangResourceDir

aprantl added a comment. Looks mostly good! Comment at: source/Plugins/ExpressionParser/Clang/ClangHost.cpp:45 +static bool DefaultComputeClangDirectory(FileSpec &lldb_shlib_spec, + FileSpec &file_spec, bool verify) { W

Re: [Lldb-commits] [PATCH] D58972: Introduce the "Formats" module and move LinuxProcMaps parser to it

How about SerializationFormats? On Tue, Mar 5, 2019 at 12:22 PM Pavel Labath via Phabricator < revi...@reviews.llvm.org> wrote: > labath added a comment. > > FileFormats wouldn't be generic enough to capture the gdb-remote or > debug-info-server protocol code. However, even calling gdb-remote prot

[Lldb-commits] [PATCH] D58930: Add XCOFF triple object format type for AIX

jasonliu updated this revision to Diff 189387. jasonliu added a comment. Address some review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58930/new/ https://reviews.llvm.org/D58930 Files: clang/lib/CodeGen/BackendUtil.cpp clang/lib/C

[Lldb-commits] [PATCH] D58930: Add XCOFF triple object format type for AIX

JDevlieghere requested changes to this revision. JDevlieghere added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1470 + case Triple::XCOFF: +// TODO: Falling through for XCOFF format for now. +break; --

[Lldb-commits] [PATCH] D58930: Add XCOFF triple object format type for AIX

jasonliu marked an inline comment as done. jasonliu added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2079 + if (log) +log->Printf("sorry: unimplemented for XCOFF"); + return false; --

[Lldb-commits] [PATCH] D58972: Introduce the "Formats" module and move LinuxProcMaps parser to it

JDevlieghere added a comment. In D58972#1418931 , @labath wrote: > FileFormats wouldn't be generic enough to capture the gdb-remote or > debug-info-server protocol code. However, even calling gdb-remote protocol a > "format" is still a bit of a stretch.

[Lldb-commits] [PATCH] D58930: Add XCOFF triple object format type for AIX

jasonliu marked 3 inline comments as done. jasonliu added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1470 + case Triple::XCOFF: +// TODO: Falling through for XCOFF format for now. +break; JDevlieghere wrote: > This is confusing, you s

[Lldb-commits] [lldb] r355443 - [lldbsuite, windows] Skip the TestEvents tests on Windows

Author: stella.stamenova Date: Tue Mar 5 13:03:36 2019 New Revision: 355443 URL: http://llvm.org/viewvc/llvm-project?rev=355443&view=rev Log: [lldbsuite, windows] Skip the TestEvents tests on Windows These tests are flakey on Windows and recently they have started failing AND also hanging the w

[Lldb-commits] [PATCH] D58748: [ExpressionParser] Test GetClangResourceDir

xiaobai updated this revision to Diff 189392. xiaobai added a comment. {Default,}ComputeClangDirectory -> {Default,}ComputeClangResourceDir Added a comment explaining exactly how DefaultComputeClangResourceDir works CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58748/new/ https://review

[Lldb-commits] [lldb] r355448 - [lit, windows] Disable stop-hook-threads on Windows

Author: stella.stamenova Date: Tue Mar 5 13:43:04 2019 New Revision: 355448 URL: http://llvm.org/viewvc/llvm-project?rev=355448&view=rev Log: [lit, windows] Disable stop-hook-threads on Windows This test is also no longer reliably failing or passing on Windows and it is hanging every few runs.

[Lldb-commits] [lldb] r355449 - Revert logging addition to SBCompileUnit::GetNumLineEntries,

Author: jmolenda Date: Tue Mar 5 14:17:47 2019 New Revision: 355449 URL: http://llvm.org/viewvc/llvm-project?rev=355449&view=rev Log: Revert logging addition to SBCompileUnit::GetNumLineEntries, causing lldb-mi testsuite failures? Modified: lldb/trunk/source/API/SBCompileUnit.cpp Modified

Re: [Lldb-commits] [lldb] r355449 - Revert logging addition to SBCompileUnit::GetNumLineEntries,

You should check whether log is enabled, I think. On Tue, Mar 5, 2019 at 2:16 PM Jason Molenda via lldb-commits wrote: > > Author: jmolenda > Date: Tue Mar 5 14:17:47 2019 > New Revision: 355449 > > URL: http://llvm.org/viewvc/llvm-project?rev=355449&view=rev > Log: > Revert logging addition to

Re: [Lldb-commits] [lldb] r355449 - Revert logging addition to SBCompileUnit::GetNumLineEntries,

Yeah, I realized that as I re-read the diff after reverting. :) I was doing all my work & testing with the api log enabled. > On Mar 5, 2019, at 2:21 PM, Davide Italiano wrote: > > You should check whether log is enabled, I think. > > On Tue, Mar 5, 2019 at 2:16 PM Jason Molenda via lldb-co

Re: [Lldb-commits] [lldb] r355406 - Revert "Fix embedded Python initialization according to changes in version 3.7"

It should be safe to checkin the change now. It looks like at some point during the last couple of days the timing of some of the threads tests on Windows changed so now instead of behaving and passing or failing nicely, they are getting struck and never completing. This does not happen on every

[Lldb-commits] [PATCH] D58930: Add XCOFF triple object format type for AIX

jasonliu marked an inline comment as done. jasonliu added inline comments. Comment at: llvm/lib/MC/MCContext.cpp:165 +case MCObjectFileInfo::IsXCOFF: + // TODO: Need to implement class MCSymbolXCOFF. + break; JDevlieghere wrote: > See previous comme

[Lldb-commits] [PATCH] D58930: Add XCOFF triple object format type for AIX

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2079 + if (log) +log->Printf("sorry: unimplemented for XCOFF"); + return false; jasonliu wrote: > JDevlieghere w

[Lldb-commits] [PATCH] D59004: [lldb] Fix DW_OP_addrx uses.

tamur created this revision. tamur added a project: LLDB. Herald added a subscriber: lldb-commits. DW_OP_GNU_addr_index has been renamed as DW_OP_addrx in the standard. clang produces DW_OP_addrx tags and with this change lldb starts to process them. Repository: rLLDB LLDB https://reviews.ll

[Lldb-commits] [PATCH] D59004: [lldb] Fix DW_OP_addrx uses.

shafik added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:2910 //-- // OPCODE: DW_OP_GNU_addr_index // OPERANDS: 1 Should this comment be updated? Repo

[Lldb-commits] [lldb] r355457 - Remove tautological #ifdefs (NFC)

Author: adrian Date: Tue Mar 5 15:51:25 2019 New Revision: 355457 URL: http://llvm.org/viewvc/llvm-project?rev=355457&view=rev Log: Remove tautological #ifdefs (NFC) Differential Revision: https://reviews.llvm.org/D58838 Modified: lldb/trunk/source/Target/ExecutionContext.cpp Modified: lld

[Lldb-commits] [PATCH] D58838: Remove tautological #ifdefs

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL355457: Remove tautological #ifdefs (NFC) (authored by adrian, committed by ). Herald added a project: LLVM. Herald added

[Lldb-commits] [PATCH] D59004: [lldb] Fix DW_OP_addrx uses.

tamur updated this revision to Diff 189415. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59004/new/ https://reviews.llvm.org/D59004 Files: lldb/source/Expression/DWARFExpression.cpp lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp

[Lldb-commits] [PATCH] D59004: [lldb] Fix DW_OP_addrx uses.

tamur marked an inline comment as done. tamur added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:2910 //-- // OPCODE: DW_OP_GNU_addr_index // OPERANDS: 1

[Lldb-commits] [PATCH] D59004: [lldb] Fix DW_OP_addrx uses.

aprantl added a comment. The code looks fine, but this needs a testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59004/new/ https://reviews.llvm.org/D59004 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D59004: [lldb] Fix DW_OP_addrx uses.

aprantl added a comment. Is there a way to force clang to generate this and/or are existing tests failing because this support is missing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59004/new/ https://reviews.llvm.org/D59004

[Lldb-commits] [lldb] r355458 - [SBAPI] Don't check IsValid in constructor

Author: jdevlieghere Date: Tue Mar 5 16:05:55 2019 New Revision: 355458 URL: http://llvm.org/viewvc/llvm-project?rev=355458&view=rev Log: [SBAPI] Don't check IsValid in constructor When running the test suite with the instrumentation macros, I noticed two lldb-mi tests regressed. The issue was t

[Lldb-commits] [PATCH] D58946: [SBAPI] Don't check IsValid in constructor

This revision was automatically updated to reflect the committed changes. Closed by commit rL355458: [SBAPI] Don't check IsValid in constructor (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

[Lldb-commits] [PATCH] D57475: [Reproducers] Add SBReproducer macros

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB355459: [Reproducers] Add SBReproducer macros (authored by JDevlieghere, committed by ). Herald added a subscriber: teemperor. Changed prior to commit: https://reviews.llvm.org/D57475?vs=188015&id=18

[Lldb-commits] [PATCH] D59004: [lldb] Fix DW_OP_addrx uses.

tamur updated this revision to Diff 189423. tamur added a comment. Herald added a reviewer: serge-sans-paille. Added a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59004/new/ https://reviews.llvm.org/D59004 Files: lldb/packages/Python/lld

[Lldb-commits] [lldb] r355463 - [ExpressionParser] Test GetClangResourceDir

Author: xiaobai Date: Tue Mar 5 16:45:16 2019 New Revision: 355463 URL: http://llvm.org/viewvc/llvm-project?rev=355463&view=rev Log: [ExpressionParser] Test GetClangResourceDir Summary: I'm doing this because I plan on implementing `ComputeClangResourceDirectory` on windows so that `GetClangReso

[Lldb-commits] [PATCH] D58748: [ExpressionParser] Test GetClangResourceDir

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB355463: [ExpressionParser] Test GetClangResourceDir (authored by xiaobai, committed by ). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D58748?vs=189392&id=189427#to

[Lldb-commits] [lldb] r355464 - [Reproducers] Fix warnings without asserts

Author: jdevlieghere Date: Tue Mar 5 16:52:48 2019 New Revision: 355464 URL: http://llvm.org/viewvc/llvm-project?rev=355464&view=rev Log: [Reproducers] Fix warnings without asserts Make sure the variable is used when asserts are compiled out. Modified: lldb/trunk/include/lldb/Utility/Reprod

[Lldb-commits] [lldb] r355465 - [Reproducers] Undef LLDB_REPRO_INSTR_TRACE

Author: jdevlieghere Date: Tue Mar 5 17:00:36 2019 New Revision: 355465 URL: http://llvm.org/viewvc/llvm-project?rev=355465&view=rev Log: [Reproducers] Undef LLDB_REPRO_INSTR_TRACE Forgot to undef this before landing. Modified: lldb/trunk/include/lldb/Utility/ReproducerInstrumentation.h Mo

[Lldb-commits] [lldb] r355466 - Replace debug-only assert with a plain old assert.

Author: adrian Date: Tue Mar 5 17:07:45 2019 New Revision: 355466 URL: http://llvm.org/viewvc/llvm-project?rev=355466&view=rev Log: Replace debug-only assert with a plain old assert. Modified: lldb/trunk/source/Interpreter/CommandObject.cpp Modified: lldb/trunk/source/Interpreter/CommandObj

[Lldb-commits] [PATCH] D58930: Add XCOFF triple object format type for AIX

hubert.reinterpretcast added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2079 + if (log) +log->Printf("sorry: unimplemented for XCOFF"); + return false; JDevlieghere wrote: >

[Lldb-commits] [PATCH] D58748: [ExpressionParser] Test GetClangResourceDir

stella.stamenova added a comment. This introduced a build break on Windows (which happened to coincide with another build break). http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/2317 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58748/new/ htt

[Lldb-commits] [lldb] r355469 - [Reproducers] Don't intercept SBDebugger::SetInputFileHandle

Author: jdevlieghere Date: Tue Mar 5 17:49:54 2019 New Revision: 355469 URL: http://llvm.org/viewvc/llvm-project?rev=355469&view=rev Log: [Reproducers] Don't intercept SBDebugger::SetInputFileHandle With the reproducer logic in place for the command interpreter we no longer need to make SBDebugg

[Lldb-commits] [lldb] r355470 - [Reproducers] Enable replay from SBRepro.

Author: jdevlieghere Date: Tue Mar 5 17:49:57 2019 New Revision: 355470 URL: http://llvm.org/viewvc/llvm-project?rev=355470&view=rev Log: [Reproducers] Enable replay from SBRepro. Now that the LLDB instrumentation macros are in place, we should use that to test reproducer replay. Differential r

[Lldb-commits] [PATCH] D58565: [Reproducers] Enable replay from SBRepro

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB355470: [Reproducers] Enable replay from SBRepro. (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D58565?vs=188016&id=189432#toc Repository: rLLDB LLDB

[Lldb-commits] [lldb] r355471 - [ExpressionParser] Fix ComputeClangResourceDirectory for windows

Author: xiaobai Date: Tue Mar 5 17:57:04 2019 New Revision: 355471 URL: http://llvm.org/viewvc/llvm-project?rev=355471&view=rev Log: [ExpressionParser] Fix ComputeClangResourceDirectory for windows The function signature of ComputeClangResourceDirectory for windows wasn't updated when the others

[Lldb-commits] [lldb] r355473 - Re-commit logging for SBCompileUnit::GetNumLineEntries.

Author: jmolenda Date: Tue Mar 5 18:32:45 2019 New Revision: 355473 URL: http://llvm.org/viewvc/llvm-project?rev=355473&view=rev Log: Re-commit logging for SBCompileUnit::GetNumLineEntries. Modified: lldb/trunk/source/API/SBCompileUnit.cpp Modified: lldb/trunk/source/API/SBCompileUnit.cpp U

[Lldb-commits] [lldb] r355476 - Change the scanning algorithm in DynamicLoaderDarwinKernel::SearchForKernelNearPC.

Author: jmolenda Date: Tue Mar 5 18:45:27 2019 New Revision: 355476 URL: http://llvm.org/viewvc/llvm-project?rev=355476&view=rev Log: Change the scanning algorithm in DynamicLoaderDarwinKernel::SearchForKernelNearPC. Currently when lldb might be doing a kernel debug session, it scans through mem