[Lldb-commits] [PATCH] D56237: Implement GetLoadAddress for the Windows process plugin

asmith updated this revision to Diff 186799. Herald added a subscriber: mgorny. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56237/new/ https://reviews.llvm.org/D56237 Files: source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp source/Plugins/DynamicLoader/Windows-

[Lldb-commits] [lldb] r354012 - [gdb-remote] Sanity check platform pointer

Author: asmith Date: Thu Feb 14 00:59:04 2019 New Revision: 354012 URL: http://llvm.org/viewvc/llvm-project?rev=354012&view=rev Log: [gdb-remote] Sanity check platform pointer Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp Modified: lldb/trunk/source/Plugi

[Lldb-commits] [PATCH] D58223: [lldb] [unittests] XFAIL two unittests failing on NetBSD

mgorny created this revision. mgorny added reviewers: krytarowski, labath, zturner. mgorny added a project: LLDB. The two following LLDBServerTests fail reliably on NetBSD: StandardStartupTest.TestStopReplyContainsThreadPcs TestBase.LaunchModePreservesEnvironment Establish an XFAIL behavior to

[Lldb-commits] [PATCH] D58223: [lldb] [unittests] XFAIL two unittests failing on NetBSD

mgorny added a comment. FTR, I've tried both @zturner's and @labath's XFAIL suggestions and the former doesn't work because we're not using exeptions, and the latter just gives some creepy C++ errors. Then I figured out this is probably the simplest and most readable possibility. Repository:

[Lldb-commits] [PATCH] D58222: [ClangExpressionParser] Reuse the FileManager from the compiler instance.

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58222/new/ https://reviews.llvm.org/D58222 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D58227: [lldb] [MainLoop] Remove redundant termination clause (NFCI)

mgorny created this revision. mgorny added reviewers: krytarowski, labath. mgorny added a project: LLDB. Herald added a subscriber: abidh. Remove the redundant termination clause from within the loop. Since the check is done at the end of the loop, it's entirely redundant to the 'while' condition

[Lldb-commits] [PATCH] D58228: [lldb] [lldb-server] Catch and report errors from main loop

mgorny created this revision. mgorny added reviewers: labath, krytarowski. mgorny added a project: LLDB. Herald added a subscriber: abidh. Catch the possible error from lldb-gdbserver's main loop, and report it verbosely. Currently, if the loop fails the server exits normally, rendering the probl

[Lldb-commits] [PATCH] D58229: [lldb] [MainLoop] Report errno for failed kevent()

mgorny created this revision. mgorny added reviewers: labath, krytarowski. mgorny added a project: LLDB. Herald added a subscriber: emaste. Modify the kevent() error reporting to use errno rather than returning the return value. At least on FreeBSD and NetBSD, kevent() always returns -1 in case o

[Lldb-commits] [PATCH] D58230: [lldb] [MainLoop] Add kevent() EINTR handling

mgorny created this revision. mgorny added reviewers: krytarowski, labath. mgorny added a project: LLDB. Herald added a subscriber: abidh. Add missing EINTR handling for kevent() calls. If the call is interrupted, return from Poll() as if zero events were returned and let the polling resume on ne

[Lldb-commits] [PATCH] D58177: Fix lldb-server test suite for python3

labath added a comment. Thanks for the review Stella. I was hoping someone would step in and tell me that there is a better way to do that. However :), I see two problems with your proposal: - build.py is a standalone file, and so it is not easy for it to share code with other stuff. This can

[Lldb-commits] [PATCH] D58177: Fix lldb-server test suite for python3

labath added inline comments. Comment at: packages/Python/lldbsuite/test/tools/lldb-server/lldbgdbserverutils.py:415 # Add zero-fill to the right/end (MSB side) of the value. -retval += "00" * (byte_size - len(retval) / 2) +retval += "00" * (

[Lldb-commits] [PATCH] D58177: Fix lldb-server test suite for python3

labath updated this revision to Diff 186823. labath marked an inline comment as done. labath added a comment. - rename the string conversion functions and explain their operation in more detail - add "from __future__ import division" to ensure consistency between python versions CHANGES SINCE

[Lldb-commits] [PATCH] D58230: [lldb] [MainLoop] Add kevent() EINTR handling

labath added a comment. We already had a patch for this, but it kind of got forgotten while we were figuring out how to test it. I had made a test for the behavior here https://reviews.llvm.org/D42206#980045. Could you please try it out and incorporate it into the patch (or write some other kin

[Lldb-commits] [PATCH] D58229: [lldb] [MainLoop] Report errno for failed kevent()

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. That seems right. Even the macos manpage for kevent says the error is returned through errno. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58229/new/ https

[Lldb-commits] [lldb] r354029 - [lldb] [MainLoop] Report errno for failed kevent()

Author: mgorny Date: Thu Feb 14 05:52:31 2019 New Revision: 354029 URL: http://llvm.org/viewvc/llvm-project?rev=354029&view=rev Log: [lldb] [MainLoop] Report errno for failed kevent() Modify the kevent() error reporting to use errno rather than returning the return value. At least on FreeBSD and

[Lldb-commits] [PATCH] D58229: [lldb] [MainLoop] Report errno for failed kevent()

This revision was automatically updated to reflect the committed changes. Closed by commit rL354029: [lldb] [MainLoop] Report errno for failed kevent() (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[Lldb-commits] [PATCH] D58228: [lldb] [lldb-server] Catch and report errors from main loop

This revision was automatically updated to reflect the committed changes. Closed by commit rL354030: [lldb] [lldb-server] Catch and report errors from main loop (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[Lldb-commits] [lldb] r354030 - [lldb] [lldb-server] Catch and report errors from main loop

Author: mgorny Date: Thu Feb 14 05:52:37 2019 New Revision: 354030 URL: http://llvm.org/viewvc/llvm-project?rev=354030&view=rev Log: [lldb] [lldb-server] Catch and report errors from main loop Catch the possible error from lldb-gdbserver's main loop, and report it verbosely. Currently, if the lo

[Lldb-commits] [PATCH] D58129: Move UnwindTable from ObjectFile to Module

labath marked 3 inline comments as done. labath added inline comments. Comment at: include/lldb/Core/Module.h:1108-1110 + llvm::Optional m_unwind_table; /// < Table of FuncUnwinders + /// objects created for this +

[Lldb-commits] [lldb] r354033 - Move UnwindTable from ObjectFile to Module

Author: labath Date: Thu Feb 14 06:40:10 2019 New Revision: 354033 URL: http://llvm.org/viewvc/llvm-project?rev=354033&view=rev Log: Move UnwindTable from ObjectFile to Module Summary: This is a preparatory step to enable adding extra unwind strategies by symbol file plugins. This has been discus

[Lldb-commits] [PATCH] D58129: Move UnwindTable from ObjectFile to Module

This revision was automatically updated to reflect the committed changes. labath marked an inline comment as done. Closed by commit rL354033: Move UnwindTable from ObjectFile to Module (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chan

[Lldb-commits] [PATCH] D58235: Don't source local .lldbinit in the test suite

teemperor created this revision. teemperor added a reviewer: labath. Herald added subscribers: lldb-commits, abidh. Herald added a reviewer: serge-sans-paille. Herald added a project: LLDB. As suggested by Pavel, we shouldn't let our tests parse the local .lldbinit to prevent random test failures

[Lldb-commits] [PATCH] D58235: Don't source local .lldbinit in the test suite

labath added a comment. Are you sure you're adding this to the right place? This is modifying the substitution for lldb-mi and not lldb.. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58235/new/ https://reviews.llvm.org/D58235 __

[Lldb-commits] [PATCH] D58230: [lldb] [MainLoop] Add kevent() EINTR handling

krytarowski added a comment. For EINTR we shall use `llvm::sys::RetryAfterSignal` Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58230/new/ https://reviews.llvm.org/D58230 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [PATCH] D42206: If kevent() is interrupted by signal (or is being debugged) and we get EINTR, retry

krytarowski added a comment. Herald added a project: LLVM. 'attaching a debugger produces an observable side-effect (EINTR) in the debugged process is considered a bug by the linux kernel folks' There are differences between Linux and BSD. On BSD we try hard to make return of such syscall peace

[Lldb-commits] [PATCH] D58227: [lldb] [MainLoop] Remove redundant termination clause (NFCI)

krytarowski added a comment. It looks good to me. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58227/new/ https://reviews.llvm.org/D58227 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [PATCH] D58235: Don't source local .lldbinit in the test suite

teemperor updated this revision to Diff 186850. teemperor added a comment. Ah yes, that also explains why the test suit failed. Fixed and the test now passes, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58235/new/ https://reviews.llvm.org/D58235 Files: lldb/lit/helper/tool

[Lldb-commits] [PATCH] D58227: [lldb] [MainLoop] Remove redundant termination clause (NFCI)

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. That sounds correct. The extra check must have crept in because of all the refactors this class has gone through to support all possible event handling mechanisms... Repository: rLLDB LLDB

[Lldb-commits] [PATCH] D58235: Don't source local .lldbinit in the test suite

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58235/new/ https://reviews.llvm.org/D58235 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [lldb] r354037 - [CMake] Fix RPATH handling for LLDB.framework

Author: stefan.graenitz Date: Thu Feb 14 09:34:39 2019 New Revision: 354037 URL: http://llvm.org/viewvc/llvm-project?rev=354037&view=rev Log: [CMake] Fix RPATH handling for LLDB.framework Summary: Generator expressions are not supported in the `BUILD_RPATH` target property. `BUILD_RPATH` is only

[Lldb-commits] [PATCH] D57989: [CMake] Fix RPATH handling for LLDB.framework

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb85fdd11595: [CMake] Fix RPATH handling for LLDB.framework (authored by sgraenitz). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to commit: https://reviews.llvm.

[Lldb-commits] [lldb] r354038 - Don't source local .lldbinit in the test suite

Author: teemperor Date: Thu Feb 14 09:39:19 2019 New Revision: 354038 URL: http://llvm.org/viewvc/llvm-project?rev=354038&view=rev Log: Don't source local .lldbinit in the test suite Summary: As suggested by Pavel, we shouldn't let our tests parse the local .lldbinit to prevent random test failu

[Lldb-commits] [PATCH] D58235: Don't source local .lldbinit in the test suite

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB354038: Don't source local .lldbinit in the test suite (authored by teemperor, committed by ). Changed prior to commit: https://reviews.llvm.org/D58235?vs=186850&id=186865#toc Repository: rLLDB LL

[Lldb-commits] [PATCH] D58177: Fix lldb-server test suite for python3

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. In D58177#1397873 , @labath wrote: > Thanks for the review Stella. I was hoping someone would step in and tell me > that there is a

[Lldb-commits] [PATCH] D58222: [ClangExpressionParser] Reuse the FileManager from the compiler instance.

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB354041: [ExpressionParser] Reuse the FileManager from the compiler instance. (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D58222?vs=186794&id=186866#to

[Lldb-commits] [lldb] r354041 - [ExpressionParser] Reuse the FileManager from the compiler instance.

Author: jdevlieghere Date: Thu Feb 14 10:05:43 2019 New Revision: 354041 URL: http://llvm.org/viewvc/llvm-project?rev=354041&view=rev Log: [ExpressionParser] Reuse the FileManager from the compiler instance. I was looking at the ClangExpressionParser and noticed that we have a FileManager owned b

[Lldb-commits] [PATCH] D57964: Fix potential UB when target_file directory is null

sgraenitz added a comment. Herald added a subscriber: jdoerfert. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57964/new/ https://reviews.llvm.org/D57964 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/

[Lldb-commits] [PATCH] D58193: Do not explicitly depend on llvm tools during standalone build

sgraenitz added a comment. All these targets are exported from the LLVM build-tree since D56606 and from the install-tree since D57383 . I did not revert or continue to work on D57233 yet, beca

[Lldb-commits] [PATCH] D58193: Do not explicitly depend on llvm tools during standalone build

sgraenitz added a comment. @xiaobai && @compnerd Do you know if `find_package` can tell us anything about it? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58193/new/ https://reviews.llvm.org/D58193 ___ lldb-commi

[Lldb-commits] [PATCH] D58172: Embed swig version into lldb.py in a different way

zturner added a comment. Long term, I wonder if we can just delete this entire `modify-python-lldb.py` script. it seems like the entire purpose is to make sure that the SB methods support iteration, equality, and some other basic stuff, and it does this by inserting lines of python code into t

[Lldb-commits] [PATCH] D58193: Do not explicitly depend on llvm tools during standalone build

compnerd added a comment. @sgraenitz - not really ... the `find_package` will load the `LLVMConfig.cmake` that is generated. We only have what we keep in there. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58193/new/ https://reviews.llvm.org/D58193 __

[Lldb-commits] [PATCH] D57402: build: remove custom variables

sgraenitz added a comment. I don't want to play the nitpicker here, but did you test this? If so, please provide a sample configuration command line. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57402/new/ https://reviews.llvm.org/D57402 __

[Lldb-commits] [PATCH] D58172: Embed swig version into lldb.py in a different way

labath added a comment. Yes, my long term plan is to try to get rid of this file altogether. Doing the hotpatching at runtime is an interesting idea. I may resort to that, but I think it would be better to add all of these as regular blocks of inline %pythoncode%, as that's how swig is meant to

[Lldb-commits] [lldb] r354047 - [dotest] Fix compiler version number comparison

Author: friss Date: Thu Feb 14 10:48:05 2019 New Revision: 354047 URL: http://llvm.org/viewvc/llvm-project?rev=354047&view=rev Log: [dotest] Fix compiler version number comparison dotest's version comparision function is just a lexicographical compare of the version strings. This is obviously wro

[Lldb-commits] [lldb] r354048 - Add explicit language specifier to test.

Author: adrian Date: Thu Feb 14 10:49:14 2019 New Revision: 354048 URL: http://llvm.org/viewvc/llvm-project?rev=354048&view=rev Log: Add explicit language specifier to test. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/modules-import/TestCXXModulesImport.py Modified: lldb/t

[Lldb-commits] [lldb] r354050 - [lldb] [MainLoop] Remove redundant termination clause (NFCI)

Author: mgorny Date: Thu Feb 14 10:51:21 2019 New Revision: 354050 URL: http://llvm.org/viewvc/llvm-project?rev=354050&view=rev Log: [lldb] [MainLoop] Remove redundant termination clause (NFCI) Remove the redundant termination clause from within the loop. Since the check is done at the end of th

[Lldb-commits] [PATCH] D57964: Fix potential UB when target_file directory is null

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. That code seems amazingly good to me ;-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57964/new/ https://reviews.llvm.org/D57964 ___

[Lldb-commits] [PATCH] D58219: [dotest] Fix compiler version number comparison

This revision was automatically updated to reflect the committed changes. Closed by commit rL354047: [dotest] Fix compiler version number comparison (authored by friss, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

[Lldb-commits] [PATCH] D58227: [lldb] [MainLoop] Remove redundant termination clause (NFCI)

This revision was automatically updated to reflect the committed changes. Closed by commit rL354050: [lldb] [MainLoop] Remove redundant termination clause (NFCI) (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D58193: Do not explicitly depend on llvm tools during standalone build

xiaobai added a comment. @sgraenitz: I don't think `find_package` alone will help you here. LLVMConfig doesn't necessarily tell you what's actually been built and/or installed, but it can tell you what's exported. Here's what I would do: 1. List the tools you need for `LLDB_TEST_DEPS` from LLVM

[Lldb-commits] [PATCH] D58167: Refactor user/group name resolving code

labath added a comment. I didn't get around to address the style issues yet, but I wanted to respond to one high-level comment today: > So we are currently only using the platform for the user ID resolving, but it > might be nice to keep the platform as the argument in case we need it for > so

[Lldb-commits] [PATCH] D58193: Do not explicitly depend on llvm tools during standalone build

labath added a comment. BTW, what's the reason for having super-high-fidelity list of dependencies in a standalone build? I know that they're important for in-tree builds, as that makes sure everything is built when you run "check-lldb". However, that's isn't going to help you with standalone b

[Lldb-commits] [PATCH] D55653: Check pointer results on nullptr before using them

tatyana-krasnukha updated this revision to Diff 186892. tatyana-krasnukha added a comment. Fixed misspelling CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55653/new/ https://reviews.llvm.org/D55653 Files: MICmdCmdGdbInfo.cpp MICmdCmdMiscellanous.cpp MICmnLLDBDebugSessionInfo.cpp

[Lldb-commits] [PATCH] D55653: Check pointer results on nullptr before using them

shafik added a comment. Looks like a great fix! Comment at: MIDataTypes.h:67 +template +class MIDereferenceable { +public: Can we use `llvm::Optional` instead? Then we can use `getValueOr()`. Comment at: MIDataTypes.h:71 + + T *Or(T &alt_va

[Lldb-commits] [PATCH] D55653: Check pointer results on nullptr before using them

tatyana-krasnukha added a comment. Thanks for the review! Comment at: MIDataTypes.h:67 +template +class MIDereferenceable { +public: shafik wrote: > Can we use `llvm::Optional` instead? Then we can use `getValueOr()`. Unfortunately no, with `Optional` getValue

[Lldb-commits] [PATCH] D58193: Do not explicitly depend on llvm tools during standalone build

xiaobai added a comment. In D58193#1398376 , @labath wrote: > BTW, what's the reason for having super-high-fidelity list of dependencies in > a standalone build? I know that they're important for in-tree builds, as that > makes sure everything is built w

[Lldb-commits] [PATCH] D58230: [lldb] [MainLoop] Add kevent() EINTR handling

mgorny added a comment. In D58230#1398020 , @krytarowski wrote: > For EINTR we shall use `llvm::sys::RetryAfterSignal` `kevent()` man page indicates: > All changes contained in the changelist are applied before any pending events > are read from the qu

[Lldb-commits] [PATCH] D58223: [lldb] [unittests] XFAIL two unittests failing on NetBSD

mgorny planned changes to this revision. mgorny added a comment. @labath suggested another implementation possibility on IRC, I'll be trying it tomorrow. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58223/new/ https://reviews.llvm.org/D58223 __

[Lldb-commits] [PATCH] D58230: [lldb] [MainLoop] Add kevent() EINTR handling

mgorny updated this revision to Diff 186915. mgorny edited the summary of this revision. mgorny added a comment. Herald added a subscriber: jfb. Added the test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58230/new/ https://reviews.llvm.org/D58230 Files: lldb/source/Host/commo

[Lldb-commits] [PATCH] D58222: [ClangExpressionParser] Reuse the FileManager from the compiler instance.

clayborg added a comment. This change was probably due to things changing over time and there may be more of these kinds of cleanups to be had. nice catch. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58222/new/ https://reviews.llvm.org/D58222

[Lldb-commits] [PATCH] D55653: Check pointer results on nullptr before using them

JDevlieghere added a comment. In the future please include context with the diff (-U should do the trick), it makes reviewing a lot easier. Have you considered wrapping raw strings in llvm's `StringRef`s? It looks like lldb-mi is already using some ADT classes from llvm. Unfortunately we c

[Lldb-commits] [PATCH] D58230: [lldb] [MainLoop] Add kevent() EINTR handling

krytarowski added a comment. In D58230#1398529 , @mgorny wrote: > In D58230#1398020 , @krytarowski > wrote: > > > For EINTR we shall use `llvm::sys::RetryAfterSignal` > > > `kevent()` man page indicates: > > > All

[Lldb-commits] [PATCH] D58257: Disable ExecControl/StopHook/stop-hook-threads.test on Linux

jgorbe created this revision. jgorbe added reviewers: labath, zturner. Herald added a subscriber: jdoerfert. ExecControl/StopHook/stop-hook-threads.test is flaky on Linux (it's consistently failing on my machine, but doesn't fail on a co-worker's). I'm seeing the following assertion failure:

[Lldb-commits] [PATCH] D58257: Disable ExecControl/StopHook/stop-hook-threads.test on Linux

jingham added a comment. I haven't gotten a chance to revisit the stop hooks in a long time. They definitely need some love. IMO, stop hooks should have the same semantics as breakpoint commands, the first command that causes the target to run should exit the stop hook. That way you would ne

[Lldb-commits] [lldb] r354099 - Implement GetLoadAddress for the Windows process plugin

Author: asmith Date: Thu Feb 14 20:32:50 2019 New Revision: 354099 URL: http://llvm.org/viewvc/llvm-project?rev=354099&view=rev Log: Implement GetLoadAddress for the Windows process plugin Summary: When a process is loaded, update its sections with the load address to resolve any created breakpo

[Lldb-commits] [PATCH] D56237: Implement GetLoadAddress for the Windows process plugin

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL354099: Implement GetLoadAddress for the Windows process plugin (authored by asmith, committed by ). Herald added a projec

[Lldb-commits] [lldb] r354100 - Fix for build bot problem from last change

Author: asmith Date: Thu Feb 14 22:13:59 2019 New Revision: 354100 URL: http://llvm.org/viewvc/llvm-project?rev=354100&view=rev Log: Fix for build bot problem from last change Modified: lldb/trunk/source/Plugins/Process/Windows/Common/ProcessWindows.cpp Modified: lldb/trunk/source/Plugins/Pr

[Lldb-commits] [PATCH] D58230: [lldb] [MainLoop] Add kevent() EINTR handling

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. The change looks fine to me. I don't understand all the intricacies of the RetryAfterSignal discussion (AFAICT, it does not matter what you do there, since `RunImpl::Poll` is called in a loop

[Lldb-commits] [PATCH] D58257: Disable ExecControl/StopHook/stop-hook-threads.test on Linux

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm. I think the current behavior of stop hooks with process control commands is so under-defined that it does not make sense to run this test, especially given that we're considering disallo

[Lldb-commits] [lldb] r354103 - Remove redundant semicolon after namespace-closing '}'

Author: labath Date: Thu Feb 14 23:33:37 2019 New Revision: 354103 URL: http://llvm.org/viewvc/llvm-project?rev=354103&view=rev Log: Remove redundant semicolon after namespace-closing '}' Modified: lldb/trunk/include/lldb/Symbol/SourceModule.h Modified: lldb/trunk/include/lldb/Symbol/SourceM

[Lldb-commits] [PATCH] D58193: Do not explicitly depend on llvm tools during standalone build

labath added a comment. In D58193#1398458 , @xiaobai wrote: > I think it's useful to be able to fully test lldb if you have all the > available tools even if it's built standalone. This is especially relevant > for swift-lldb, which more often than not i

[Lldb-commits] [lldb] r354104 - Embed swig version into lldb.py in a different way

Author: labath Date: Thu Feb 14 23:41:12 2019 New Revision: 354104 URL: http://llvm.org/viewvc/llvm-project?rev=354104&view=rev Log: Embed swig version into lldb.py in a different way Summary: Instead of doing string chopping on the resulting python file, get swig to output the version for us. Th

[Lldb-commits] [lldb] r354105 - Use sys.executable in lldb-dotest

Author: labath Date: Thu Feb 14 23:41:17 2019 New Revision: 354105 URL: http://llvm.org/viewvc/llvm-project?rev=354105&view=rev Log: Use sys.executable in lldb-dotest Without that, dotest.py would be executed with the default python interpreter, which may not be the same one that lldb is built wi

[Lldb-commits] [PATCH] D58172: Embed swig version into lldb.py in a different way

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB354104: Embed swig version into lldb.py in a different way (authored by labath, committed by ). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D58172?vs=186676&id=186

[Lldb-commits] [PATCH] D58177: Fix lldb-server test suite for python3

This revision was automatically updated to reflect the committed changes. Closed by commit rL354106: Fix lldb-server test suite for python3 (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D58177: Fix lldb-server test suite for python3

labath added a comment. Thank you for reviewing this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58177/new/ https://reviews.llvm.org/D58177 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[Lldb-commits] [lldb] r354106 - Fix lldb-server test suite for python3

Author: labath Date: Thu Feb 14 23:47:06 2019 New Revision: 354106 URL: http://llvm.org/viewvc/llvm-project?rev=354106&view=rev Log: Fix lldb-server test suite for python3 Summary: This patch finishes the python3-ification of the lldb-server test suite. It reverts the partial attempt in r352709 t