[Lldb-commits] [PATCH] D56322: [Reproducers] SBReproducer framework

labath added a comment. Thank you. I think this looks much better now. It occurred to me that the (de)serializer classes are fully standalone. Since they already have a comprehensive test suite, do you think it would make sense to split them off into a separate patch, which can be committed sep

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

labath added a comment. In D56230#1365898 , @Hui wrote: > Hello labath, I am thinking maybe it is just because the windows command > 'dir' can't interpret "\\" in the root directory path. For example, > > This is working > "C:\\WINDOWS\\system32\\cmd.exe

[Lldb-commits] [PATCH] D56237: Implement GetLoadAddress for the Windows process plugin

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. Going to the Host straight from the DynamicLoader is the worst possible option, since then this code will not be correct for remote processes (it will just randomly pick up some data

[Lldb-commits] [PATCH] D56602: Move FileAction, ProcessInfo and ProcessLaunchInfo from Target to Host

labath added a comment. Yep, I have only one or two more of these to do and then the only source of circular dependencies will be `Host/$OS/Symbols.cpp`. That one is going to be tricky, but I have some ideas how to solve that. I'll send an email about that once I'm ready. CHANGES SINCE LAST A

[Lldb-commits] [lldb] r353047 - Move FileAction, ProcessInfo and ProcessLaunchInfo from Target to Host

Author: labath Date: Mon Feb 4 06:28:08 2019 New Revision: 353047 URL: http://llvm.org/viewvc/llvm-project?rev=353047&view=rev Log: Move FileAction, ProcessInfo and ProcessLaunchInfo from Target to Host Summary: These classes describe the details of the process we are about to launch, and so the

[Lldb-commits] [PATCH] D56602: Move FileAction, ProcessInfo and ProcessLaunchInfo from Target to Host

This revision was automatically updated to reflect the committed changes. Closed by commit rL353047: Move FileAction, ProcessInfo and ProcessLaunchInfo from Target to Host (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [PATCH] D56737: [SymbolFile] Split ParseVariablesForContext into two functions.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56737/new/ https://reviews.llvm.org/D56737 ___ lldb-commits mailing list

[Lldb-commits] [lldb] r353049 - Fixes for the ProcessLaunchInfo move

Author: labath Date: Mon Feb 4 07:03:06 2019 New Revision: 353049 URL: http://llvm.org/viewvc/llvm-project?rev=353049&view=rev Log: Fixes for the ProcessLaunchInfo move Modified: lldb/trunk/source/Plugins/Platform/MacOSX/objcxx/PlatformiOSSimulatorCoreSimulatorSupport.h lldb/trunk/sourc

[Lldb-commits] [PATCH] D56904: [NativePDB] Process virtual bases in the correct order

aleksandr.urakov added a comment. Ping! What do you think about it? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56904/new/ https://reviews.llvm.org/D56904 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D55318: [Expressions] Add support of expressions evaluation in some object's context

aleksandr.urakov added a comment. Ping! Can you take a look, please? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55318/new/ https://reviews.llvm.org/D55318 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [PATCH] D56237: Implement GetLoadAddress for the Windows process plugin

Hui added inline comments. Comment at: source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp:82 + // Second, try through the underlying platform. + load_addr = Host::GetProcessBaseAddress(m_process->GetID()); + if (load_addr != LLDB_INVALID_ADDRESS) -

[Lldb-commits] [PATCH] D56237: Implement GetLoadAddress for the Windows process plugin

labath added inline comments. Comment at: source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp:82 + // Second, try through the underlying platform. + load_addr = Host::GetProcessBaseAddress(m_process->GetID()); + if (load_addr != LLDB_INVALID_ADDRESS) --

[Lldb-commits] [PATCH] D57689: Adds property to force enabling of GDB JIT loader for MacOS

yurydelendik created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Based on https://gist.github.com/thlorenz/30bf0a3f67b1d97b2945#patching-and-rebuilding The functionality was disabled at https://github.com/llvm/llvm-project/commit/521c2278abb16f0148cef1b

[Lldb-commits] [PATCH] D57689: Adds property to force enabling of GDB JIT loader for MacOS

yurydelendik updated this revision to Diff 185053. yurydelendik added a comment. Fix GetEnableLoaderForDarwin name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57689/new/ https://reviews.llvm.org/D57689 Files: lldb/source/Plugins/JITLoader/GDB/

[Lldb-commits] [PATCH] D56237: Implement GetLoadAddress for the Windows process plugin

Hui added a comment. In D56237#1383070 , @labath wrote: > Going to the Host straight from the DynamicLoader is the worst possible > option, since then this code will not be correct for remote processes (it > will just randomly pick up some data from the

[Lldb-commits] [PATCH] D56237: Implement GetLoadAddress for the Windows process plugin

Hui added inline comments. Comment at: source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp:82 + // Second, try through the underlying platform. + load_addr = Host::GetProcessBaseAddress(m_process->GetID()); + if (load_addr != LLDB_INVALID_ADDRESS) -

[Lldb-commits] [PATCH] D56237: Implement GetLoadAddress for the Windows process plugin

labath added a comment. In D56237#1383232 , @Hui wrote: > In D56237#1383070 , @labath wrote: > > > Going to the Host straight from the DynamicLoader is the worst possible > > option, since then this code will not b

[Lldb-commits] [PATCH] D51578: Contiguous .debug_info+.debug_types for D32167

clayborg added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:693-707 +DataBufferHeap *databufferheap = new DataBufferHeap(); +DataBufferSP databuffer = DataBufferSP(databufferheap); +databufferheap->AppendData( +debug_in

[Lldb-commits] [PATCH] D57552: Handle "." in target.source-map in PathMapListing::FindFiles

jingham marked an inline comment as done. jingham added inline comments. Comment at: source/Target/PathMappingList.cpp:223 + + if (prefix_ref == ".") { +prefix_is_relative = true; clayborg wrote: > We are we finding a "." in any path now? I tho

[Lldb-commits] [PATCH] D56904: [NativePDB] Process virtual bases in the correct order

zturner added a comment. In D56904#1383148 , @aleksandr.urakov wrote: > Ping! What do you think about it? Generally the change looks good, but I'm not sure why the compiler can't properly compile the source file. I know it's something to do with the

[Lldb-commits] [PATCH] D57689: Adds property to force enabling of GDB JIT loader for MacOS

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. It would be better to have the setting be an enum of "on/off/default", and then have the somebody - the current DynamicLoader plugin seems the best somebody - provide the default v

[Lldb-commits] [lldb] r353087 - Update stale comment in lang/c/struct_types/main.c

Author: jdevlieghere Date: Mon Feb 4 12:33:35 2019 New Revision: 353087 URL: http://llvm.org/viewvc/llvm-project?rev=353087&view=rev Log: Update stale comment in lang/c/struct_types/main.c rdar://47322760 Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/struct_types/main.c Modifi

Re: [Lldb-commits] [lldb] r353087 - Update stale comment in lang/c/struct_types/main.c

> On Feb 4, 2019, at 12:33 PM, Jonas Devlieghere via lldb-commits > wrote: > > Author: jdevlieghere > Date: Mon Feb 4 12:33:35 2019 > New Revision: 353087 > > URL: http://llvm.org/viewvc/llvm-project?rev=353087&view=rev > Log: > Update stale comment in lang/c/struct_types/main.c > > rdar://

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

asmith added a comment. Thanks for the feedback and interesting discussion! If no more comments, let's go with this version for now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56230/new/ https://reviews.llvm.org/D56230 ___ lldb-commits

[Lldb-commits] [PATCH] D57714: [Reproducers] Instrumentation Framework: Serialization

JDevlieghere created this revision. JDevlieghere added reviewers: labath, davide. JDevlieghere added a project: LLDB. Herald added a subscriber: mgorny. This is the is serialization/deserialization part of the reproducer instrumentation framework. Repository: rLLDB LLDB https://reviews.llvm.

[Lldb-commits] [PATCH] D56322: [Reproducers] SBReproducer framework

JDevlieghere marked 11 inline comments as done. JDevlieghere added a comment. In D56322#1382971 , @labath wrote: > Thank you. I think this looks much better now. > > It occurred to me that the (de)serializer classes are fully standalone. Since > they alre

[Lldb-commits] [PATCH] D57689: Adds property to force enabling of GDB JIT loader for MacOS

yurydelendik updated this revision to Diff 185164. yurydelendik added a comment. - Change to on/off/default property. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57689/new/ https://reviews.llvm.org/D57689 Files: lldb/source/Plugins/JITLoader/G

[Lldb-commits] [PATCH] D57689: Adds property to force enabling of GDB JIT loader for MacOS

jingham added a comment. That looks good. Could you add a test for this setting to the ./functionalities/jitloader_gdb/TestJITLoaderGDB.py test? I wouldn't test that the default has any particular behavior because that might change over time. But test that if you turn it on, you do get load

[Lldb-commits] [PATCH] D55318: [Expressions] Add support of expressions evaluation in some object's context

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Thanks for adding the ObjC tests! I had two trivial requests for the test comments to be a little clearer, but even without that this is fine. Comment at: packages/Pytho

[Lldb-commits] [lldb] r353130 - [Python2 to Python 3] Fix print -> print().

Author: davide Date: Mon Feb 4 16:59:57 2019 New Revision: 353130 URL: http://llvm.org/viewvc/llvm-project?rev=353130&view=rev Log: [Python2 to Python 3] Fix print -> print(). Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.p

[Lldb-commits] [PATCH] D56221: [lldb] Make frame recognizers vend synthesized eValueTypeVariableArgument values

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56221/new/ https://reviews.llvm.org/D56221 ___ lldb-commi

[Lldb-commits] [PATCH] D56322: [Reproducers] SBReproducer framework

JDevlieghere updated this revision to Diff 185207. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56322/new/ https://reviews.llvm.org/D56322 Files: include/lldb/API/SBReproducer.h include/lldb/Utility/ReproducerInstrumentation.h source/API/CMakeLists.txt source/API/SBReproducer.cp

[Lldb-commits] [PATCH] D56322: [Reproducers] SBReproducer framework

JDevlieghere updated this revision to Diff 185208. JDevlieghere added a comment. Add context CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56322/new/ https://reviews.llvm.org/D56322 Files: include/lldb/API/SBReproducer.h include/lldb/Utility/ReproducerInstrumentation.h source/API

[Lldb-commits] [PATCH] D56322: [Reproducers] SBReproducer framework

JDevlieghere added a comment. (I plan to add another test that deals with returning objects) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56322/new/ https://reviews.llvm.org/D56322 ___ lldb-commits mailing list lldb-commits@lists.llvm.org