[Lldb-commits] [PATCH] D57011: Refactor HAVE_LIBCOMPRESSION and related code in GDBRemoteCommunication

teemperor updated this revision to Diff 183265. teemperor added a comment. - Added missing include. Thanks for testing Jason! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57011/new/ https://reviews.llvm.org/D57011 Files: include/lldb/Host/Config.h source/Plugins/Process/gdb-remot

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha added inline comments. Comment at: source/Plugins/Architecture/Arc/ArchitectureArc.cpp:1-8 +//===-- ArchitectureArc.cpp -*- C++ -*-===// +// +// The LLVM Compiler Infrastructure +// +// This file is distri

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha updated this revision to Diff 183301. tatyana-krasnukha added a comment. Herald added subscribers: jsji, atanasyan, kbarton, nemanjai, sdardis. Moved ARC flags enum inside the `ArchitectureArc` class; Made `OverrideStopInfo` with empty body instead of being pure virtual. If this

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha updated this revision to Diff 183310. tatyana-krasnukha added a comment. Updated new file headers to reflect the new license Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55718/new/ https://reviews.llvm.org/D55718 Files: include/lldb/Core/A

[Lldb-commits] [lldb] r352058 - [CMake] Get back some variables used in AddLLVM.cmake

Author: stefan.graenitz Date: Thu Jan 24 08:02:21 2019 New Revision: 352058 URL: http://llvm.org/viewvc/llvm-project?rev=352058&view=rev Log: [CMake] Get back some variables used in AddLLVM.cmake This fixes 'gtest/gtest.h' file not found when building unit tests after r351863. Modified: lld

[Lldb-commits] [PATCH] D56531: [CMake] Replace use of llvm-config with LLVM and Clang CMake packages

sgraenitz added a comment. Thanks -- and one more :) https://reviews.llvm.org/rL352058 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56531/new/ https://reviews.llvm.org/D56531 ___ lldb-commits mailing list lldb-commit

[Lldb-commits] [PATCH] D57091: [www] Remove implemented Open Project

This revision was automatically updated to reflect the committed changes. Closed by commit rL352065: [www] Remove implemented Open Project (authored by omtcyfz, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D57091?vs=183071&id=183330#

[Lldb-commits] [lldb] r352072 - Add decorator support for the DWARF version produced by the compiler

Author: adrian Date: Thu Jan 24 10:24:14 2019 New Revision: 352072 URL: http://llvm.org/viewvc/llvm-project?rev=352072&view=rev Log: Add decorator support for the DWARF version produced by the compiler and mark up some tests failing in http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-mat

[Lldb-commits] [lldb] r352073 - Rename test directory

Author: adrian Date: Thu Jan 24 10:24:17 2019 New Revision: 352073 URL: http://llvm.org/viewvc/llvm-project?rev=352073&view=rev Log: Rename test directory Added: lldb/trunk/packages/Python/lldbsuite/test/expression_command/scoped_enums/ lldb/trunk/packages/Python/lldbsuite/test/expressio

[Lldb-commits] [PATCH] D56196: ProcessLaunchInfo: Remove Target reference

Hui added inline comments. Comment at: lldb/trunk/source/Target/ProcessLaunchInfo.cpp:220 + if (!m_pty->OpenFirstAvailableMaster(open_flags, nullptr, 0)) { +return llvm::createStringError(llvm::inconvertibleErrorCode(), + "PTY::OpenFirstAvai

[Lldb-commits] [PATCH] D56237: Implement GetFileLoadAddress for the Windows process plugin

Hui added a comment. In D56237#1344682 , @labath wrote: > I think there is something wrong here. Normally, it should be the job of the > dynamic loader plugin to figure out where a module got loaded (and populate > the target section load list). `Process

[Lldb-commits] [lldb] r352078 - [CMake] Remove duplicated cache variable. NFC.

Author: xiaobai Date: Thu Jan 24 10:52:19 2019 New Revision: 352078 URL: http://llvm.org/viewvc/llvm-project?rev=352078&view=rev Log: [CMake] Remove duplicated cache variable. NFC. Modified: lldb/trunk/cmake/modules/LLDBStandalone.cmake Modified: lldb/trunk/cmake/modules/LLDBStandalone.cmake

[Lldb-commits] [lldb] r352086 - Unbreak windows bots

Author: adrian Date: Thu Jan 24 11:16:45 2019 New Revision: 352086 URL: http://llvm.org/viewvc/llvm-project?rev=352086&view=rev Log: Unbreak windows bots Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py URL: http

[Lldb-commits] [lldb] r352094 - Only check the dwarf version when using the dwarf category

Author: adrian Date: Thu Jan 24 12:09:17 2019 New Revision: 352094 URL: http://llvm.org/viewvc/llvm-project?rev=352094&view=rev Log: Only check the dwarf version when using the dwarf category Modified: lldb/trunk/packages/Python/lldbsuite/test/decorators.py lldb/trunk/packages/Python/lldb

[Lldb-commits] [lldb] r352103 - [Scalar] Clarify the constructor from APInt and document through a test.

Author: davide Date: Thu Jan 24 12:55:12 2019 New Revision: 352103 URL: http://llvm.org/viewvc/llvm-project?rev=352103&view=rev Log: [Scalar] Clarify the constructor from APInt and document through a test. I want to add 512-bits support but I first want to make sure I'm not breaking anything obvi

[Lldb-commits] [lldb] r352111 - Remove NO_DEBUGINFO_TESTCASE from testcase.

Author: adrian Date: Thu Jan 24 13:32:32 2019 New Revision: 352111 URL: http://llvm.org/viewvc/llvm-project?rev=352111&view=rev Log: Remove NO_DEBUGINFO_TESTCASE from testcase. This makes it easier to exclude the test n bots that test earlier DWARF formats, also it feels like this is the better d

[Lldb-commits] [lldb] r352114 - Add unittests to the Xcode gtest target.

Author: jingham Date: Thu Jan 24 14:03:36 2019 New Revision: 352114 URL: http://llvm.org/viewvc/llvm-project?rev=352114&view=rev Log: Add unittests to the Xcode gtest target. A handful of test files had been added to lldb, but not to the appropriate target in the Xcode project. So they weren't b

[Lldb-commits] [PATCH] D57193: [lldb] [Process/NetBSD] Add missing linkage to -lutil

mgorny created this revision. mgorny added a reviewer: krytarowski. Herald added a subscriber: abidh. Add missing linkage to fix build failure with LLD: ld: error: undefined symbol: kinfo_getvmmap >>> referenced by NativeProcessNetBSD.cpp >>> NativeProcessNetBSD.cpp.o:(lldb_p

[Lldb-commits] [PATCH] D57195: Add UUID::SetFromOptionalStringRef, use it in DynamicLoaderDarwin

jingham created this revision. jingham added reviewers: jasonmolenda, labath. Herald added subscribers: lldb-commits, abidh. When you build a macOS binary with -no_uuid, we get a binary blob of all 0's from the file, and we read that in with UUID::fromOptionalData, so we get an invalid UUID. Wh

[Lldb-commits] [PATCH] D57194: [CMake] Use llvm-tblgen from NATIVE LLVM build when cross-compiling

xiaobai created this revision. xiaobai added reviewers: compnerd, sgraenitz. Herald added a subscriber: mgorny. When cross-compiling LLDB, we want to use llvm-tblgen built for the host, not the target. https://reviews.llvm.org/D57194 Files: cmake/modules/LLDBStandalone.cmake Index: cmake/mo

[Lldb-commits] [lldb] r352116 - [Process/NetBSD] Add missing linkage to -lutil

Author: mgorny Date: Thu Jan 24 14:20:47 2019 New Revision: 352116 URL: http://llvm.org/viewvc/llvm-project?rev=352116&view=rev Log: [Process/NetBSD] Add missing linkage to -lutil Add missing linkage to fix build failure with LLD: ld: error: undefined symbol: kinfo_getvmmap >>> referenced by

[Lldb-commits] [PATCH] D57193: [lldb] [Process/NetBSD] Add missing linkage to -lutil

This revision was automatically updated to reflect the committed changes. Closed by commit rL352116: [Process/NetBSD] Add missing linkage to -lutil (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D57193?vs=183397&id

[Lldb-commits] [PATCH] D57195: Add UUID::SetFromOptionalStringRef, use it in DynamicLoaderDarwin

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57195/new/ https://reviews.llvm.org/D57195 ___ lldb-commits

[Lldb-commits] [lldb] r352122 - Add UUID::SetFromOptionalStringRef, use it in DynamicLoaderDarwin

Author: jingham Date: Thu Jan 24 14:43:44 2019 New Revision: 352122 URL: http://llvm.org/viewvc/llvm-project?rev=352122&view=rev Log: Add UUID::SetFromOptionalStringRef, use it in DynamicLoaderDarwin We use UUID::fromOptionalData to read UUID's from the Mach-O files, so UUID's of all 0's are inva

[Lldb-commits] [PATCH] D57195: Add UUID::SetFromOptionalStringRef, use it in DynamicLoaderDarwin

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB352122: Add UUID::SetFromOptionalStringRef, use it in DynamicLoaderDarwin (authored by jingham, committed by ). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57195/new

Re: [Lldb-commits] [lldb] r352116 - [Process/NetBSD] Add missing linkage to -lutil

Merged to 8.0 in r352134. Please let me know if there are any follow-ups. Thanks, Hans On Thu, Jan 24, 2019 at 2:20 PM Michal Gorny via lldb-commits wrote: > > Author: mgorny > Date: Thu Jan 24 14:20:47 2019 > New Revision: 352116 > > URL: http://llvm.org/viewvc/llvm-project?rev=352116&view=rev

[Lldb-commits] [PATCH] D56822: [WIP] Tool to insert SBReproducer macros

JDevlieghere updated this revision to Diff 183442. JDevlieghere added a comment. - Update files in place. - Check for existing macros. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56822/new/ https://reviews.llvm.org/D56822 Files: tools/CMakeLists.txt tools/sbrepro/CMakeLists.txt

[Lldb-commits] [PATCH] D57213: [Scalar] Add support for 512-bits values.

davide created this revision. davide added a reviewer: clayborg. rdar://problem/46886288 https://reviews.llvm.org/D57213 Files: lldb/include/lldb/Utility/Scalar.h lldb/source/Utility/RegisterValue.cpp lldb/source/Utility/Scalar.cpp lldb/unittests/Utility/ScalarTest.cpp Index: lldb/unit

[Lldb-commits] [PATCH] D57213: [Scalar] Add support for 512-bits values.

davide added a comment. @clayborg, this is fairly mechanical, but I would appreciate if you can sign it off. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57213/new/ https://reviews.llvm.org/D57213 ___ lldb-commits mailing list lldb-commit

[Lldb-commits] [PATCH] D56322: SBReproducer prototype

JDevlieghere updated this revision to Diff 183458. JDevlieghere added a comment. Rebase on recent reproducer changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56322/new/ https://reviews.llvm.org/D56322 Files: include/lldb/API/SBReproducer.h include/lldb/Utility/Reproducer.h.re

[Lldb-commits] [PATCH] D56822: [WIP] Tool to insert SBReproducer macros

JDevlieghere updated this revision to Diff 183470. JDevlieghere added a comment. - Skip unsupported signatures (function pointers and void*) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56822/new/ https://reviews.llvm.org/D56822 Files: tools/CMakeLists.txt tools/sbrepro/CMakeLists

[Lldb-commits] [lldb] r352158 - Remove a warning in DynamicLoaderDarwin::UpdateImageLoadAddress

Author: jmolenda Date: Thu Jan 24 19:01:48 2019 New Revision: 352158 URL: http://llvm.org/viewvc/llvm-project?rev=352158&view=rev Log: Remove a warning in DynamicLoaderDarwin::UpdateImageLoadAddress when the binary loaded in memory has a section that we cannot find in the on-disk version. I added

[Lldb-commits] [lldb] r352159 - Define the _fltused symbol in one lldb test as well, post-r352076.

Author: jyknight Date: Thu Jan 24 19:21:23 2019 New Revision: 352159 URL: http://llvm.org/viewvc/llvm-project?rev=352159&view=rev Log: Define the _fltused symbol in one lldb test as well, post-r352076. Modified: lldb/trunk/lit/SymbolFile/NativePDB/function-types-builtins.cpp Modified: lldb/t