[Lldb-commits] [PATCH] D57091: [www] Remove implemented Open Project

2019-01-23 Thread Kirill Bobyrev via Phabricator via lldb-commits
kbobyrev created this revision. kbobyrev added a reviewer: aprantl. kbobyrev added a project: LLDB. "Open LLVM Projects" page is used by students willing to apply for Google Summer of Code, this patch updates the page by removing the "Reimplement LLDB's command-line commands using the public SB

[Lldb-commits] [PATCH] D57091: [www] Remove implemented Open Project

2019-01-23 Thread Kirill Bobyrev via Phabricator via lldb-commits
kbobyrev added a comment. @aprantl if there is still some work left for GSoC/potential contributors, feel free to mention it and then it should be just updated for the future. I couldn't infer whether there is still a chunk of work to be done from the project report, but you might have more inf

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

2019-01-23 Thread Tatyana Krasnukha via Phabricator via lldb-commits
tatyana-krasnukha updated this revision to Diff 183110. tatyana-krasnukha added a comment. Herald added a subscriber: llvm-commits. Addressed comments Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55718/new/ https://reviews.llvm.org/D55718 Files: include/lldb/C

[Lldb-commits] [PATCH] D55724: [ARC] Add SystemV ABI

2019-01-23 Thread Tatyana Krasnukha via Phabricator via lldb-commits
tatyana-krasnukha updated this revision to Diff 183111. tatyana-krasnukha added a subscriber: anton.kolesov. tatyana-krasnukha added a comment. Updated according to D55718 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55724/new/

[Lldb-commits] [PATCH] D57091: [www] Remove implemented Open Project

2019-01-23 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Thanks, LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57091/new/ https://reviews.llvm.org/D57091 ___ lldb-commits mailing list l

[Lldb-commits] [PATCH] D57037: BreakpadRecords: Address post-commit feedback

2019-01-23 Thread Leonard Mosescu via Phabricator via lldb-commits
lemo accepted this revision. lemo added a comment. This revision is now accepted and ready to land. Looks good - the all-zero UUID case is a bit unfortunate but it seems we have to handle it (like Greg suggested) Comment at: source/Plugins/ObjectFile/Breakpad/BreakpadRecords.c

[Lldb-commits] [PATCH] D57037: BreakpadRecords: Address post-commit feedback

2019-01-23 Thread Pavel Labath via Phabricator via lldb-commits
labath marked 5 inline comments as done. labath added a comment. After some internal discussion, it seems that the situation with the all-zero UUIDs is as follows: - breakpad symbol files do not attach a special meaning to a zero UUID - if a file does not have a build-id, the dump_syms tool wil

Re: [Lldb-commits] [PATCH] D57037: BreakpadRecords: Address post-commit feedback

2019-01-23 Thread Leonard Mosescu via lldb-commits
> > After some internal discussion, it seems that the situation with the > all-zero UUIDs is as follows: > - breakpad symbol files do not attach a special meaning to a zero UUID - > if a file does not have a build-id, the dump_syms tool will use a hash of > the first page of the text section (or so

[Lldb-commits] [PATCH] D57011: Refactor HAVE_LIBCOMPRESSION and related code in GDBRemoteCommunication

2019-01-23 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda added a comment. Sorry for the delay in checking this out. It works fine. You need to add a #include "lldb/Host/Config.h" to GDBRemoteCommunication.h. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57011/new/ https://reviews.llvm.org/D57011

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

2019-01-23 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added inline comments. Comment at: source/Plugins/Architecture/Arc/ArchitectureArc.cpp:1-8 +//===-- ArchitectureArc.cpp -*- C++ -*-===// +// +// The LLVM Compiler Infrastructure +// +// This file is distributed und

[Lldb-commits] [lldb] r352009 - Skip test on clang <8 instead of 7

2019-01-23 Thread Adrian Prantl via lldb-commits
Author: adrian Date: Wed Jan 23 18:37:28 2019 New Revision: 352009 URL: http://llvm.org/viewvc/llvm-project?rev=352009&view=rev Log: Skip test on clang <8 instead of 7 Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/tail_call_frames/sbapi_support/TestTailCallFrameSBAPI.py

[Lldb-commits] [lldb] r352021 - BreakpadRecords: Address post-commit feedback

2019-01-23 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Jan 23 20:17:59 2019 New Revision: 352021 URL: http://llvm.org/viewvc/llvm-project?rev=352021&view=rev Log: BreakpadRecords: Address post-commit feedback Summary: This addresses the issues raised in D56844. It removes the accessors from the breakpad record structures by m

[Lldb-commits] [PATCH] D57037: BreakpadRecords: Address post-commit feedback

2019-01-23 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. labath marked an inline comment as done. Closed by commit rLLDB352021: BreakpadRecords: Address post-commit feedback (authored by labath, committed by ). Changed prior to commit: https://reviews.llvm.org/D57037?vs=182847&