[Lldb-commits] [PATCH] D56010: [NativePDB] Fix setting breakpoint by file and line

aleksandr.urakov accepted this revision. aleksandr.urakov added a comment. This revision is now accepted and ready to land. LGTM too! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56010/new/ https://reviews.llvm.org/D56010 ___ lldb-commits

[Lldb-commits] [PATCH] D53530: Fix (and improve) the support for C99 variable length array types

jankratochvil added subscribers: dblaikie, jankratochvil. jankratochvil added a comment. There is a regression in trunk clang+lldb. Using either 7.0 clang or 7.0 lldb makes the testcases PASS but both trunk clang and trunk lldb makes the testcase FAIL. This commit (rL346165

[Lldb-commits] [PATCH] D55998: ELF: create "container" sections from PT_LOAD segments

joerg added a comment. In D55998#1340448 , @jankratochvil wrote: > > it is in theory possible to create an elf file where only a part of a > > section would belong to some segment (and another part to a different one). > > ELF standard

[Lldb-commits] [PATCH] D56068: Use reference only for DW_FORM_ref*

jankratochvil created this revision. jankratochvil added reviewers: clayborg, aprantl. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. D53530 could interpret `DW_AT_count` in `DW_FORM_data1` as a DIE reference as it did not verify it

[Lldb-commits] [PATCH] D53530: Fix (and improve) the support for C99 variable length array types

jankratochvil added inline comments. Comment at: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3476 + if (DWARFDIE var_die = die.GetReferencedDIE(DW_AT_count)) { +if (var_die.Tag() == DW_TAG_variable) + if (exe_c