[Lldb-commits] [PATCH] D54385: Remove comments after header includes.

teemperor added a comment. Do we also want to get rid of the `// C Includes` comments that are in some files? LLVM isn't using them either and just removing lines doesn't make git blame more complicated. Comment at: source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.cpp:3

[Lldb-commits] [PATCH] D44060: [lldb] Fix "code requires global destructor" warning in g_architecture_mutex

kubamracek added a comment. Ping. https://reviews.llvm.org/D44060 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D44081: [lldb] Add synthetic frontend for _NSCallStackArray

kubamracek added a reviewer: aprantl. kubamracek added a comment. Ping. https://reviews.llvm.org/D44081 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D44073: [lldb] Refactor ObjC/NSException.cpp (cleanup, avoid code duplication). NFC.

kubamracek added a reviewer: aprantl. kubamracek added a comment. Ping. https://reviews.llvm.org/D44073 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

kubamracek added a reviewer: aprantl. kubamracek added a comment. Ping. https://reviews.llvm.org/D43884 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D54385: Remove comments after header includes.

JDevlieghere added a comment. In https://reviews.llvm.org/D54385#1294534, @teemperor wrote: > Do we also want to get rid of the `// C Includes` comments that are in some > files? LLVM isn't using them either and just removing lines doesn't make git > blame more complicated. Yup, I'll do that

[Lldb-commits] [PATCH] D43886: [lldb] Add GetCurrentException and GetCurrentExceptionBacktrace APIs to SBThread

kubamracek updated this revision to Diff 173603. kubamracek added a comment. Updating patch for the recently-landed StackFrameRecognizers. https://reviews.llvm.org/D43886 Files: include/lldb/API/SBThread.h include/lldb/Target/StackFrameRecognizer.h include/lldb/Target/Thread.h source/AP

[Lldb-commits] [PATCH] D43886: [lldb] Add GetCurrentException and GetCurrentExceptionBacktrace APIs to SBThread

kubamracek added a comment. Hi, I've updated this patch after a while. Since then, StackFrameRecognizers have already landed, so this patch now just adds one subclass of a StackFrameRecognizer. > It seems however like providing some interesting ValueObjects is a pretty > common thing to do, so