This revision was automatically updated to reflect the committed changes.
Closed by commit rL345127: [LLDB] - Add support for DW_RLE_base_address and
DW_RLE_offset_pair entries (. (authored by grimar, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://revi
aleksandr.urakov updated this revision to Diff 170852.
aleksandr.urakov added a comment.
I've added the test. Can you see, please, is it ok?
https://reviews.llvm.org/D53361
Files:
include/lldb/API/SBThreadPlan.h
packages/Python/lldbsuite/test/functionalities/step_scripted/Makefile
package
grimar created this revision.
grimar added reviewers: LLDB, clayborg.
Herald added subscribers: JDevlieghere, aprantl.
Currently, we always parse the `length` field of DW_LLE_startx_length entry as
U32.
That is correct for pre-standard definition:
https://gcc.gnu.org/wiki/DebugFission - "A start
aleksandr.urakov updated this revision to Diff 170889.
aleksandr.urakov added a comment.
I've implemented things as Greg have said, except for a few moments:
- haven't added `AddSymbols` to `SymbolVendor` because it is not used anywhere,
and we can just use `SymbolFile::AddSymbols` directly insi
aprantl added a comment.
It looks like this might have broken the bots, could you please take a look?
http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/11671/consoleFull#434797663d489585b-5106-414a-ac11-3ff90657619c
TEST 'lldb :: Breakpoint/debug_rnglist_rlestartend
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
Seems reasonable.
https://reviews.llvm.org/D48226
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
Author: kuba.brecka
Date: Wed Oct 24 08:59:31 2018
New Revision: 345155
URL: http://llvm.org/viewvc/llvm-project?rev=345155&view=rev
Log:
[lldb] Remove enableThreadSanitizer from shared Xcode schemes
This was probably committed accidentally and default Xcode builds of LLDB now
have TSan on. Let'
kubamracek closed this revision.
kubamracek added a comment.
r345155.
https://reviews.llvm.org/D48226
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
shafik created this revision.
shafik added reviewers: jingham, davide.
Herald added a reviewer: EricWF.
Herald added a subscriber: christof.
We currently support formatting for std::string and std::wstring but not
std::u16string and std::u32string which was added with C++11. This adds support
fo
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Very close. Just a bit of cleanup now that we changed SymbolFilePDB where we
don't seem to need m_public_symbols anymore. See inlined comments and let me
know what you think
=
jingham accepted this revision.
jingham added a comment.
That looks right. Thanks for adding the test!
https://reviews.llvm.org/D53361
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
clayborg added a comment.
Zach: yes the module mutex needs to be recursive. Plenty of places where the
symbol file stuff can call other symbol file APIs. To avoid A/B locking issues,
the lldb_private::Module, lldb_private::ObjectFile and
lldb_private::SymbolVendor and lldb_private::SymbolFile a
lemo added a comment.
drive by CR notes:
1. does this handle forwarding imports? (it doesn't seem to from a quick glance
at the code)
2. can you please add, or extend the existing test to cover the transitive
case? A simple dag would suffice (ex. make both dllA and dllB implicitly import
dllC)
zturner created this revision.
zturner added reviewers: clayborg, labath, jingham.
Herald added subscribers: JDevlieghere, aprantl.
Previously the Module would parse a type name into scope and base name during a
lookup and only give the SymbolFile plugin the base name, then it would filter
the r
zturner added a comment.
Note that AFAICT, native PDB plugin is now the only plugin where you can do
`type lookup -- NS::Struct::Local` and have it return instantly. On the
regular PDB plugin it doesn't work at all (returns no results). On the DWARF
plugin, I haven't tested, but it will eithe
JDevlieghere added a comment.
ping
https://reviews.llvm.org/D52772
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
aprantl added a comment.
Just FYI, I just came across this patch while debugging strangeness in
PlatformDarwin.cpp and unfortunately this patch isn't NFC.
`VersionTuple::tryParse()` can deal with an optional third (micro) component,
but the parse will fail when there are extra characters after
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
That looks fine.
https://reviews.llvm.org/D52772
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
Author: jdevlieghere
Date: Wed Oct 24 15:04:20 2018
New Revision: 345207
URL: http://llvm.org/viewvc/llvm-project?rev=345207&view=rev
Log:
[Settings] Add -force flag to "settings set"
The -force option allows you to pass an empty value to settings set to
reset the value to its default. This means
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345207: [Settings] Add -force flag to "settings
set" (authored by JDevlieghere, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D52772?vs=17025
JDevlieghere added a comment.
@teemperor Can you have another look?
https://reviews.llvm.org/D52651
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
aprantl created this revision.
aprantl added reviewers: jingham, clayborg, labath.
This fixes a bug PlatformDarwin::SDKSupportsModule introduced by
https://reviews.llvm.org/D47889.
VersionTuple::tryParse() can deal with an optional third (micro) component, but
the parse will fail when there are
zturner added a comment.
Hi Greg, any thoughts on this?
https://reviews.llvm.org/D53597
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
This looks reasonable to me.
https://reviews.llvm.org/D53656
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cg
teemperor requested changes to this revision.
teemperor added a comment.
This revision now requires changes to proceed.
Sorry, this somehow didn't show up in my review queue. I think this can land
after two minor things are fixed:
- I think unknown arguments to write/read shouldn't be silently i
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
Woops, I wanted to accept in my previous comment.
https://reviews.llvm.org/D52651
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
JDevlieghere added a comment.
Thanks Raphael!
With r345207 the empty behavior only works if you explicitly specify `-force`.
I'll address the second issue before landing this.
https://reviews.llvm.org/D52651
___
lldb-commits mailing list
lldb-comm
jingham added a comment.
I worry that your patch changes the behavior when you add the type_class
explicitly in the lookup (i.e. look up "struct Struct" not "Struct". That
should work...
Note, this doesn't currently work in type lookup:
(lldb) type lookup "struct Foo"
no type was found ma
zturner added a comment.
In https://reviews.llvm.org/D53662#1275238, @jingham wrote:
> I worry that your patch changes the behavior when you add the type_class
> explicitly in the lookup (i.e. look up "struct Struct" not "Struct". That
> should work...
>
> Note, this doesn't currently work in
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
Looks good to me.
https://reviews.llvm.org/D53677
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
JDevlieghere added a comment.
Note that there's also a File class which we'll need to patch up separately
together with all other uses that actually open or read a file. For this class
we can do the same as we did for FileSpec: deferring relevant operations to the
FileSystem class.
https://re
It seems like FileSpec was moved out of Utility and into Host. I’m not a
fan of this change, because it took a lot of effort to get it into Utility,
which helped break a lot of bad dependencies. Can we invert this dependency
and move FileSpec back into Utility?
On Wed, Oct 24, 2018 at 5:53 PM Jonas
zturner added a subscriber: JDevlieghere.
zturner added a comment.
It seems like FileSpec was moved out of Utility and into Host. I’m not a
fan of this change, because it took a lot of effort to get it into Utility,
which helped break a lot of bad dependencies. Can we invert this dependency
and mo
Sent from my iPhone
> On Oct 24, 2018, at 7:05 PM, Zachary Turner wrote:
>
> It seems like FileSpec was moved out of Utility and into Host. I’m not a fan
> of this change, because it took a lot of effort to get it into Utility, which
> helped break a lot of bad dependencies. Can we invert th
34 matches
Mail list logo
