aleksandr.urakov added a comment.
Thanks all!
https://reviews.llvm.org/D51162
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: aleksandr.urakov
Date: Mon Sep 10 01:08:43 2018
New Revision: 341782
URL: http://llvm.org/viewvc/llvm-project?rev=341782&view=rev
Log:
[PDB] Restore AST from PDB symbols
Summary:
This patch adds an implementation of retrieving of declarations and declaration
contexts based on PDB symbols.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341782: [PDB] Restore AST from PDB symbols (authored by
aleksandr.urakov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51162?vs=164027&id=1
JDevlieghere updated this revision to Diff 164650.
JDevlieghere added a comment.
Added a test case. I really didn't know where to put it so I decided on
something generic. Hope that's fine.
https://reviews.llvm.org/D51730
Files:
packages/Python/lldbsuite/test/lang/c/local_variables/Makefile
JDevlieghere created this revision.
JDevlieghere added reviewers: jingham, jasonmolenda, LLDB.
Herald added subscribers: abidh, emaste.
This is an NFC commit to refactor the "load dependent files" parameter from a
boolean to an enum value. We want to be able to specify a default, in which
case w
stella.stamenova added a comment.
This change is causing three of the symbol file PDB tests to fail:
lldb-Unit ::
SymbolFile/PDB/release/SymbolFilePDBTests.exe/SymbolFilePDBTests.TestClassInNamespace
lldb-Unit ::
SymbolFile/PDB/release/SymbolFilePDBTests.exe/SymbolFilePDBTests.TestNestedCla
jingham added a comment.
Thanks for adding Greg. I am the code owner for the breakpoints part of lldb,
and most recently I've been the only one adding to the scripting interface.
There wasn't another really germane reviewer, and since the dev list was CC'ed
I figured if anybody was interested
aleksandr.urakov added a comment.
Sorry, I've missed this. I'll fix it tomorrow. Thank you!
Repository:
rL LLVM
https://reviews.llvm.org/D51162
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
Author: ted
Date: Mon Sep 10 11:19:01 2018
New Revision: 341849
URL: http://llvm.org/viewvc/llvm-project?rev=341849&view=rev
Log:
Fix raw address breakpoints not resolving
Summary: An address breakpoint of the form "b 0x1000" won't resolve if it's
created while the process isn't running. This pa
jankratochvil created this revision.
jankratochvil added a reviewer: vsk.
jankratochvil added a project: LLDB.
With buildbot slave under test - I get:
http://lab.llvm.org:8014/builders/lldb-x86_64-fedora-28-cmake/builds/243/steps/test1/logs/stdio
File
"/home/buildbot/lldbroot/lldb-x86_64-fed
Ted, this commit broke a large number of tests.
http://green.lab.llvm.org/green/job/lldb-cmake/9969/console
Testing Time: 907.91s
Failing Tests (57):
lldb-Suite :: expression_command/multiline/TestMultilineExpressions.py
lldb-Suite :: functionali
ted added a comment.
Another issue:
auto context = symbol.getRawSymbol().getName();
auto context_size = context.rfind("::");
...
auto from = 0;
while (from < context_size) {
context_size is size_t (from std::string::rfind), but on clang 5.01, "auto from
= 0" makes from an int. The
Author: davide
Date: Mon Sep 10 16:09:09 2018
New Revision: 341878
URL: http://llvm.org/viewvc/llvm-project?rev=341878&view=rev
Log:
Rollback "Fix raw address breakpoints not resolving".
It broke a bunch of bots. Ted confirmed, but can't revert for
now so I'm reverting on his behalf.
Modified:
Reverted on behalf of Ted in r341878.
On Mon, Sep 10, 2018 at 11:20 AM Ted Woodward via lldb-commits
wrote:
>
> Author: ted
> Date: Mon Sep 10 11:19:01 2018
> New Revision: 341849
>
> URL: http://llvm.org/viewvc/llvm-project?rev=341849&view=rev
> Log:
> Fix raw address breakpoints not resolving
>
Author: shafik
Date: Mon Sep 10 16:12:29 2018
New Revision: 341879
URL: http://llvm.org/viewvc/llvm-project?rev=341879&view=rev
Log:
First test commit into svn, adding space to comment
Modified:
lldb/trunk/source/Plugins/Language/CPlusPlus/LibCxxOptional.cpp
Modified: lldb/trunk/source/Plugi
Author: shafik
Date: Mon Sep 10 16:18:32 2018
New Revision: 341881
URL: http://llvm.org/viewvc/llvm-project?rev=341881&view=rev
Log:
Undoing first commit which added a space to a comment
Modified:
lldb/trunk/source/Plugins/Language/CPlusPlus/LibCxxOptional.cpp
Modified: lldb/trunk/source/Plu
shafik created this revision.
shafik added a reviewer: jingham.
Moving the core functionality of std::function formatter into
CPPLanguageRuntime in preparation for future changes to allow us to step into
the wrapped callable of std::function.
This will prevent code duplication since both functi
zturner added inline comments.
Comment at: lldb/trunk/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:268-269
+
+std::unique_ptr
+GetClassOrFunctionParent(const llvm::pdb::PDBSymbol &symbol) {
+ const IPDBSession &session = symbol.getSession();
All file local fun
vsk added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/variant/TestDataFormatterLibcxxVariant.py:70
+self.expect("frame variable v_no_value",
+substrs=['v_no_value = No Value'])
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
A bunch of little comments and two more substantial bits.
1. Can you add a test where we do "frame variable" on a one of these variants
when it has one value, and then continue to
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
Since the runtime has to use the results of the introspection that the
formatter is based on, it seems appropriate to put it there. This seems like a
fine way to do it.
https://reviews.ll
21 matches
Mail list logo
