aleksandr.urakov added a subscriber: labath.
aleksandr.urakov added a comment.
It seems that the cause of the failure is https://reviews.llvm.org/rL340206,
but I'm not sure if the adding of `-gpubnames` switch to `clang` will be a
correct fix for that?
Repository:
rL LLVM
https://reviews.ll
EugeneBi updated this revision to Diff 161959.
EugeneBi added a comment.
Do not use /tmp directory in the test
https://reviews.llvm.org/D49685
Files:
packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py
source/Target/Platform.cpp
Index: source/Target/Platfor
EugeneBi marked an inline comment as done.
EugeneBi added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py:215
+# /home/labath/test/a.out)
+tmp_sysroot = "/tmp/lldb_i386_mock_sysroot"
+execut
On Wed, Aug 22, 2018 at 12:34 AM Aleksandr Urakov via Phabricator <
revi...@reviews.llvm.org> wrote:
> aleksandr.urakov added a subscriber: labath.
> aleksandr.urakov added a comment.
>
> It seems that the cause of the failure is
> https://reviews.llvm.org/rL340206, but I'm not sure if the adding
shafik updated this revision to Diff 161997.
shafik added a comment.
Updating comment
https://reviews.llvm.org/D50864
Files:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/function/TestLibCxxFunction.py
packages/Python/lldbsuite/test/functionalitie
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
This is another one of classes we should probably get rid of (it looks like all
of this functionality is available in StringRef), but while we have it, it
might as well be tested.
https://re
Author: teemperor
Date: Wed Aug 22 13:22:34 2018
New Revision: 340448
URL: http://llvm.org/viewvc/llvm-project?rev=340448&view=rev
Log:
Add unit test for StringLexer
Reviewers: labath, #lldb
Reviewed By: labath
Subscribers: jloser, mgorny, lldb-commits
Differential Revision: https://reviews.ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340448: Add unit test for StringLexer (authored by
teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50298?vs=159193&id=162038#toc
R
teemperor abandoned this revision.
teemperor marked 2 inline comments as done.
teemperor added a comment.
Abandon in favor of https://reviews.llvm.org/D50912
https://reviews.llvm.org/D48463
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
h
teemperor edited reviewers, added: LLDB; removed: jingham.
teemperor added a comment.
(Adding the team as a reviewer, because the code this patch touches doesn't
seem to have a dedicated code owner).
Repository:
rLLDB LLDB
https://reviews.llvm.org/D50481
__
vsk accepted this revision as: vsk.
vsk added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM!
Repository:
rLLDB LLDB
https://reviews.llvm.org/D50481
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.
clayborg added inline comments.
Comment at: source/Target/Process.cpp:4692-4693
+// the IOHandler for Editline).
+bool cancel_top_handler = m_mod_id.IsRunningUtilityFunction();
+GetTarget().GetDebugger().PushIOHandler(io_handler_sp, cancel_top_handler);
return tr
clayborg added a comment.
Changed look fine. Wondering if we want to be adding pexpect style tests
though. Those tests tend to be flaky. This could easily be done with SB API
calls instead of using pexpect.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D50481
__
teemperor planned changes to this revision.
teemperor added a comment.
@clayborg Thanks, getting rid of pexpect sounds good.
TODO:
- Get rid of pexpect.
- Fix some of the comments in the test that are still referring to the test I
copied this from.
- Reuse `builtin_context` instead of calling `
jingham added a comment.
What would happen to any output that the process produced while running the
utility function if we did this.
https://reviews.llvm.org/D50912
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cg
clayborg added a comment.
In https://reviews.llvm.org/D50912#1209994, @jingham wrote:
> What would happen to any output that the process produced while running the
> utility function if we did this.
I believe it would still be fetched on next stop. Just not real time. Do you
think anyone runn
jingham added a comment.
It's not a huge deal, but it would be disconcerting to have a bunch of text
dumped to your console the next time you continue. I think the ideal solution
would be for utility functions to push a "capture & report" IO handler, so the
Utility function could retrieve what
Author: sas
Date: Wed Aug 22 15:25:45 2018
New Revision: 340460
URL: http://llvm.org/viewvc/llvm-project?rev=340460&view=rev
Log:
Add include directory for libxml on macOS
Summary:
Builds fail because libxml/xmlreader.h isn't found. Adding the include
directory to the include list fixes the issue
18 matches
Mail list logo
