[Lldb-commits] [PATCH] D49739: Add new API to SBTarget class

labath added a comment. In https://reviews.llvm.org/D49739#1194037, @apolyakov wrote: > I think those options don't fit. I'm looking for behavior like this: > > ~/workspace/gsoc/build/bin/lldb-server gdbserver --pipe 1 localhost:0 > 36251 > > > Here lldb-server prints out the port number it i

[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

labath added inline comments. Comment at: lit/tools/lldb-mi/interpreter/cli-support/breakpoint-set.test:4 +# +# RUN: %cxx -o %t %p/inputs/main.cpp -g +# RUN: %lldbmi %t < %s | FileCheck %s aprantl wrote: > stella.stamenova wrote: > > apolyakov wrote: > > > stella

[Lldb-commits] [lldb] r339430 - Amend "Remove unused type Either from Utility library".

Author: tkrasnukha Date: Fri Aug 10 06:01:26 2018 New Revision: 339430 URL: http://llvm.org/viewvc/llvm-project?rev=339430&view=rev Log: Amend "Remove unused type Either from Utility library". Removed: lldb/trunk/include/lldb/Utility/Either.h Removed: lldb/trunk/include/lldb/Utility/Either.h

Re: [Lldb-commits] [lldb] r339328 - Remove unused type Either from Utility library.

You are right, it seems I removed it only in my mind, sorry. Thank you for noting that. > -Original Message- > From: Davide Italiano > Sent: Thursday, 9 August, 2018 6:32 PM > To: tatyana.krasnu...@synopsys.com > Cc: lldb-commits > Subject: Re: [Lldb-commits] [lldb] r339328 - Remove unu

[Lldb-commits] [lldb] r339440 - RichManglingContext: Make m_ipd_str_len a local variable and simplify processIPDStrResult + polishing in test and Mangled

Author: stefan.graenitz Date: Fri Aug 10 08:21:33 2018 New Revision: 339440 URL: http://llvm.org/viewvc/llvm-project?rev=339440&view=rev Log: RichManglingContext: Make m_ipd_str_len a local variable and simplify processIPDStrResult + polishing in test and Mangled Modified: lldb/trunk/include

[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

probinson added inline comments. Comment at: lit/tools/lldb-mi/interpreter/cli-support/target-list.test:5 +# We should hardcode executable name since at the moment of running of +# lldb-mi the name must be known. +# RUN: %cxx -o a.exe %p/inputs/main.cpp -g aprant

[Lldb-commits] [PATCH] D50536: Fix: ConstString::GetConstCStringAndSetMangledCounterPart() should update the value if the key exists already

friss added inline comments. Comment at: source/Utility/ConstString.cpp:123-126 + assert((map.find(demangled) == map.end() || strlen(map[demangled]) == 0 || + map[demangled] == mangled_ccstr) && + "The demangled string must have a unique counterpart

[Lldb-commits] [PATCH] D50536: Fix: ConstString::GetConstCStringAndSetMangledCounterPart() should update the value if the key exists already

sgraenitz updated this revision to Diff 160143. sgraenitz added a comment. Move assert after try_emplace https://reviews.llvm.org/D50536 Files: source/Utility/ConstString.cpp unittests/Utility/ConstStringTest.cpp Index: unittests/Utility/ConstStringTest.cpp

[Lldb-commits] [lldb] r339457 - [tests, libstdcxx] Add missing test category on the TestDataFormatterStdUniquePtr tests

Author: stella.stamenova Date: Fri Aug 10 10:52:45 2018 New Revision: 339457 URL: http://llvm.org/viewvc/llvm-project?rev=339457&view=rev Log: [tests, libstdcxx] Add missing test category on the TestDataFormatterStdUniquePtr tests Each test needs to be marked with the add_test_categories decorat

[Lldb-commits] [PATCH] D50536: Fix: ConstString::GetConstCStringAndSetMangledCounterPart() should update the value if the key exists already

sgraenitz marked an inline comment as done. sgraenitz added inline comments. Comment at: source/Utility/ConstString.cpp:123-126 + assert((map.find(demangled) == map.end() || strlen(map[demangled]) == 0 || + map[demangled] == mangled_ccstr) && + "The

[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

stella.stamenova added inline comments. Comment at: lit/tools/lldb-mi/interpreter/cli-support/breakpoint-set.test:4 +# +# RUN: %cxx -o %t %p/inputs/main.cpp -g +# RUN: %lldbmi %t < %s | FileCheck %s labath wrote: > aprantl wrote: > > stella.stamenova wrote: > > >

[Lldb-commits] [lldb] r339473 - Remove copy-pasted and unrelated comment [NFC]

Author: teemperor Date: Fri Aug 10 14:31:44 2018 New Revision: 339473 URL: http://llvm.org/viewvc/llvm-project?rev=339473&view=rev Log: Remove copy-pasted and unrelated comment [NFC] That comment was copied from the CombineConsecutiveEntriesWithEqualData() implementation below, and doesn't actual

[Lldb-commits] [PATCH] D50587: Straight forward FastDemangle replacement in SubsPrimitiveParmItanium

sgraenitz created this revision. sgraenitz added reviewers: erik.pilkington, friss, jingham, JDevlieghere. Herald added subscribers: chrib, kristof.beyls. Removing FastDemangle will greatly reduce maintenance efforts. This patch replaces the last point of use in LLDB. Semantics should be kept int

[Lldb-commits] [PATCH] D50225: Use a DenseMap for looking up functions by UID in CompileUnit::FindFunctionByUID

teemperor updated this revision to Diff 160214. teemperor added a comment. Herald added a subscriber: mgrang. - Replaced m_functions and instead copy the map to a temporary sorted vector and iterate over that. https://reviews.llvm.org/D50225 Files: include/lldb/Symbol/CompileUnit.h source/

[Lldb-commits] [PATCH] D50225: Use a DenseMap for looking up functions by UID in CompileUnit::FindFunctionByUID

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, LGTM! https://reviews.llvm.org/D50225 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[Lldb-commits] [PATCH] D50478: WIP: Basic tail call frame support

vsk updated this revision to Diff 160224. vsk added a comment. Herald added a subscriber: mgrang. Rebase, and update the patch to use DW_AT_call_return_pc information. https://reviews.llvm.org/D50478 Files: lldb/include/lldb/Symbol/Block.h lldb/include/lldb/Symbol/Function.h lldb/include/