labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
I think there's a small difference in semantics between this and the `tell`
function on llvm streams. This tells the number of bytes written, while the
other one an absolute position within th
JDevlieghere added inline comments.
Comment at: include/lldb/Utility/Stream.h:542
int m_indent_level; ///< Indention level.
+ std::size_t m_bytes_written = 0; /// The bytes this stream has written so
far.
I believe you need the `<` for Doxygen to associate
labath added a comment.
Wouldn't it be even better to actually expose the llvm class via some accessor
or something? This way we could slowly migrate existing code by changing it to
write to `stream.accessor()` instead of `stream` ? (I am not saying to do that
now, but it opens up possibilities
Author: stefan.graenitz
Date: Thu Aug 2 03:13:18 2018
New Revision: 338695
URL: http://llvm.org/viewvc/llvm-project?rev=338695&view=rev
Log:
Unit test for Symtab::InitNameIndexes
Summary: In order to exploit the potential of LLVM's new
ItaniumPartialDemangler for indexing in LLDB, we expect con
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338695: Unit test for Symtab::InitNameIndexes (authored by
stefan.graenitz, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D49909
Files:
lldb/t
labath added a comment.
In https://reviews.llvm.org/D50071#1184960, @sgraenitz wrote:
> > If I understand things correctly, we could avoid circular deps and untyped
> > pointers (or llvm::Any, which is essentially the same thing), by moving
> > CPlusPlusLanguage::MethodName to a separate file.
Author: tnorthover
Date: Thu Aug 2 05:50:23 2018
New Revision: 338712
URL: http://llvm.org/viewvc/llvm-project?rev=338712&view=rev
Log:
Move ClangHighlighter.cpp to hopefully better place in Xcode project.
But with a write-only format, who can really say?
Modified:
lldb/trunk/lldb.xcodeproj
sgraenitz created this revision.
sgraenitz added a reviewer: teemperor.
Fix linker error:
Undefined symbols for architecture x86_64:
"lldb_private::ClangHighlighter::ClangHighlighter()", referenced from:
lldb_private::ObjCLanguage::ObjCLanguage() in
liblldb-core.a(ObjCLanguage.o)
l
teemperor added a reviewer: t.p.northover.
teemperor added a comment.
This was changed by https://reviews.llvm.org/rLLDB338712 so I think Tim
probably knows better what's going on here.
https://reviews.llvm.org/D50192
___
lldb-commits mailing list
davide added a comment.
My understanding is that @t.p.northover just committed the same patch.
https://reviews.llvm.org/D50192
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
teemperor updated this revision to Diff 158777.
teemperor added a comment.
- Fixing some of the merge conflicts.
- Fixed doxygen comment.
Thanks for the reviews!
https://reviews.llvm.org/D50159
Files:
include/lldb/Core/StreamAsynchronousIO.h
include/lldb/Core/StreamBuffer.h
include/lldb/
Author: teemperor
Date: Thu Aug 2 09:38:34 2018
New Revision: 338733
URL: http://llvm.org/viewvc/llvm-project?rev=338733&view=rev
Log:
Add byte counting mechanism to LLDB's Stream class.
Summary:
This patch allows LLDB's Stream class to count the bytes it has written to so
far.
There are two m
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338733: Add byte counting mechanism to LLDB's Stream
class. (authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50159?vs=1
Author: gclayton
Date: Thu Aug 2 09:46:15 2018
New Revision: 338734
URL: http://llvm.org/viewvc/llvm-project?rev=338734&view=rev
Log:
Add support for ARM and ARM64 breakpad generated minidump files
In this patch I add support for ARM and ARM64 break pad files. There are two
flavors of ARM: Appl
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338734: Add support for ARM and ARM64 breakpad generated
minidump files (authored by gclayton, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/
sgraenitz abandoned this revision.
sgraenitz added a comment.
Yep
https://reviews.llvm.org/D50192
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added a comment.
Please remember to test with the cmake build when you add or remove files,
as that is the build that all of the buildbots use. I almost reverted this
since it broke every LLDB buildbot, but I noticed that it's just forgetting
to remove the files from the CMakeLists.txt so
Please remember to test with the cmake build when you add or remove files,
as that is the build that all of the buildbots use. I almost reverted this
since it broke every LLDB buildbot, but I noticed that it's just forgetting
to remove the files from the CMakeLists.txt so I'll fix it.
On Thu, Aug
Author: zturner
Date: Thu Aug 2 10:44:41 2018
New Revision: 338746
URL: http://llvm.org/viewvc/llvm-project?rev=338746&view=rev
Log:
Fix CMake build.
Some new files were committed to the repository but not added
to the CMakeLists.txt, so this patch fixes the build.
Modified:
lldb/trunk/sour
sgraenitz added a comment.
> (However if you are interested in something like this, then it might be
> interesting to look at whether this MethodName stuff couldn't be properly
> pluginified. Something like where a Language class registers a callback for a
> specific mangling type, and then acc
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
Hmm.. yeah, this looks more like a side-channel than a proper part of the MI
protocol. That said, this is also what the original code was doing, so we can
investigate the proper protocol sep
Author: stella.stamenova
Date: Thu Aug 2 14:26:19 2018
New Revision: 338769
URL: http://llvm.org/viewvc/llvm-project?rev=338769&view=rev
Log:
[lldbsuite, windows] Mark tests as XFAIL on Windows or skip them
Summary:
1) Several tests that are flakey on windows fail the run even if they are
marke
Author: dlj
Date: Thu Aug 2 14:45:05 2018
New Revision: 338772
URL: http://llvm.org/viewvc/llvm-project?rev=338772&view=rev
Log:
[lldb] Remove unused variable.
The use of this variable was removed in r338734. It now causes unused variable
warnings.
Modified:
lldb/trunk/source/Plugins/Proce
stella.stamenova added a comment.
There are a number of minidump tests that started failing for us on both Linux
and Windows and I suspect it's due to this change. Did the unit tests pass for
you with the changes on either Linux or Windows?
Failing Tests (6):
lldb-Unit ::
Process/minidump/.
teemperor created this revision.
teemperor added a reviewer: vsk.
Instead of iterating over our vector of functions, we might as well use a map
here to
directly get the function we need.
Thanks to Vedant for pointing this out.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D50225
Files:
teemperor added a comment.
I don't see this mentioned here yet, so: This patch also seems to introduce a
few hundred warnings with -Wextended-offsetof (which is enabled by default on
the macOS builds):
[...]llvm/tools/lldb/source/Plugins/Process/minidump/RegisterContextMinidump_ARM64.cpp:510
teemperor updated this revision to Diff 158926.
teemperor added a reviewer: labath.
teemperor added a comment.
- Renamed m_forward_to to m_target.
- Added a getter to allow external code to use the raw_ostream API.
- Renamed m_forward to m_forwarder.
@labath Thanks, fixed the problems you pointed
teemperor updated this revision to Diff 158930.
teemperor added a reviewer: labath.
teemperor added a comment.
- Fixed compilation errors after changes in parent revision.
https://reviews.llvm.org/D50162
Files:
source/Utility/Stream.cpp
Index: source/Utility/Stream.cpp
=
28 matches
Mail list logo
