labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
I am not too familiar with this code, but the descriptions seem to make sense.
However, since you have kind of opened up the `Optional` discussion, I'll use
this opportunity to give my take on
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D50038
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lld
labath added a comment.
Sounds like a nice feature to have. In addition to the other feedback you've
received, I'd suggest splitting out the addition of new format entities (frame
count and friends) and the core interpolation feature into separate patches.
Repository:
rL LLVM
https://review
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks great. I only noticed some typos when looking this over again. We can
continue the register shuffling discussion offline.
Comment at: include/lldb/Target/Target.h:929-
labath added a comment.
Thanks for the patience. I've tried the patch out on our end. You shouldn't
have any problems now.
Comment at:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/optional/TestDataFormatterLibcxxOptional.py:21
+@
labath added inline comments.
Comment at: unittests/Utility/StreamTest.cpp:38-41
+TEST_F(StreamTest, ChangingByteOrder) {
+ s.SetByteOrder(lldb::eByteOrderPDP);
+ EXPECT_EQ(lldb::eByteOrderPDP, s.GetByteOrder());
+}
probinson wrote:
> teemperor wrote:
> > labat
vsk added a comment.
In https://reviews.llvm.org/D50087#1183982, @labath wrote:
> I am not too familiar with this code, but the descriptions seem to make sense.
>
> However, since you have kind of opened up the `Optional` discussion, I'll use
> this opportunity to give my take on it:
>
> I've wa
clayborg added a comment.
Might be nice to put a blurb in the build page about this in the MacOS section?
https://reviews.llvm.org/D50038
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
Author: vedantk
Date: Wed Aug 1 10:07:40 2018
New Revision: 338588
URL: http://llvm.org/viewvc/llvm-project?rev=338588&view=rev
Log:
[StackFrame] Factor GetOnlyConcreteFramesUpTo out of GetFramesUpTo (NFC)
Splitting GetOnlyConcreteFramesUpTo will make it easier to implement
support for synthetic
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338590: [StackFrame] Add doxygen comments to the
StackFrameList API (NFC) (authored by vedantk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org
Author: vedantk
Date: Wed Aug 1 10:08:11 2018
New Revision: 338590
URL: http://llvm.org/viewvc/llvm-project?rev=338590&view=rev
Log:
[StackFrame] Add doxygen comments to the StackFrameList API (NFC)
Clarify how StackFrameList works by documenting its methods. Also,
delete some dead code and inse
Author: vedantk
Date: Wed Aug 1 10:07:56 2018
New Revision: 338589
URL: http://llvm.org/viewvc/llvm-project?rev=338589&view=rev
Log:
[StackFrame] Use early returns in ResetCurrentInlinedDepth (NFC)
Using early returns in this function substantially reduces the nesting
level, making the logic eas
teemperor updated this revision to Diff 158563.
teemperor added a comment.
- Updated patch to reflect code changes in the parent commit.
https://reviews.llvm.org/D50025
Files:
source/Utility/Stream.cpp
unittests/Utility/StreamTest.cpp
Index: unittests/Utility/StreamTest.cpp
==
Author: teemperor
Date: Wed Aug 1 10:12:58 2018
New Revision: 338591
URL: http://llvm.org/viewvc/llvm-project?rev=338591&view=rev
Log:
Don't ignore byte_order in Stream::PutMaxHex64
Reviewers: labath
Reviewed By: labath
Subscribers: zturner, lldb-commits
Differential Revision: https://reviews
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338591: Don't ignore byte_order in Stream::PutMaxHex64
(authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50025?vs=158563
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338594: Introduce install-lldb-framework target (authored by
xiaobai, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D50038
Files:
lldb/trunk/C
xiaobai added a comment.
In https://reviews.llvm.org/D50038#1184445, @clayborg wrote:
> Might be nice to put a blurb in the build page about this in the MacOS
> section?
Yep, I think that wouldn't be a bad idea. I can handle that in a separate
commit. Might be nice for one of the buildbots to
Author: xiaobai
Date: Wed Aug 1 10:21:18 2018
New Revision: 338594
URL: http://llvm.org/viewvc/llvm-project?rev=338594&view=rev
Log:
Introduce install-lldb-framework target
Summary:
Previously, I thought that install-liblldb would fail because CMake had
a bug related to installing frameworks. In
teemperor created this revision.
When I added the Stream unit test (r338488), the build bots failed due to an
out-of-
bound reads when passing an empty string to the PutCStringAsRawHex8 method.
In r338491 I removed the test case to fix the bots.
This patch fixes this in PutCStringAsRawHex8 by al
Author: teemperor
Date: Wed Aug 1 11:28:54 2018
New Revision: 338605
URL: http://llvm.org/viewvc/llvm-project?rev=338605&view=rev
Log:
Remove outdated documentation for Stream's LEB128 methods
There is no format parameter for any of these methods.
Modified:
lldb/trunk/include/lldb/Utility/S
Author: teemperor
Date: Wed Aug 1 11:38:19 2018
New Revision: 338611
URL: http://llvm.org/viewvc/llvm-project?rev=338611&view=rev
Log:
Fixed documentation for PutHex8 [NFC]
The previous documentation was just copied from PrintfAsRawHex8
but doesn't actually fit to the PutHex8 method.
Modified:
apolyakov added a comment.
@clayborg can you explain what are you worry about because I don't completely
understand you? As I said, all lldb-mi commands print their result to STDOUT,
AFAIK, an IDE should parse it and then show in a GUI.
https://reviews.llvm.org/D49632
__
vsk created this revision.
vsk added reviewers: aprantl, jasonmolenda.
Herald added subscribers: chrib, krytarowski, mgorny, srhines.
This code looks like a good reference for building a new unwinder, but
is currently unused, so there's no need to keep it.
https://reviews.llvm.org/D50155
Files:
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM.
https://reviews.llvm.org/D50149
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
aprantl added a comment.
Deleting dead code is always good; I'll let Jason sign this off though.
https://reviews.llvm.org/D50155
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg updated this revision to Diff 158631.
clayborg added a comment.
- run clang-format
- fix doxygen parameter names
https://reviews.llvm.org/D49750
Files:
include/lldb/Target/Target.h
lldb.xcodeproj/project.pbxproj
packages/Python/lldbsuite/test/functionalities/postmortem/minidump-
clayborg marked 2 inline comments as done.
clayborg added inline comments.
Comment at: source/Plugins/Process/minidump/RegisterContextMinidump_ARM64.cpp:57
+nullptr, nullptr, nullptr, 0}
+
+// Zero based LLDB register numbers for this register context
No need
Author: teemperor
Date: Wed Aug 1 14:07:18 2018
New Revision: 338637
URL: http://llvm.org/viewvc/llvm-project?rev=338637&view=rev
Log:
Fix out-of-bounds read in Stream::PutCStringAsRawHex8
Summary:
When I added the Stream unit test (r338488), the build bots failed due to an
out-of-
bound reads
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338637: Fix out-of-bounds read in
Stream::PutCStringAsRawHex8 (authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50149?vs
Author: davide
Date: Wed Aug 1 14:13:45 2018
New Revision: 338638
URL: http://llvm.org/viewvc/llvm-project?rev=338638&view=rev
Log:
[DWARFASTParser] Remove special cases for `llvm-gcc`
Reviewed by: aprantl, labath.
Differential Revision: https://reviews.llvm.org/D48500
Modified:
lldb/trun
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338638: [DWARFASTParser] Remove special cases for `llvm-gcc`
(authored by davide, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D48500?vs=152
sgraenitz updated this revision to Diff 158638.
sgraenitz added a comment.
Minor improvements.
https://reviews.llvm.org/D50071
Files:
include/lldb/Core/Mangled.h
include/lldb/Core/RichManglingInfo.h
include/lldb/Symbol/Symtab.h
include/lldb/Utility/ConstString.h
include/lldb/lldb-forw
sgraenitz marked 2 inline comments as done.
sgraenitz added inline comments.
Comment at: include/lldb/Core/RichManglingInfo.h:83-84
+public:
+ RichManglingInfo *SetItaniumInfo();
+ RichManglingInfo *SetLegacyCxxParserInfo(const ConstString &mangled);
+
labath w
teemperor created this revision.
teemperor added a reviewer: labath.
This patch allows LLDB's Stream class to count the bytes it has written to so
far.
There are two major motivations for this patch:
The first one is that this will allow us to get rid of all the handwritten byte
counting code
teemperor updated this revision to Diff 158642.
teemperor edited the summary of this revision.
teemperor added a comment.
- Added some more documentation.
https://reviews.llvm.org/D50159
Files:
include/lldb/Core/StreamAsynchronousIO.h
include/lldb/Core/StreamBuffer.h
include/lldb/Core/Str
sgraenitz added a comment.
> If I understand things correctly, we could avoid circular deps and untyped
> pointers (or llvm::Any, which is essentially the same thing), by moving
> CPlusPlusLanguage::MethodName to a separate file.
Banning public nested classes in general is a good practice as lo
teemperor created this revision.
This wrapper will allow us in the future to reuse LLVM methods from within the
Stream class.
Currently no test as this is intended to be an internal class that shouldn't
have any
NFC. The test for this change will be the follow up patch that migrates LLDB's
LEB12
teemperor created this revision.
https://reviews.llvm.org/D50162
Files:
source/Utility/Stream.cpp
Index: source/Utility/Stream.cpp
===
--- source/Utility/Stream.cpp
+++ source/Utility/Stream.cpp
@@ -12,6 +12,7 @@
#include "lldb/
jingham added a comment.
One trivial fix to the test case.
Repository:
rL LLVM
https://reviews.llvm.org/D49949
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
shafik updated this revision to Diff 158662.
shafik added a comment.
Simplifying initialization of has_optional in test.
https://reviews.llvm.org/D49271
Files:
lldb.xcodeproj/project.pbxproj
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/optional/Ma
shafik marked 4 inline comments as done.
shafik added a comment.
@labath Addressed comment, thank you for helping out.
Comment at:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/optional/TestDataFormatterLibcxxOptional.py:21
+@add_t
Author: teemperor
Date: Wed Aug 1 16:54:37 2018
New Revision: 338657
URL: http://llvm.org/viewvc/llvm-project?rev=338657&view=rev
Log:
Remove unnecessary target from TestCompletion patch
As Jim pointed out, we don't need to manually create a target
here because we already create a target implici
Author: teemperor
Date: Wed Aug 1 17:30:15 2018
New Revision: 338662
URL: http://llvm.org/viewvc/llvm-project?rev=338662&view=rev
Log:
[LLDB] Added syntax highlighting support
Summary:
This patch adds syntax highlighting support to LLDB. When enabled (and lldb is
allowed
to use colors), printed
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338662: [LLDB] Added syntax highlighting support (authored
by teemperor, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49334?vs=157702&id=158671#toc
Repository:
rL LLVM
https://
Author: teemperor
Date: Wed Aug 1 20:01:09 2018
New Revision: 338669
URL: http://llvm.org/viewvc/llvm-project?rev=338669&view=rev
Log:
Added missing highlighter files to XCode project
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL
45 matches
Mail list logo
