[Lldb-commits] [PATCH] D49888: Stop building liblldb with CMake's framework functionality

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Can't say I fully understand what's going on, but the changes seem reasonable to me. If there is some public cmake bug describing the issue you ran into, it would be nice, for the sake of fut

[Lldb-commits] [PATCH] D49909: Unit test for Symtab::InitNameIndexes

sgraenitz created this revision. sgraenitz added reviewers: labath, jingham, JDevlieghere. In order to exploit the potential of LLVM's new ItaniumPartialDemangler for indexing in LLDB, we expect conceptual changes in the implementation of the InitNameIndexes function. Here is a unit test that ai

[Lldb-commits] [PATCH] D49685: LLDB does not respect platform sysroot when loading core on Linux

labath added a comment. In https://reviews.llvm.org/D49685#1177046, @EugeneBi wrote: > It is specific to shared libraries. Opening the executable and core dump > follows different code path. Which path is that? Is the path different even when you don't specify an executable when opening the c

[Lldb-commits] [PATCH] D49909: Unit test for Symtab::InitNameIndexes

labath added a comment. I am wondering whether a test like this wouldn't be better of as a lit test instead of a unit test. Right now, if you do a `lldb-test symbols foo.o` (and foo.o contains debug info), we will dump out a very similar index which is built from the information in the debug_i

[Lldb-commits] [PATCH] D49909: Unit test for Symtab::InitNameIndexes

sgraenitz added a comment. Sounds very reasonable. I think unit tests are great for development, because turnaround times are fast and debugging easy. But I am happy to have a look on how to turn this into a lit test once that's done. Thanks for the remark. https://reviews.llvm.org/D49909 _

[Lldb-commits] [PATCH] D49334: [LLDB} Added syntax highlighting support

teemperor updated this revision to Diff 157702. teemperor added a comment. - Removed extra semicolons that slipped in somehow. https://reviews.llvm.org/D49334 Files: include/lldb/Core/Debugger.h include/lldb/Core/Highlighter.h include/lldb/Target/Language.h packages/Python/lldbsuite/tes

[Lldb-commits] [PATCH] D49334: [LLDB} Added syntax highlighting support

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: source/Core/Highlighter.cpp:34 + // Calculate how many bytes we have written. + return m_prefix.size() + value.size() + m_suffix.size(); +} labath wrote: > teemperor wrote:

[Lldb-commits] [PATCH] D49888: Stop building liblldb with CMake's framework functionality

xiaobai added a comment. In https://reviews.llvm.org/D49888#1177929, @labath wrote: > Can't say I fully understand what's going on, but the changes seem reasonable > to me. Let me know if I can clear anything up. > If there is some public cmake bug describing the issue you ran into, it would

[Lldb-commits] [PATCH] D49322: Narrow the CompletionRequest API to being append-only.

teemperor updated this revision to Diff 157710. teemperor added a comment. - Rebased and fixed merge conflicts. - Applied Pavel's suggestion for the duplicate filter (thanks!). https://reviews.llvm.org/D49322 Files: include/lldb/Utility/CompletionRequest.h source/Commands/CommandCompletions

[Lldb-commits] [PATCH] D49888: Stop building liblldb with CMake's framework functionality

xiaobai updated this revision to Diff 157713. xiaobai added a comment. Add comment pointing to CMake bug report https://reviews.llvm.org/D49888 Files: CMakeLists.txt cmake/modules/AddLLDB.cmake cmake/modules/LLDBConfig.cmake cmake/modules/LLDBFramework.cmake scripts/CMakeLists.txt s

[Lldb-commits] [PATCH] D49685: LLDB does not respect platform sysroot when loading core on Linux

EugeneBi added a comment. In https://reviews.llvm.org/D49685#1178125, @labath wrote: > In https://reviews.llvm.org/D49685#1177046, @EugeneBi wrote: > > > It is specific to shared libraries. Opening the executable and core dump > > follows different code path. > > > Which path is that? Is the pat

[Lldb-commits] [PATCH] D49322: Narrow the CompletionRequest API to being append-only.

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Although I'm not entirely sure whether this is safe (as in, it doesn't break anything), it's probably not worth to block this further. My understanding is that Raphael did a bunch of testing a

[Lldb-commits] [PATCH] D49685: LLDB does not respect platform sysroot when loading core on Linux

EugeneBi added a comment. Hmm... I never thought I can do that :) Anyway, with the change as it is now, LLDB would try to load executable in the sysroot, fail that, then open it without the sysroot. https://reviews.llvm.org/D49685 ___ lldb-commits

[Lldb-commits] [PATCH] D49685: LLDB does not respect platform sysroot when loading core on Linux

lemo added a comment. > I never *ran LLDB tests*, not sure where they are and what they are. I hope you're planning to look into this before submitting the change :) https://reviews.llvm.org/D49685 ___ lldb-commits mailing list lldb-commits@lists.l

Re: [Lldb-commits] [PATCH] D49685: LLDB does not respect platform sysroot when loading core on Linux

> > I never *ran LLDB tests*, not sure where they are and what they are. I hope you're planning to look into this before submitting the change :) On Fri, Jul 27, 2018 at 11:28 AM, Eugene Birukov via Phabricator < revi...@reviews.llvm.org> wrote: > EugeneBi added a comment. > > Hmm... I never t

[Lldb-commits] [lldb] r338151 - Narrow the CompletionRequest API to being append-only.

Author: teemperor Date: Fri Jul 27 11:42:46 2018 New Revision: 338151 URL: http://llvm.org/viewvc/llvm-project?rev=338151&view=rev Log: Narrow the CompletionRequest API to being append-only. Summary: We currently allow any completion handler to read and manipulate the list of matches we calculat

[Lldb-commits] [PATCH] D49322: Narrow the CompletionRequest API to being append-only.

This revision was automatically updated to reflect the committed changes. Closed by commit rL338151: Narrow the CompletionRequest API to being append-only. (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D49322?v

[Lldb-commits] [PATCH] D49685: LLDB does not respect platform sysroot when loading core on Linux

labath added a comment. In https://reviews.llvm.org/D49685#1178528, @EugeneBi wrote: > Hmm... I never thought I can do that :) > Anyway, with the change as it is now, LLDB would try to load executable in > the sysroot, fail that, then open it without the sysroot. Does that mean it is possible

[Lldb-commits] [PATCH] D49271: Adding libc++ formattors for std::optional

davide added a comment. Your latest update doesn't contain CMakeList.txt files and the Xcode project changes. That's why it failed to apply. Please upload a correct version and I'll commit it for you. Repository: rL LLVM https://reviews.llvm.org/D49271 ___

[Lldb-commits] [PATCH] D49685: LLDB does not respect platform sysroot when loading core on Linux

EugeneBi added a comment. In https://reviews.llvm.org/D49685#1178543, @lemo wrote: > > I never *ran LLDB tests*, not sure where they are and what they are. > > I hope you're planning to look into this before submitting the change :) Good idea :) Scanning dependencies of target check-lldb [100%

[Lldb-commits] [PATCH] D49888: Stop building liblldb with CMake's framework functionality

This revision was automatically updated to reflect the committed changes. Closed by commit rL338154: Stop building liblldb with CMake's framework functionality (authored by xiaobai, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D49888 Fi

[Lldb-commits] [lldb] r338154 - Stop building liblldb with CMake's framework functionality

Author: xiaobai Date: Fri Jul 27 12:41:17 2018 New Revision: 338154 URL: http://llvm.org/viewvc/llvm-project?rev=338154&view=rev Log: Stop building liblldb with CMake's framework functionality Summary: CMake has a bug in its ninja generator that prevents you from installing targets that are built

[Lldb-commits] [PATCH] D49271: Adding libc++ formattors for std::optional

davide added a comment. Recommitted: a11963323fc Recommit [DataFormatters] Add formatter for C++17 std::optional. Authentication realm: https://llvm.org:443 LLVM Subversion repository Password for 'davide': *** Sendinglldb/trunk/lldb.xcodeproj/project.pbxproj Adding lldb/

[Lldb-commits] [lldb] r338156 - Recommit [DataFormatters] Add formatter for C++17 std::optional.

Author: davide Date: Fri Jul 27 12:57:30 2018 New Revision: 338156 URL: http://llvm.org/viewvc/llvm-project?rev=338156&view=rev Log: Recommit [DataFormatters] Add formatter for C++17 std::optional. This should have all the correct files now. Patch by Shafik Yaghmour. Differential Revision: htt

[Lldb-commits] [PATCH] D49685: LLDB does not respect platform sysroot when loading core on Linux

EugeneBi added a comment. In https://reviews.llvm.org/D49685#1178553, @labath wrote: > In https://reviews.llvm.org/D49685#1178528, @EugeneBi wrote: > > > Hmm... I never thought I can do that :) > > Anyway, with the change as it is now, LLDB would try to load executable in > > the sysroot, fail

[Lldb-commits] [lldb] r338162 - Revert "Recommit [DataFormatters] Add formatter for C++17 std::optional."

Author: davide Date: Fri Jul 27 13:38:01 2018 New Revision: 338162 URL: http://llvm.org/viewvc/llvm-project?rev=338162&view=rev Log: Revert "Recommit [DataFormatters] Add formatter for C++17 std::optional." This broke a linux bot which doesn't support -std=c++17. The solution is to add a decorato

[Lldb-commits] [PATCH] D49271: Adding libc++ formattors for std::optional

davide added a comment. I'm afraid I had to revert this again. It broke an ubuntu lldb-cmake bot which builds with clang-3.5 (which has no `-std=c++17` support flag, as 17 wasn't there yet). I'd recommend to update this patch with another decorator to skip places where `-std=c++17` is not avai

[Lldb-commits] [PATCH] D49271: Adding libc++ formattors for std::optional

davide added a comment. Bot logs for completeness: Session logs for test failures/errors/unexpected successes will go into directory 'logs-clang-3.5-i386' Command invoked: /lldb-buildbot/lldbSlave/buildWorkingDir/scripts/../llvm/tools/lldb/test/dotest.py -A i386 -C clang-3.5 -v -s logs-cla

[Lldb-commits] [PATCH] D49943: Fix whitespace in the python test suite.

teemperor created this revision. Herald added subscribers: christof, JDevlieghere, ki.stfu. The test suite has often unnecessary trailing whitespace, and sometimes unnecessary trailing lines or a missing final new line. This patch just strips trailing whitespace/lines and adds missing newlines at

[Lldb-commits] [PATCH] D49943: Fix whitespace in the python test suite.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL338171: Fix whitespace in the python test suite. (authored by teemperor, committed by ). Herald added a subscriber: llvm-c

[Lldb-commits] [lldb] r338171 - Fix whitespace in the python test suite.

Author: teemperor Date: Fri Jul 27 15:20:59 2018 New Revision: 338171 URL: http://llvm.org/viewvc/llvm-project?rev=338171&view=rev Log: Fix whitespace in the python test suite. Summary: The test suite has often unnecessary trailing whitespace, and sometimes unnecessary trailing lines or a missing

[Lldb-commits] [PATCH] D49947: Add the actually calculated completions to COMPLETION_MSG

teemperor created this revision. Otherwise this assertion message is not very useful to whoever is reading the log. https://reviews.llvm.org/D49947 Files: packages/Python/lldbsuite/test/functionalities/completion/TestCompletion.py packages/Python/lldbsuite/test/lldbtest.py Index: package

[Lldb-commits] [PATCH] D49949: Add missing boundary checks to variable completion.

teemperor created this revision. Stopgap patch to at least stop all the crashes I get from this code. https://reviews.llvm.org/D49949 Files: packages/Python/lldbsuite/test/functionalities/completion/TestCompletion.py packages/Python/lldbsuite/test/functionalities/completion/main.cpp sourc

[Lldb-commits] [PATCH] D49949: Add missing boundary checks to variable completion.

teemperor updated this revision to Diff 157803. teemperor added a comment. - Fixed formatting. https://reviews.llvm.org/D49949 Files: packages/Python/lldbsuite/test/functionalities/completion/TestCompletion.py packages/Python/lldbsuite/test/functionalities/completion/main.cpp source/Symbo

[Lldb-commits] [lldb] r338177 - Add missing boundary checks to variable completion.

Author: teemperor Date: Fri Jul 27 16:37:08 2018 New Revision: 338177 URL: http://llvm.org/viewvc/llvm-project?rev=338177&view=rev Log: Add missing boundary checks to variable completion. Summary: Stopgap patch to at least stop all the crashes I get from this code. Subscribers: lldb-commits Dif

[Lldb-commits] [PATCH] D49949: Add missing boundary checks to variable completion.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL338177: Add missing boundary checks to variable completion. (authored by teemperor, committed by ). Herald added a subscri

[Lldb-commits] [lldb] r338178 - Revert "Stop building liblldb with CMake's framework functionality"

Author: xiaobai Date: Fri Jul 27 16:38:58 2018 New Revision: 338178 URL: http://llvm.org/viewvc/llvm-project?rev=338178&view=rev Log: Revert "Stop building liblldb with CMake's framework functionality" This reverts r338154. This change is actually unnecessary, as the CMake bug I referred to was a

[Lldb-commits] [PATCH] D49947: Add the actually calculated completions to COMPLETION_MSG

teemperor updated this revision to Diff 157806. teemperor added a comment. - FIxed formatting. https://reviews.llvm.org/D49947 Files: packages/Python/lldbsuite/test/functionalities/completion/TestCompletion.py packages/Python/lldbsuite/test/lldbtest.py Index: packages/Python/lldbsuite/tes

[Lldb-commits] [lldb] r338179 - Add the actually calculated completions to COMPLETION_MSG

Author: teemperor Date: Fri Jul 27 16:42:34 2018 New Revision: 338179 URL: http://llvm.org/viewvc/llvm-project?rev=338179&view=rev Log: Add the actually calculated completions to COMPLETION_MSG Summary: Otherwise this assertion message is not very useful to whoever is reading the log. Subscribe

[Lldb-commits] [PATCH] D49947: Add the actually calculated completions to COMPLETION_MSG

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL338179: Add the actually calculated completions to COMPLETION_MSG (authored by teemperor, committed by ). Herald added a s